Re: [webkit-dev] Approving / Rejects PRs on GitHub when not a reviewer?

+1! The bugzilla-style “unofficial r=me” comment was much clearer for exactly these reasons. > On Nov 28, 2023, at 10:27 AM, Chris Dumez via webkit-dev > wrote: > > Hi, > > Back in the Bugzilla days, only reviewers were allowed to r+ or r- patches. > Non-reviewers were - of course -

Re: [webkit-dev] Smart Pointers Usage Guidelines

> On Aug 21, 2023, at 4:39 PM, Ryosuke Niwa wrote: > > >> On Aug 21, 2023, at 4:34 PM, Darin Adler wrote: >> >> >>> On Aug 21, 2023, at 4:31 PM, Tim Horton via webkit-dev >>> wrote: >>> >>>> One subtle thing is that even

Re: [webkit-dev] Smart Pointers Usage Guidelines

> On Aug 21, 2023, at 4:34 PM, Darin Adler wrote: > > >> On Aug 21, 2023, at 4:31 PM, Tim Horton via webkit-dev >> wrote: >> >>> One subtle thing is that even when a member variable is already Ref / >>> RefPtr / CheckedRef / CheckedPtr, we

Re: [webkit-dev] Smart Pointers Usage Guidelines

> On Aug 21, 2023, at 4:25 PM, Ryosuke Niwa via webkit-dev > wrote: > > Hi all, > > It has been a while since I last announced the plan to adopt smart pointers > using clang static analyzer: > https://lists.webkit.org/pipermail/webkit-dev/2020-September/031386.html > > Here are some

Re: [webkit-dev] OK to flatten WTF's header directory?

> On Feb 1, 2022, at 12:30 PM, Elliott Williams via webkit-dev > wrote: > > Hi webkit-dev, > > I’m working on fixing some ambiguities in our Xcode projects to permit > adoption of Xcode’s new build system and better parallelize our builds. I > noticed that WTF’s headers

[webkit-dev] Aditya Keerthi is now a WebKit reviewer!

Hello! I am delighted to announce that Aditya Keerthi is now a WebKit reviewer. Now it's time for all of you to send him tricky patches and see how he does :) Congratulations, Aditya! --Tim ___ webkit-dev mailing list webkit-dev@lists.webkit.org

Re: [webkit-dev] New EWS Non-Unified builder

> On Apr 29, 2021, at 9:02 PM, Darin Adler wrote: > >> On Apr 29, 2021, at 9:01 PM, Tim Horton wrote: >> >> This is a huge problem for people on the Apple platforms using the Xcode >> projects. Nearly every time someone adds a file they have to add random

Re: [webkit-dev] New EWS Non-Unified builder

> On Apr 29, 2021, at 7:15 PM, Darin Adler via webkit-dev > wrote: > >> On Apr 29, 2021, at 12:04 PM, Ross Kirsling via webkit-dev >> wrote: >> >> Yeah, I think it's important to clarify that nobody is "using >> non-Unified-Source building for their development", at least to my >>

Re: [webkit-dev] Having trouble building

> On Oct 4, 2019, at 8:55 PM, Ken Russell wrote: > > Hi, > > Recently I upgraded to Xcode 11.0 and re-synced to top-of-tree WebKit. With a > clean WebKitBuild directory I'm seeing the following build error: What OS are you on? You might want to peek at

Re: [webkit-dev] Moving to Python 3

> On Jul 12, 2019, at 12:18 PM, Jonathan Bedard wrote: > > Hello WebKit developers, > > Now that the Catalina developer seeds are available, it is official that the > new Mac developer tools come with Python 3. As a result, we need to continue > the ongoing discussion about migrating our

Re: [webkit-dev] Which WTF headers still should be in C++11?

This was a hopefully-shortlived internal complication. I think this is already fixed and we could probably revert this change. Is that right, Alex? > On Jun 19, 2019, at 7:38 PM, Fujii Hironori wrote: > > Hi, > > wtf/CheckedArithmetic.h has been converted from C++14 to C++11. > > Bug 195187

Re: [webkit-dev] Requesting feedback about EWS comments on Bugzilla bugs

> On Jun 15, 2019, at 21:13, Aakash Jain wrote: > >  > Hi Everyone, > > I am gathering feedback about EWS - specially about the comments which EWS > makes on the Bugzilla bugs. Currently, the comments are not very > user-friendly/polished/readable and are sometimes very noisy (e.g.: 72 >

Re: [webkit-dev] Unified source builds and adding or removing files...

We already had this discussion; see the thread titled "Unified sources have broken our #include hygiene" > On Mar 19, 2019, at 3:48 PM, Said Abou-Hallawa wrote: > > I have been working on patches that require adding and removing cpp files > from WebCore/Sources.txt. Almost every time I add or

Re: [webkit-dev] Code Style: Opinion on returning void

> On Feb 7, 2019, at 12:47 PM, Daniel Bates wrote: > > Hi all, > > Something bothers me about code like: > > void f(); > void g() > { > if (...) > return f(); > return f(); > } ⸘do people do this‽ > I prefer: > > void g() > { > if (...) { > f(); >

Re: [webkit-dev] WebKit Commit Queue blocked by build errors in ToT

t; >> On Dec 7, 2018, at 8:45 AM, Chris Fleizach wrote: >> >> Looks like there's quite a few of these. Will try to get them all >> >>> On Dec 7, 2018, at 8:37 AM, Tim Horton wrote: >>> >>> Someone in UnifiedSource28-mm.mm is “using namesp

Re: [webkit-dev] WebKit Commit Queue blocked by build errors in ToT

Someone in UnifiedSource28-mm.mm is “using namespace WebCore” outside of the root namespace. > On Dec 7, 2018, at 08:31, Chris Fleizach wrote: > > I'm hitting this tougher one now. Namespace conflict between Rect in Carbon > and WebCore::Rect > > Any ideas? > Thanks for your help > > n file

Re: [webkit-dev] Unified sources have broken our #include hygiene

> On Sep 1, 2018, at 17:14, Simon Fraser wrote: > > Unified sources allow you to get away without #including all the files you > need in a .cpp file, because some earlier file in the group has probably > already included them for you. > > This means that when you add a new file to the

Re: [webkit-dev] Experimental features enabled by default

Alright, how’s it looking now? :) > On Jun 26, 2018, at 19:06, Tim Horton wrote: > > > >> On Jun 26, 2018, at 18:55, Michael Catanzaro wrote: >> >> >> Hi, >> >> We're a lot closer after r233227! >> >> There is still IsSecureCo

Re: [webkit-dev] Experimental features enabled by default

> On Jun 26, 2018, at 18:55, Michael Catanzaro wrote: > > > Hi, > > We're a lot closer after r233227! > > There is still IsSecureContextAttributeEnabled. Shall we switch the default > value of that one to use DEFAULT_EXPERIMENTAL_FEATURES_ENABLED instead of > true? Not sure, waiting for

Re: [webkit-dev] Experimental features enabled by default

Resending from the right address. > On Jun 20, 2018, at 11:12 AM, Michael Catanzaro wrote: > > Hi, Apple folks have been chatting about this elsewhere, so it’s a humorous coincidence to see this here at the same time. > I noticed in glancing over WebPreferences.yaml that we have a large

Re: [webkit-dev] Update WebKit style to better accommodate accepted Obj-C block syntax

Whatever we decide, we should probably also get it in https://webkit.org/code-style-guidelines/ > On Oct 3, 2017, at 4:51 PM, Megan Gardner wrote: > > > Currently, the webkit style checker does not allow ^{ at the beginning of > Obj-C blocks. It demands that there is

Re: [webkit-dev] Are CSS constant properties and viewport fit features still experimental?

> On Sep 22, 2017, at 12:08, Michael Catanzaro wrote: > > Hi, > > I noticed today that in our experimental features list (in > WebPreferencesDefinitions.h), CSS constant properties and viewport fit are > both enabled unconditionally. > > Should I move them to the

Re: [webkit-dev] RFC: Removing feature flag defaults in build-webkit

> On Sep 21, 2017, at 13:25, Michael Catanzaro <mcatanz...@igalia.com> wrote: > > On Thu, Sep 21, 2017 at 2:26 PM, Tim Horton <timothy_hor...@apple.com> wrote: >> Sure. And someday I think we should go down that path, but generating the >> xcconfigs will

Re: [webkit-dev] RFC: Removing feature flag defaults in build-webkit

> On Sep 21, 2017, at 12:04, Konstantin Tokarev <annu...@yandex.ru> wrote: > > > > 21.09.2017, 22:01, "Tim Horton" <timothy_hor...@apple.com>: >>> On Sep 21, 2017, at 11:57, Konstantin Tokarev <annu...@yandex.ru> wrote: >>> &

Re: [webkit-dev] RFC: Removing feature flag defaults in build-webkit

> On Sep 21, 2017, at 11:57, Konstantin Tokarev <annu...@yandex.ru> wrote: > > > > 21.09.2017, 21:54, "Tim Horton" <timothy_hor...@apple.com>: >> Hi, all! >> >> Would anybody mind if build-webkit stopped being a source of defau

[webkit-dev] RFC: Removing feature flag defaults in build-webkit

Hi, all! Would anybody mind if build-webkit stopped being a source of default values of feature flags? We have defaults for feature flags in FeatureDefines.xcconfig for Xcode, WebKitFeatures.cmake (and Options*.cmake for platform overrides) for CMake, and FeatureDefines.h for everyone. This

Re: [webkit-dev] Proposal: Remove CSS color-correction property

On Jul 1, 2015, at 23:36, Dirk Schulze dschu...@adobe.com wrote: Hi Darin, On Jul 1, 2015, at 5:16 PM, Darin Adler da...@apple.com wrote: Hi folks. WebKit has a CSS property named color-correction. It’s still prefixed, so some would call it -webkit-color-correction and I don’t

Re: [webkit-dev] WEBCORE_EXPORT

They also seem like prime candidates for stylebot rules. On Feb 23, 2015, at 3:31 PM, Darin Adler da...@apple.com wrote: Hooray! Lets document these somewhere so people don’t have to read the webkit-dev archives to learn these rules. Maybe in the header that defines WEBCORE_EXPORT?

Re: [webkit-dev] Abandoned Tests

On Jan 22, 2015, at 14:02, Benjamin Poulain benja...@webkit.org wrote: On 1/21/15 8:48 PM, Brent Fulgham wrote: I’ve been reviewing the various Windows layout tests, and have run across a few tests that seem to be leftovers from the Chromium project. I think all ports currently skip

Re: [webkit-dev] Is commit-queue broken ?

I think the necessary emails have been sent to resolve it, but everyone is on vacation :( I can't commit manually either. On Nov 26, 2014, at 19:33, Gyuyoung Kim gyuyoung@webkit.org wrote: Hello, It looks WebKit queue doesn't work now. Does anyone check it ? Gyuyoung. --

Re: [webkit-dev] Port-specific OpenType support

On 2014.09.14, at 01:11, Dirk Schulze k...@webkit.org wrote: On Sep 11, 2014, at 11:03 PM, Martin Robinson mrobin...@webkit.org wrote: On Thu, Sep 11, 2014 at 11:44 AM, Myles C. Maxfield mmaxfi...@apple.com wrote: My question to WebKit-Dev is: Are there any ports who: 1) Want continued

Re: [webkit-dev] TestWebKitAPI doesn't initialize WKWebView from command line

On 2014.08.26, at 04:44, Daniel Lazarenko dani...@opera.com wrote: Hello, I’m trying to run the WKWebView API tests using this command: ./TestWebKitAPI --gtest_filter=_WKDownload.DownloadRequest This binary is located in webkit/WebKitBuild/Debug, I’ve built it using Xcode beta 6 on

Re: [webkit-dev] Please avoid inheriting concrete types over WebCore/WebKit boundary

On Aug 22, 2014, at 11:07, Antti Koivisto koivi...@iki.fi wrote: Hi, To make callbacks from WebCore to WebKit(2) we have generally used approach where WebCore exports an abstract client interface which is then implemented on the WebKit side. More recently there has been some

Re: [webkit-dev] Questions about ports

On Aug 5, 2014, at 23:48, Jacques-Olivier jo.ha...@temasys.com.sg wrote: Hi everyone, I have a couple of questions regarding the different ports of WebKit: 1) I suppose the port used by Safari Mac OS X is the Apple’s mac port (built by default) Is there a planing of when a version of

Re: [webkit-dev] Comment on the bug email author/reviewer before reverting a patch

On Jul 9, 2014, at 12:10 PM, Maciej Stachowiak m...@apple.com wrote: Could we teach webkitbot to do an appropriate notification with a waiting period? Either as part of rollout or add a new command to do it. It already does. The “waiting period” is defined by when the person who asked

Re: [webkit-dev] PSA: please sort WebCore.exp.in when you change it

On Jul 7, 2014, at 11:41 AM, Simon Fraser simon.fra...@apple.com wrote: We have a handy script that sorts the export file; please use it whenever you modify WebCore.exp.in: ./Tools/Scripts/sort-export-file Source/WebCore/WebCore.exp.in It’s also smart enough to require no arguments at

Re: [webkit-dev] PSA: please sort WebCore.exp.in when you change it

On Jul 7, 2014, at 1:51 PM, Bem Jones-Bey bjone...@adobe.com wrote: On Jul 7, 2014, at 11:55 , Tim Horton timothy_hor...@apple.com wrote: On Jul 7, 2014, at 11:41 AM, Simon Fraser simon.fra...@apple.com wrote: We have a handy script that sorts the export file; please use it whenever

Re: [webkit-dev] PDF: context menu and view mode

On Apr 6, 2014, at 2:00 AM, Rüdiger Cordes r...@opelgt.org wrote: Hello list, this is my first mail and I want so say Hi to you. The reason why I entered this list: I would like to know why the context menu for opened PDFs in Safari has changed after r153570 in r153759. The context

Re: [webkit-dev] EWS doesn't lie!

On Feb 10, 2014, at 12:51 AM, youenn fablet youe...@gmail.com wrote: Is it by design that only mac bots run regression tests? Certainly not. Technical issue? I think so; look at http://build.webkit.org/dashboard/; the Mac port is the only one that’s even close to green enough to make

Re: [webkit-dev] MathML

On Dec 20, 2013, at 4:57 PM, Peter Frane pfran...@hotmail.com wrote: Why did my email bounce? I'm a subscribed. Thanks. It didn’t. From: pfran...@hotmail.com To: webkit-dev@lists.webkit.org Date: Sat, 21 Dec 2013 08:15:07 +0800 Subject: [webkit-dev] MathML To whom it may concern,

Re: [webkit-dev] Test flakiness.

On Dec 3, 2013, at 1:51 PM, Samuel White samuel_wh...@apple.com wrote: Hey everyone, I've noticed the following build message: Unexpected flakiness: text-only failures (1) platform/mac/accessibility/search-predicate-element-count.html [ Failure Pass ] Oddly, when this test is run

Re: [webkit-dev] Layout Tests Failure

On 2013.10.09, at 19:18, Gurpreet Kaur gur.t...@gmail.com wrote: address space needed by 'datetime.dll' (0x211) is already occupied http://cygwin.com/faq-nochunks.html#faq.using.fixing-fork-failures and http://cygwin.com/faq-nochunks.html#faq.using.bloda might be helpful. I’ve seen this

Re: [webkit-dev] WebGL :: Win32 = build successful and rendering assumed so = but white page

On 2013.10.03, at 09:06, Hugo Machefer hugo.mache...@gmail.com wrote: Dear all. Might not the best place -here- to describe my issue [Win32], but I don't know where exactly this shall be submitted, as a novice by WebKit. To recap, I managed to compile WebKit-r156532 sources by Microsoft

Re: [webkit-dev] Webkit 2 drawing

On Jun 4, 2013, at 10:18 PM, Vishvesh Community vishvesh@gmail.com wrote: Hi All, I have been going through the webkit 2 code. But I am not able to findout how the bitmaps are shared between the webprocess and the UI process. Can anybody point me to the appropriate class or share

Re: [webkit-dev] Buildsystem cleanup

On Apr 8, 2013, at 3:44 PM, Patrick Gansterer par...@paroga.com wrote: I wasn’t aware that the build worked without a VS2010 pThreads build. I was running into issues because of the pThreads dll having embedded manifest problems earlier. Did you do anything special to circumvent that issue?

Re: [webkit-dev] Re-enabling pixel tests

We should probably sort out some of our known and solvable OS-version-dependent color profile bugs *before* attempting any mass rebaselines, to avoid having to do them twice. On Apr 4, 2013, at 7:37 PM, Benjamin Poulain benja...@webkit.org wrote: On Thu, Apr 4, 2013 at 7:26 PM, Ryosuke Niwa

Re: [webkit-dev] Please don't land patches without rebaselining tests for at least one platform

On Mar 22, 2013, at 1:34 PM, Ryosuke Niwa rn...@webkit.org wrote: On Thu, Mar 21, 2013 at 6:43 PM, Ryosuke Niwa rn...@webkit.org wrote: On Thu, Mar 21, 2013 at 6:39 PM, Silvia Pfeiffer silvi...@chromium.org wrote: On Fri, Mar 22, 2013 at 12:30 PM, Ryosuke Niwa rn...@webkit.org wrote: On

Re: [webkit-dev] Proposal for coding guidelines: Do not use fall-through switch cases inside #ifdef's

On Aug 17, 2012, at 11:57 AM, Bruno Abinader brunoabina...@gmail.com wrote: On Fri, Aug 17, 2012 at 2:24 PM, Joe Mason jma...@rim.com wrote: What do you mean by precompiler? The preprocessor? Or is this a precompiled headers thing? Indeed, s/precompiler/preprocessor :) Are you

Re: [webkit-dev] Proposal for coding guidelines: Do not use fall-through switch cases inside #ifdef's

. The line is correct as it stands. -Jake On Sat, Aug 18, 2012 at 8:20 PM, Tim Horton timothy_hor...@apple.com wrote: On Aug 17, 2012, at 11:57 AM, Bruno Abinader brunoabina...@gmail.com wrote: On Fri, Aug 17, 2012 at 2:24 PM, Joe Mason jma...@rim.com wrote: What do you mean by precompiler