It sounds like no one wants this (passionately) as part of the WebKit style,
so I put up a patch to remove this warning (and I won't add that text to the
WebKit style guide when I modify it).
https://bugs.webkit.org/show_bug.cgi?id=33214
Dave
On Mon, Jan 4, 2010 at 4:02 PM, Dirk Schulze
I noticed recently that the style bot started complaining about header files
ending with #endif instead of #endif // Foo_h. I was surprised by this
since the style guide does not require it.
Should the style guide be changed to require this comment, or should the
style bot be taught to ignore
On Jan 4, 2010, at 3:33 PM, Darin Fisher wrote:
I noticed recently that the style bot started complaining about header files
ending with #endif instead of #endif // Foo_h. I was surprised by this
since the style guide does not require it.
I personally see little value in this sort of
These seemed to be common in WebKit code, so I had it in
http://lists.macosforge.org/pipermail/webkit-dev/2009-September/009807.html(--
Sorry for letting this one linger for so long. It is in my queue just
low on the priority list).
Here's the relevant part:
#if(def) statements
If an #if(def)
We have somtimes constructs like
#endif // ENABLE(SVG)
#endif // Foo_h
It just helps to understand why there are two endif's and what they are
good for. I think it's not a style issue not to write this comment, but
it can be helpful.
-Dirk
Am Montag, den 04.01.2010, 15:41 -0800 schrieb Darin
5 matches
Mail list logo