Re: [webkit-dev] [chromium] using WEBKIT_API properly

2011-01-04 Thread Darin Fisher
Correction: you meant pure virtual functions. (I'm adding a note to the README file about these rules by the way.) -Darin On Fri, Dec 3, 2010 at 8:55 AM, Darin Fisher da...@chromium.org wrote: Yes, indeed. Thanks Jeremy! On Fri, Dec 3, 2010 at 3:13 AM, Jeremy Orlow jor...@chromium.org

Re: [webkit-dev] [chromium] using WEBKIT_API properly

2010-12-03 Thread Jeremy Orlow
You forgot to mention virtual functions, which is another case where you do _not_ use WEBKIT_API. J On Thu, Dec 2, 2010 at 9:27 PM, Darin Fisher da...@chromium.org wrote: If you do not work on the Chromium port of WebKit, you can stop reading now. I've noticed that there is some confusion

Re: [webkit-dev] [chromium] using WEBKIT_API properly

2010-12-03 Thread Darin Fisher
Yes, indeed. Thanks Jeremy! On Fri, Dec 3, 2010 at 3:13 AM, Jeremy Orlow jor...@chromium.org wrote: You forgot to mention virtual functions, which is another case where you do _not_ use WEBKIT_API. J On Thu, Dec 2, 2010 at 9:27 PM, Darin Fisher da...@chromium.org wrote: If you do not

[webkit-dev] [chromium] using WEBKIT_API properly

2010-12-02 Thread Darin Fisher
If you do not work on the Chromium port of WebKit, you can stop reading now. I've noticed that there is some confusion about how to use WEBKIT_API properly. WEBKIT_API causes a function to be exported from WebKit when it is built as a DLL, allowing Chromium to call the function. The rule is