Re: [webkit-dev] Adding New Layout Tests

2007-06-02 Thread David D. Kilzer
Reem Yazigi <[EMAIL PROTECTED]> wrote: > Thanks for your helpful answers. I still have some more questions for you guys: > > 1- Dave said "Image test is required to capture expected results that a text > based test can't". Can you please provide me with a path/name of one of these > cases? $ ls

Re: [webkit-dev] Adding New Layout Tests

2007-06-01 Thread Reem Yazigi
Dave, Adam, and All, Thanks for your helpful answers. I still have some more questions for you guys: 1- Dave said "Image test is required to capture expected results that a text based test can't". Can you please provide me with a path/name of one of these cases? 2- I actually need to know which o

Re: [webkit-dev] Adding New Layout Tests

2007-05-29 Thread Adam Roben
On May 29, 2007, at 6:14 PM, David D. Kilzer wrote: 2- Why is the render tree dumps different for each platform? They should be the same, but invariably differences in fonts (and thus font metrics) may cause the pages to be laid out slightly differently. I'm not sure if there are any othe

Re: [webkit-dev] Adding New Layout Tests

2007-05-29 Thread David D. Kilzer
> 1- Why not all of the layout tests are working on Qt? Aren't they supposed to test > the core? Because the Qt port is still a work-in-progress, although it is progressing rapidly! > So, why do they all work on Safari but not on Qt? Because they were written first for the Safari port. > 2- Why

Re: [webkit-dev] Adding New Layout Tests

2007-05-29 Thread Reem Yazigi
Dave, Kirby and all, Thanks for the useful answers and documentation. I have some more questions that I need answers for before I start adding new test cases: 1- Why not all of the layout tests are working on Qt? Aren't they supposed to test the core? So, why do they all work on Safari but not on

Re: [webkit-dev] Adding New Layout Tests

2007-05-24 Thread David D. Kilzer
Reem Yazigi <[EMAIL PROTECTED]> wrote: > 1- Are the expected-results files browser dependent? The expected results files are simply text, but there are two basic types: render tree dumps and text dumps. The render tree dumps will be different for each platform, while the text dumps should be t

Re: [webkit-dev] Adding New Layout Tests

2007-05-24 Thread Kirby White
On 5/23/07, Kirby White <[EMAIL PROTECTED]> wrote: On 5/23/07, Darin Adler <[EMAIL PROTECTED]> wrote: > On May 22, 2007, at 5:04 PM, Reem Yazigi wrote: > > > Any step by step documentation for adding and running a new Layout > > test? > > There's not. Many people have added new tests themselves

Re: [webkit-dev] Adding New Layout Tests

2007-05-24 Thread Reem Yazigi
Darin and All, Thanks for the useful info. >Layout tests have expected results. Running the "run-webkit-tests"  >script creates an expected result file for each new test. The person >  who writes the test looks at the expected result file and makes >sure  it reflects correct behavior. Then the per

Re: [webkit-dev] Adding New Layout Tests

2007-05-23 Thread Kirby White
On 5/23/07, Darin Adler <[EMAIL PROTECTED]> wrote: On May 22, 2007, at 5:04 PM, Reem Yazigi wrote: > I need to add some new Layout tests and everything I found online > concerning this issue can be found in the following 2 links: > > http://webkit.org/quality/testwriting.html > http://t

Re: [webkit-dev] Adding New Layout Tests

2007-05-23 Thread Darin Adler
On May 22, 2007, at 5:04 PM, Reem Yazigi wrote: I need to add some new Layout tests and everything I found online concerning this issue can be found in the following 2 links: http://webkit.org/quality/testwriting.html http://trac.webkit.org/projects/webkit/wiki/Writing%20Layout% 20Te

[webkit-dev] Adding New Layout Tests

2007-05-22 Thread Reem Yazigi
Hi,   I need to add some new Layout tests and everything I found online concerning this issue can be found in the following 2 links:   http://webkit.org/quality/testwriting.html http://trac.webkit.org/projects/webkit/wiki/Writing%20Layout%20Tests%20for%20DumpRenderTree   I'm still confused though