Isn't ref counting supposed to be _really_ optimized for exactly this use?
It seems like a good match--unless you have major issues with
cycles...which might be the issue?
J
On Thu, Sep 2, 2010 at 3:20 AM, Kenneth Russell k...@google.com wrote:
I would be happy to not add another Arena
On Thu, Sep 2, 2010 at 8:51 AM, Chris Marrin cmar...@apple.com wrote:
On Sep 1, 2010, at 7:20 PM, Kenneth Russell wrote:
I would be happy to not add another Arena client, but the primary
reason I need an arena is not just for performance but to avoid having
to keep track of all of the
Reference counting is not a solution. It still requires pointers to track
objects. KBR is avoiding the overhead of storing pointers to track objects.
That's the point of using an arena allocator for things that do not have
destructors.
-Darin
On Thu, Sep 2, 2010 at 3:15 AM, Jeremy Orlow
There are two cyclic data structures in the code I am adding. I would
not want to have to retrofit them with reference counting, at least
not before an initial commit so that there is a checkpoint.
-Ken
On Thu, Sep 2, 2010 at 3:15 AM, Jeremy Orlow jor...@chromium.org wrote:
Isn't ref counting
On Thu, Sep 2, 2010 at 8:51 AM, Chris Marrin cmar...@apple.com wrote:
On Sep 1, 2010, at 7:20 PM, Kenneth Russell wrote:
I would be happy to not add another Arena client, but the primary
reason I need an arena is not just for performance but to avoid having
to keep track of all of the
On Sep 2, 2010, at 8:51 AM, Chris Marrin wrote:
On Sep 1, 2010, at 7:20 PM, Kenneth Russell wrote:
I would be happy to not add another Arena client, but the primary
reason I need an arena is not just for performance but to avoid having
to keep track of all of the objects I need to
On Sep 2, 2010, at 9:41 AM, Kenneth Russell wrote:
On Thu, Sep 2, 2010 at 8:51 AM, Chris Marrin cmar...@apple.com wrote:
On Sep 1, 2010, at 7:20 PM, Kenneth Russell wrote:
I would be happy to not add another Arena client, but the primary
reason I need an arena is not just for performance
On Thu, Sep 2, 2010 at 9:59 AM, Chris Marrin cmar...@apple.com wrote:
On Sep 2, 2010, at 9:41 AM, Kenneth Russell wrote:
On Thu, Sep 2, 2010 at 8:51 AM, Chris Marrin cmar...@apple.com wrote:
On Sep 1, 2010, at 7:20 PM, Kenneth Russell wrote:
I would be happy to not add another Arena
Ken's PODRedBlackTree patch has made me go back and take a closer look at
WebKit's Arena class. Turns out it's not a class at all, just some structs
and macros. That seems very un-WebKit-like to me. Ken's patch also has a
PODArena class, which uses Arena in its implementation. Sam suggests
On Wed, Sep 1, 2010 at 4:20 PM, Chris Marrin cmar...@apple.com wrote:
Ken's PODRedBlackTree patch has made me go back and take a closer look at
WebKit's Arena class. Turns out it's not a class at all, just some structs
and macros. That seems very un-WebKit-like to me. Ken's patch also has a
On Sep 1, 2010, at 4:20 PM, Chris Marrin wrote:
Ken's PODRedBlackTree patch has made me go back and take a closer look at
WebKit's Arena class. Turns out it's not a class at all, just some structs
and macros. That seems very un-WebKit-like to me. Ken's patch also has a
PODArena class,
On Sep 1, 2010, at 4:39 PM, Maciej Stachowiak wrote:
On Sep 1, 2010, at 4:20 PM, Chris Marrin wrote:
Ken's PODRedBlackTree patch has made me go back and take a closer look at
WebKit's Arena class. Turns out it's not a class at all, just some structs
and macros. That seems very
On Wed, Sep 1, 2010 at 5:08 PM, Chris Marrin cmar...@apple.com wrote:
On Sep 1, 2010, at 4:39 PM, Maciej Stachowiak wrote:
On Sep 1, 2010, at 4:20 PM, Chris Marrin wrote:
Ken's PODRedBlackTree patch has made me go back and take a closer look at
WebKit's Arena class. Turns out it's not a
On Sep 1, 2010, at 5:12 PM, Kenneth Russell wrote:
On Wed, Sep 1, 2010 at 5:08 PM, Chris Marrin cmar...@apple.com wrote:
On Sep 1, 2010, at 4:39 PM, Maciej Stachowiak wrote:
On Sep 1, 2010, at 4:20 PM, Chris Marrin wrote:
Ken's PODRedBlackTree patch has made me go back and take a
We should just kill Arena and remove it and RenderArena both.
dave
On Sep 1, 2010, at 4:20 PM, Chris Marrin wrote:
Ken's PODRedBlackTree patch has made me go back and take a closer look at
WebKit's Arena class. Turns out it's not a class at all, just some structs
and macros. That seems
On Sep 1, 2010, at 7:04 PM, David Hyatt wrote:
We should just kill Arena and remove it and RenderArena both.
Wasn't it still a measurable slowdown last time we tried that?
- Maciej
On Sep 1, 2010, at 4:20 PM, Chris Marrin wrote:
Ken's PODRedBlackTree patch has made me go back and
On Sep 1, 2010, at 7:07 PM, Maciej Stachowiak wrote:
On Sep 1, 2010, at 7:04 PM, David Hyatt wrote:
We should just kill Arena and remove it and RenderArena both.
Wasn't it still a measurable slowdown last time we tried that?
Not enough to matter. We could easily make up the
Please let's not add another client of Arena though. That will just make it
harder to remove, and I highly doubt you're getting any real performance gain
from using it.
dave
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
I would be happy to not add another Arena client, but the primary
reason I need an arena is not just for performance but to avoid having
to keep track of all of the objects I need to delete.
Is there any consensus yet on how to proceed with
https://bugs.webkit.org/show_bug.cgi?id=45059 ? I'm
19 matches
Mail list logo