Re: [webkit-dev] C++ unit tests for WebKit?

2012-07-11 Thread Hajime Morrita
ally. > That's not always possible, but it tends to be a good approach for > generating test coverage. > > I'm happy to discuss this topic further in #webkit if that would be > helpful to you. > > Adam > > > >> From: Adam Barth >> To: Hans Muller

Re: [webkit-dev] C++ unit tests for WebKit?

2012-07-11 Thread Adam Barth
rage. I'm happy to discuss this topic further in #webkit if that would be helpful to you. Adam > From: Adam Barth > To: Hans Muller > Cc: Benjamin Poulain , Konrad Piascik < > kpias...@rim.com>, webkit-dev > Subject: Re: [webkit-dev] C++ unit tests for WebKit? > &g

Re: [webkit-dev] C++ unit tests for WebKit?

2012-07-11 Thread Hans Muller
bkit-dev mailto:webkit-dev@lists.webkit.org>> Subject: Re: [webkit-dev] C++ unit tests for WebKit? Generally speaking, WebKit's testing philosophy is to test at API boundaries, typically either a given port's WebKit API or the web platform API. The benefit of that approach i

Re: [webkit-dev] C++ unit tests for WebKit?

2012-07-11 Thread Adam Barth
Generally speaking, WebKit's testing philosophy is to test at API boundaries, typically either a given port's WebKit API or the web platform API. The benefit of that approach is that it makes it easier for us to refactor the internals of WebCore without being constrained by fragile tests---only by

Re: [webkit-dev] C++ unit tests for WebKit?

2012-07-11 Thread Hans Muller
It looks like Tools/TestWebKitAPI/Tests/WebCore just contains one small KURL test. I could certainly add more for the Exclusions shape classes, but I got that feeling that maybe you get about being the first to take a table at an empty restaurant. Perhaps it's just that most of the C++ classes in

Re: [webkit-dev] C++ unit tests for WebKit?

2012-07-11 Thread Konrad Piascik
ebkit-dev] C++ unit tests for WebKit? Bear Travis, Alexandru Chiculita, and I have been working on the WebKit CSS Exclusions implementation. I've been working on a set of C++ classes that are used to compute the layout of inline content around or within exclusion shapes. When I got start

Re: [webkit-dev] C++ unit tests for WebKit?

2012-07-11 Thread Benjamin Poulain
On Wed, Jul 11, 2012 at 2:23 PM, Hans Muller wrote: > Have the merits of C++ unit tests been debated before? I noticed that a bug > representing as much has been around since 2008 > (https://bugs.webkit.org/show_bug.cgi?id=21010). The last comment (2009) > concludes with: "I'd be interested to h

[webkit-dev] C++ unit tests for WebKit?

2012-07-11 Thread Hans Muller
Bear Travis, Alexandru Chiculita, and I have been working on the WebKit CSS Exclusions implementation. I've been working on a set of C++ classes that are used to compute the layout of inline content around or within exclusion shapes. When I got started, before attempting to integrate the code