Re: [webkit-dev] Complex and Vector3 classes in WTF?

2010-09-01 Thread Chris Marrin
On Aug 31, 2010, at 6:59 PM, Kenneth Russell wrote: On Tue, Aug 31, 2010 at 6:42 PM, Maciej Stachowiak m...@apple.com wrote: On Aug 31, 2010, at 5:29 PM, Chris Marrin wrote: On Aug 31, 2010, at 5:25 PM, Kenneth Russell wrote: ...Yes, I did the Google search and you're right that the

Re: [webkit-dev] Complex and Vector3 classes in WTF?

2010-09-01 Thread Maciej Stachowiak
On Sep 1, 2010, at 11:43 AM, Chris Marrin wrote: But I agree with Maciej that all of the public API is transformation oriented. Even things like inverse() and transpose() have application in doing transforms. I think it would be a stretch to use this 4x4 matrix for general purposes. A

Re: [webkit-dev] Complex and Vector3 classes in WTF?

2010-09-01 Thread Chris Marrin
On Sep 1, 2010, at 1:48 PM, Simon Fraser wrote: On Sep 1, 2010, at 1:04 PM, Chris Marrin wrote: On Sep 1, 2010, at 12:29 PM, Maciej Stachowiak wrote: On Sep 1, 2010, at 11:43 AM, Chris Marrin wrote: But I agree with Maciej that all of the public API is transformation oriented. Even

[webkit-dev] Complex and Vector3 classes in WTF?

2010-08-31 Thread Chris Marrin
I just noticed these classes, added 7 months ago as part of Chris Rogers' audio work. I think it's a mistake to have these in WTF for a few reasons: 1) Complex is just std::complex with a single added function, complexFromMagnitudePhase(), which seems pretty audio specific, so it should go

Re: [webkit-dev] Complex and Vector3 classes in WTF?

2010-08-31 Thread David Hyatt
On Aug 31, 2010, at 10:36 AM, Chris Marrin wrote: Or should we get rid of Vector3, added the functionality it needs to FloatPoint3D and use that? Ken Russell already has plans to do add the functions to FloatPoint3D, so I would vote for that. I would vote for this. I don't think the

Re: [webkit-dev] Complex and Vector3 classes in WTF?

2010-08-31 Thread Kenneth Russell
On Tue, Aug 31, 2010 at 11:05 AM, David Hyatt hy...@apple.com wrote: On Aug 31, 2010, at 10:36 AM, Chris Marrin wrote: Or should we get rid of Vector3, added the functionality it needs to FloatPoint3D and use that? Ken Russell already has plans to do add the functions to FloatPoint3D, so I

Re: [webkit-dev] Complex and Vector3 classes in WTF?

2010-08-31 Thread Maciej Stachowiak
On Aug 31, 2010, at 2:06 PM, Chris Marrin wrote: On Aug 31, 2010, at 11:48 AM, Kenneth Russell wrote: On Tue, Aug 31, 2010 at 11:05 AM, David Hyatt hy...@apple.com wrote: On Aug 31, 2010, at 10:36 AM, Chris Marrin wrote: Or should we get rid of Vector3, added the functionality it needs

Re: [webkit-dev] Complex and Vector3 classes in WTF?

2010-08-31 Thread Chris Marrin
On Aug 31, 2010, at 3:25 PM, Maciej Stachowiak wrote: On Aug 31, 2010, at 2:06 PM, Chris Marrin wrote: On Aug 31, 2010, at 11:48 AM, Kenneth Russell wrote: On Tue, Aug 31, 2010 at 11:05 AM, David Hyatt hy...@apple.com wrote: On Aug 31, 2010, at 10:36 AM, Chris Marrin wrote: Or

Re: [webkit-dev] Complex and Vector3 classes in WTF?

2010-08-31 Thread Kenneth Russell
On Tue, Aug 31, 2010 at 3:39 PM, Chris Marrin cmar...@apple.com wrote: On Aug 31, 2010, at 3:25 PM, Maciej Stachowiak wrote: On Aug 31, 2010, at 2:06 PM, Chris Marrin wrote: On Aug 31, 2010, at 11:48 AM, Kenneth Russell wrote: On Tue, Aug 31, 2010 at 11:05 AM, David Hyatt hy...@apple.com

Re: [webkit-dev] Complex and Vector3 classes in WTF?

2010-08-31 Thread Chris Marrin
On Aug 31, 2010, at 3:43 PM, Kenneth Russell wrote: On Tue, Aug 31, 2010 at 3:39 PM, Chris Marrin cmar...@apple.com wrote: On Aug 31, 2010, at 3:25 PM, Maciej Stachowiak wrote: On Aug 31, 2010, at 2:06 PM, Chris Marrin wrote: On Aug 31, 2010, at 11:48 AM, Kenneth Russell wrote:

Re: [webkit-dev] Complex and Vector3 classes in WTF?

2010-08-31 Thread Maciej Stachowiak
On Aug 31, 2010, at 3:59 PM, Chris Marrin wrote: On Aug 31, 2010, at 3:43 PM, Kenneth Russell wrote: On Tue, Aug 31, 2010 at 3:39 PM, Chris Marrin cmar...@apple.com wrote: On Aug 31, 2010, at 3:25 PM, Maciej Stachowiak wrote: On Aug 31, 2010, at 2:06 PM, Chris Marrin wrote: On

Re: [webkit-dev] Complex and Vector3 classes in WTF?

2010-08-31 Thread Kenneth Russell
On Tue, Aug 31, 2010 at 4:22 PM, Maciej Stachowiak m...@apple.com wrote: On Aug 31, 2010, at 3:59 PM, Chris Marrin wrote: On Aug 31, 2010, at 3:43 PM, Kenneth Russell wrote: On Tue, Aug 31, 2010 at 3:39 PM, Chris Marrin cmar...@apple.com wrote: On Aug 31, 2010, at 3:25 PM, Maciej

Re: [webkit-dev] Complex and Vector3 classes in WTF?

2010-08-31 Thread Chris Marrin
On Aug 31, 2010, at 5:25 PM, Kenneth Russell wrote: ...Yes, I did the Google search and you're right that the term is not in common usage (although I still maintain it's a completely reasonable term). The reason I think it's meaningful is because it really is a matrix of sorts, but a

Re: [webkit-dev] Complex and Vector3 classes in WTF?

2010-08-31 Thread Maciej Stachowiak
On Aug 31, 2010, at 5:29 PM, Chris Marrin wrote: On Aug 31, 2010, at 5:25 PM, Kenneth Russell wrote: ...Yes, I did the Google search and you're right that the term is not in common usage (although I still maintain it's a completely reasonable term). The reason I think it's meaningful