On Wed, Jul 7, 2010 at 7:29 PM, Maciej Stachowiak m...@apple.com wrote:
One negative externality is that it
sometimes makes people excessively upset about tree redness, and sometimes
makes them want to fix redness in a way that papers over problems (e.g. by
adding to the skipped list).
If
On Thu, Jul 8, 2010 at 7:54 PM, Adam Barth aba...@webkit.org wrote:
2) Currently the commit-queue only lands if it gets a 100% passing run
of all the tests. We could instead change it to land if there are no
new test failures as a result of applying the patch. This check is to
avoid
On Thu, Jul 8, 2010 at 10:58 AM, Xan Lopez x...@gnome.org wrote:
On Thu, Jul 8, 2010 at 7:54 PM, Adam Barth aba...@webkit.org wrote:
2) Currently the commit-queue only lands if it gets a 100% passing run
of all the tests. We could instead change it to land if there are no
new test failures
On Thu, Jul 8, 2010 at 8:09 PM, Adam Barth aba...@webkit.org wrote:
Originally, we had the commit-queue to land only if all the core
builders were green. One recent change we made to make the
commit-queue more agressive is to land when the commit-queue itself
sees 100% passing tests on
On Fri, Jul 9, 2010 at 2:14 AM, Xan Lopez x...@gnome.org wrote:
On Thu, Jul 8, 2010 at 8:09 PM, Adam Barth aba...@webkit.org wrote:
Originally, we had the commit-queue to land only if all the core
builders were green. One recent change we made to make the
commit-queue more agressive is to
On Thu, Jul 8, 2010 at 11:38 PM, Jeremy Orlow jor...@chromium.org wrote:
I think the point that's been made in this thread is that whatever policy
the commit queue uses should be in line with whatever policies all
committers should be using. Otherwise you run into the problems Maciej
noted.
On Thu, Jul 8, 2010 at 14:55, Xan Lopez x...@gnome.org wrote:
On Thu, Jul 8, 2010 at 11:38 PM, Jeremy Orlow jor...@chromium.org wrote:
I think the point that's been made in this thread is that whatever policy
the commit queue uses should be in line with whatever policies all
committers
On Fri, Jul 9, 2010 at 12:30 AM, Daniel Cheng dch...@chromium.org wrote:
As someone who doesn't have committer access, I like the change to the CQ.
Before, I might have to wait 3 days for a patch to land since the CQ would
wait for all the core builders to be green. Meanwhile, committers see
On Thu, Jul 8, 2010 at 15:38, Xan Lopez x...@gnome.org wrote:
Aren't you essentially saying that you like the change because it
allows you to join the fun of adding code to already broken trees?
Again, I don't see how this helps us to move towards
as-greener-as-possible trees.
If
What I noticed wrt the commit queue is that when a core build is broken
continuously for days (like what happened with the Chromium Linux bot
earlier this week for example), it causes big problems for the commit queue.
Perhaps a 12 hour rule would be sufficient -- the cq doesn't submit if a
If you're tired of my complaining about the tree being red, you can
skip this message.
Today Alexey checked in http://trac.webkit.org/changeset/62576,
which broke two tests on every port. 12 hours later, these failures
remained in the tree until I cleaned them up. This mess could have
been
Thank you for fixing the problem.
Did you try talking to Alexey directly about this? Or to someone else who may
be familiar with the situation? It's usually better to try steps like that
before calling someone out on the mailing list. And if you do need to bring
something to wider attention,
07.07.2010, в 00:47, Adam Barth написал(а):
If you're tired of my complaining about the tree being red, you can
skip this message.
I understand that you're frustrated, but I think that you're misinterpreting
what happened.
1) He could have run-webkit-tests before committing his change.
I
Sorry for singling you out Alexey. I was just frustrated last night.
On Wed, Jul 7, 2010 at 8:58 AM, Alexey Proskuryakov a...@webkit.org wrote:
07.07.2010, в 00:47, Adam Barth написал(а):
If you're tired of my complaining about the tree being red, you can
skip this message.
I understand
07.07.2010, в 9:18, Adam Barth написал(а):
This problem is now fixed thanks to William Siegrist. Patches written
by committers show up correctly in SVN blame and trac even if they're
landed by the commit-queue.
That's good to know, I'll try that next time.
I think we can improve this by
I agree with Maciej's response, but at the same time I can understand why
Adam was so frustrated. He (and others) have pointed out stuff like this on
and off list over and over again with little apparent change...
But that's not what I'm most worried about; why this was broken in the tree
for 12
07.07.2010, в 9:49, Jeremy Orlow написал(а):
Why did not one of those people roll the patch out when it was clear
that there were failures and Alexey wasn't in the process of fixing
them?
Just to avoid any misunderstanding, the best thing to do would have
been to tell me about the
On Jul 7, 2010, at 9:45 AM, Alexey Proskuryakov wrote:
I think we can improve this by having sheriff-bot say which tests
broke. I bet if you saw these tests listed, you'd have realized what
was going one.
That would be very useful indeed! It currently takes some effort to find out
On Thu, Jul 8, 2010 at 2:03 AM, Alexey Proskuryakov a...@webkit.org wrote:
07.07.2010, в 9:49, Jeremy Orlow написал(а):
Why did not one of those people roll the patch out when it was clear that
there were failures and Alexey wasn't in the process of fixing them?
Just to avoid any
Maybe I should complain this in a different threads, but recently the commit
bot waiting time is way too long. Several times a patch of mine got the r+
and cq+ and it landed two days later. This is really frustrating.
I am very tempted to use svn directly to commit patches, but that means the
On Wed, Jul 7, 2010 at 6:50 PM, Mo, Zhenyao zhen...@gmail.com wrote:
Maybe I should complain this in a different threads, but recently the
commit bot waiting time is way too long. Several times a patch of mine got
the r+ and cq+ and it landed two days later. This is really frustrating.
I
On Jul 7, 2010, at 7:16 PM, Tony Gentilcore wrote:
On Wed, Jul 7, 2010 at 6:50 PM, Mo, Zhenyao zhen...@gmail.com wrote:
Maybe I should complain this in a different threads, but recently the commit
bot waiting time is way too long. Several times a patch of mine got the r+
and cq+ and
On Wed, Jul 7, 2010 at 7:19 PM, Oliver Hunt oli...@apple.com wrote:
On Jul 7, 2010, at 7:16 PM, Tony Gentilcore wrote:
On Wed, Jul 7, 2010 at 6:50 PM, Mo, Zhenyao zhen...@gmail.com wrote:
Maybe I should complain this in a different threads, but recently the
commit bot waiting time is way
On Wed, Jul 7, 2010 at 7:22 PM, James Robinson jam...@google.com wrote:
On Wed, Jul 7, 2010 at 7:19 PM, Oliver Hunt oli...@apple.com wrote:
On Jul 7, 2010, at 7:16 PM, Tony Gentilcore wrote:
On Wed, Jul 7, 2010 at 6:50 PM, Mo, Zhenyao zhen...@gmail.com wrote:
Maybe I should complain
On Thu, Jul 8, 2010 at 10:19 AM, Oliver Hunt oli...@apple.com wrote:
On Jul 7, 2010, at 7:16 PM, Tony Gentilcore wrote:
On Wed, Jul 7, 2010 at 6:50 PM, Mo, Zhenyao zhen...@gmail.com wrote:
Maybe I should complain this in a different threads, but recently the
commit bot waiting time is
On Jul 7, 2010, at 7:22 PM, James Robinson wrote:
On Wed, Jul 7, 2010 at 7:19 PM, Oliver Hunt oli...@apple.com wrote:
On Jul 7, 2010, at 7:16 PM, Tony Gentilcore wrote:
On Wed, Jul 7, 2010 at 6:50 PM, Mo, Zhenyao zhen...@gmail.com wrote:
Maybe I should complain this in a
On Jul 7, 2010, at 7:26 PM, Jeremy Orlow wrote:
On Thu, Jul 8, 2010 at 10:19 AM, Oliver Hunt oli...@apple.com wrote:
On Jul 7, 2010, at 7:16 PM, Tony Gentilcore wrote:
On Wed, Jul 7, 2010 at 6:50 PM, Mo, Zhenyao zhen...@gmail.com wrote:
Maybe I should complain this in a different
On Jul 7, 2010, at 7:32 PM, Oliver Hunt wrote:
webkit-patch land-safely does the job of running the tests automatically,
that said if you have commit privileges you should be running the tests
yourself otherwise you're wasting the reviewers time.
Pushing a patch through the normal
On Jul 7, 2010, at 7:42 PM, Maciej Stachowiak wrote:
On Jul 7, 2010, at 7:32 PM, Oliver Hunt wrote:
My opinion is that if people want to use the commit-queue to land patches
they should be happy to drop their commit privileges thus mooting this
entire issue.
That would probably make
On Wed, Jul 7, 2010 at 9:46 PM, William Siegrist wsiegr...@apple.comwrote:
On Jul 7, 2010, at 7:42 PM, Maciej Stachowiak wrote:
On Jul 7, 2010, at 7:32 PM, Oliver Hunt wrote:
My opinion is that if people want to use the commit-queue to land
patches they should be happy to drop their
30 matches
Mail list logo
