Re: [webkit-dev] Join the URL hackathon (already in progress)!

2010-04-14 Thread Adam Barth
My thought process at the time was just the facts, but I think the comments are valuable and we should probably put them back. Adam On Tue, Apr 13, 2010 at 10:22 PM, Darin Fisher da...@chromium.org wrote: Looking at ipv4.js, I don't see any of the comments from url_canon_unittest.cc.  Is

Re: [webkit-dev] Join the URL hackathon (already in progress)!

2010-04-14 Thread Adam Barth
I think Maciej took notes, but my recollection is as follows: 1) Convert as many of the unit tests to LayoutTests as possible. 2) Land GURL in svn.webkit.org as is. 3) Convert GURL to WebKit style. 4) Make an ifdef that lets ports switch between KURL and GURL. Once we get to this point, it will

Re: [webkit-dev] Join the URL hackathon (already in progress)!

2010-04-14 Thread Adam Barth
Ah, sorry, I meant to the point where the library was integrated with the various build systems, etc. Maybe that's already possible today. I haven't investigated it in detail. It probably also makes sense to talk about correctness between steps (1) and (2), once we have the tests and their

Re: [webkit-dev] Join the URL hackathon (already in progress)!

2010-04-14 Thread Darin Fisher
I see. Sounds good to me. -Darin On Tue, Apr 13, 2010 at 11:35 PM, Adam Barth aba...@webkit.org wrote: Ah, sorry, I meant to the point where the library was integrated with the various build systems, etc. Maybe that's already possible today. I haven't investigated it in detail. It probably

Re: [webkit-dev] Join the URL hackathon (already in progress)!

2010-04-14 Thread David Levin
On Tue, Apr 13, 2010 at 11:35 PM, Adam Barth aba...@webkit.org wrote: Ah, sorry, I meant to the point where the library was integrated with the various build systems, etc. Maybe that's already possible today. I haven't investigated it in detail. It probably also makes sense to talk about

Re: [webkit-dev] Join the URL hackathon (already in progress)!

2010-04-14 Thread Darin Fisher
On Tue, Apr 13, 2010 at 11:39 PM, David Levin le...@google.com wrote: On Tue, Apr 13, 2010 at 11:35 PM, Adam Barth aba...@webkit.org wrote: Ah, sorry, I meant to the point where the library was integrated with the various build systems, etc. Maybe that's already possible today. I haven't

Re: [webkit-dev] Join the URL hackathon (already in progress)!

2010-04-14 Thread Eric Seidel
Dammit. I'm not smart enough to use mailing lists. My suggestion was WTFURL. ;) On Tue, Apr 13, 2010 at 11:51 PM, Darin Fisher da...@chromium.org wrote: On Tue, Apr 13, 2010 at 11:39 PM, David Levin le...@google.com wrote: On Tue, Apr 13, 2010 at 11:35 PM, Adam Barth aba...@webkit.org

Re: [webkit-dev] Join the URL hackathon (already in progress)!

2010-04-14 Thread Adam Barth
I'd like to avoid bikeshedding about the name, but URLCore sounds like my shade of blue. :) Adam On Tue, Apr 13, 2010 at 11:51 PM, Darin Fisher da...@chromium.org wrote: On Tue, Apr 13, 2010 at 11:39 PM, David Levin le...@google.com wrote: On Tue, Apr 13, 2010 at 11:35 PM, Adam Barth

Re: [webkit-dev] Join the URL hackathon (already in progress)!

2010-04-14 Thread Maciej Stachowiak
That's very close to my notes, minor correction inline: On Apr 13, 2010, at 11:17 PM, Adam Barth wrote: I think Maciej took notes, but my recollection is as follows: 1) Convert as many of the unit tests to LayoutTests as possible. 2) Land GURL in svn.webkit.org as is. 3) Convert GURL to

Re: [webkit-dev] Join the URL hackathon (already in progress)!

2010-04-14 Thread Maciej Stachowiak
On Apr 13, 2010, at 11:55 PM, Eric Seidel wrote: Dammit. I'm not smart enough to use mailing lists. My suggestion was WTFURL. ;) WTFURLBBQ - Maciej ___ webkit-dev mailing list webkit-dev@lists.webkit.org

Re: [webkit-dev] Join the URL hackathon (already in progress)!

2010-04-14 Thread Peter Kasting
On Wed, Apr 14, 2010 at 3:40 AM, Maciej Stachowiak m...@apple.com wrote: On Apr 13, 2010, at 11:55 PM, Eric Seidel wrote: Dammit. I'm not smart enough to use mailing lists. My suggestion was WTFURL. ;) WTFURLBBQ MyNameIsURL PK ___

Re: [webkit-dev] Join the URL hackathon (already in progress)!

2010-04-14 Thread Alex Russell
On Tue, Apr 13, 2010 at 11:39 PM, David Levin le...@google.com wrote: On Tue, Apr 13, 2010 at 11:35 PM, Adam Barth aba...@webkit.org wrote: Ah, sorry, I meant to the point where the library was integrated with the various build systems, etc.  Maybe that's already possible today. I haven't

[webkit-dev] Join the URL hackathon (already in progress)!

2010-04-13 Thread Adam Barth
Have you ever wanted WebKit's URL parsing to be awesome? Do crazy characters in URLs keep you up at night? Do you love writing tests? If you answered yes to any of these questions, you might want to join the URL hackathon. In this hackathon, we're adding a ton of test of our URL parsing code

Re: [webkit-dev] Join the URL hackathon (already in progress)!

2010-04-13 Thread Chris Jerdonek
Regarding the URL parsing code, could someone that attended the session list what steps were proposed or tentatively agreed to (of which the below is the first)? Thanks a lot, --Chris On Tue, Apr 13, 2010 at 1:46 AM, Adam Barth aba...@webkit.org wrote: Have you ever wanted WebKit's URL

Re: [webkit-dev] Join the URL hackathon (already in progress)!

2010-04-13 Thread Darin Fisher
Looking at ipv4.js, I don't see any of the comments from url_canon_unittest.cc. Is there a reason why you chose to drop them? It seems like they could be helpful to someone reading ipv4.js in the future. -Darin On Tue, Apr 13, 2010 at 1:46 AM, Adam Barth aba...@webkit.org wrote: Have you