Re: [webkit-dev] Use of Frame by ResourceHandle

2010-09-13 Thread Darin Fisher
I agree that NetworkingContext is cleaner than a direct Frame association. I'm concerned though about the idea of network requests that are not associated with a Page. Associating network requests with a Page is important so that you know how to show UI (auth prompt, cookie prompt, ssl error

Re: [webkit-dev] Use of Frame by ResourceHandle

2010-09-12 Thread Adam Barth
On Sat, Sep 11, 2010 at 10:52 PM, Darin Fisher da...@chromium.org wrote: On Sat, Sep 11, 2010 at 10:42 PM, Adam Barth aba...@webkit.org wrote: On Sat, Sep 11, 2010 at 10:02 PM, Darin Fisher da...@chromium.org wrote: I don't understand.  WebWorkers use ThreadableLoader, which routes the

Re: [webkit-dev] Use of Frame by ResourceHandle

2010-09-12 Thread Darin Fisher
On Sat, Sep 11, 2010 at 11:07 PM, Adam Barth aba...@webkit.org wrote: On Sat, Sep 11, 2010 at 10:52 PM, Darin Fisher da...@chromium.org wrote: On Sat, Sep 11, 2010 at 10:42 PM, Adam Barth aba...@webkit.org wrote: On Sat, Sep 11, 2010 at 10:02 PM, Darin Fisher da...@chromium.org wrote: I

Re: [webkit-dev] Use of Frame by ResourceHandle

2010-09-12 Thread Maciej Stachowiak
I like Adam's thinking on this. ResourceHandle depending on Frame, even indirectly, is something of a layering violation. It makes more sense to factor out the bits that it does need, a la NetworkContext. Using client methods to make an association externally seems ok too, but poses more risk

Re: [webkit-dev] Use of Frame by ResourceHandle

2010-09-12 Thread Adam Barth
On Sat, Sep 11, 2010 at 11:28 PM, Darin Fisher da...@chromium.org wrote: On Sat, Sep 11, 2010 at 11:07 PM, Adam Barth aba...@webkit.org wrote: On Sat, Sep 11, 2010 at 10:52 PM, Darin Fisher da...@chromium.org wrote: For example, you cannot load any network requests in Chromium unless you

Re: [webkit-dev] Use of Frame by ResourceHandle

2010-09-12 Thread David Levin
On Sat, Sep 11, 2010 at 11:07 PM, Adam Barth aba...@webkit.org wrote: On Sat, Sep 11, 2010 at 10:52 PM, Darin Fisher da...@chromium.org wrote: On Sat, Sep 11, 2010 at 10:42 PM, Adam Barth aba...@webkit.org wrote: On Sat, Sep 11, 2010 at 10:02 PM, Darin Fisher da...@chromium.org wrote: I

Re: [webkit-dev] Use of Frame by ResourceHandle

2010-09-12 Thread Adam Barth
On Sun, Sep 12, 2010 at 12:33 PM, David Levin le...@chromium.org wrote: On Sat, Sep 11, 2010 at 11:07 PM, Adam Barth aba...@webkit.org wrote: Having fake versions of objects add complexity to all the code that expects to talk to real versions of those objects.  For example, SVG-in-img creates

Re: [webkit-dev] Use of Frame by ResourceHandle

2010-09-12 Thread David Levin
On Sun, Sep 12, 2010 at 12:37 PM, Adam Barth aba...@webkit.org wrote: On Sun, Sep 12, 2010 at 12:33 PM, David Levin le...@chromium.org wrote: On Sat, Sep 11, 2010 at 11:07 PM, Adam Barth aba...@webkit.org wrote: Having fake versions of objects add complexity to all the code that expects to

Re: [webkit-dev] Use of Frame by ResourceHandle

2010-09-12 Thread Adam Barth
On Sat, Sep 11, 2010 at 11:28 PM, Darin Fisher da...@chromium.org wrote: On Sat, Sep 11, 2010 at 11:07 PM, Adam Barth aba...@webkit.org wrote: On Sat, Sep 11, 2010 at 10:52 PM, Darin Fisher da...@chromium.org wrote: There are are lots of ways to get a Frameless document.  For example,

Re: [webkit-dev] Use of Frame by ResourceHandle

2010-09-12 Thread Adam Barth
On Sun, Sep 12, 2010 at 12:43 PM, David Levin le...@chromium.org wrote: On Sun, Sep 12, 2010 at 12:37 PM, Adam Barth aba...@webkit.org wrote: On Sun, Sep 12, 2010 at 12:33 PM, David Levin le...@chromium.org wrote: On Sat, Sep 11, 2010 at 11:07 PM, Adam Barth aba...@webkit.org wrote: Having

[webkit-dev] Use of Frame by ResourceHandle

2010-09-11 Thread Adam Barth
I don't mean to spam this list with design questions, but I'm trying to wrap my mind around how the loader is put together today and how we'd like it to be put together in the future. There's a FIXME in ResourceHandle that says that ResourceHandle shouldn't depend on Frame. (For those who aren't

Re: [webkit-dev] Use of Frame by ResourceHandle

2010-09-11 Thread Holger Freyther
On 09/11/2010 05:57 PM, Adam Barth wrote: Do we still believe this FIXME is accurate? If so, I have some time next week to look at removing the dependency. There's a patch that either recently landed or is about to land that furthers the use of Frame by ResourceHandle, so I wanted to check

Re: [webkit-dev] Use of Frame by ResourceHandle

2010-09-11 Thread Sam Weinig
It seems the dependency on Frame is now gone (as of last night I guess?) with the advent of the NetworkingContext. -Sam On Sat, Sep 11, 2010 at 3:42 PM, Maciej Stachowiak m...@apple.com wrote: On Sep 11, 2010, at 2:57 AM, Adam Barth wrote: I don't mean to spam this list with design

Re: [webkit-dev] Use of Frame by ResourceHandle

2010-09-11 Thread Adam Barth
Excellent. :) Adam On Sat, Sep 11, 2010 at 4:21 PM, Sam Weinig sam.wei...@gmail.com wrote: It seems the dependency on Frame is now gone (as of last night I guess?) with the advent of the NetworkingContext. -Sam On Sat, Sep 11, 2010 at 3:42 PM, Maciej Stachowiak m...@apple.com wrote: On

Re: [webkit-dev] Use of Frame by ResourceHandle

2010-09-11 Thread Maciej Stachowiak
On Sep 11, 2010, at 4:21 PM, Sam Weinig wrote: It seems the dependency on Frame is now gone (as of last night I guess?) with the advent of the NetworkingContext. Neat. I was going to suggest using factory objects to create ResourceHandles (then they can stuff in whatever info they need, or

Re: [webkit-dev] Use of Frame by ResourceHandle

2010-09-11 Thread Darin Fisher
On Sat, Sep 11, 2010 at 9:17 AM, Adam Barth aba...@webkit.org wrote: On Sat, Sep 11, 2010 at 8:15 AM, Holger Freyther ze...@selfish.org wrote: On 09/11/2010 05:57 PM, Adam Barth wrote: Do we still believe this FIXME is accurate? If so, I have some time next week to look at removing the

Re: [webkit-dev] Use of Frame by ResourceHandle

2010-09-11 Thread Adam Barth
On Sat, Sep 11, 2010 at 10:02 PM, Darin Fisher da...@chromium.org wrote: On Sat, Sep 11, 2010 at 9:17 AM, Adam Barth aba...@webkit.org wrote: On Sat, Sep 11, 2010 at 8:15 AM, Holger Freyther ze...@selfish.org wrote: On 09/11/2010 05:57 PM, Adam Barth wrote: Do we still believe this FIXME is

Re: [webkit-dev] Use of Frame by ResourceHandle

2010-09-11 Thread Darin Fisher
On Sat, Sep 11, 2010 at 10:42 PM, Adam Barth aba...@webkit.org wrote: On Sat, Sep 11, 2010 at 10:02 PM, Darin Fisher da...@chromium.org wrote: On Sat, Sep 11, 2010 at 9:17 AM, Adam Barth aba...@webkit.org wrote: On Sat, Sep 11, 2010 at 8:15 AM, Holger Freyther ze...@selfish.org wrote: