[webkit-dev] Web Audio API

2010-08-24 Thread Chris Rogers
Over the past months I've been refining the web audio API implementation that I've been developing in the 'audio' branch of WebKit (per Maciej's recommendation). The API has been through a good amount of review by WebKit developers at Apple, Google, and in the W3C Audio Incubator group. For

Re: [webkit-dev] Web Audio API

2010-08-24 Thread Chris Marrin
On Aug 24, 2010, at 12:05 PM, Chris Rogers wrote: Over the past months I've been refining the web audio API implementation that I've been developing in the 'audio' branch of WebKit (per Maciej's recommendation). The API has been through a good amount of review by WebKit developers at

Re: [webkit-dev] Web Audio API

2010-08-24 Thread Chris Rogers
Hi Chris, That also sounds like a reasonable naming scheme. The only counter-argument I would have is that we have several directories in WebCore which don't have the 'web' prefix such as: WebCore/notifications WebCore/storage WebCore/workers (and not webnotifications, webstorage, webworkers)

Re: [webkit-dev] Web Audio API

2010-08-24 Thread Simon Fraser
On Aug 24, 2010, at 12:05 PM, Chris Rogers wrote: Over the past months I've been refining the web audio API implementation that I've been developing in the 'audio' branch of WebKit (per Maciej's recommendation). The API has been through a good amount of review by WebKit developers at

Re: [webkit-dev] Web Audio API

2010-08-24 Thread Chris Rogers
Hi Simon, #if WEBAUDIO is fine. Do you also prefer WebCore/webaudio like Chris Marrin, or WebCore/audio? Chris On Tue, Aug 24, 2010 at 4:04 PM, Simon Fraser simon.fra...@apple.comwrote: On Aug 24, 2010, at 12:05 PM, Chris Rogers wrote: Over the past months I've been refining the web audio

Re: [webkit-dev] Web Audio API

2010-08-24 Thread Darin Fisher
My only concern with using the Web* prefix in WebCore is that the Web* prefix is commonly used in WebKit APIs as a namespace for API types. It seems like it could lead to some confusion. -Darin On Tue, Aug 24, 2010 at 4:15 PM, Chris Rogers crog...@google.com wrote: Hi Simon, #if WEBAUDIO

Re: [webkit-dev] Web Audio API

2010-08-24 Thread Chris Marrin
On Aug 24, 2010, at 3:53 PM, Chris Rogers wrote: Hi Chris, That also sounds like a reasonable naming scheme. The only counter-argument I would have is that we have several directories in WebCore which don't have the 'web' prefix such as: WebCore/notifications WebCore/storage

Re: [webkit-dev] Web Audio API

2010-08-24 Thread Simon Fraser
On Aug 24, 2010, at 4:15 PM, Chris Rogers wrote: Hi Simon, #if WEBAUDIO is fine. Do you also prefer WebCore/webaudio like Chris Marrin, or WebCore/audio? I am ambivalent. Everything in WebCore is ultimately web-related, so 'web' prefixes on the directories seem redundant. One direction

Re: [webkit-dev] Web Audio API

2010-08-24 Thread Eric Seidel
This is fantastically wonderful. Let me know what I can do to help. I'm happy to do reviews for what I can. -eric On Tue, Aug 24, 2010 at 12:05 PM, Chris Rogers crog...@google.com wrote: Over the past months I've been refining the web audio API implementation that I've been developing in the

Re: [webkit-dev] Web Audio API

2010-08-24 Thread Chris Rogers
Hi Simon, thanks for helping here. By the way, anybody who is interested can look at the files in: https://svn.webkit.org/repository/webkit/branches/audio/WebCore/audio/ There are actually a number of audio files which could be considered re-usable, although I know of nothing at this time other

Re: [webkit-dev] Web Audio API

2010-08-24 Thread Simon Fraser
On Aug 24, 2010, at 4:47 PM, Chris Rogers wrote: Hi Simon, thanks for helping here. By the way, anybody who is interested can look at the files in: https://svn.webkit.org/repository/webkit/branches/audio/WebCore/audio/ There are actually a number of audio files which could be considered

Re: [webkit-dev] Web Audio API

2010-08-24 Thread Eric Carlson
Chris - On Aug 24, 2010, at 4:47 PM, Chris Rogers wrote: Hi Simon, thanks for helping here. By the way, anybody who is interested can look at the files in: https://svn.webkit.org/repository/webkit/branches/audio/WebCore/audio/ There are actually a number of audio files which could be

Re: [webkit-dev] Web Audio API

2010-08-24 Thread Chris Rogers
Good, it looks like we're getting close. So we've agreed to how the files should be split up, but Darin Fisher still was concerned about the 'web' prefix. Darin, was it the directory name WebCore/webaudio that you didn't like or: #if ENABLE(WEB_AUDIO) Alternatives might be: WebCore/audio or

Re: [webkit-dev] Web Audio API

2010-08-24 Thread Maciej Stachowiak
This sounds like a reasonable plan. I have no strong feelings about any of the naming options, but I like the overall idea of getting this code into trunk now, using a feature define, and separating the Web-facing parts from the platform implementation parts. - Maciej On Aug 24, 2010, at

Re: [webkit-dev] Web Audio API

2010-08-24 Thread Darin Fisher
My objection (and it's only a slight one) was about using Web as a prefix for class names defined in WebCore. WebSockets is the main example of the Web prefix used in WebCore, and that's probably because sockets by itself would be too confusing. However, I have found the use of the Web prefix in

Re: [webkit-dev] Web Audio API

2010-08-24 Thread Eric Carlson
On Aug 24, 2010, at 8:39 PM, Darin Fisher wrote: My objection (and it's only a slight one) was about using Web as a prefix for class names defined in WebCore. WebSockets is the main example of the Web prefix used in WebCore, and that's probably because sockets by itself would be too

Re: [webkit-dev] Web Audio API

2010-08-24 Thread Darin Fisher
On Tue, Aug 24, 2010 at 8:55 PM, Eric Carlson eric.carl...@apple.comwrote: On Aug 24, 2010, at 8:39 PM, Darin Fisher wrote: My objection (and it's only a slight one) was about using Web as a prefix for class names defined in WebCore. WebSockets is the main example of the Web prefix used in

Re: [webkit-dev] Web Audio API

2010-08-24 Thread Chris Rogers
Ok, then it looks like we'll go with this for the directory names: WebCore/webaudio WebCore/platform/audio And this for the feature define: #if ENABLE(WEB_AUDIO) Thanks everybody, Chris On Tue, Aug 24, 2010 at 9:02 PM, Darin Fisher da...@chromium.org wrote: On Tue, Aug 24, 2010 at 8:55 PM,