Re: [webkit-dev] WebAccessibilityRole must match AccessiblityRole enums?

2010-06-10 Thread Maciej Stachowiak
On Jun 4, 2010, at 1:32 PM, Darin Fisher wrote: On Fri, Jun 4, 2010 at 11:15 AM, Peter Kasting pkast...@google.com wrote: On Fri, Jun 4, 2010 at 11:11 AM, Darin Adler da...@apple.com wrote: If the two enum types are identical except for their names, then this doesn’t firewall the types at

[webkit-dev] WebAccessibilityRole must match AccessiblityRole enums?

2010-06-04 Thread Chris Fleizach
Could someone explain why WebAccessibilityRole duplicates AccessibilityRole? This will make it very painful to change, re-order or add to AccessibilityRole as it becomes necessary in the future ie) see https://bugs.webkit.org/show_bug.cgi?id=40133 ___

Re: [webkit-dev] WebAccessibilityRole must match AccessiblityRole enums?

2010-06-04 Thread Adam Barth
[+fishd] I believe this is a common pattern in the Chromium WebKit API. fishd can speak to why this works the way it does in more detail. I believe these enums exist to encapsulate WebCore types in the interface. Adam On Fri, Jun 4, 2010 at 9:40 AM, Chris Fleizach cfleiz...@apple.com wrote:

Re: [webkit-dev] WebAccessibilityRole must match AccessiblityRole enums?

2010-06-04 Thread Chris Fleizach
Is there any way chromium can automate this so if it sees it is different, it can re-generate to match the enums again On Jun 4, 2010, at 10:04 AM, Adam Barth wrote: [+fishd] I believe this is a common pattern in the Chromium WebKit API. fishd can speak to why this works the way it does

Re: [webkit-dev] WebAccessibilityRole must match AccessiblityRole enums?

2010-06-04 Thread Peter Kasting
On Fri, Jun 4, 2010 at 10:14 AM, Chris Fleizach cfleiz...@apple.com wrote: Is there any way chromium can automate this so if it sees it is different, it can re-generate to match the enums again Is it really that enormous of a problem? It doesn't seem like you're going to be making hundreds

Re: [webkit-dev] WebAccessibilityRole must match AccessiblityRole enums?

2010-06-04 Thread Chris Fleizach
For one, I would like to alphabetize that list. That will require hundreds of changes, requiring me to make hundreds of blind changes in chromium code. It seems like rather bad form to duplicate core WebCore code used by all platforms, within one platform, and not a solution that is forward

Re: [webkit-dev] WebAccessibilityRole must match AccessiblityRole enums?

2010-06-04 Thread Darin Adler
For what it’s worth, this kind of pattern was quite common in the Mac OS X WebKit API, with public enums in the Objective-C API that exactly matched private enums inside WebCore and had to be kept in sync. Over the years, working towards the goal of making WebKit better cross-platform, we’ve

Re: [webkit-dev] WebAccessibilityRole must match AccessiblityRole enums?

2010-06-04 Thread Peter Kasting
On Fri, Jun 4, 2010 at 10:54 AM, Chris Fleizach cfleiz...@apple.com wrote: For one, I would like to alphabetize that list. That will require hundreds of changes, requiring me to make hundreds of blind changes in chromium code. When ARIA2 comes out, mayhaps there will be a dozen or two new

Re: [webkit-dev] WebAccessibilityRole must match AccessiblityRole enums?

2010-06-04 Thread Chris Fleizach
Was just hoping something easier might come along. I'll let the appropriate people know if I need any help thanx On Jun 4, 2010, at 11:04 AM, Peter Kasting wrote: On Fri, Jun 4, 2010 at 10:54 AM, Chris Fleizach cfleiz...@apple.com wrote: For one, I would like to alphabetize that list. That

Re: [webkit-dev] WebAccessibilityRole must match AccessiblityRole enums?

2010-06-04 Thread Darin Adler
If the two enum types are identical except for their names, then this doesn’t firewall the types at all. -- Darin ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

Re: [webkit-dev] WebAccessibilityRole must match AccessiblityRole enums?

2010-06-04 Thread Peter Kasting
On Fri, Jun 4, 2010 at 11:11 AM, Darin Adler da...@apple.com wrote: If the two enum types are identical except for their names, then this doesn’t firewall the types at all. It doesn't firewall the concepts (but then, it's hard for an embedding layer to not transmit any concepts, as that's

Re: [webkit-dev] WebAccessibilityRole must match AccessiblityRole enums?

2010-06-04 Thread Darin Fisher
On Fri, Jun 4, 2010 at 11:15 AM, Peter Kasting pkast...@google.com wrote: On Fri, Jun 4, 2010 at 11:11 AM, Darin Adler da...@apple.com wrote: If the two enum types are identical except for their names, then this doesn’t firewall the types at all. It doesn't firewall the concepts (but then,