It absolutely does! Thanks Ojan ... this is a great tool.
On Tue, Feb 15, 2011 at 12:47 AM, Ojan Vafai o...@chromium.org wrote:
shift+click can now be used to extend the context for a comment.
http://trac.webkit.org/changeset/78530
On Mon, Feb 14, 2011 at 4:27 PM, Ojan Vafai
shift+click can now be used to extend the context for a comment.
http://trac.webkit.org/changeset/78530
On Mon, Feb 14, 2011 at 4:27 PM, Ojan Vafai o...@chromium.org wrote:
This behavior did change. But ctrl was never involved. If you ever clicked
on a line next to an existing review comment
On Thu, Feb 10, 2011 at 6:05 AM, Adam Barth aba...@webkit.org wrote:
Thanks for the feedback. Please feel encouraged to let me and others
know how you'd like these tools improved.
Ditto. While I've mostly been addressing the issues the bother me, I do so
in the belief that they likely bother
Previously, I was able to increase the context of my inline review comments
by clicking on consecutive line numbers while pressing CONTROL. It seems
regressed. Am I the only one noticing that?
--
--Antonio Gomes
___
webkit-dev mailing list
This behavior did change. But ctrl was never involved. If you ever clicked
on a line next to an existing review comment line, it would expand to
include it. The problem is that it's then difficult to leave comments on
adjacent lines.
You can still click and drag to expand the context though as
I just discovered that the review tool doesn't save the general comments, only
inline ones (http://webkit.org/b/54121). This just got me when I clicked on
the style bot to see what style checks had failed and lost my feedback :(
This was particularly annoying as i had command-clicked the link
I just discovered that the review tool doesn't save the general comments, only
inline ones (http://webkit.org/b/54121). This just got me when I clicked on
the style bot to see what style checks had failed and lost my feedback :(
This was particularly annoying as i had command-clicked the link
Thanks for the feedback. Please feel encouraged to let me and others
know how you'd like these tools improved.
Adam
On Wed, Feb 9, 2011 at 10:49 AM, Oliver Hunt oli...@apple.com wrote:
I just discovered that the review tool doesn't save the general comments,
only inline ones
On Tue, Feb 1, 2011 at 5:09 PM, Ojan Vafai o...@chromium.org wrote:
-Side-by-side diffs: You can view the entire diff or individual files in
side-by-side diff. If you change the entire diff, we'll store that in
localstorage and load diffs in side-by-side by default.
-Comments and diff
There's been a slew of changes to the code review tool. It's probably a good
time to send a summary now that I don't intend to add significant new
features.
-Side-by-side diffs: You can view the entire diff or individual files in
side-by-side diff. If you change the entire diff, we'll store that
On Tue, Feb 1, 2011 at 5:09 PM, Ojan Vafai o...@chromium.org wrote:
There's been a slew of changes to the code review tool. It's probably a good
time to send a summary now that I don't intend to add significant new
features.
-Side-by-side diffs: You can view the entire diff or individual files
Forgot one. Comments from the style checker are also shown in the code
review tool now.
On Wed, Feb 2, 2011 at 12:09 PM, Ojan Vafai o...@chromium.org wrote:
There's been a slew of changes to the code review tool. It's probably a
good time to send a summary now that I don't intend to add
12 matches
Mail list logo
