Re: [webkit-dev] Question about Heap::markConservatively.

2010-01-04 Thread Dominik Roettsches
Hi Pattin, b. Cound somebody tell me the crash reason about? I think maybe program access non-align(4bytes) memory address? Did you implement JSC::currentThreadStackBase correctly? It needs to return the base address of the stack (bottom or top, depending on platform) as the starting point

Re: [webkit-dev] Patch status display on bugs.webkit.org

2010-01-04 Thread Tor Arne Vestbø
Adam Barth wrote: As we bring more bots online, this user interface should scale better than posting lots of pass comments. If folks like this display, we can incorporate it into bugs.webkit.org directly. +1 for including this in the site directly! Cool stuff! Tor Arne

[webkit-dev] Extra privileges for local javascripts with WebkitGtk

2010-01-04 Thread Dieter Plaetinck
Hi guys, for the uzbl browser (www.uzbl.org) we want to give users the ability to execute their own javascripts with extra privileges. Extra privileges = executing uzbl commands which can do many actions, such as executing shell commands. But at the same time, we want js scripts from the users to

[webkit-dev] LayoutTests new-window-opener

2010-01-04 Thread Mario Bensi
Hello, Just an question on this expected : LayoutTests/fast/dom/Window/new-window- opener-expected.txt In test you have this text : On success, you will see a series of PASS messages, followed by TEST COMPLETE. But in expected you have : Toolbar FAIL newWin.toolbar.visible should be

Re: [webkit-dev] Extra privileges for local javascripts with WebkitGtk

2010-01-04 Thread Darin Adler
WebKit contributors have developed a feature called “isolated worlds” to handle requirements like this. But I don’t know where we are in the implementation of that feature. Perhaps one of the people working on isolated worlds could comment on its current status. -- Darin

Re: [webkit-dev] Extra privileges for local javascripts with WebkitGtk

2010-01-04 Thread Adam Barth
Yes. This is exactly the problem that isolated worlds is trying to solve. The implementation in the bindings to the V8 JavaScript engine is complete. I believe the implementation in the JavaScriptCore bindings is complete as well. You should look for some APIs with the words isolated and world

[webkit-dev] RenderObject is-a boolean methods

2010-01-04 Thread Alex Milowski
There are a number of isSomething methods used by different parts of the rendering tree code to determine the type of a render object. To add something similar for MathML, I'll need to add my own methods here. I've chosen to add a single method: virtual bool isRenderMathMLBlock() const {

Re: [webkit-dev] RenderObject is-a boolean methods

2010-01-04 Thread Eric Seidel
My understanding is that RenderObject::isRenderMathMLBlock() is the right approach, yes. Although if MathML base renderer (like RenderBoxModelObject or RenderSVGModelObject), then an isMathMLModelObject() would be even better. Then you only add one method to RenderObject and the rest can go on

Re: [webkit-dev] RenderObject is-a boolean methods

2010-01-04 Thread Alex Milowski
On Mon, Jan 4, 2010 at 1:02 PM, Eric Seidel e...@webkit.org wrote: My understanding is that RenderObject::isRenderMathMLBlock() is the right approach, yes.  Although if MathML base renderer (like RenderBoxModelObject or RenderSVGModelObject), then an isMathMLModelObject() would be even better.

Re: [webkit-dev] RenderObject is-a boolean methods

2010-01-04 Thread Eric Seidel
I agree that line-layout logic could be split out of RenderBlock at some point. RenderSVGBlock inherits from RenderBlock in order to get line layout logic, yet it probably doesn't want to be a real RenderBlock long term. -eric On Mon, Jan 4, 2010 at 3:21 PM, Alex Milowski a...@milowski.org

[webkit-dev] #endif // Foo_h

2010-01-04 Thread Darin Fisher
I noticed recently that the style bot started complaining about header files ending with #endif instead of #endif // Foo_h. I was surprised by this since the style guide does not require it. Should the style guide be changed to require this comment, or should the style bot be taught to ignore

Re: [webkit-dev] #endif // Foo_h

2010-01-04 Thread Darin Adler
On Jan 4, 2010, at 3:33 PM, Darin Fisher wrote: I noticed recently that the style bot started complaining about header files ending with #endif instead of #endif // Foo_h. I was surprised by this since the style guide does not require it. I personally see little value in this sort of

Re: [webkit-dev] #endif // Foo_h

2010-01-04 Thread David Levin
These seemed to be common in WebKit code, so I had it in http://lists.macosforge.org/pipermail/webkit-dev/2009-September/009807.html(-- Sorry for letting this one linger for so long. It is in my queue just low on the priority list). Here's the relevant part: #if(def) statements If an #if(def)

Re: [webkit-dev] #endif // Foo_h

2010-01-04 Thread Dirk Schulze
We have somtimes constructs like #endif // ENABLE(SVG) #endif // Foo_h It just helps to understand why there are two endif's and what they are good for. I think it's not a style issue not to write this comment, but it can be helpful. -Dirk Am Montag, den 04.01.2010, 15:41 -0800 schrieb Darin

[webkit-dev] how to map local file extension to the MIMEType

2010-01-04 Thread Fei Wang
Please help! I define my own MIMEType like application/foo with file extension .foo. It works fine if I serve file through web server ( inside web server configuration, I add application/foo foo to the mime type map). In the webkit, I modify the MIMETypeRegistry.cpp file, add those MIMEType

Re: [webkit-dev] how to map local file extension to the MIMEType

2010-01-04 Thread David Kilzer
On Mon, January 4, 2010 at 5:19:46 PM, Fei Wang wrote: I define my own MIMEType like application/foo with file extension .foo. It works fine if I serve file through web server ( inside web server configuration, I add application/foo foo to the mime type map). In the webkit, I modify

[webkit-dev] Tech Talk on WebKit

2010-01-04 Thread Jeremy Orlow
(Oops, I meant to post this before the holidays but completely forgot. Better late than never I suppose?) A couple weeks ago, Eric Seidel gave a tech talk to a live studio audience of Googlers on the guts of webkit. Although there are a few bits that only apply to Chromium, the vast majority of

Re: [webkit-dev] Tech Talk on WebKit

2010-01-04 Thread Eric Seidel
Thanks Jeremy. I did my best to tell the whole truth and nothing but the truth, but if there are factual errors in my talk, I'd love to know about them. -eric On Mon, Jan 4, 2010 at 6:25 PM, Jeremy Orlow jor...@chromium.org wrote: (Oops, I meant to post this before the holidays but completely

Re: [webkit-dev] Tech Talk on WebKit

2010-01-04 Thread Jeremy Orlow
Well, if there's enough errors, maybe it'll guilt Hyatt into giving a talk. O wait...was that out loud? :-) J On Mon, Jan 4, 2010 at 7:38 PM, Eric Seidel e...@webkit.org wrote: Thanks Jeremy. I did my best to tell the whole truth and nothing but the truth, but if there are factual errors

[webkit-dev] performance improvement techniques for JSCORE

2010-01-04 Thread nagarjuna atluri
Hi guys, Can anyone suggest performance improvement techniques for JSCORE . SFX is already implemeted... -- Nagarjuna ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev