Re: [webkit-dev] New Rich Text Editing Test suite

2010-10-04 Thread Roland Steiner
On Sat, Oct 2, 2010 at 5:14 AM, Ryosuke Niwa rn...@webkit.org wrote: I also noticed: RTE2-CC_FN:a_FONTf:a-1_SI fontname 'courier' y y y y FAIL font face=arialfoo[bar]baz/font font face=arialfoo[bar]baz/font font face=arialfoo/fontspanclass=apple-style-span style=font-family:

Re: [webkit-dev] New Rich Text Editing Test suite

2010-10-04 Thread Roland Steiner
I don't have a ToT WebKit browser ATM, but I'll check once I updated and compiled. FWIW, this seems to be a regression anyways, since release Chromium (Chrome 6.0) at least passes all those tests, without extra br (?) Cheers, - Roland On Sat, Oct 2, 2010 at 5:07 AM, Ryosuke Niwa

Re: [webkit-dev] PSA: Don't try to hold onto temporaries with references

2010-10-04 Thread Hans Wennborg
On Mon, Oct 4, 2010 at 12:41 PM, Hans Wennborg h...@chromium.org wrote: On Mon, Oct 4, 2010 at 12:23 PM, Leandro Graciá Gil leandrogra...@chromium.org wrote: In summary, looking at code like this  B b = c-foo();  ...  b.m(); If c-foo() returns a temporary (return B();), then it is safe.

[webkit-dev] Safari for Windows symbol server updated

2010-10-04 Thread Adam Roben
The Safari for Windows symbol server has been updated with symbols for all releases through Safari 5.0.2. You can find instructions for using the symbol server at http://developer.apple.com/internet/safari/windows_symbols_agree.html. -Adam ___

Re: [webkit-dev] PSA: Don't try to hold onto temporaries with references

2010-10-04 Thread Leandro Graciá Gil
In summary, looking at code like this B b = c-foo(); ... b.m(); If c-foo() returns a temporary (return B();), then it is safe. Maybe I'm wrong, but are you completely sure about this one? I would say that the temporary object created in return B() will cease to exist as soon as it

Re: [webkit-dev] PSA: Don't try to hold onto temporaries with references

2010-10-04 Thread Hans Wennborg
On Mon, Oct 4, 2010 at 12:23 PM, Leandro Graciá Gil leandrogra...@chromium.org wrote: In summary, looking at code like this  B b = c-foo();  ...  b.m(); If c-foo() returns a temporary (return B();), then it is safe. Maybe I'm wrong, but are you completely sure about this one? I would say

Re: [webkit-dev] PSA: Don't try to hold onto temporaries with references

2010-10-04 Thread Mike Marchywka
Date: Mon, 4 Oct 2010 12:23:06 +0100 From: leandrogra...@chromium.org To: le...@google.com CC: webkit-dev@lists.webkit.org Subject: Re: [webkit-dev] PSA: Don't try to hold onto temporaries with references In summary, looking at code like this B b =

Re: [webkit-dev] HTML5 Parsing amp; MathML

2010-10-04 Thread Alex Milowski
On Sat, Oct 2, 2010 at 3:48 PM, David Carlisle d.p.carli...@gmail.com wrote: Alex Milowski alex at milowski.org writes: From reading the section on in foreign content' [1], it would seem that it should assign the 'svg' elements to the MathML namespace when they are embedded as above.  That

Re: [webkit-dev] PSA: Don't try to hold onto temporaries with references

2010-10-04 Thread Darin Adler
The standard is clear on this. The temporary does persist for the lifetime of the reference. See https://bugs.webkit.org/show_bug.cgi?id=47055#c4, a comment I posted yesterday morning, for the reference to the appropriate section in the C++ standard. -- Darin

Re: [webkit-dev] PSA: Don't try to hold onto temporaries with references

2010-10-04 Thread Peter Kasting
On Mon, Oct 4, 2010 at 4:23 AM, Leandro Graciá Gil leandrogra...@chromium.org wrote: In summary, looking at code like this B b = c-foo(); ... b.m(); If c-foo() returns a temporary (return B();), then it is safe. Maybe I'm wrong, but are you completely sure about this one? I would

Re: [webkit-dev] HTML5 Parsing MathML

2010-10-04 Thread Alex Milowski
On Fri, Oct 1, 2010 at 12:52 PM, Adam Barth aba...@webkit.org wrote: Our parser follows the spec (modulo late-breaking spec changes that we haven't picked up yet).  The different namespaces can only be nested in certain ways, unlike in XML where arbitrary nesting is possible. Actually, I don't

[webkit-dev] When to use FastAllocBase?

2010-10-04 Thread Tony Gentilcore
For general reference, when is it appropriate to use FastAllocBase? If you subclass RefCountedT or Noncopyable, which is very common, you pick up FastAllocBase. So, my naive guess is that any class/struct which doesn't pick up FastAllocBase through its inheritance chain should subclass it

Re: [webkit-dev] HTML5 Parsing MathML

2010-10-04 Thread Adam Barth
On Mon, Oct 4, 2010 at 10:03 AM, Alex Milowski a...@milowski.org wrote: On Fri, Oct 1, 2010 at 12:52 PM, Adam Barth aba...@webkit.org wrote: Our parser follows the spec (modulo late-breaking spec changes that we haven't picked up yet).  The different namespaces can only be nested in certain

Re: [webkit-dev] When to use FastAllocBase?

2010-10-04 Thread Adam Barth
On Mon, Oct 4, 2010 at 11:31 AM, Tony Gentilcore to...@chromium.org wrote: For general reference, when is it appropriate to use FastAllocBase? If you subclass RefCountedT or Noncopyable, which is very common, you pick up FastAllocBase. So, my naive guess is that any class/struct which doesn't

Re: [webkit-dev] When to use FastAllocBase?

2010-10-04 Thread Darin Adler
On Oct 4, 2010, at 11:31 AM, Tony Gentilcore wrote: If you subclass RefCountedT or Noncopyable, which is very common, you pick up FastAllocBase. Yes, so in those cases you don’t want to use it. So, my naive guess is that any class/struct which doesn't pick up FastAllocBase through its

Re: [webkit-dev] When to use FastAllocBase?

2010-10-04 Thread Tony Gentilcore
Thanks for the responses. That clears everything up for me. I would recommend we add something to http://webkit.org/coding/coding-style.html, but it sounds like we shouldn't do anything at this point since everything is change. On Mon, Oct 4, 2010 at 11:46 AM, Darin Adler da...@apple.com wrote:

Re: [webkit-dev] PSA: Don't try to hold onto temporaries with references

2010-10-04 Thread David Levin
On Tue, Oct 5, 2010 at 3:42 AM, Peter Kasting pkast...@chromium.org wrote: On Mon, Oct 4, 2010 at 4:23 AM, Leandro Graciá Gil leandrogra...@chromium.org wrote: In summary, looking at code like this B b = c-foo(); ... b.m(); If c-foo() returns a temporary (return B();), then it is

[webkit-dev] WebSocket crashes

2010-10-04 Thread Adam Barth
As you might have noticed, the WebSocket tests are crashing on Leopard and Snow Leopard. I thought for a while that this might be related to my recent move of the WebSocket tests, but looks unrelated. The crashes started with a patch that flipped off the SVN executable bit for a bunch of files,

Re: [webkit-dev] a ping landed

2010-10-04 Thread Jeremy Orlow
Given that a ping really doesn't open up any new privacy holes (just makes it easier for sites to get the data they're going to gather anyway without slowing down the experience for the user), it seems like we might as well enable it by default. If a port doesn't want it, they can always disable

Re: [webkit-dev] WebSocket crashes

2010-10-04 Thread Simon Fraser
On Oct 4, 2010, at 2:33 PM, Adam Barth wrote: As you might have noticed, the WebSocket tests are crashing on Leopard and Snow Leopard. I thought for a while that this might be related to my recent move of the WebSocket tests, but looks unrelated. The crashes started with a patch that

Re: [webkit-dev] WebSocket crashes

2010-10-04 Thread Simon Fraser
On Oct 4, 2010, at 5:30 PM, Simon Fraser wrote: On Oct 4, 2010, at 2:33 PM, Adam Barth wrote: As you might have noticed, the WebSocket tests are crashing on Leopard and Snow Leopard. I thought for a while that this might be related to my recent move of the WebSocket tests, but looks

[webkit-dev] Supporting css ime-mode property

2010-10-04 Thread Kenichi Ishibashi
Hi, I'd like to implement CSS ime-mode property, which activates/deactivates input methods, to WebKit. Here is the MDC's document about this property: https://developer.mozilla.org/en/CSS/ime-mode This property is not a part of any public standard, but both of IE and Firefox support this

Re: [webkit-dev] Supporting css ime-mode property

2010-10-04 Thread Simon Fraser
On Oct 4, 2010, at 6:59 PM, Kenichi Ishibashi wrote: I'd like to implement CSS ime-mode property, which activates/deactivates input methods, to WebKit. Here is the MDC's document about this property: https://developer.mozilla.org/en/CSS/ime-mode This property is not a part of any public

Re: [webkit-dev] Supporting css ime-mode property

2010-10-04 Thread David Hyatt
On Oct 4, 2010, at 10:49 PM, Simon Fraser wrote: On Oct 4, 2010, at 6:59 PM, Kenichi Ishibashi wrote: I'd like to implement CSS ime-mode property, which activates/deactivates input methods, to WebKit. Here is the MDC's document about this property:

Re: [webkit-dev] Supporting css ime-mode property

2010-10-04 Thread Alexey Proskuryakov
04.10.2010, в 18:59, Kenichi Ishibashi написал(а): As the MDC document noted, it's not appropriate for excessive use of this property, but, IMHO, supporting this property would be helpful for people who musta take care of input method related stuff. I still think that this feature would be

Re: [webkit-dev] a ping landed

2010-10-04 Thread Maciej Stachowiak
Since a ping has been controversial in the past (for arguably bogus reasons, but controversial nontheless), I suggest we keep it off by default until we find it has some mainstream acceptance and/or we discover that more ports want it. Regards, Maciej P.S. We haven't decided yet if we want