[webkit-dev] Regarding SecurityOrigin API usage

2011-01-06 Thread Pushparajan V
Hi all, I have a query regarding addOriginAccessWhitelistEntry API in SecurityOrigin.cpp. Is there any special requirement in the sourceOrigin argument of this API when the scheme of the sourceOrigin is already added to the localScheme list? Because if the sourceOrigin is localScheme and the URI

[webkit-dev] WebKit 2: Debugging message passing between the processes

2011-01-06 Thread Benjamin
Hello, Is there a way to debug/visualize the messages passed between the WebProcess and the UIProcess? I am debugging an issue on page loading and it is made a bit difficult by the passage back and forth between the two processses. I wonder if there is better way to do that. cheers, Benjamin

[webkit-dev] Getting at Settings object from WorkerContext

2011-01-06 Thread Joe Mason
I'm trying to add a setting to enable/disable WebSockets at runtime (so that the browser can make websockets available as a user preference, for instance). It's easy to add a flag to Settings, and check it from JSDOMWindowCustom::webSocket to return undefined for the websocket object when

Re: [webkit-dev] Getting at Settings object from WorkerContext

2011-01-06 Thread Jeremy Orlow
The RuntimeEnabledFeatures class [1] seems like what you're looking for. J [1] http://codesearch.google.com/codesearch/p?hl=en#OAMlx_jo-ck/src/third_party/WebKit/WebCore/bindings/generic/RuntimeEnabledFeatures.hq=RuntimeFeatureexact_package=chromiumd=6 On Thu, Jan 6, 2011 at 6:05 PM, Joe Mason

Re: [webkit-dev] Getting at Settings object from WorkerContext

2011-01-06 Thread Joe Mason
Aha, there is already a websocketsEnabled method there! Thanks, that's perfect. From: jor...@google.com [mailto:jor...@google.com] On Behalf Of Jeremy Orlow Sent: Thursday, January 06, 2011 1:25 PM To: Joe Mason Cc: webkit-dev Development Subject: Re: [webkit-dev] Getting at Settings object

Re: [webkit-dev] Getting at Settings object from WorkerContext

2011-01-06 Thread Joe Mason
Hmm, I can't get the RuntimeEnabledFeatures class working. bool RuntimeEnabledFeatures::webSocketEnabled() { return WebSocket::isAvailable(); } So it looks from that like I should just be able to call WebSocket::setIsAvailable(false), and then websockets would automatically drop out. But

Re: [webkit-dev] Getting at Settings object from WorkerContext

2011-01-06 Thread Jeremy Orlow
Hmm. It might still be v8-only, though I'm surprised since the class was moved from the v8 directory to generic. If that's the case, then I suppose it'll need to be ported to JSC. J On Thu, Jan 6, 2011 at 7:24 PM, Joe Mason jma...@rim.com wrote: Hmm, I can’t get the RuntimeEnabledFeatures

Re: [webkit-dev] Getting at Settings object from WorkerContext

2011-01-06 Thread Jeremy Orlow
Btw, the reason that this behavior has to live in the bindings and not WebCore is to ensure feature detection code still works. For example, if indexedDB is disabled at runtime, then the webkitIndexedDB attribute on window needs to not exist in any form. Also, IIRC, because of optimizations, the

Re: [webkit-dev] Regarding SecurityOrigin API usage

2011-01-06 Thread Adam Barth
On Thu, Jan 6, 2011 at 6:27 AM, Pushparajan V vpra...@gmail.com wrote: I have a query regarding addOriginAccessWhitelistEntry API in SecurityOrigin.cpp. Is there any special requirement in the sourceOrigin argument of this API when the scheme of the sourceOrigin is already added to the

[webkit-dev] RuntimeEnabledFeatures for JSC (was RE: Getting at Settings object from WorkerContext)

2011-01-06 Thread Joe Mason
I took a look at CodeGeneratorJS.pm to see how hard it would be to port this over. I have no idea where to start... The structure of CodeGeneratorJS.pm and CodeGeneratorV8.pm seem quite different. This also seems like a lot of work to do just to enable/disable one feature, but I guess if

Re: [webkit-dev] RuntimeEnabledFeatures for JSC (was RE: Getting at Settings object from WorkerContext)

2011-01-06 Thread Darin Adler
On Jan 6, 2011, at 12:41 PM, Joe Mason wrote: I took a look at CodeGeneratorJS.pm to see how hard it would be to port this over. I have no idea where to start… The structure of CodeGeneratorJS.pm and CodeGeneratorV8.pm seem quite different. This also seems like a lot of work to do just to

Re: [webkit-dev] RuntimeEnabledFeatures for JSC (was RE: Getting at Settings object from WorkerContext)

2011-01-06 Thread Adam Barth
On Thu, Jan 6, 2011 at 12:47 PM, Darin Adler da...@apple.com wrote: On Jan 6, 2011, at 12:41 PM, Joe Mason wrote: I took a look at CodeGeneratorJS.pm to see how hard it would be to port this over. I have no idea where to start…  The structure of CodeGeneratorJS.pm and CodeGeneratorV8.pm seem

Re: [webkit-dev] RuntimeEnabledFeatures for JSC (was RE: Getting at Settings object from WorkerContext)

2011-01-06 Thread Joe Mason
-Original Message- From: aba...@gmail.com [mailto:aba...@gmail.com] On Behalf Of Adam Barth That's one my list of things I'd like to do, but my Perl isn't strong enough yet. :( I'm pretty sure my Perl is worse than yours, unfortunately. Perl and I do not get along. I've filed

Re: [webkit-dev] RuntimeEnabledFeatures for JSC (was RE: Getting at Settings object from WorkerContext)

2011-01-06 Thread Jeremy Orlow
On Thu, Jan 6, 2011 at 8:57 PM, Adam Barth aba...@webkit.org wrote: On Thu, Jan 6, 2011 at 12:47 PM, Darin Adler da...@apple.com wrote: On Jan 6, 2011, at 12:41 PM, Joe Mason wrote: I took a look at CodeGeneratorJS.pm to see how hard it would be to port this over. I have no idea where to

Re: [webkit-dev] RuntimeEnabledFeatures for JSC (was RE: Getting at Settings object from WorkerContext)

2011-01-06 Thread Adam Barth
On Thu, Jan 6, 2011 at 1:04 PM, Jeremy Orlow jor...@chromium.org wrote: On Thu, Jan 6, 2011 at 8:57 PM, Adam Barth aba...@webkit.org wrote: On Thu, Jan 6, 2011 at 12:47 PM, Darin Adler da...@apple.com wrote: On Jan 6, 2011, at 12:41 PM, Joe Mason wrote: I took a look at CodeGeneratorJS.pm to

Re: [webkit-dev] RuntimeEnabledFeatures for JSC (was RE: Getting at Settings object from WorkerContext)

2011-01-06 Thread Darin Fisher
On Thu, Jan 6, 2011 at 12:47 PM, Darin Adler da...@apple.com wrote: On Jan 6, 2011, at 12:41 PM, Joe Mason wrote: I took a look at CodeGeneratorJS.pm to see how hard it would be to port this over. I have no idea where to start… The structure of CodeGeneratorJS.pm and CodeGeneratorV8.pm

Re: [webkit-dev] RuntimeEnabledFeatures for JSC (was RE: Getting at Settings object from WorkerContext)

2011-01-06 Thread Joe Mason
From: da...@google.com [mailto:da...@google.com] On Behalf Of Darin Fisher IIRC, there was not much interest from JSC-using ports for RuntimeEnabledFeatures. Well, there is now! Joe - This transmission (including any

Re: [webkit-dev] Best way to track feature evolution from release-to-release

2011-01-06 Thread Ojan Vafai
On Wed, Jan 5, 2011 at 9:38 AM, Darin Adler da...@apple.com wrote: The user agent string in Chromium cites, for example, AppleWebKit/534.10. Does this refer directly to the /tags/Safari-534.10 code base? In other words, this is just an example of an organization chosing to use a tag created

Re: [webkit-dev] Best way to track feature evolution from release-to-release

2011-01-06 Thread Darin Fisher
On Thu, Jan 6, 2011 at 4:39 PM, Ojan Vafai o...@chromium.org wrote: On Wed, Jan 5, 2011 at 9:38 AM, Darin Adler da...@apple.com wrote: The user agent string in Chromium cites, for example, AppleWebKit/534.10. Does this refer directly to the /tags/Safari-534.10 code base? In other words,

[webkit-dev] WebGL refactor

2011-01-06 Thread Mo, Zhenyao
Hi, I am doing some refactoring in WebGL, and it will touch almost every function in WebGLRenderingContext and other classes start with WebGL* under WebCore/html/canvas. Can I ask that for next Monday and Tuesday, do not touch these files until my patch lands? Otherwise merge will be a big

[webkit-dev] Fwd: Best way to track feature evolution from release-to-release

2011-01-06 Thread Ryosuke Niwa
On Thu, Jan 6, 2011 at 8:31 PM, Darin Fisher da...@chromium.org wrote: On Thu, Jan 6, 2011 at 4:39 PM, Ojan Vafai o...@chromium.org wrote: Some ideas: -Use the svn revision number. That has the downside of being tied to SVN should we want to change version control systems. -Have a file

Re: [webkit-dev] Regarding SecurityOrigin API usage

2011-01-06 Thread Pushparajan V
On Fri, Jan 7, 2011 at 1:18 AM, Adam Barth aba...@webkit.org wrote: On Thu, Jan 6, 2011 at 6:27 AM, Pushparajan V vpra...@gmail.com wrote: I have a query regarding addOriginAccessWhitelistEntry API in SecurityOrigin.cpp. Is there any special requirement in the sourceOrigin argument of this API

Re: [webkit-dev] Regarding SecurityOrigin API usage

2011-01-06 Thread Adam Barth
On Thu, Jan 6, 2011 at 10:17 PM, Pushparajan V vpra...@gmail.com wrote: On Fri, Jan 7, 2011 at 1:18 AM, Adam Barth aba...@webkit.org wrote: On Thu, Jan 6, 2011 at 6:27 AM, Pushparajan V vpra...@gmail.com wrote: I have a query regarding addOriginAccessWhitelistEntry API in SecurityOrigin.cpp.