Re: [webkit-dev] Removing the prefix from webkitPostMessage

2012-09-13 Thread Maciej Stachowiak
On Sep 12, 2012, at 10:36 PM, Ojan Vafai o...@chromium.org wrote: On Wed, Sep 12, 2012 at 6:40 PM, Maciej Stachowiak m...@apple.com wrote: - Is this approach substantially less time and effort than adding a histogram-style metric? I expect you have added a histogram to Chrome at some

[webkit-dev] unsigned vs unsigned int

2012-09-13 Thread Kenneth Rohde Christiansen
Hi there, I was telling people to use unsigned instead of unsigned int, as I have been told that was the preferred style before, but apparently that is not in the style guide. The question is, should it be? A few greps in the code: unsigned - 18406 occurrences. unsigned int - 1721 unsigned i =

Re: [webkit-dev] unsigned vs unsigned int

2012-09-13 Thread Dan Bernstein
On Sep 13, 2012, at 1:29 AM, Kenneth Rohde Christiansen kenneth.christian...@gmail.com wrote: Hi there, I was telling people to use unsigned instead of unsigned int, as I have been told that was the preferred style before, but apparently that is not in the style guide. The question

Re: [webkit-dev] Removing the prefix from webkitPostMessage

2012-09-13 Thread Dirk Pranke
On Wed, Sep 12, 2012 at 11:00 PM, Maciej Stachowiak m...@apple.com wrote: On Sep 12, 2012, at 10:36 PM, Ojan Vafai o...@chromium.org wrote: On Wed, Sep 12, 2012 at 6:40 PM, Maciej Stachowiak m...@apple.com wrote: - Is this approach substantially less time and effort than adding a

Re: [webkit-dev] Removing the prefix from webkitPostMessage

2012-09-13 Thread Ojan Vafai
On Thu, Sep 13, 2012 at 12:06 PM, Dirk Pranke dpra...@chromium.org wrote: On Wed, Sep 12, 2012 at 11:00 PM, Maciej Stachowiak m...@apple.com wrote: On Sep 12, 2012, at 10:36 PM, Ojan Vafai o...@chromium.org wrote: On Wed, Sep 12, 2012 at 6:40 PM, Maciej Stachowiak m...@apple.com wrote:

Re: [webkit-dev] unsigned vs unsigned int

2012-09-13 Thread Ryosuke Niwa
Uploaded a patch on https://bugs.webkit.org/show_bug.cgi?id=96682. - Ryosuke On Thu, Sep 13, 2012 at 8:11 AM, Dan Bernstein m...@apple.com wrote: On Sep 13, 2012, at 1:29 AM, Kenneth Rohde Christiansen kenneth.christian...@gmail.com wrote: Hi there, I was telling people to use

[webkit-dev] Should we support multiple bug URLs in TestExpectations?

2012-09-13 Thread Ryosuke Niwa
Hi, This discussion came out of https://bugs.webkit.org/show_bug.cgi?id=96569. Should we allow URLs other than webkit.org/b/ to be used in TestExpectations? I vote for yes, and in fact, adding new URLs should be easy. What do you guys think? Best, Ryosuke Niwa Software Engineer Google Inc.

Re: [webkit-dev] Should we support multiple bug URLs in TestExpectations?

2012-09-13 Thread Dirk Pranke
On Thu, Sep 13, 2012 at 12:32 PM, Ryosuke Niwa rn...@webkit.org wrote: Hi, This discussion came out of https://bugs.webkit.org/show_bug.cgi?id=96569. Should we allow URLs other than webkit.org/b/ to be used in TestExpectations? I vote for yes, and in fact, adding new URLs should be easy.

Re: [webkit-dev] unsigned vs unsigned int

2012-09-13 Thread Ryosuke Niwa
Landed in http://trac.webkit.org/changeset/128499 (Thanks ggaren!) On Thu, Sep 13, 2012 at 12:29 PM, Ryosuke Niwa rn...@webkit.org wrote: Uploaded a patch on https://bugs.webkit.org/show_bug.cgi?id=96682. - Ryosuke On Thu, Sep 13, 2012 at 8:11 AM, Dan Bernstein m...@apple.com wrote: On

Re: [webkit-dev] unsigned vs unsigned int

2012-09-13 Thread Oliver Hunt
Does the style bot pick up unsigned int etc? --Oliver On Sep 13, 2012, at 1:19 PM, Ryosuke Niwa rn...@webkit.org wrote: Landed in http://trac.webkit.org/changeset/128499 (Thanks ggaren!) On Thu, Sep 13, 2012 at 12:29 PM, Ryosuke Niwa rn...@webkit.org wrote: Uploaded a patch on

Re: [webkit-dev] unsigned vs unsigned int

2012-09-13 Thread Ryosuke Niwa
No. I think we can update webkitpy/style/checkers/cpp.py to do that. Unfortunately, I don't understand that code base. - Ryosuke On Thu, Sep 13, 2012 at 1:34 PM, Oliver Hunt oli...@apple.com wrote: Does the style bot pick up unsigned int etc? --Oliver On Sep 13, 2012, at 1:19 PM, Ryosuke

Re: [webkit-dev] unsigned vs unsigned int

2012-09-13 Thread Kenneth Rohde Christiansen
Filed https://bugs.webkit.org/show_bug.cgi?id=96693 On Thu, Sep 13, 2012 at 10:47 PM, Ryosuke Niwa rn...@webkit.org wrote: No. I think we can update webkitpy/style/checkers/cpp.py to do that. Unfortunately, I don't understand that code base. - Ryosuke On Thu, Sep 13, 2012 at 1:34 PM,

Re: [webkit-dev] unsigned vs unsigned int

2012-09-13 Thread David Levin
If someone wanted this and understood python, I suspect that they could search for unsigned in that cpp.py and in about 10 min have a pretty good idea of how to add such a check. If you don't understand Python, then 30 minutes :) dave On Thu, Sep 13, 2012 at 2:12 PM, Kenneth Rohde Christiansen

[webkit-dev] Existing metrics for deprecated features

2012-09-13 Thread Adam Barth
In connection with the thread on webkitPostMessage, I took a look at what sorts of metrics we have currently for depreciated features. We have high quality data for two groups of APIs: For mutation events, we measure what percent of Documents have listeners for various kinds of mutation events:

Re: [webkit-dev] SH4, MIPS, and legacy-ARM assemblers in JavaScriptCore

2012-09-13 Thread Gergely Kis
Hi, Submitted the patch for enabling the MIPS slave in build.webkit.org. https://bugs.webkit.org/show_bug.cgi?id=96713 Who should I send the buildbot password for the slave? Thanks, Gergely On Thu, Aug 30, 2012 at 9:52 AM, Holger Freyther ze...@selfish.org wrote: On 08/30/2012 12:10 AM,

[webkit-dev] Removing webkitSlice (was Re: Existing metrics for deprecated features)

2012-09-13 Thread Adam Barth
On Thu, Sep 13, 2012 at 5:13 PM, Adam Barth aba...@webkit.org wrote: Another metric we have is for Blob.webkitSlice: Ratio of Blob.webkitSlice calls to Blob.slice: 14.87% Ratio of Blob.webkitSlice calls to Document creation: 0.0053% It's difficult to know how to interpret this data because

Re: [webkit-dev] Removing webkitSlice (was Re: Existing metrics for deprecated features)

2012-09-13 Thread Darin Fisher
On Thu, Sep 13, 2012 at 6:16 PM, Adam Barth aba...@webkit.org wrote: On Thu, Sep 13, 2012 at 5:13 PM, Adam Barth aba...@webkit.org wrote: Another metric we have is for Blob.webkitSlice: Ratio of Blob.webkitSlice calls to Blob.slice: 14.87% Ratio of Blob.webkitSlice calls to Document

[webkit-dev] New WebKit reviewer: Yuta Kitamura

2012-09-13 Thread TAMURA, Kent
I'd like to announce that Yuta Kitamura yu...@chromium.org is now a WebKit reviewer. He has contributed to WebKit project for three years mainly in WebSocket area. He is a trustworthy authority on WebSocket area. If you worked on WebSocket issues, please involve him. -- TAMURA Kent Software

Re: [webkit-dev] New WebKit reviewer: Yuta Kitamura

2012-09-13 Thread Adam Barth
Congrats Yuta!! Adam On Thu, Sep 13, 2012 at 8:56 PM, TAMURA, Kent tk...@chromium.org wrote: I'd like to announce that Yuta Kitamura yu...@chromium.org is now a WebKit reviewer. He has contributed to WebKit project for three years mainly in WebSocket area. He is a trustworthy authority on

Re: [webkit-dev] Removing webkitSlice (was Re: Existing metrics for deprecated features)

2012-09-13 Thread Maciej Stachowiak
On Sep 13, 2012, at 11:15 PM, Darin Fisher da...@google.com wrote: On Thu, Sep 13, 2012 at 6:16 PM, Adam Barth aba...@webkit.org wrote: On Thu, Sep 13, 2012 at 5:13 PM, Adam Barth aba...@webkit.org wrote: Another metric we have is for Blob.webkitSlice: Ratio of Blob.webkitSlice calls

Re: [webkit-dev] New WebKit reviewer: Yuta Kitamura

2012-09-13 Thread Gyuyoung Kim
Wow, congratulation Yuta :-) Gyuyoung On Fri, Sep 14, 2012 at 1:01 PM, Adam Barth aba...@webkit.org wrote: Congrats Yuta!! Adam On Thu, Sep 13, 2012 at 8:56 PM, TAMURA, Kent tk...@chromium.org wrote: I'd like to announce that Yuta Kitamura yu...@chromium.org is now a WebKit reviewer.

Re: [webkit-dev] New WebKit reviewer: Yuta Kitamura

2012-09-13 Thread Yin, Li
Congrats Yuta. -Original Message- From: webkit-dev-boun...@lists.webkit.org [mailto:webkit-dev-boun...@lists.webkit.org] On Behalf Of TAMURA, Kent Sent: Friday, September 14, 2012 11:57 AM To: WebKit Development Subject: [webkit-dev] New WebKit reviewer: Yuta Kitamura I'd like to

Re: [webkit-dev] Removing webkitSlice (was Re: Existing metrics for deprecated features)

2012-09-13 Thread Adam Barth
On Thu, Sep 13, 2012 at 9:05 PM, Maciej Stachowiak m...@apple.com wrote: On Sep 13, 2012, at 11:15 PM, Darin Fisher da...@google.com wrote: On Thu, Sep 13, 2012 at 6:16 PM, Adam Barth aba...@webkit.org wrote: On Thu, Sep 13, 2012 at 5:13 PM, Adam Barth aba...@webkit.org wrote: Another metric

Re: [webkit-dev] Existing metrics for deprecated features

2012-09-13 Thread Pavel Feldman
On Fri, Sep 14, 2012 at 4:13 AM, Adam Barth aba...@webkit.org wrote: In connection with the thread on webkitPostMessage, I took a look at what sorts of metrics we have currently for depreciated features. We have high quality data for two groups of APIs: For mutation events, we measure what