Re: [webkit-dev] Switching open source Debug bots to building and testing with configuration --force-opt=O3

[Simon Fraser]

I also object to losing good stack traces for crashes on Debug bots.

Also, I don't think Debug bots should build something different from what I 
build at my desk.

Simon

> On Jun 17, 2020, at 1:36 PM, Mark Lam  wrote:
> 
> Hi folks,
> 
> We're planning to switch the JSC EWS bot and build.webkit.org 
>  Debug build and test bots to building with the 
> following set first:
> ./Tools/Scripts/set-webkit-configuration --force-opt=O3
> 
> This means the Debug builds will be built with optimization level forced to 
> O3.
> 
> Why are we doing this?
> 1. So that the JSC EWS will start catching ASSERT failures.
> 2. JSC stress test Debug bots have been timing out and not running tests at 
> all.  Hopefully, this change will fix this issue.
> 3. Tests will run to completion faster and we’ll catch regressions sooner.
> 
> The downside: crash stack traces will be like Release build stack traces.  
> But I don’t think we should let this deter us.  It’s not like there’s no 
> stack information.  And just as we do with debugging Release build test 
> failures, we can always do a Debug build locally to do our debugging.
> 
> We would like to apply this change to all Debug build and test bots, not just 
> the JSC ones.  Does anyone strongly object to this change?
> 
> Thanks.
> 
> Cheers,
> Mark
> 
> ___
> webkit-dev mailing list
> webkit-dev@lists.webkit.org
> https://lists.webkit.org/mailman/listinfo/webkit-dev

___
webkit-dev mailing list
webkit-dev@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev

Re: [webkit-dev] Switching open source Debug bots to building and testing with configuration --force-opt=O3

[Yusuke Suzuki]

In JSC EWS bots. For the other Debug EWS bots, (Like, WebCore Debug builds), I 
have no strong opinion.

-Yusuke

> On Jun 17, 2020, at 6:07 PM, Yusuke Suzuki  wrote:
> 
> For EWS, we are running Release build right now. So in terms of stack traces, 
> nothing is changed.
> 
> -Yusuke
> 
>> On Jun 17, 2020, at 5:21 PM, Alexey Proskuryakov > > wrote:
>> 
>> 
>> I frequently find it critically useful to see stack traces from debug 
>> builds, because of no inlining. So I don't think that we should do this. A 
>> local build does not help when the issue is not readily reproducible.
>> 
>> - Alexey
>> 
>> 
>>> 17 июня 2020 г., в 1:36 PM, Mark Lam >> > написал(а):
>>> 
>>> Hi folks,
>>> 
>>> We're planning to switch the JSC EWS bot and build.webkit.org 
>>>  Debug build and test bots to building with the 
>>> following set first:
>>> ./Tools/Scripts/set-webkit-configuration --force-opt=O3
>>> 
>>> This means the Debug builds will be built with optimization level forced to 
>>> O3.
>>> 
>>> Why are we doing this?
>>> 1. So that the JSC EWS will start catching ASSERT failures.
>>> 2. JSC stress test Debug bots have been timing out and not running tests at 
>>> all.  Hopefully, this change will fix this issue.
>>> 3. Tests will run to completion faster and we’ll catch regressions sooner.
>>> 
>>> The downside: crash stack traces will be like Release build stack traces.  
>>> But I don’t think we should let this deter us.  It’s not like there’s no 
>>> stack information.  And just as we do with debugging Release build test 
>>> failures, we can always do a Debug build locally to do our debugging.
>>> 
>>> We would like to apply this change to all Debug build and test bots, not 
>>> just the JSC ones.  Does anyone strongly object to this change?
>>> 
>>> Thanks.
>>> 
>>> Cheers,
>>> Mark
>>> 
>>> ___
>>> webkit-dev mailing list
>>> webkit-dev@lists.webkit.org 
>>> https://lists.webkit.org/mailman/listinfo/webkit-dev 
>>> 
>> 
>> 
>> ___
>> webkit-dev mailing list
>> webkit-dev@lists.webkit.org 
>> https://lists.webkit.org/mailman/listinfo/webkit-dev
> 
> ___
> webkit-dev mailing list
> webkit-dev@lists.webkit.org
> https://lists.webkit.org/mailman/listinfo/webkit-dev

___
webkit-dev mailing list
webkit-dev@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev

Re: [webkit-dev] Switching open source Debug bots to building and testing with configuration --force-opt=O3

[Yusuke Suzuki]

For EWS, we are running Release build right now. So in terms of stack traces, 
nothing is changed.

-Yusuke

> On Jun 17, 2020, at 5:21 PM, Alexey Proskuryakov  wrote:
> 
> 
> I frequently find it critically useful to see stack traces from debug builds, 
> because of no inlining. So I don't think that we should do this. A local 
> build does not help when the issue is not readily reproducible.
> 
> - Alexey
> 
> 
>> 17 июня 2020 г., в 1:36 PM, Mark Lam > > написал(а):
>> 
>> Hi folks,
>> 
>> We're planning to switch the JSC EWS bot and build.webkit.org 
>>  Debug build and test bots to building with the 
>> following set first:
>> ./Tools/Scripts/set-webkit-configuration --force-opt=O3
>> 
>> This means the Debug builds will be built with optimization level forced to 
>> O3.
>> 
>> Why are we doing this?
>> 1. So that the JSC EWS will start catching ASSERT failures.
>> 2. JSC stress test Debug bots have been timing out and not running tests at 
>> all.  Hopefully, this change will fix this issue.
>> 3. Tests will run to completion faster and we’ll catch regressions sooner.
>> 
>> The downside: crash stack traces will be like Release build stack traces.  
>> But I don’t think we should let this deter us.  It’s not like there’s no 
>> stack information.  And just as we do with debugging Release build test 
>> failures, we can always do a Debug build locally to do our debugging.
>> 
>> We would like to apply this change to all Debug build and test bots, not 
>> just the JSC ones.  Does anyone strongly object to this change?
>> 
>> Thanks.
>> 
>> Cheers,
>> Mark
>> 
>> ___
>> webkit-dev mailing list
>> webkit-dev@lists.webkit.org 
>> https://lists.webkit.org/mailman/listinfo/webkit-dev
> 
> 
> ___
> webkit-dev mailing list
> webkit-dev@lists.webkit.org
> https://lists.webkit.org/mailman/listinfo/webkit-dev

___
webkit-dev mailing list
webkit-dev@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev

Re: [webkit-dev] Switching open source Debug bots to building and testing with configuration --force-opt=O3

[Alexey Proskuryakov]

I frequently find it critically useful to see stack traces from debug builds, 
because of no inlining. So I don't think that we should do this. A local build 
does not help when the issue is not readily reproducible.

- Alexey


> 17 июня 2020 г., в 1:36 PM, Mark Lam  написал(а):
> 
> Hi folks,
> 
> We're planning to switch the JSC EWS bot and build.webkit.org 
>  Debug build and test bots to building with the 
> following set first:
> ./Tools/Scripts/set-webkit-configuration --force-opt=O3
> 
> This means the Debug builds will be built with optimization level forced to 
> O3.
> 
> Why are we doing this?
> 1. So that the JSC EWS will start catching ASSERT failures.
> 2. JSC stress test Debug bots have been timing out and not running tests at 
> all.  Hopefully, this change will fix this issue.
> 3. Tests will run to completion faster and we’ll catch regressions sooner.
> 
> The downside: crash stack traces will be like Release build stack traces.  
> But I don’t think we should let this deter us.  It’s not like there’s no 
> stack information.  And just as we do with debugging Release build test 
> failures, we can always do a Debug build locally to do our debugging.
> 
> We would like to apply this change to all Debug build and test bots, not just 
> the JSC ones.  Does anyone strongly object to this change?
> 
> Thanks.
> 
> Cheers,
> Mark
> 
> ___
> webkit-dev mailing list
> webkit-dev@lists.webkit.org
> https://lists.webkit.org/mailman/listinfo/webkit-dev


___
webkit-dev mailing list
webkit-dev@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev

Re: [webkit-dev] Request for position on Media Feeds

[Maciej Stachowiak]

Without having read the spec in detail, the first thing I wonder is why not use 
RSS for this purpose? That seems to be the de facto standard for audio feeds 
(i.e. podcasts). This is dismissed in a cursory way in the explainer. There’s 
some more detailed discussion in the issue filed by the TAG: 
, which I found 
eventually. It seems like some of that should go in the Explainer.

Second, it’s not clear to me if this spec has anything that would need to be 
implemented in the browser engine. Rather, it provides a format for metadata 
linked from the page, which can optionally be used by the UA in some manner 
unrelated to processing of web content. Is that correct? (Asking in part to 
know the right people to ask for an opinion.)

Third, and this is a minor thing, it seems strange that the spec (and parts of 
its syntax) are called Media Feeds instead of Video Feeds, since audio is 
explicitly out of scope. Perhaps audio is intended to be added later. If so, 
that increases the value of aligning with how podcasts are done today.


> On Jun 17, 2020, at 2:48 PM, Becca Hughes  wrote:
> 
> Hi webkit-dev,
> 
> I would like to request an official position on Media Feeds.
> 
> Explainer: https://github.com/WICG/media-feeds/blob/master/explainer.md 
> 
> Chrome Status: https://chromestatus.com/feature/5695114963845120 
> 
> TAG review: https://github.com/w3ctag/design-reviews/issues/477 
> 
> 
> Thanks,
> Becca
> ___
> webkit-dev mailing list
> webkit-dev@lists.webkit.org
> https://lists.webkit.org/mailman/listinfo/webkit-dev

___
webkit-dev mailing list
webkit-dev@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev

[webkit-dev] Request for position on Media Feeds

[Becca Hughes]

Hi webkit-dev,

I would like to request an official position on Media Feeds.

Explainer: https://github.com/WICG/media-feeds/blob/master/explainer.md
Chrome Status: https://chromestatus.com/feature/5695114963845120
TAG review: https://github.com/w3ctag/design-reviews/issues/477

Thanks,
Becca
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev

[webkit-dev] Switching open source Debug bots to building and testing with configuration --force-opt=O3

[Mark Lam]

Hi folks,

We're planning to switch the JSC EWS bot and build.webkit.org 
 Debug build and test bots to building with the 
following set first:
./Tools/Scripts/set-webkit-configuration --force-opt=O3

This means the Debug builds will be built with optimization level forced to O3.

Why are we doing this?
1. So that the JSC EWS will start catching ASSERT failures.
2. JSC stress test Debug bots have been timing out and not running tests at 
all.  Hopefully, this change will fix this issue.
3. Tests will run to completion faster and we’ll catch regressions sooner.

The downside: crash stack traces will be like Release build stack traces.  But 
I don’t think we should let this deter us.  It’s not like there’s no stack 
information.  And just as we do with debugging Release build test failures, we 
can always do a Debug build locally to do our debugging.

We would like to apply this change to all Debug build and test bots, not just 
the JSC ones.  Does anyone strongly object to this change?

Thanks.

Cheers,
Mark

___
webkit-dev mailing list
webkit-dev@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev