Re: [webkit-dev] WebKit Transition to Git

2020-10-05 Thread Konstantin Tokarev
05.10.2020, 13:26, "Frédéric Wang" : > One thing to take into account is that WebKit's repository is big and > public GitHub/GitLab prevent creating large repository by default. This > means it might not be possible for contributors to actually fork > WebKit's repository on their account and

Re: [webkit-dev] WebKit Transition to Git

2020-10-05 Thread Konstantin Tokarev
05.10.2020, 17:19, "Robert Ma" : > On Mon, Oct 5, 2020 at 6:22 AM Frédéric Wang wrote: >> One thing to take into account is that WebKit's repository is big and >> public GitHub/GitLab prevent creating large repository by default. This >> means it might not be possible for contributors to

Re: [webkit-dev] WebKit Transition to Git

2020-10-05 Thread Konstantin Tokarev
05.10.2020, 23:41, "Yusuke Suzuki" : > I think security component is special in terms of how to handle it already > (e.g. not posting a test with the patch etc.) > To me, handling non-security issues in GitHub and security issues in Bugzilla > is OK. > By nature, security issues are not open.

Re: [webkit-dev] WebKit Transition to Git

2020-10-05 Thread Yusuke Suzuki
I think security component is special in terms of how to handle it already (e.g. not posting a test with the patch etc.) To me, handling non-security issues in GitHub and security issues in Bugzilla is OK. By nature, security issues are not open. Since one of our motivation of moving to GitHub

Re: [webkit-dev] WebKit Transition to Git

2020-10-05 Thread Fujii Hironori
On Tue, Oct 6, 2020 at 12:40 AM Jonathan Bedard wrote: > > That's one solution, but even that is somewhat insufficient because we > don’t want to give someone access to every security issue just to give > access to a single one. One of the solutions we’ve discussed is to migrate > bugs component

Re: [webkit-dev] WebKit Transition to Git

2020-10-05 Thread Michael Catanzaro
On Mon, Oct 5, 2020 at 8:40 am, Jonathan Bedard wrote: That's one solution, but even that is somewhat insufficient because we don’t want to give someone access to every security issue just to give access to a single one. One of the solutions we’ve discussed is to migrate bugs component by

Re: [webkit-dev] WebKit Transition to Git [Identifiers and Merge Commits]

2020-10-05 Thread Jonathan Bedard
>> Monotonic Commit Identifiers >> Of great interest to Apple?s engineers has been retaining some kind >> of ordered tag we can use to refer to commits to make defending CI >> and bisection easier. We?ve developed a scheme for this that assigns >> commits an ordered identifier per-branch,

Re: [webkit-dev] WebKit Transition to Git

2020-10-05 Thread Jonathan Bedard
> On Oct 2, 2020, at 5:05 PM, Michael Catanzaro wrote: > > On Fri, Oct 2, 2020 at 09:43, Jonathan Bedard wrote: >> The biggest blocker we are aware of is managing security bugs, since the >> security advisory system used by GitHub is essentially the opposite of how >> WebKit security bugs

Re: [webkit-dev] WebKit Transition to Git

2020-10-05 Thread Jonathan Bedard
`git describe` is quite a bit less powerful, unfortunately. First, while the string coming from `git-describe` can be used in git commands, that’s only because it contains the abbreviated commit hash, which alone is sufficient to identify a commit. Second, such identifiers end up being pretty

Re: [webkit-dev] WebKit Transition to Git

2020-10-05 Thread Frédéric Wang
On 05/10/2020 16:15, Robert Ma wrote: > On Mon, Oct 5, 2020 at 6:22 AM Frédéric Wang > wrote: > > One thing to take into account is that WebKit's repository is big and > public GitHub/GitLab prevent creating large repository by default. > This > means it

Re: [webkit-dev] WebKit Transition to Git

2020-10-05 Thread Adrien Destugues
> One thing to take into account is that WebKit's repository is big and > public GitHub/GitLab prevent creating large repository by default. This > means it might not be possible for contributors to actually fork > WebKit's repository on their account and then create a pull request > (which is the

Re: [webkit-dev] WebKit Transition to Git

2020-10-05 Thread Robert Ma
On Mon, Oct 5, 2020 at 6:22 AM Frédéric Wang wrote: > One thing to take into account is that WebKit's repository is big and > public GitHub/GitLab prevent creating large repository by default. This > means it might not be possible for contributors to actually fork > WebKit's repository on their

Re: [webkit-dev] WebKit Transition to Git

2020-10-05 Thread Frédéric Wang
On 02/10/2020 18:43, Jonathan Bedard wrote: Hi all, This is great to hear! Several people have already made comments about things that I wanted to say, but I'd just to add my personal point of view... I've used both Mozilla's Phabricator and Chromium's Gerrit for patches/review, and I find both