Re: [webkit-dev] Update commit log template to add placeholder for explanation of why a patch fixes a bug

On Nov 17, 2022, at 3:17 PM, Michael Catanzaro wrote: > On Thu, Nov 17 2022 at 02:48:04 PM -0800, Ryosuke Niwa > wrote: >> But every change in WebKit comes with a Bugzilla bug. > > Certainly most do, but some counterexamples: > > * Unreviewed build fixes sometimes do not reference a bug > *

[webkit-dev] Update commit log template to make GNU changelog optional

Hi, I'd like to remove the GNU changelog from the bottom of the commit messages by default. With "by default" I mean people who prefer to use the GNU changelog for formatting their commit messages would have to change git-webkit configuration to keep using it, and it would go away for

Re: [webkit-dev] Update commit log template to add placeholder for explanation of why a patch fixes a bug

On Thu, Nov 17 2022 at 02:48:04 PM -0800, Ryosuke Niwa wrote: But every change in WebKit comes with a Bugzilla bug. Certainly most do, but some counterexamples: * Unreviewed build fixes sometimes do not reference a bug * When fixing a new compiler warning or build failure, I often reference

Re: [webkit-dev] Update commit log template to add placeholder for explanation of why a patch fixes a bug

> On Nov 17, 2022, at 2:46 PM, Michael Catanzaro wrote: > > On Thu, Nov 17 2022 at 02:41:35 PM -0800, Ryosuke Niwa > wrote: >> We don´t want a description of what PR is; that´s obvious from diff. We want >> a description of why that PR fixes the bug. > > Problem is, that is not very useful

Re: [webkit-dev] Update commit log template to add placeholder for explanation of why a patch fixes a bug

On Thu, Nov 17 2022 at 02:41:35 PM -0800, Ryosuke Niwa wrote: We don’t want a description of what PR is; that’s obvious from diff. We want a description of why that PR fixes the bug. Problem is, that is not very useful when the change is anything other than a change that fixes a bug. :)

Re: [webkit-dev] Update commit log template to add placeholder for explanation of why a patch fixes a bug

> On Nov 17, 2022, at 2:37 PM, Michael Catanzaro via webkit-dev > wrote: > > On Thu, Nov 17 2022 at 12:23:54 PM -0800, David Kilzer via webkit-dev > wrote: >> Any feedback on this change? > > We could alternatively say "Explanation of this change (OOPS!)" or > "Explanation of this commit

Re: [webkit-dev] Update commit log template to add placeholder for explanation of why a patch fixes a bug

On Thu, Nov 17 2022 at 12:23:54 PM -0800, David Kilzer via webkit-dev wrote: Any feedback on this change? We could alternatively say "Explanation of this change (OOPS!)" or "Explanation of this commit (OOPS!)" to be a little more general. Michael

Re: [webkit-dev] Update commit log template to add placeholder for explanation of why a patch fixes a bug

> On Nov 17, 2022, at 12:43 PM, Simon Fraser via webkit-dev > wrote: > >> >> On Nov 17, 2022, at 12:23 PM, David Kilzer via webkit-dev >> wrote: >> >> Hi, >> >> The following PR adds placeholder text in the commit log template to remind >> authors to explain why a change fixes a bug: >>

Re: [webkit-dev] Update commit log template to add placeholder for explanation of why a patch fixes a bug

> On Nov 17, 2022, at 12:23 PM, David Kilzer via webkit-dev > wrote: > > Hi, > > The following PR adds placeholder text in the commit log template to remind > authors to explain why a change fixes a bug: > > Bug 248012: Update commit message template to request a brief explanation of > why

Re: [webkit-dev] Update commit log template to add placeholder for explanation of why a patch fixes a bug

> On Nov 17, 2022, at 12:23 PM, David Kilzer via webkit-dev > wrote: > > The following PR adds placeholder text in the commit log template to remind > authors to explain why a change fixes a bug: > > Bug 248012: Update commit message template to request a brief explanation of > why a PR

[webkit-dev] Update commit log template to add placeholder for explanation of why a patch fixes a bug

Hi, The following PR adds placeholder text in the commit log template to remind authors to explain why a change fixes a bug: Bug 248012: Update commit message template to request a brief explanation of why a PR fixes the bug