Re: [webkit-dev] LocalStorage spec and structured cloning

2011-06-03 Thread Jeremy Orlow
You can't store much data in cookies and thus you're only shooting yourself in the foot with a bb gun. 5mb means you're shooting yourself in the foot with a real gun. And if you're allowing over 5mb, it's a bazooka. Anyway, I've written extensively about this many times on many different lists.

Re: [webkit-dev] LocalStorage spec and structured cloning

2011-06-03 Thread Jeremy Orlow
On Fri, Jun 3, 2011 at 1:40 AM, Jeremy Orlow jor...@chromium.org wrote: You can't store much data in cookies and thus you're only shooting yourself in the foot with a bb gun. 5mb means you're shooting yourself in the foot with a real gun. And if you're allowing over 5mb, it's a bazooka

Re: [webkit-dev] bugid in ChangeLog

2011-03-28 Thread Jeremy Orlow
Can you please explain why? Its very little overhead and is useful for tracking regressions and such. J On Mar 28, 2011 9:52 AM, Darin Adler da...@apple.com wrote: On Mar 27, 2011, at 1:31 AM, Jeremy Orlow wrote: I'd even go a bit further and say that if something is worth a review (even

Re: [webkit-dev] bugid in ChangeLog

2011-03-28 Thread Jeremy Orlow
/changeset/81864 J On Mon, Mar 28, 2011 at 9:58 AM, Jeremy Orlow jor...@chromium.org wrote: Can you please explain why? Its very little overhead and is useful for tracking regressions and such. J On Mar 28, 2011 9:52 AM, Darin Adler da...@apple.com wrote: On Mar 27, 2011, at 1:31 AM

Re: [webkit-dev] bugid in ChangeLog

2011-03-28 Thread Jeremy Orlow
On Mon, Mar 28, 2011 at 11:48 AM, Maciej Stachowiak m...@apple.com wrote: I think it's better to have no exceptions than a very narrow exception. This seems to be a reason for saying we should always have a bug for anything that's reviewed... J ___

Re: [webkit-dev] bugid in ChangeLog

2011-03-28 Thread Jeremy Orlow
On Mon, Mar 28, 2011 at 11:51 AM, Jeremy Orlow jor...@chromium.org wrote: On Mon, Mar 28, 2011 at 11:48 AM, Maciej Stachowiak m...@apple.com wrote: I think it's better to have no exceptions than a very narrow exception. This seems to be a reason for saying we should always have a bug

Re: [webkit-dev] Towards a unified build system

2011-03-01 Thread Jeremy Orlow
On Tue, Mar 1, 2011 at 11:08 AM, Nikolas Zimmermann zimmerm...@physik.rwth-aachen.de wrote: Am 01.03.2011 um 18:33 schrieb Maciej Stachowiak: On Mar 1, 2011, at 5:18 AM, Adam Roben wrote: Reducing the number of build systems is a face-meltingly worthy goal. I have one small question:

Re: [webkit-dev] Towards a unified build system

2011-03-01 Thread Jeremy Orlow
On Tue, Mar 1, 2011 at 1:59 PM, David Levin le...@google.com wrote: On Tue, Mar 1, 2011 at 1:13 PM, Jeremy Orlow jor...@chromium.org wrote: We could quickly find ourselves in the position of generating build files for many different ports every time we submit patches, which could add

Re: [webkit-dev] Getting CC-ed on webkit.org/new-inspector-bug

2011-02-10 Thread Jeremy Orlow
It seems like it'd be nice to be able to watch bugs that are assigned to someone too though. On Thu, Feb 10, 2011 at 11:18 AM, Alexey Proskuryakov a...@webkit.org wrote: 10.02.2011, в 10:58, Darin Fisher написал(а): What Mozilla does is they set the QA Contact field to an email address of

Re: [webkit-dev] Using Visual Studio 2010 for Apple's Windows WebKit port

2011-01-31 Thread Jeremy Orlow
How hard will the transition be? If it's going to take a lot of time and cause a lot of churn anyway, would this be a good time to try and make that port use GYP or CMake? (I assume the answer is probably no, but figured it was worth asking anyway. :-) J On Mon, Jan 31, 2011 at 12:46 PM, Adam

Re: [webkit-dev] Same Origin Restriction on WOFF fonts across WebKit

2011-01-28 Thread Jeremy Orlow
On Fri, Jan 28, 2011 at 3:11 PM, Maciej Stachowiak m...@apple.com wrote: On Jan 28, 2011, at 3:06 PM, Tab Atkins Jr. wrote: The WOFF font specification requires that browsers apply Same Origin Restrictions (SOR) to WOFF fonts. So far, Firefox and IE9 follow this requirement, while we

Re: [webkit-dev] Blog post(s) about layout tests

2011-01-27 Thread Jeremy Orlow
On Thu, Jan 27, 2011 at 9:32 AM, Ryan Leavengood leaveng...@gmail.comwrote: On Tue, Jan 25, 2011 at 9:24 PM, Mihai Parparita mih...@chromium.org wrote: The post is link-heavy (generally into Trac, and Bugzilla), I'm hoping that would also encourage exploration of the code/site by people

Re: [webkit-dev] Using Git for WebKit development

2011-01-18 Thread Jeremy Orlow
The info is on https://trac.webkit.org/wiki/UsingGitWithWebKit as well. On Tue, Jan 18, 2011 at 8:42 AM, Philippe Normand pnorm...@igalia.comwrote: On Tue, 2011-01-18 at 11:26 +0300, Konstantin Tokarev wrote: Hi all, When I'm trying to cherry-pick or rebase something in my WebKit git

Re: [webkit-dev] Getting at Settings object from WorkerContext

2011-01-06 Thread Jeremy Orlow
The RuntimeEnabledFeatures class [1] seems like what you're looking for. J [1] http://codesearch.google.com/codesearch/p?hl=en#OAMlx_jo-ck/src/third_party/WebKit/WebCore/bindings/generic/RuntimeEnabledFeatures.hq=RuntimeFeatureexact_package=chromiumd=6 On Thu, Jan 6, 2011 at 6:05 PM, Joe Mason

Re: [webkit-dev] Getting at Settings object from WorkerContext

2011-01-06 Thread Jeremy Orlow
. Is this a V8-only thing? Joe *From:* webkit-dev-boun...@lists.webkit.org [mailto: webkit-dev-boun...@lists.webkit.org] *On Behalf Of *Joe Mason *Sent:* Thursday, January 06, 2011 1:52 PM *To:* Jeremy Orlow *Cc:* webkit-dev Development *Subject:* Re: [webkit-dev] Getting at Settings

Re: [webkit-dev] Getting at Settings object from WorkerContext

2011-01-06 Thread Jeremy Orlow
:38 PM, Jeremy Orlow jor...@chromium.org wrote: Hmm. It might still be v8-only, though I'm surprised since the class was moved from the v8 directory to generic. If that's the case, then I suppose it'll need to be ported to JSC. J On Thu, Jan 6, 2011 at 7:24 PM, Joe Mason jma...@rim.com

Re: [webkit-dev] RuntimeEnabledFeatures for JSC (was RE: Getting at Settings object from WorkerContext)

2011-01-06 Thread Jeremy Orlow
On Thu, Jan 6, 2011 at 8:57 PM, Adam Barth aba...@webkit.org wrote: On Thu, Jan 6, 2011 at 12:47 PM, Darin Adler da...@apple.com wrote: On Jan 6, 2011, at 12:41 PM, Joe Mason wrote: I took a look at CodeGeneratorJS.pm to see how hard it would be to port this over. I have no idea where to

Re: [webkit-dev] Tip: Use 64-bit git binaries on Mac OS X

2010-12-09 Thread Jeremy Orlow
For what it's worth, on my 12GB of ram mac pro: $ sudo sysctl -w kern.maxvnodes=384000 kern.maxvnodes: 197632 - 384000 Took times from 2.11-2.06 down to 2.05-2.02. I.e. it made a small difference, but not much. The 64 bit patch definitely seemed to help, but I didn't think to time before and

Re: [webkit-dev] [chromium] using WEBKIT_API properly

2010-12-03 Thread Jeremy Orlow
You forgot to mention virtual functions, which is another case where you do _not_ use WEBKIT_API. J On Thu, Dec 2, 2010 at 9:27 PM, Darin Fisher da...@chromium.org wrote: If you do not work on the Chromium port of WebKit, you can stop reading now. I've noticed that there is some confusion

Re: [webkit-dev] Why are the mock implementations in WebCore/platform?

2010-11-26 Thread Jeremy Orlow
Note that it's still a bit of an open question as to where mocks should live in general. IIRC, the top candidates are like device orientation and speech do now, somehow in some central place but not compiled into production libraries, or in DRT (which means more copied code, but the platform

Re: [webkit-dev] Enhancements

2010-11-24 Thread Jeremy Orlow
On Tue, Nov 23, 2010 at 10:51 PM, Jack Allegrezza jackallegre...@mac.comwrote: Hello, I am proposing that WebKit have an Enhancements ability - Here is what the reason is - with abilities of WebKit to draw and handle THML,SVG, Canvas and Video, along with access to resources via AJAX

Re: [webkit-dev] Tiger?

2010-10-21 Thread Jeremy Orlow
Ping? On Mon, Oct 11, 2010 at 9:26 AM, Adam Barth aba...@webkit.org wrote: I don't see a Tiger buildbot anymore. Does that mean I'm allowed to break the Tiger build? If so, can we rip out all the Tiger-specific code? Adam ___ webkit-dev

Re: [webkit-dev] Pixel test experiment

2010-10-12 Thread Jeremy Orlow
the tools only work for Chromium. - James On Fri, Oct 8, 2010 at 11:18 PM, Nikolas Zimmermann zimmerm...@physik.rwth-aachen.de wrote: Am 08.10.2010 um 20:14 schrieb Jeremy Orlow: I'm not an expert on Pixel tests, but my understanding is that in Chromium (where we've always run with tolerance

Re: [webkit-dev] Pixel test experiment

2010-10-08 Thread Jeremy Orlow
I'm not an expert on Pixel tests, but my understanding is that in Chromium (where we've always run with tolerance 0) we've seen real regressions that would have slipped by with something like tolerance 0.1. When you have 0 tolerance, it is more maintenance work, but if we can avoid regressions,

Re: [webkit-dev] Pixel test experiment

2010-10-07 Thread Jeremy Orlow
This does seem like a great idea. The more pixel tests we can run on the bots, the better! J On Thu, Oct 7, 2010 at 11:06 AM, Dirk Schulze k...@webkit.org wrote: I strongly support pixel tests for SVG on the bots! Niko and me are hard working to get SVG pxiel perfect at all time. We run

[webkit-dev] Upgrading VS (WAS: Any objections to switching to Xcode 3.2.4 or newer?)

2010-10-06 Thread Jeremy Orlow
Although this is a noble goal, wouldn't it require either 1) Us maintaining yet another build system or 2) Any Windows based WebKit hackers needing to upgrade their Visual Studio...which would require $$? [1] Either way, what's our migration plan (since we can't use VS 2005 forever)? J [1] Yes

Re: [webkit-dev] a ping landed

2010-10-04 Thread Jeremy Orlow
Given that a ping really doesn't open up any new privacy holes (just makes it easier for sites to get the data they're going to gather anyway without slowing down the experience for the user), it seems like we might as well enable it by default. If a port doesn't want it, they can always disable

Re: [webkit-dev] Disable sheriffbot bug posts?

2010-09-24 Thread Jeremy Orlow
They've also helped me on occasion. I get enough bug spam already that even in the worst case, I don't find the notices all that obtrusive. More useful messages would be nice though. J On Thu, Sep 23, 2010 at 10:28 PM, Geoffrey Garen gga...@apple.com wrote: Does anyone find the sheriffbot

Re: [webkit-dev] Bug system: Platform and OS fields don't quite align

2010-09-14 Thread Jeremy Orlow
On Tue, Sep 14, 2010 at 6:32 PM, David Levin le...@chromium.org wrote: On Tue, Sep 14, 2010 at 10:28 AM, Adam Barth aba...@webkit.org wrote: We're not very good at using these fields in Bugzilla. In this situation, folks will usually prefix the summary of the bug with [Chromium]. This is

[webkit-dev] GTK Skiplist

2010-09-03 Thread Jeremy Orlow
Recently in a code review for IndexedDB, I was told that I should be adding every test individually to GTK's skip list. The reason cited was this comment at the top # Also, no grouping should occur. Every test for itself. For features like IndexedDB which are not turned on by a port, is it still

Re: [webkit-dev] GTK Skiplist

2010-09-03 Thread Jeremy Orlow
I promise to only put IndexedDB tests in the indexeddb directory. :-) On Fri, Sep 3, 2010 at 5:52 PM, Darin Adler da...@apple.com wrote: On Sep 3, 2010, at 5:50 AM, Jeremy Orlow wrote: Recently in a code review for IndexedDB, I was told that I should be adding every test individually

Re: [webkit-dev] GTK Skiplist

2010-09-03 Thread Jeremy Orlow
of a code, I would have done it differently.) Btw, I find it humorous that, by your own logic, you probably should have sent your rebuke in a private email. :-) J dave On Fri, Sep 3, 2010 at 9:54 AM, Jeremy Orlow jor...@chromium.org wrote: I promise to only put IndexedDB tests in the indexeddb

Re: [webkit-dev] Arena is crufty?

2010-09-02 Thread Jeremy Orlow
Isn't ref counting supposed to be _really_ optimized for exactly this use? It seems like a good match--unless you have major issues with cycles...which might be the issue? J On Thu, Sep 2, 2010 at 3:20 AM, Kenneth Russell k...@google.com wrote: I would be happy to not add another Arena

Re: [webkit-dev] How to specify files to be copied to WebKitBuild/Debug/WebCore.framework/PrivateHeaders/ ?

2010-09-02 Thread Jeremy Orlow
Is this documented somewhere? It seems like it comes up every now and then and can be quite frustrating. On the other hand, I really don't know where makes sense to document it. :-) Note that this is also what you do when needing to export something form wtf. J On Thu, Sep 2, 2010 at 12:37

Re: [webkit-dev] Misplaced files

2010-08-31 Thread Jeremy Orlow
On Mon, Aug 30, 2010 at 5:17 PM, Darin Fisher da...@chromium.org wrote: On Mon, Aug 30, 2010 at 9:11 AM, Maciej Stachowiak m...@apple.com wrote: On Aug 30, 2010, at 8:36 AM, Darin Fisher wrote: On Mon, Aug 30, 2010 at 12:18 AM, Adam Barth aba...@webkit.org wrote: On Fri, Aug 27, 2010 at

Re: [webkit-dev] Misplaced files

2010-08-31 Thread Jeremy Orlow
, Aug 31, 2010 at 3:02 AM, Jeremy Orlow jor...@chromium.org wrote: On Mon, Aug 30, 2010 at 5:17 PM, Darin Fisher da...@chromium.org wrote: On Mon, Aug 30, 2010 at 9:11 AM, Maciej Stachowiak m...@apple.comwrote: On Aug 30, 2010, at 8:36 AM, Darin Fisher wrote: On Mon, Aug 30, 2010 at 12:18 AM

Re: [webkit-dev] Misplaced files

2010-08-31 Thread Jeremy Orlow
this in the past. Also, is there a reason why they're necessary? On Tue, Aug 31, 2010 at 9:00 AM, Jeremy Orlow jor...@chromium.org wrote: You're talking about the module part of the IDL? Is that even used by anything or specified anywhere? As far as I can tell, the answer is no. On Tue

Re: [webkit-dev] Place For new Core Module

2010-08-25 Thread Jeremy Orlow
On Tue, Aug 24, 2010 at 11:50 PM, Chinmaya Sn chinm...@gmail.com wrote: Thanks All. I think I am getting the general idea of what can get into to WebKit and how things fit. Right now both the standard and implementation are WIP, spec is intended to be a Web standard. At this point, neither

Re: [webkit-dev] Not enough space message when linking webkit (lots of free disk space)

2010-08-23 Thread Jeremy Orlow
The Kernel usually reserves 1/4 (but up to 3/4 on some OSes) of the address space for itself + you can get fragmentation. So the linker only can use part of the 4gb of ram in your machine. So switching to a 64 bit linker would probably fix the problem for now. Another option is to disable some

Re: [webkit-dev] Getting rid of WebCore.xcodeproj developmentRegion diff

2010-08-17 Thread Jeremy Orlow
In that case, can we please standardize on the Xcode 3 behavior and ask those using the beta to keep it out manually? J On Tue, Aug 17, 2010 at 7:41 PM, Jeff Johnson opendar...@lapcatsoftware.com wrote: Actually, this is caused by Xcode 4 (still in beta). See rdar://problem/8295614 Xcode 4

Re: [webkit-dev] Tests that separate JS and HTML

2010-08-13 Thread Jeremy Orlow
On Fri, Aug 13, 2010 at 11:17 AM, Alexey Proskuryakov a...@webkit.org wrote: On multiple occasions, I've been noticing that separating JavaScript for tests into its own file has been causing me pain. There are several disadvantages that I know of: 1. One doesn't see test content when a tool

[webkit-dev] Build system complexity

2010-08-12 Thread Jeremy Orlow
Are there currently any plans for simplifying the situation regarding build systems? I haven't seen any threads for a while, which I assume means no. Is there any low hanging fruit out there? Since many of the build systems are little more than lists of files, it really seems like we should be

Re: [webkit-dev] Build system complexity

2010-08-12 Thread Jeremy Orlow
On Thu, Aug 12, 2010 at 7:18 AM, David Kilzer ddkil...@webkit.org wrote: On Aug 12, 2010, at 3:54 AM, Dumitru Daniliuc d...@chromium.org wrote: i completely agree with jeremy. is it possible to at least drop the cryptic hashcodes/timestamps? without them, the .xcodeproj files should at

Re: [webkit-dev] Build system complexity

2010-08-12 Thread Jeremy Orlow
on the mac port) is out of hand--and has been for some time. And I'm hoping we can come to some sort of conclusion that'll start the project moving in the right direction--even if it's slowly. That's it. I promise! J On Thu, Aug 12, 2010 at 3:37 PM, Jeremy Orlow jor...@chromium.org wrote: On Thu, Aug

Re: [webkit-dev] HTML5 tree builder enabled

2010-08-05 Thread Jeremy Orlow
Impressive! Thanks Eric+Adam for all the work on this! You guys are quite a team. J On Thu, Aug 5, 2010 at 9:10 AM, Adam Barth aba...@webkit.org wrote: The HTML5 tree builder is enabled as of http://trac.webkit.org/changeset/64712. Check out our awesome SVG-in-HTML demo (in a post r64712

Re: [webkit-dev] Some new coding style rules

2010-08-04 Thread Jeremy Orlow
On Wed, Aug 4, 2010 at 9:29 AM, Nikolas Zimmermann zimmerm...@physik.rwth-aachen.de wrote: Good morning WebKit crowd, I'd like to discuss some style issues, that I'm frequently unsure about: 1. namespace closing brace It was discussed in

Re: [webkit-dev] Rendering a PDF on an HTML5 Canvas using WebKit/AIR

2010-08-03 Thread Jeremy Orlow
This is not the right mailing list for such questions. Please see http://webkit.org/contact.html On Tue, Aug 3, 2010 at 4:26 AM, Andrew Sealy-Bell andyamsterdam2...@gmail.com wrote: Hi, I'd like to know if anybody has experience with rendering a PDF on an HTML5 canvas? I'd like to to this

Re: [webkit-dev] Sharing WebKit mocks across platforms

2010-07-30 Thread Jeremy Orlow
Why wasn't it done that way originally? That sounds (to my uneducated ear) much better than what's done today. J On Thu, Jul 29, 2010 at 11:19 PM, Adam Barth aba...@webkit.org wrote: WebCore::LayoutTestController would be exposed to JavaScript running in LayoutTests directly (like the DOM),

Re: [webkit-dev] Remove me from your mailing list..

2010-07-12 Thread Jeremy Orlow
Seriously? It's the first result: http://www.lmgtfy.com/?q=webkit-dev Clearly you overly value your own time if you couldn't even do a quick search on how to properly unsubscribe and instead spammed an entire mailing list. J On Mon, Jul 12, 2010 at 11:23 AM, Johnson, Christopher

Re: [webkit-dev] Frustrated at inconsiderate behavior

2010-07-08 Thread Jeremy Orlow
On Fri, Jul 9, 2010 at 2:14 AM, Xan Lopez x...@gnome.org wrote: On Thu, Jul 8, 2010 at 8:09 PM, Adam Barth aba...@webkit.org wrote: Originally, we had the commit-queue to land only if all the core builders were green. One recent change we made to make the commit-queue more agressive is to

Re: [webkit-dev] Frustrated at inconsiderate behavior

2010-07-07 Thread Jeremy Orlow
I agree with Maciej's response, but at the same time I can understand why Adam was so frustrated. He (and others) have pointed out stuff like this on and off list over and over again with little apparent change... But that's not what I'm most worried about; why this was broken in the tree for 12

Re: [webkit-dev] Frustrated at inconsiderate behavior

2010-07-07 Thread Jeremy Orlow
On Thu, Jul 8, 2010 at 2:03 AM, Alexey Proskuryakov a...@webkit.org wrote: 07.07.2010, в 9:49, Jeremy Orlow написал(а): Why did not one of those people roll the patch out when it was clear that there were failures and Alexey wasn't in the process of fixing them? Just to avoid any

[webkit-dev] Frustrated at inconsiderate behavior

2010-07-07 Thread Jeremy Orlow
On Thu, Jul 8, 2010 at 10:19 AM, Oliver Hunt oli...@apple.com wrote: On Jul 7, 2010, at 7:16 PM, Tony Gentilcore wrote: On Wed, Jul 7, 2010 at 6:50 PM, Mo, Zhenyao zhen...@gmail.com wrote: Maybe I should complain this in a different threads, but recently the commit bot waiting time is

Re: [webkit-dev] Does any port implements Navigator.registerProtocolHandler and Navigator.registerContentHandler?

2010-07-07 Thread Jeremy Orlow
That would be the standard thing to do. The sooner someone gets started on the feature, the easier it'll be to revert the patch that removes the code. :-) J On Thu, Jul 8, 2010 at 10:55 AM, David Levin le...@chromium.org wrote: On Wed, Jul 7, 2010 at 5:24 PM, Peter Kasting

Re: [webkit-dev] strategy for evaluating performance issues related to memory.

2010-06-21 Thread Jeremy Orlow
On Mon, Jun 21, 2010 at 2:21 PM, Mike Marchywka marchy...@hotmail.comwrote: So where does this stand right now? I hope to actually contribute at some point. but right now I'm just trying to determine approaches to even finding the problems. ( and yes my disk light still comes on for

Re: [webkit-dev] strategy for evaluating performance issues related to memory.

2010-06-21 Thread Jeremy Orlow
On Mon, Jun 21, 2010 at 7:08 PM, Mike Marchywka marchy...@hotmail.comwrote: Unless you're actively working on this problem within WebKit, these emails seem out of scope for webkit-dev. The topic addresses this doesn't it? I would think that outlining a development strategy would be

Re: [webkit-dev] Style question: static, protected, or public members

2010-06-13 Thread Jeremy Orlow
On Sun, Jun 13, 2010 at 12:46 AM, Maciej Stachowiak m...@apple.com wrote: On Jun 4, 2010, at 3:54 PM, Joe Mason wrote: I'm strongly in favour of g_. It seems weird and ugly to me to have prefixes for some non-local scopes but not all. And it's very helpful to be able to look at a

Re: [webkit-dev] Pyjamas-Desktop patch to webkit ??

2010-06-09 Thread Jeremy Orlow
The patch needs a champion who's willing to take the time to get it into landable shape. This mainly means splitting it up into small bits for review, cleaning up the code, and fixing problems brought up in review. It will probably require a lot of work. J On Sat, Jun 5, 2010 at 8:34 PM,

Re: [webkit-dev] sick of forgetting bugzilla email addresses?

2010-06-07 Thread Jeremy Orlow
This will save me so many iterations of trying a name into gmail and then copying it over to bugzilla. :-) Thanks Ojan! On Mon, Jun 7, 2010 at 9:28 PM, Adam Barth aba...@webkit.org wrote: Wow, that's pretty awesome. Thanks Ojan. Adam On Mon, Jun 7, 2010 at 1:25 PM, Ojan Vafai

Re: [webkit-dev] How to handle a new protocol for Blob.url support?

2010-06-03 Thread Jeremy Orlow
On Thu, Jun 3, 2010 at 2:08 AM, Darin Adler da...@apple.com wrote: On Jun 1, 2010, at 5:14 PM, Jian Li wrote: I am working on Blob.url support as defined in the latest version of File API (http://dev.w3.org/2006/webapi/FileAPI/). The Blob.url will return a URL that can be used to refer to

Re: [webkit-dev] Need more diagnostic information for ApplicationCache events

2010-05-19 Thread Jeremy Orlow
If you want to change the web platform (which adding information to events is), sending an email to WhatWG [1] is probably the right first step. The other option is to think about how to extend the existing developer tools to aid in debugging. Personally, that makes more sense to me, and I

Re: [webkit-dev] What is the webkit-patch version of svn-unapply?

2010-05-19 Thread Jeremy Orlow
On Wed, May 19, 2010 at 7:15 PM, Adam Barth aba...@webkit.org wrote: On Wed, May 19, 2010 at 11:06 AM, Darin Adler da...@apple.com wrote: On May 19, 2010, at 10:56 AM, Adam Barth wrote: On Wed, May 19, 2010 at 10:41 AM, Darin Adler da...@apple.com wrote: Lets say I just did webkit-patch

Re: [webkit-dev] Local Storage (SQL Database) not working in my app built with XCode

2010-05-14 Thread Jeremy Orlow
See the enable functions in WebCore/page/Settings.h. On Fri, May 14, 2010 at 2:48 PM, Adam Thorsen adam.thor...@gmail.comwrote: I've got a minimal browser app that is linked against the WebKit framework that I'm building with XCode. I'm developing a website that uses some HTML5 local storage

Re: [webkit-dev] Ancient patches in pending-review

2010-05-13 Thread Jeremy Orlow
On Thu, May 13, 2010 at 5:41 PM, David Levin le...@google.com wrote: On Thu, May 13, 2010 at 9:12 AM, Adam Barth aba...@webkit.org wrote: One of the least fun things in the project is to pour a bunch of effort into writing a patch only to see it sit forever waiting for review. In the

Re: [webkit-dev] Yet another bug-less change hosed the tree.

2010-05-12 Thread Jeremy Orlow
On Tue, May 11, 2010 at 10:11 PM, Geoffrey Garen gga...@apple.com wrote: We require a ChangeLog for every patch. Isn't that a TPS report? No. A ChangeLog is much less time-consuming to manage. For me, letting webkit-patch make the bug for me and post updates to the bug is maybe 10-15

Re: [webkit-dev] Yet another bug-less change hosed the tree.

2010-05-11 Thread Jeremy Orlow
On Tue, May 11, 2010 at 5:51 PM, Alexey Proskuryakov a...@webkit.org wrote: 11.05.2010, в 0:56, Maciej Stachowiak написал(а): I do think making it capable of handling subdirectories would be an improvement for SVN users. Also, I suspect it doesn't work as well as it could for people who

Re: [webkit-dev] Testing changes to CodeGenerator*.pm

2010-04-29 Thread Jeremy Orlow
On Thu, Apr 29, 2010 at 9:05 PM, Adam Barth aba...@webkit.org wrote: On Thu, Apr 29, 2010 at 12:43 PM, Maciej Stachowiak m...@apple.com wrote: It seems to me a better model would be to regenerate the bindings test file automatically as part of the build. Then the changes can still be

Re: [webkit-dev] MD5 in WebCore

2010-04-20 Thread Jeremy Orlow
Agreed. Can you give us a pointer to the email thread this decision was made on? On Tue, Apr 20, 2010 at 12:12 PM, Alex Russell slightly...@google.comwrote: Hate to ask a dumb question, but why MD5? Isn't it on its last legs as a secure hash? New protocols should be avoiding it. On Tue, Apr

Re: [webkit-dev] Announcing WebKit2

2010-04-09 Thread Jeremy Orlow
On Fri, Apr 9, 2010 at 2:33 AM, Adam Treat tr...@kde.org wrote: On Thursday 08 April 2010 09:24:32 pm Darin Adler wrote: On Apr 8, 2010, at 6:23 PM, Adam Treat wrote: Can someone please point to the bug report and the forum where this development was discussed by the greater WebKit

Re: [webkit-dev] [webkit-changes] [57262] trunk/JavaScriptCore

2010-04-08 Thread Jeremy Orlow
On Thu, Apr 8, 2010 at 5:59 PM, Alexey Proskuryakov a...@webkit.org wrote: On 08.04.2010, at 1:16, o...@webkit.org wrote: + // [Qt]r57240 broke Qt build (might be a gcc bug) + // FIXME! See: https://bugs.webkit.org/show_bug.cgi?id=37253 FIXME! is different from FIXME: in that Xcode

Re: [webkit-dev] Windows mobile build

2010-04-06 Thread Jeremy Orlow
On Sun, Apr 4, 2010 at 10:45 AM, Patrick Roland Gansterer par...@paroga.com wrote: Hi, i had the same problem some months ago (https://lists.webkit.org/pipermail/webkit-dev/2010-January/011160.html), but didn't get any final reply. I had a look onto other (meta) buildsystems, but most of

Re: [webkit-dev] WebKit Icon license?

2010-03-24 Thread Jeremy Orlow
On Wed, Mar 24, 2010 at 12:28 AM, Maciej Stachowiak m...@apple.com wrote: On Mar 23, 2010, at 3:25 AM, Jeremy Orlow wrote: It seems as though we should at very least change the main icon on webkit.org to match what is apparently the official webkit logo. The icons for the Mac and Windows

Re: [webkit-dev] WebKit Icon license?

2010-03-23 Thread Jeremy Orlow
On Mon, Mar 22, 2010 at 5:43 AM, Kenneth Christiansen kenneth.christian...@openbossa.org wrote: I have asked our designers to look into it :-) Kenneth On Mon, Mar 22, 2010 at 8:42 AM, Jeremy Orlow jor...@chromium.org wrote: On Fri, Mar 19, 2010 at 4:00 PM, Darin

Re: [webkit-dev] WebKit Icon license?

2010-03-23 Thread Jeremy Orlow
And does anyone know where the original artwork is and/or came from? On Tue, Mar 23, 2010 at 10:25 AM, Jeremy Orlow jor...@chromium.org wrote: It seems as though we should at very least change the main icon on webkit.org to match what is apparently the official webkit logo. The icons

Re: [webkit-dev] WebKit Icon license?

2010-03-22 Thread Jeremy Orlow
On Fri, Mar 19, 2010 at 4:00 PM, Darin Adler da...@apple.com wrote: On Mar 19, 2010, at 8:40 AM, Dimitri Glazkov wrote: Would you happen to know how WebKit icon is licensed? The icon currently on webkit.org has the icon for Apple’s Safari web browser in it. Because of that, Apple has

[webkit-dev] Unofficial reviews (WAS: Why I'm reviewing patches outside my area (and why you should too))

2010-03-10 Thread Jeremy Orlow
On Wed, Mar 10, 2010 at 7:45 AM, Zoltan Herczeg zherc...@inf.u-szeged.huwrote: Hi, It's also a big help when peers (which aren't necessarily WebKit reviewers) look over it and give review-style feedback as well. Especially when said peers know more about that code than any of the

Re: [webkit-dev] Unofficial reviews (WAS: Why I'm reviewing patches outside my area (and why you should too))

2010-03-10 Thread Jeremy Orlow
On Wed, Mar 10, 2010 at 1:16 PM, Adam Treat tr...@kde.org wrote: On Wednesday 10 March 2010 07:06:16 am Jeremy Orlow wrote: I can give you a success story though: michaeln is probably the most qualified reviewer of WebSQLDatabase code these days. He looks at most patches that go by, and I

Re: [webkit-dev] Increasing the number of cross-platform/port expected results

2010-03-09 Thread Jeremy Orlow
On Tue, Mar 9, 2010 at 9:19 AM, Robert O'Callahan rob...@ocallahan.orgwrote: Mozilla has been using this technique for years. Perhaps we can pick their brains for some good tricks. Or, dare I say it, share some tests. Hi, hope I'm not crashing the party, and sorry I'm late :-). Let me just

Re: [webkit-dev] Why I'm reviewing patches outside my area (and why you should too)

2010-03-09 Thread Jeremy Orlow
On Tue, Mar 9, 2010 at 9:39 PM, David Levin le...@chromium.org wrote: (3) Someone reviewed an earlier version of the patch but then didn't follow up. I think having a partial review by one person encourages other people to assume that person will finish the review. That cause the patch to

Re: [webkit-dev] Crashes during testing

2010-02-26 Thread Jeremy Orlow
On Fri, Feb 26, 2010 at 12:03 AM, Oliver Hunt oli...@apple.com wrote: But any regressions would have been blamed on eric. His name would show up in the SVN log, sure, but I don't think that'd fool your average WebKit developer for long. webkit-patch land does the correct thing, but i disable

Re: [webkit-dev] The tree is on fire: a tragedy of the commons

2010-02-26 Thread Jeremy Orlow
On Fri, Feb 26, 2010 at 10:36 AM, Adam Barth aba...@webkit.org wrote: Not to point fingers, but we've been having trouble keeping build.webkit.org green these past few weeks. As I write this message, every platform is broken, again. As the project scales, polluting the build with brokenness

Re: [webkit-dev] Crashes during testing

2010-02-26 Thread Jeremy Orlow
Personally, I've found those kind of changes are responsible for a disproportionate percentage of build errors and bugs. :-) On Fri, Feb 26, 2010 at 5:16 PM, Darin Adler da...@apple.com wrote: On Feb 26, 2010, at 1:42 AM, Jeremy Orlow wrote: Did you run the layout tests at all? Oliver

Re: [webkit-dev] The tree is on fire: a tragedy of the commons

2010-02-26 Thread Jeremy Orlow
On Fri, Feb 26, 2010 at 6:47 PM, Dimitri Glazkov dglaz...@chromium.orgwrote: On Fri, Feb 26, 2010 at 9:44 AM, Eric Seidel e...@webkit.org wrote: The bots take 15 minutes to cycle. The moment the build is broken, thats FIX_TIME + BOT_CYCLE_TIME until their green again. I think we should

Re: [webkit-dev] The tree is on fire: a tragedy of the commons

2010-02-26 Thread Jeremy Orlow
On Fri, Feb 26, 2010 at 7:06 PM, Maciej Stachowiak m...@apple.com wrote: On Feb 26, 2010, at 9:56 AM, Alexey Proskuryakov wrote: On 26.02.2010, at 9:29, Maciej Stachowiak wrote: I'd like it if we had an IRC bot that announced build breakage on #webkit. Perhaps better yet, on

Re: [webkit-dev] The tree is on fire: a tragedy of the commons

2010-02-26 Thread Jeremy Orlow
On Fri, Feb 26, 2010 at 8:53 PM, Maciej Stachowiak m...@apple.com wrote: On Feb 26, 2010, at 11:43 AM, Simon Fraser wrote: Mozilla has (or at least had when I worked there) two additional tree rules that helped keep the tree green: 1. A sheriff was appointed at all times, and had the

Re: [webkit-dev] The tree is on fire: a tragedy of the commons

2010-02-26 Thread Jeremy Orlow
On Fri, Feb 26, 2010 at 9:00 PM, Jeremy Orlow jor...@chromium.org wrote: On Fri, Feb 26, 2010 at 8:53 PM, Maciej Stachowiak m...@apple.com wrote: On Feb 26, 2010, at 11:43 AM, Simon Fraser wrote: Mozilla has (or at least had when I worked there) two additional tree rules that helped keep

Re: [webkit-dev] Commit queue blocked because of failing tests

2010-02-25 Thread Jeremy Orlow
The only time I've ever had an issue with committing is when I forgot to add the file myself. The bot uses the same scripts that committers do. I think it'd be worth your time to become comfortable with them. If nothing else, so you can land fixes for when you break the build. It also frees up

Re: [webkit-dev] Commit queue blocked because of failing tests

2010-02-25 Thread Jeremy Orlow
The only time I've ever had an issue with committing is when I forgot to add the file myself. The bot uses the same scripts that committers do. I think it'd be worth your time to become comfortable with them. If nothing else, so you can land fixes for when you break the build. It also frees up

Re: [webkit-dev] [webkit-changes] [55234] trunk/JavaScriptCore

2010-02-25 Thread Jeremy Orlow
Done. On Thu, Feb 25, 2010 at 7:18 PM, Jeremy Orlow jor...@chromium.org wrote: I already started the process of doing a revert and submitting it with a better change log. J On Thu, Feb 25, 2010 at 7:11 PM, Alexey Proskuryakov a...@webkit.orgwrote: On 25.02.2010, at 10:00, David Levin

Re: [webkit-dev] Odd binding problems

2010-02-22 Thread Jeremy Orlow
On Mon, Feb 22, 2010 at 11:22 PM, Alexey Proskuryakov a...@webkit.org wrote: On 22.02.2010, at 15:16, Eric Uhrhane wrote: My bet is I've failed to add something critical to the bindings, some override for the idl-generated code that wasn't needed in the DOM bindings but is for the Worker

Re: [webkit-dev] Features supported in Android's Webkit borwser

2010-02-10 Thread Jeremy Orlow
This mailing list is not the proper place for such a question. This is for WebKit development related email only. On Wed, Feb 10, 2010 at 5:49 PM, Vishwesh Jirgale vishwesh.gro...@gmail.com wrote: Hello All, Is there a page/blog where all the features of Android's webkit browser are listed

Re: [webkit-dev] IndexedDB API

2010-01-22 Thread Jeremy Orlow
Hm. Now that I look closer, I think the only actual conflict is in the Database interface. It still seemed worth the webapps email though. On Thu, Jan 21, 2010 at 11:40 PM, Jeremy Orlow jor...@chromium.org wrote: On Thu, Jan 21, 2010 at 11:14 PM, Maciej Stachowiak m...@apple.com wrote

Re: [webkit-dev] IndexedDB API

2010-01-22 Thread Jeremy Orlow
(I had forgotten that many of the sql interfaces are prefixed by SQL. So IndexedDB's Transaction interface doesn't actually conflict because SQL's is named SQLTransaction.) On Fri, Jan 22, 2010 at 12:04 AM, Jeremy Orlow jor...@chromium.org wrote: Hm. Now that I look closer, I think the only

[webkit-dev] IndexedDB API

2010-01-21 Thread Jeremy Orlow
A couple of us at Google are starting to look at implementing the IndexedDB API [1] in WebKit. We thought a good first step would be to create the IDL files. The first thing I noticed is that it and the Web SQL Database API [2] have quite a few conflicts in terms of their interface names. I'm

Re: [webkit-dev] MathML Patch - Current Code

2010-01-14 Thread Jeremy Orlow
On Thu, Jan 14, 2010 at 8:23 PM, Alex Milowski a...@milowski.org wrote: I've create a new patch that contains all the current code that I have on MathML at: https://bugs.webkit.org/show_bug.cgi?id=33703 I don't expect anyone to review this patch (unless they want to do so). Since I

Re: [webkit-dev] Running pixel tests on build.webkit.org

2010-01-11 Thread Jeremy Orlow
On Fri, Jan 8, 2010 at 9:52 AM, Jeremy Orlow jor...@chromium.org wrote: Plan 3 seems like the best (and simplest) one until the infrastructure for the others (and/or a champion for fixing currently failing tests) is available. What would it take to go with plan 3? I guess someone needs

Re: [webkit-dev] Running pixel tests on build.webkit.org

2010-01-11 Thread Jeremy Orlow
the patch. :DG On Mon, Jan 11, 2010 at 9:06 AM, Jeremy Orlow jor...@chromium.org wrote: On Fri, Jan 8, 2010 at 9:52 AM, Jeremy Orlow jor...@chromium.org wrote: Plan 3 seems like the best (and simplest) one until the infrastructure for the others (and/or a champion for fixing currently

Re: [webkit-dev] Running pixel tests on build.webkit.org

2010-01-08 Thread Jeremy Orlow
Plan 3 seems like the best (and simplest) one until the infrastructure for the others (and/or a champion for fixing currently failing tests) is available. What would it take to go with plan 3? I guess someone needs to rebaseline everything that's currently failing, check them in, and then

[webkit-dev] Tech Talk on WebKit

2010-01-04 Thread Jeremy Orlow
(Oops, I meant to post this before the holidays but completely forgot. Better late than never I suppose?) A couple weeks ago, Eric Seidel gave a tech talk to a live studio audience of Googlers on the guts of webkit. Although there are a few bits that only apply to Chromium, the vast majority of

Re: [webkit-dev] Tech Talk on WebKit

2010-01-04 Thread Jeremy Orlow
in my talk, I'd love to know about them. -eric On Mon, Jan 4, 2010 at 6:25 PM, Jeremy Orlow jor...@chromium.org wrote: (Oops, I meant to post this before the holidays but completely forgot. Better late than never I suppose?) A couple weeks ago, Eric Seidel gave a tech talk to a live

  1   2   3   >