I'm trying to upload a patch and webkit-patch upload appears to do
everything except actually add the patch to the bug.
I first ran webkit-patch upload and it correctly created the bug (
https://bugs.webkit.org/show_bug.cgi?id=106955) for me, but didn't upload
the patch. When I run webkit-patch
Have you tried uploading the patch manually by running
svn-create-patch and using the attachments UI in bugs.webkit.org?
One possibility is that your patch is too big for bugs.webkit.org to
handle. You mention that it contains a number of binary files, which
might be the cause of the problem.
Hmm. I have a git checkout of webkit so svn-create-patch doesn't want to
work.
Yeah, the patch is probably too big. The particular patch could be broken
up into 3-4 separate smaller patches. Perhaps that will work.
On Thu, Jan 17, 2013 at 9:52 AM, Adam Barth aba...@webkit.org wrote:
Have
Sorry. webkit-patch upload does not have very good error handling:
https://bugs.webkit.org/show_bug.cgi?id=72863
On Thu, Jan 17, 2013 at 10:49 AM, Raymond Toy r...@google.com wrote:
Hmm. I have a git checkout of webkit so svn-create-patch doesn't want to
work.
Yeah, the patch is probably
Note that "git show" produces a valid different file, extra commit message notwithstanding. (The commit message is part of the header and will be ignored when used with diff and related tools.)If you have your commit, plus the ChangeLog changes mer
ged into the same commit, you can just pipe the
... valid *diff* file. Damn you autocorrect! From: jpe...@gmx.atSent: Thursday, January 17, 2013 3:42 PMTo: Raymond ToyCc: webkit-d
e...@lists.webkit.orgSubject: Re: [webkit-dev] Can't upload patchNote that "git show" produces a valid different file, extra commit message notwithstanding. (The
of jpe...@gmx.at [jpe...@gmx.at]
Sent: Thursday, January 17, 2013 3:43 PM
To: Raymond Toy
Cc: webkit-dev@lists.webkit.org
Subject: Re: [webkit-dev] Can't upload patch
... valid *diff* file. Damn you autocorrect!
From: jpe...@gmx.at
Sent: Thursday, January 17, 2013 3:42 PM
To: Raymond Toy
Cc
] on behalf of jpe...@gmx.at [
jpe...@gmx.at]
Sent: Thursday, January 17, 2013 3:43 PM
To: Raymond Toy
Cc: webkit-dev@lists.webkit.org
Subject: Re: [webkit-dev] Can't upload patch
... valid *diff* file. Damn you autocorrect!
From: jpe...@gmx.at
Sent: Thursday, January 17, 2013 3:42 PM
...@gmx.at; webkit-dev@lists.webkit.org
Subject: Re: [webkit-dev] Can't upload patch
On Thu, Jan 17, 2013 at 1:17 PM, Konrad Piascik
kpias...@rim.commailto:kpias...@rim.com wrote:
Instead of piping the output of git show, I'd use git format-patch -1 This
will generate a patch file
9 matches
Mail list logo
