Re: [webkit-dev] Proposed Windows Drawing Change (WebNodeHighlight) Logic

2011-06-27 Thread Adam Roben
On Jun 27, 2011, at 1:55 AM, Simon Fraser wrote: This should go into a bug. Agreed. On Jun 26, 2011, at 4:12 PM, Brent Fulgham wrote: While investigating a separate issue, I noticed that I was hitting an assertion in the Cairo drawing layer because it was attempting to use an invalid

Re: [webkit-dev] Proposed Windows Drawing Change (WebNodeHighlight) Logic

2011-06-27 Thread Brent Fulgham
On Mon, Jun 27, 2011 at 5:36 AM, Adam Roben aro...@apple.com wrote: On Jun 27, 2011, at 1:55 AM, Simon Fraser wrote: This should go into a bug. Agreed. Opened https://bugs.webkit.org/show_bug.cgi?id=63484. Thanks, -Brent ___ webkit-dev mailing

[webkit-dev] Proposed Windows Drawing Change (WebNodeHighlight) Logic

2011-06-26 Thread Brent Fulgham
While investigating a separate issue, I noticed that I was hitting an assertion in the Cairo drawing layer because it was attempting to use an invalid HBITMAP created in the WebNodeHighlight::update method. The underlying issue was that the CreateDIBSection function was failing, because it was

Re: [webkit-dev] Proposed Windows Drawing Change (WebNodeHighlight) Logic

2011-06-26 Thread Simon Fraser
This should go into a bug. Simon On Jun 26, 2011, at 4:12 PM, Brent Fulgham wrote: While investigating a separate issue, I noticed that I was hitting an assertion in the Cairo drawing layer because it was attempting to use an invalid HBITMAP created in the WebNodeHighlight::update method.