Re: [webkit-dev] Timing updates for SVG SMIL animations
Am 27.07.2011 um 23:03 schrieb Darin Fisher: Perhaps related to this thread, shouldn't we be basing SVG animations off of the same animation scheduler that drives requestAnimationFrame and soon CSS animations (https://bugs.webkit.org/show_bug.cgi?id=64591)? It seems less than ideal to use a Timer. I'd love to share as much animation timing stuff as possible! Dirk ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
[webkit-dev] Timing updates for SVG SMIL animations
Hi, When the Timer is fired for SMILTimeContainer to update animations, the elapsed time is calculated based on the client's currentTime(). That elapsed time is passed into updateAnimations and is used most of the way down. In some cases during the update though, SMILTimeContainer::elapsed() is re-called (e.g. in SVGSMILElement::beginListChanged, endListChanged, createInstanceTimesFromSyncbase). This seems somewhat incorrect because it means that various parts of the animation will be updated with (slightly) different elapsed times than others. It also makes it impractical to use a debugger to step the code. Does anyone disagree that all updates should use the same elapsed time during the update? Or, in other words, is there any reason to re-get the current wallclock time during the update? Thanks, Scott ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] Timing updates for SVG SMIL animations
On Jul 27, 2011, at 11:14 AM, Scott Graham wrote: Hi, When the Timer is fired for SMILTimeContainer to update animations, the elapsed time is calculated based on the client's currentTime(). That elapsed time is passed into updateAnimations and is used most of the way down. In some cases during the update though, SMILTimeContainer::elapsed() is re-called (e.g. in SVGSMILElement::beginListChanged, endListChanged, createInstanceTimesFromSyncbase). This seems somewhat incorrect because it means that various parts of the animation will be updated with (slightly) different elapsed times than others. It also makes it impractical to use a debugger to step the code. Does anyone disagree that all updates should use the same elapsed time during the update? Or, in other words, is there any reason to re-get the current wallclock time during the update? I think your analysis is correct. You should file a bug for this in bugs.webkit.org, and folks can review your proposed changes there. Simon ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] Timing updates for SVG SMIL animations
On Wed, Jul 27, 2011 at 12:15 PM, Simon Fraser simon.fra...@apple.comwrote: On Jul 27, 2011, at 11:14 AM, Scott Graham wrote: Does anyone disagree that all updates should use the same elapsed time during the update? Or, in other words, is there any reason to re-get the current wallclock time during the update? I think your analysis is correct. You should file a bug for this in bugs.webkit.org, and folks can review your proposed changes there. Thanks, done: https://bugs.webkit.org/show_bug.cgi?id=65274 scott ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] Timing updates for SVG SMIL animations
Perhaps related to this thread, shouldn't we be basing SVG animations off of the same animation scheduler that drives requestAnimationFrame and soon CSS animations (https://bugs.webkit.org/show_bug.cgi?id=64591)? It seems less than ideal to use a Timer. -Darin On Wed, Jul 27, 2011 at 11:14 AM, Scott Graham scot...@chromium.org wrote: Hi, When the Timer is fired for SMILTimeContainer to update animations, the elapsed time is calculated based on the client's currentTime(). That elapsed time is passed into updateAnimations and is used most of the way down. In some cases during the update though, SMILTimeContainer::elapsed() is re-called (e.g. in SVGSMILElement::beginListChanged, endListChanged, createInstanceTimesFromSyncbase). This seems somewhat incorrect because it means that various parts of the animation will be updated with (slightly) different elapsed times than others. It also makes it impractical to use a debugger to step the code. Does anyone disagree that all updates should use the same elapsed time during the update? Or, in other words, is there any reason to re-get the current wallclock time during the update? Thanks, Scott ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
