[webkit-dev] Review states

2009-06-17 Thread Eric Seidel
(Maciej and I chatted about this briefly over IRC a while back.) I think we need a new r+ state. Or at least we need more than just r=?, r-, r+. Why? Currently r+ means at least 3 things: 1. Ready to commit if you make some mods and re-post [non-committers] 2. Ready to commit if you make

Re: [webkit-dev] ARM JIT and related issues

2009-06-17 Thread Zoltan Herczeg
Hi, 1) The armv7 port is separate from the armv6 work, and uses the thumb2 instruction set. Both ports are (I hope!) useful. We hope it as well. 2) We would have liked to let the community know about the arm v7 port sooner. Unfortunately, we were not at liberty to disclose it until the

Re: [webkit-dev] Help! I can't survive building WebKit in Visual Studio 2005 IDE!

2009-06-17 Thread Nevo
From your log : missing pthread.h and uchar.h unicode/uchar.h and pthread.h are all located in WebKitSupportLibrary ,which would be extracted to WebKitLibraries under your source root .Check the build script (I think it's readable enough) .I only built Webkit Win32 port once, saw the similar

[webkit-dev] WebCore architecture for persistent cache

2009-06-17 Thread Jeremy Serdin
Hi all I'm trying to implement a persistent cache for WebCore with libcurl. I'm looking for some documents about webcore architecture in order to implement it in a right way. Can somebody help me? Thx, jser...@gmail.com ___ webkit-dev mailing list

Re: [webkit-dev] Review states

2009-06-17 Thread Mark Rowe
On 2009-06-17, at 00:41, Eric Seidel wrote: I propose altering our bugzilla setup to have the following review states (effectively adding a 4th state): review: REQUESTED DENIED APPROVED WITH MODIFICATIONS APPROVED I think DENIED could also do with having a hard and soft state. One to

Re: [webkit-dev] Crash on the Mac (RapidWeaver plugin and Safari 4)

2009-06-17 Thread Gilberto De Faveri
I've just reported the bug #26476. Unfortunately, I was not able to reproduce it outside RapidWeaver plugin SDK. On 12/giu/09, at 16:38, David Kilzer wrote: Hi Gilberto, Please file a bug on either https://bugreport.apple.com/ or https://bugs.webkit.org with explicit steps on how to

Re: [webkit-dev] Help! I can't survive building WebKit in Visual Studio 2005 IDE!

2009-06-17 Thread Ryosuke Niwa
Instead of trying to build from Visual Studio, try WebKitTools/Scripts/build-webkit --debug on cygwin. Ryosuke On Tue, Jun 16, 2009 at 8:55 PM, 张雷 zhang@kortide.com.cn wrote: I tried several times, but failed always! God damn! I read all the instructions detailedly. These are my steps:

Re: [webkit-dev] Help! I can't survive building WebKit in Visual Studio 2005 IDE!

2009-06-17 Thread Takeshi Yoshino
Or just run WebKitTools/Scripts/update-webkit and then WebKitTools/Scripts/update-webkit-support-libs to fetch and extract both WebKitAuxiliaryLibrary.zip and WebKitSupportLibrary.zip . And then you'll be able to build using WebKit/win/WebKit.vcproj/WebKit.sln . Thanks, Takeshi 2009/6/17

Re: [webkit-dev] Help! I can't survive building WebKit in Visual Studio 2005 IDE!

2009-06-17 Thread 张雷
I tried building from the Cygwin command line with WebKitTools/Scripts/build-webkit --debug. Buf failed with the same error message. :( 原始信息 主题: Re: [webkit-dev] Help! I can't survive building WebKit in Visual Studio 2005 IDE! 发件人: Ryosuke Niwa rn...@google.com 收件人: WebKit

[webkit-dev] 答复: Help! I can't survive b uilding WebKit in Visual Studio 2005 ID E!

2009-06-17 Thread canquan.shencq
Please run update-webkit at first. Btw: please join in qq group:8763622 _ 发件人: webkit-dev-boun...@lists.webkit.org [mailto:webkit-dev-boun...@lists.webkit.org] 代表 张雷 发送时间: 2009年6月17日 18:05 收件人: Ryosuke Niwa 抄送: WebKit Development 主题: Re: [webkit-dev] Help! I can't survive

Re: [webkit-dev] Help! I can't survive building WebKit in Visual Studio 2005 IDE!

2009-06-17 Thread 张雷
What's WebKitAuxiliaryLibrary.zip? I searched it in my WebKit source folder but found none. 原始信息 主题: Re: [webkit-dev] Help! I can't survive building WebKit in Visual Studio 2005 IDE! 发件人: Takeshi Yoshino tyosh...@google.com 收件人: Ryosuke Niwa rn...@google.com 抄送: WebKit

Re: [webkit-dev] Help! I can't survive building WebKit in Visual Studio 2005 IDE!

2009-06-17 Thread Nevo
But someone better to document the detail building setup in the official webkit building page (or at least provide a link to related wiki pages ). Firefox has a well documented building guide (Im not complaining :)) 2009/6/17 Nevo sakur.dea...@gmail.com I think Takeshi already show you the way

[webkit-dev] Webkit in AIR - Getting text's coordniates for highlighting

2009-06-17 Thread Rehan Abdulaziz
Hey, I wish to highlight a certain term (e.g. a search query) in HTMLLoader or HTML (AIR) wherever it appears. The only way to do it in my mind is to traverse through each component and find the occurrence of the term in its body. So far, I have written the following code, and do not know where to

Re: [webkit-dev] 答复: Help! I can't survive b uilding WebKit in Visual Studio 2005 IDE!

2009-06-17 Thread 张雷
OK! I ran WebKit/WebKitTools/Scripts/update-webkit and recompiled and then I passed! It seems that I lacked WebKitAuxiliaryLibrary.zip before, but the instructions(http://webkit.org/building/checkout.html) for checking out source from Nightly Builds does not say(or at least does not emphasize)

Re: [webkit-dev] Using WebKit renderer to produce PDF output

2009-06-17 Thread Dominik Roettsches
Hi Ben, I need to produce a tool that can generate PDFs from HTML. The best solution I can think of is to use WebKit's layout engine, and plug my own PDF generator in as a renderer backend. On both, Windows or Linux, you could try using Cairo's PDF backend for your purpose [1], i.e.

[webkit-dev] Building WebKit on ARM

2009-06-17 Thread jagadeesh k
Hi,     I want to built WebKit on OMAP 3530(ARM cortex A8)with Open embedded Linux distribution. 1.Want to know the build instructions for building WebKit on OMAP 3530? 2.Does the WebKit source need to be changed(makefile) so that it builds for OMAP 3530? Thanks jagadeesh

Re: [webkit-dev] Building WebKit on ARM

2009-06-17 Thread Zoltan Herczeg
Hi, 1.Want to know the build instructions for building WebKit on OMAP 3530? WebKit is written in c++, so you don't need to do anything special for your CPU. Just run WebKitTools/Scripts/build-webkit 2.Does the WebKit source need to be changed(makefile) so that it builds for OMAP 3530? If

Re: [webkit-dev] Review states

2009-06-17 Thread Adam Barth
On Wed, Jun 17, 2009 at 1:39 AM, Mark Rowemr...@apple.com wrote: On 2009-06-17, at 00:41, Eric Seidel wrote: I propose altering our bugzilla setup to have the following review states (effectively adding a 4th state): review: REQUESTED DENIED APPROVED WITH MODIFICATIONS APPROVED I

Re: [webkit-dev] Building WebKit on ARM

2009-06-17 Thread Holger Freyther
On Wednesday 17 June 2009 15:50:32 jagadeesh k wrote: Hi, I want to built WebKit on OMAP 3530(ARM cortex A8)with Open embedded Linux distribution. 1.Want to know the build instructions for building WebKit on OMAP 3530? 2.Does the WebKit source need to be changed(makefile) so that it

Re: [webkit-dev] Should we put the webkit.org mailing lists on Gmane?

2009-06-17 Thread Adam Roben
Given the single vote in favor and no one opposed, I'm going to work on this today. -Adam On Jun 15, 2009, at 4:52 PM, Gustavo Noronha wrote: On Sat, 2009-06-13 at 09:00 -0400, Adam Roben wrote: Gmane (http://gmane.org) provides a few features that could be useful for thewebkit.org

Re: [webkit-dev] Quesition about DumpRenderTree output

2009-06-17 Thread David Hyatt
On Jun 16, 2009, at 12:26 AM, Lucius Fox wrote: Hi, Can you please tell me what is the meaning of relative positioned and the meaning of positioned in DumpRenderTree? Those are CSS terms. Relative positioned means you have position:relative specified in CSS. Positioned with no qualifier

[webkit-dev] Javascript window.open()

2009-06-17 Thread Zongheng Zhou
Hi, I am using the QT port of webkit. Instead of doing anything else for the Javascript 's window.open(), I only want to log the URL being requested. Can anybody tell me how I can change the behavior of the window.open? Thanks, ___ webkit-dev mailing

Re: [webkit-dev] Review states

2009-06-17 Thread Maciej Stachowiak
On Jun 17, 2009, at 1:39 AM, Mark Rowe wrote: On 2009-06-17, at 00:41, Eric Seidel wrote: I propose altering our bugzilla setup to have the following review states (effectively adding a 4th state): review: REQUESTED DENIED APPROVED WITH MODIFICATIONS APPROVED I think DENIED could also do

Re: [webkit-dev] Review states

2009-06-17 Thread Jeremy Orlow
Rietveld doesn't really support any flags, right? It seems like they could be added in without too much effort though. Mondrian (its closed source parent) does. J On Wed, Jun 17, 2009 at 11:13 AM, Eric Seidel e...@webkit.org wrote: It would appear bugzilla is too lame to support changing flag

Re: [webkit-dev] Review states

2009-06-17 Thread Joe Mason
Eric Seidel wrote: It would appear bugzilla is too lame to support changing flag values +/-/? are all we get. :( https://bugs.webkit.org/editflagtypes.cgi (only accessible to bugzilla users with edit privilages). Maybe the solution is a different review tool instead of adding flags to

Re: [webkit-dev] Review states

2009-06-17 Thread Mark Rowe
On 2009-06-17, at 11:20, Joe Mason wrote: Eric Seidel wrote: It would appear bugzilla is too lame to support changing flag values +/-/? are all we get. :( https://bugs.webkit.org/editflagtypes.cgi (only accessible to bugzilla users with edit privilages). Maybe the solution is a different

Re: [webkit-dev] Review states

2009-06-17 Thread David Hyatt
On Jun 17, 2009, at 1:20 PM, Joe Mason wrote: Eric Seidel wrote: It would appear bugzilla is too lame to support changing flag values +/-/? are all we get. :( https://bugs.webkit.org/editflagtypes.cgi (only accessible to bugzilla users with edit privilages). Maybe the solution is a different

Re: [webkit-dev] script to assist converting pixel tests to dumpastext tests

2009-06-17 Thread Darin Adler
On Jun 16, 2009, at 6:16 PM, Ryosuke Niwa wrote: I've been converting a bunch of pixel tests to dumpAsText tests. Thanks for telling us about your script. These are layout tests, not pixel tests. While it's true that the tests dump the render tree as text and when run in the --pixel mode

Re: [webkit-dev] Review states

2009-06-17 Thread Maciej Stachowiak
On Jun 17, 2009, at 11:45 AM, Ojan Vafai wrote: This is surely bike-shedding, but... On Wed, Jun 17, 2009 at 8:14 AM, Maciej Stachowiak m...@apple.com wrote: Review Rejected (for the rare case where the concept of a patch tries to do is completely wrong; often in this case the bug will

Re: [webkit-dev] Review states

2009-06-17 Thread Maciej Stachowiak
On Jun 17, 2009, at 12:52 PM, Maciej Stachowiak wrote: On Jun 17, 2009, at 11:45 AM, Ojan Vafai wrote: This is surely bike-shedding, but... On Wed, Jun 17, 2009 at 8:14 AM, Maciej Stachowiak m...@apple.com wrote: Review Rejected (for the rare case where the concept of a patch tries to

Re: [webkit-dev] MIPS port problem - cti_op_put_by_id slow case problem

2009-06-17 Thread Geoffrey Garen
If someone could be kind enough to explain how it works on other platforms, it would be very helpful. I'm not really interested in helping with the dubiously legal task of taking JavaScriptCore, which is an OpenSource library, and turning it into a closed, proprietary library.

Re: [webkit-dev] Review states

2009-06-17 Thread Ojan Vafai
On Wed, Jun 17, 2009 at 12:54 PM, Maciej Stachowiak m...@apple.com wrote: I forgot to mention - there should probably be a final Checked In state. I think that would help smooth out the workflow when people attach multiple patches to a single bug. It seems more clear than unflagging. Would

Re: [webkit-dev] MIPS port problem - cti_op_put_by_id slow case problem

2009-06-17 Thread Toshiyasu Morita
--- On Wed, 6/17/09, Geoffrey Garen gga...@apple.com wrote: I'm not really interested in helping with the dubiously legal task of taking JavaScriptCore, which is an OpenSource library, and turning it into a closed, proprietary library. I'm not sure where this weird idea of developing a closed

Re: [webkit-dev] MIPS port problem - cti_op_put_by_id slow case problem

2009-06-17 Thread Jeremy Orlow
IANAL (and correct me if I'm wrong), but 1) Parts of WebKit are licensed under the LGPL 2) Even if you're not modifying (or copying code from) files licensed under the LGPL, any files linked to those LGPL files are governed by the LGPL 3) Presumably you're going to distribute binaries that

Re: [webkit-dev] MIPS port problem - cti_op_put_by_id slow case problem

2009-06-17 Thread Toshiyasu Morita
--- On Wed, 6/17/09, Geoffrey Garen gga...@apple.com wrote: I'm not really interested in helping with the dubiously legal task of taking JavaScriptCore, which is an OpenSource library, and turning it into a closed, proprietary library. I've talked to my client, and he's told me

Re: [webkit-dev] MIPS port problem - cti_op_put_by_id slow case problem

2009-06-17 Thread Kenneth Christiansen
That doesn't mean that you cannot develop it in the open. We can integrate the code once you are ready to do so. Kenneth I've talked to my client, and he's told me it's their intent to contribute the port back to the community once the port is finished. IMHO main problem with trying to

Re: [webkit-dev] MIPS port problem - cti_op_put_by_id slow case problem

2009-06-17 Thread Toshiyasu Morita
--- On Wed, 6/17/09, Jeremy Orlow jor...@chromium.org wrote: IANAL (and correct me if I'm wrong), but 1) Parts of WebKit are licensed under the LGPL 2) Even if you're not modifying (or copying code from) files licensed under the LGPL, any files linked to those LGPL files are governed by

Re: [webkit-dev] MIPS port problem - cti_op_put_by_id slow case problem

2009-06-17 Thread Toshiyasu Morita
kenneth.christian...@openbossa.org wrote: That doesn't mean that you cannot develop it in the open. We can integrate the code once you are ready to do so. Kenneth You're preaching to the choir. It's not my decision to make. Toshi

[webkit-dev] Attaching property to external (Obj-c) synthetic event

2009-06-17 Thread Ross Lillie
Greetings, I need to generate a synthetic event (DOM Level 2) from external (native) code and inject into the current DOM structure. Furthermore, this event needs to have a custom property attached, to pass external data into the current Javascript context. Generating and dispatching the event

Re: [webkit-dev] MIPS port problem - cti_op_put_by_id slow case problem

2009-06-17 Thread Kenneth Christiansen
When then I guess that you can only expect to get help after you have contributed the code back to the community. ;-) Good luck with your port anyway. Kenneth On Wed, Jun 17, 2009 at 6:29 PM, Toshiyasu Moritatm_web...@yahoo.com wrote: kenneth.christian...@openbossa.org wrote: That doesn't

Re: [webkit-dev] MIPS port problem - cti_op_put_by_id slow case problem

2009-06-17 Thread Adam Treat
On Wednesday 17 June 2009 05:12:41 pm Jeremy Orlow wrote: If so, why not just develop in the open? I'm just guessing here... but probably for the same rough combination of reasons that Google didn't develop Chromium in the open before it was publicly announced... or for the same rough

Re: [webkit-dev] [Bulk] Re: MIPS port problem - cti_op_put_by_id slow case problem

2009-06-17 Thread Adam Treat
On Wednesday 17 June 2009 06:24:32 pm Adam Treat wrote: It would be nice if every change that is envisioned will eventually be merged back into the official repository to be developed in the open, but that is just not realistic given the commercial world we live in. I would also add that in my

Re: [webkit-dev] SharedWorkers alternate design

2009-06-17 Thread Drew Wilson
Following up again on this - now that my cross-thread MessagePort patch is getting close to landing, I am moving forward on the SharedWorker design described earlier in this thread. I think there is still little clarity around the appcache behavior (dimich: are you bring over your shadow frame

Re: [webkit-dev] Attaching property to external (Obj-c) synthetic event

2009-06-17 Thread Ross Lillie
Greetings again, Never mind. If I understand things correctly, calling into the DOMDocument from native code, to create a new Event instance, does not create the corresponding JSObject in the window's global context. Dispatching the event to a target appears to be when the corresponding

Re: [webkit-dev] How to find a WebKit Nightly corresponding roughly to particular Safari version

2009-06-17 Thread Thomas Jaggi
Am 15.06.2009 um 18:31 schrieb Darin Adler: On Jun 15, 2009, at 9:03 AM, Thomas Jaggi wrote: Thanks for your help. If I got that right, 38725 would correspond to Safari 3.2.1 (http://trac.webkit.org/changeset/38725). Using the 'official' detection script with 38707 (the last version before

Re: [webkit-dev] MIPS port problem - cti_op_put_by_id slow case problem

2009-06-17 Thread Maciej Stachowiak
On Jun 17, 2009, at 2:18 PM, Toshiyasu Morita wrote: --- On Wed, 6/17/09, Geoffrey Garen gga...@apple.com wrote: I'm not really interested in helping with the dubiously legal task of taking JavaScriptCore, which is an OpenSource library, and turning it into a closed, proprietary

Re: [webkit-dev] SharedWorkers alternate design

2009-06-17 Thread Michael Nordman
On Wed, Jun 17, 2009 at 3:43 PM, Drew Wilson atwil...@google.com wrote: Following up again on this - now that my cross-thread MessagePort patch is getting close to landing, I am moving forward on the SharedWorker design described earlier in this thread. I think there is still little clarity

Re: [webkit-dev] SharedWorkers alternate design

2009-06-17 Thread Dmitry Titov
I think there is still little clarity around the appcache behavior (dimich: are you bring over your shadow frame concept to webkit?). I'm wondering about bringing the 'shadow frame' technique to webcore too? If needs be :-) Just to explain what is meant by 'shadow frame' (I'm not sure it

[webkit-dev] Tab key Navigation

2009-06-17 Thread n179911
Hi, Is 'Tab key Navigation a browser functionality or Webkit functionally? For example, I load google.com, I put my mouse on the search input box click once. The search input box should have focus. And then i press 'Tab', the focus should moved. But what I find out is the way Safari moves focus

Re: [webkit-dev] rdar://5735912 for DumpRenderTree?

2009-06-17 Thread Ryosuke Niwa
So I tracked down here the message is sent. \WebCore\platform\network\cf\ResourceHandleCFNet.cpp line 365 in ResourceHandle::start(Frame* frame) But when I deleted the call to CFURLConnectionScheduleWithCurrentMessageQueue, DumpRenderTree crashed. So I don't think simply removing the call solves