[webkit-dev] Please include function-level comments in change log entries

2012-07-06 Thread Dan Bernstein
It appears that lately most WebCore change log entires don’t include any comments on individual functions. An overall description of the change at the top of the change log entry is valuable, but it is no substitute for describing the changes to each function. Good function-level comments are

Re: [webkit-dev] Please include function-level comments in change log entries

2012-07-06 Thread Per Bothner
On 07/06/2012 10:05 AM, Dan Bernstein wrote: It appears that lately most WebCore change log entires don’t include any comments on individual functions. An overall description of the change at the top of the change log entry is valuable, but it is no substitute for describing the changes to

Re: [webkit-dev] Please include function-level comments in change log entries

2012-07-06 Thread Hugo Parente Lima
On Friday, July 06, 2012 11:34:01 AM Per Bothner wrote: On 07/06/2012 10:05 AM, Dan Bernstein wrote: It appears that lately most WebCore change log entires don’t include any comments on individual functions. An overall description of the change at the top of the change log entry is

Re: [webkit-dev] Please include function-level comments in change log entries

2012-07-06 Thread Ryosuke Niwa
On Fri, Jul 6, 2012 at 11:34 AM, Per Bothner per.both...@oracle.com wrote: On 07/06/2012 10:05 AM, Dan Bernstein wrote: It appears that lately most WebCore change log entires don’t include any comments on individual functions. An overall description of the change at the top of the change log

Re: [webkit-dev] Please include function-level comments in change log entries

2012-07-06 Thread Dana Jansens
On Fri, Jul 6, 2012 at 1:05 PM, Dan Bernstein m...@apple.com wrote: It appears that lately most WebCore change log entires don’t include any comments on individual functions. An overall description of the change at the top of the change log entry is valuable, but it is no substitute for

Re: [webkit-dev] Please include function-level comments in change log entries

2012-07-06 Thread Konrad Piascik
: Friday, July 06, 2012 02:42 PM To: Dan Bernstein m...@apple.com Cc: WebKit Development webkit-dev@lists.webkit.org Subject: Re: [webkit-dev] Please include function-level comments in change log entries On Fri, Jul 6, 2012 at 1:05 PM, Dan Bernstein m...@apple.commailto:m...@apple.com wrote

Re: [webkit-dev] Please include function-level comments in change log entries

2012-07-06 Thread Ryosuke Niwa
On Fri, Jul 6, 2012 at 11:42 AM, Dana Jansens dan...@chromium.org wrote: On Fri, Jul 6, 2012 at 1:05 PM, Dan Bernstein m...@apple.com wrote: It appears that lately most WebCore change log entires don’t include any comments on individual functions. An overall description of the change at the

Re: [webkit-dev] Please include function-level comments in change log entries

2012-07-06 Thread Per Bothner
On 07/06/2012 11:41 AM, Ryosuke Niwa wrote: Indeed, we try to avoid adding comments as much as possible since comments tend to get out-of-date very quickly, we don't want to be spending all our time updating comments. Heavens forbid that someone who actually understands the code should have to

Re: [webkit-dev] Please include function-level comments in change log entries

2012-07-06 Thread Eric Seidel
Per: You began by thread-jacking Dan's discussion of ChangeLogs, and now appear to be attacking a seasoned contributors polite response with sarcasm and derision. I recommend you soften your words, and try again on another thread. Commenting, or lack there of, has been discussed at great

Re: [webkit-dev] Please include function-level comments in change log entries

2012-07-06 Thread Per Bothner
On 07/06/2012 01:02 PM, Eric Seidel wrote: You began by thread-jacking Dan's discussion of ChangeLogs, and now appear to be attacking a seasoned contributors polite response with sarcasm and derision. Sorry - it wasn't meant to be a thread-jacking, but the issue of commenting in WebKit hit a