Hi
I suggest:
That you apply and commit the currently best patch for large files. That is
probably the one Leonid works/worked on. Isn't that the one Redhat has
applied?
I suggest that off_t isn't used to store/keep large file sizes, but instead a
privately typedefed type instead. Named wget_off_t for example.
On linux and most unix-like systems, we can 'typedef off_t wget_off_t' and
most things will be fine. A strtoll() replacement is needed for some
platforms. I believe this works fine for VMS too. I could check later.
On systems like Windows, large file support takes some more work, and then the
wget_off_t is probably best made 'typedef signed __int64 wget_off_t' with MSVC
(but all libc-calls using wget_off_t will need attention/replacements since
the windows libc APIs aren't supporting large files).
On Windows with mingw or watcom, the typedef is better made 'typedef long long
wget_off_t'.
On Windows CE, I believe it works best as 'typedef long wget_off_t'.
On systems without large file support, off_t is most often still present and
simply just a 32 bit type. Thus, a file-size-as-string-to-number function
(basicly strtol() or strtoll() depending on the platform) is suitable, to
convert a string to wget_off_t.
Now, this is only a suggestion meant to kick-start some discussions and
possibly implementations.
--
-=- Daniel Stenberg -=- http://daniel.haxx.se -=-
ech`echo xiun|tr nu oc|sed 'sx\([sx]\)\([xoi]\)xo un\2\1 is xg'`ol
