Re: version.c take two

Micah Cowan [EMAIL PROTECTED] writes: version.c: $(wget_SOURCES) $(LDADD) printf '%s' 'const char *version_string = @VERSION@' $@ -hg log -r tip --template=' ({node|short})' $@ printf '%s\n' ';' $@ printf is not portable to older systems, but that may not be a

Re: version.c take two

-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Hrvoje Niksic wrote: Micah Cowan [EMAIL PROTECTED] writes: version.c: $(wget_SOURCES) $(LDADD) printf '%s' 'const char *version_string = @VERSION@' $@ -hg log -r tip --template=' ({node|short})' $@ printf '%s\n' ';'

Re: version.c take two

On Tue, 16 Oct 2007, Micah Cowan wrote: I may take liberties with the Make environment, and assume the presence of a GNU toolset, though I'll try to avoid that where it's possible. Well, the issue has been resolved one way or another with many GNU packages, including the core ones such as

Re: version.c take two

Micah Cowan [EMAIL PROTECTED] writes: I may take liberties with the Make environment, and assume the presence of a GNU toolset, though I'll try to avoid that where it's possible. Requiring the GNU toolset puts a large burden on the users of non-GNU systems (both free and non-free ones).

Re: version.c take two

Micah Cowan wrote: I've improved the generation of version.c, removing the intermediate generation of an hg-id file and using a more portable replacement for hg id | cut -d ' ' -f 1 (can be used on Windows and MS-DOS). The relevant lines in src/Makefile.am are now: version.c:

Re: version.c take two

Hrvoje Niksic wrote: Micah Cowan [EMAIL PROTECTED] writes: I may take liberties with the Make environment, and assume the presence of a GNU toolset, though I'll try to avoid that where it's possible. Requiring the GNU toolset puts a large burden on the users of non-GNU systems (both free

Re: [Patch] Plug some memleaks

Hrvoje Niksic wrote: Gisle Vanem [EMAIL PROTECTED] writes: Building with 'DEBUG_MALLOC' reveals some memory leaks that should be plugged IMHO. Recursive d/l has lots more leaks which I didn't address with the following patch (yet). Note that, technically, those are not leaks in real need

Re: version.c take two

Micah Cowan [EMAIL PROTECTED] writes: Alright; I'll make an extra effort to avoid non-portable Make assumptions then. It's just... portable Make _sucks_ (not that non-portable Make doesn't). It might be fine to require GNU make if there is a good reason for it -- many projects do. But

Re: [Patch] Plug some memleaks

Micah Cowan [EMAIL PROTECTED] writes: Note that, technically, those are not leaks in real need of plugging because they get called only once, i.e. they do not accumulate (leak) unused memory. Of course, it's still a good idea to remove them, if nothing else, then to remove false positives

Re: version.c take two

Hrvoje Niksic wrote: Micah Cowan [EMAIL PROTECTED] writes: Alright; I'll make an extra effort to avoid non-portable Make assumptions then. It's just... portable Make _sucks_ (not that non-portable Make doesn't). It might be fine to require GNU make if there is a good reason for it --

Re: version.c take two

-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Micah Cowan wrote: Gisle and Chris, you should be able to write this rule in your Makefiles. Something like: version.c: $(SOURCES) echo 'const char *version_string = @VERSION@' $@ -hg log -r tip --template=' ({node|short})\n' $@

Re: ... --limit-rate nn%

On 10/15/07, Matthias Vill [EMAIL PROTECTED] wrote: Micah Cowan schrieb: Matthias Vill wrote: I would appreciate having a --limit-rate N% option. So now about those broken cases. You could do some least of both policy (which would of course still need the time to do measuring and can

Re: wget default behavior [was Re: working on patch to limit to percent of bandwidth]

On 10/13/07, Micah Cowan [EMAIL PROTECTED] wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA256 On 10/13/07, Tony Godshall [EMAIL PROTECTED] wrote: OK, so let's go back to basics for a moment. wget's default behavior is to use all available bandwidth. Is this the right thing to