Re: [whatwg] HTMLForms: Implicit Submission with {display:none} button

2012-09-05 Thread Ian Hickson
On Thu, 5 Jul 2012, Glenn Maynard wrote: On Fri, Jun 29, 2012 at 4:24 PM, Ian Hickson i...@hixie.ch wrote: On Tue, 21 Feb 2012, Glenn Maynard wrote: I don't think the existence of implicit submit should depend on platform conventions, though, for interop on forms without visible

Re: [whatwg] HTMLForms: Implicit Submission with {display:none} button

2012-07-05 Thread Glenn Maynard
On Fri, Jun 29, 2012 at 4:24 PM, Ian Hickson i...@hixie.ch wrote: On Tue, 21 Feb 2012, Glenn Maynard wrote: I don't think the existence of implicit submit should depend on platform conventions, though, for interop on forms without visible submit buttons. The form implicit submit takes

Re: [whatwg] HTMLForms: Implicit Submission with {display:none} button

2012-06-29 Thread Ian Hickson
On Tue, 21 Feb 2012, Boris Zbarsky wrote: On 2/21/12 10:47 PM, Dimitri Glazkov wrote: I made WebKit match this behavior a couple of years ago: https://bugs.webkit.org/show_bug.cgi?id=9756 Ah, interesting. Some of the links in that bug indicate that people are in fact depending on this

Re: [whatwg] HTMLForms: Implicit Submission with {display:none} button

2012-06-29 Thread Boris Zbarsky
On 6/29/12 5:24 PM, Ian Hickson wrote: Let me know if it's not quite right. I wasn't sure exactly what weird things to test. I mostly relied on WebKit's (specifically Chrome's) behaviour here since they were apparently the ones most recently affected by real compat reasons to implement something

Re: [whatwg] HTMLForms: Implicit Submission with {display:none} button

2012-06-29 Thread Boris Zbarsky
On 6/29/12 6:19 PM, Boris Zbarsky wrote: In any case, I believe the spec is wrong in one aspect: in the case that there is a default button, what needs to happen is a click event on that button, not just a triggering of its activation behavior. In particular, onclick handlers need to fire and

Re: [whatwg] HTMLForms: Implicit Submission with {display:none} button

2012-06-29 Thread Ian Hickson
On Fri, 29 Jun 2012, Boris Zbarsky wrote: On 6/29/12 5:24 PM, Ian Hickson wrote: Let me know if it's not quite right. I wasn't sure exactly what weird things to test. I mostly relied on WebKit's (specifically Chrome's) behaviour here since they were apparently the ones most recently

Re: [whatwg] HTMLForms: Implicit Submission with {display:none} button

2012-06-29 Thread Ian Hickson
On Fri, 29 Jun 2012, Boris Zbarsky wrote: On 6/29/12 6:19 PM, Boris Zbarsky wrote: In any case, I believe the spec is wrong in one aspect: in the case that there is a default button, what needs to happen is a click event on that button, not just a triggering of its activation behavior. In

Re: [whatwg] HTMLForms: Implicit Submission with {display:none} button

2012-06-29 Thread Boris Zbarsky
On 6/29/12 7:20 PM, Ian Hickson wrote: The main difference was that Chrome and Firefox differ in what input types they support, which affects which they allow to affect the implicit submission thing. Oh, ok. Yeah, that's a bit of a mess... ;) Oh, wow, yeah, the spec was just bogus there,

Re: [whatwg] HTMLForms: Implicit Submission with {display:none} button

2012-05-23 Thread Rob Crowther
On 22/02/12 00:35, Ian Hickson wrote: I've changed the spec to be clearer that CSS cannot be taken into account when determining the default. The default button is just always the first submit button in the form. What about the situation where there isn't a button? Implicit submission still

Re: [whatwg] HTMLForms: Implicit Submission with {display:none} button

2012-04-03 Thread Glenn Maynard
On Tue, Feb 21, 2012 at 7:36 PM, Boris Zbarsky bzbar...@mit.edu wrote: Not offhand. Again, it's been a while since I looked into this, but at the time this was being implemented in Gecko we carefully made the two-input-no-submit case not submit. I thought that was for good reason, but

Re: [whatwg] HTMLForms: Implicit Submission with {display:none} button

2012-04-03 Thread Boris Zbarsky
On 4/3/12 5:14 PM, Glenn Maynard wrote: Ten years later it's still giving me headaches, when I try to do a trivial two-input login form without a browser submit button, and find that every obvious way of hiding the submit button breaks implicit submit in one browser or another. Do I really need

Re: [whatwg] HTMLForms: Implicit Submission with {display:none} button

2012-02-21 Thread Ian Hickson
On Sat, 24 Sep 2011, Kaustubh Atrawalkar wrote: On 24-Sep-2011, at 12:24 AM, Ian Hickson i...@hixie.ch wrote: On Fri, 23 Sep 2011, Kaustubh Atrawalkar wrote: If the form has submit button with display property as none, will that form should be implicitly submitted on pressing enter key?

Re: [whatwg] HTMLForms: Implicit Submission with {display:none} button

2012-02-21 Thread Boris Zbarsky
On 2/21/12 7:35 PM, Ian Hickson wrote: On Sun, 25 Sep 2011, Boris Zbarsky wrote: Not doing that last is actually a requirement for web compat, last I looked at this. Do you have any links to pages that break if a form with more than one text field supports implicit submission? Not offhand.

Re: [whatwg] HTMLForms: Implicit Submission with {display:none} button

2012-02-21 Thread Glenn Maynard
On Tue, Feb 21, 2012 at 6:35 PM, Ian Hickson i...@hixie.ch wrote: (It also explicitly says that if implicit submit is supported but there's no submit button in the form, the implicit submit must still happen. That doesn't sound like it could be followed, since lots of pages are probably

Re: [whatwg] HTMLForms: Implicit Submission with {display:none} button

2012-02-21 Thread Dimitri Glazkov
On Tue, Feb 21, 2012 at 5:36 PM, Boris Zbarsky bzbar...@mit.edu wrote: On 2/21/12 7:35 PM, Ian Hickson wrote: On Sun, 25 Sep 2011, Boris Zbarsky wrote: Not doing that last is actually a requirement for web compat, last I looked at this. Do you have any links to pages that break if a form

Re: [whatwg] HTMLForms: Implicit Submission with {display:none} button

2012-02-21 Thread Boris Zbarsky
On 2/21/12 10:47 PM, Dimitri Glazkov wrote: I made WebKit match this behavior a couple of years ago: https://bugs.webkit.org/show_bug.cgi?id=9756 Ah, interesting. Some of the links in that bug indicate that people are in fact depending on this behavior -Boris

Re: [whatwg] HTMLForms: Implicit Submission with {display:none} button

2011-12-09 Thread Ryosuke Niwa
Given that both IE and WebKit have been disabling implicit form submission for years when the button has display: none, I don't think we can change our behavior here. Best, Ryosuke Niwa Software Engineer Google Inc. On Wed, Oct 12, 2011 at 11:33 PM, Kaustubh Atrawalkar kaust...@motorola.com

Re: [whatwg] HTMLForms: Implicit Submission with {display:none} button

2011-12-09 Thread Boris Zbarsky
On 12/9/11 6:06 PM, Ryosuke Niwa wrote: Given that both IE and WebKit have been disabling implicit form submission for years when the button has display: none, I don't think we can change our behavior here. Why, given that neither Gecko nor Opera have, and as far as I know have gotten

Re: [whatwg] HTMLForms: Implicit Submission with {display:none} button

2011-10-13 Thread Kaustubh Atrawalkar
On Mon, Sep 26, 2011 at 2:36 AM, Glenn Maynard gl...@zewt.org wrote: On Sun, Sep 25, 2011 at 1:02 PM, Ryosuke Niwa rn...@webkit.org wrote: The current Trident/WebKit behavior has a nice side-effect to (without scripts) require a visible submit button to enable implicit form submission. I

Re: [whatwg] HTMLForms: Implicit Submission with {display:none} button

2011-09-29 Thread Kaustubh Atrawalkar
On Mon, Sep 26, 2011 at 2:36 AM, Glenn Maynard gl...@zewt.org wrote: On Sun, Sep 25, 2011 at 1:02 PM, Ryosuke Niwa rn...@webkit.org wrote: The current Trident/WebKit behavior has a nice side-effect to (without scripts) require a visible submit button to enable implicit form submission. I

Re: [whatwg] HTMLForms: Implicit Submission with {display:none} button

2011-09-25 Thread Kaustubh Atrawalkar
On Sun, Sep 25, 2011 at 5:25 AM, Glenn Maynard gl...@zewt.org wrote: On Fri, Sep 23, 2011 at 2:52 PM, Ian Hickson i...@hixie.ch wrote: The strict answer is that it's up to the browsers; the spec allows browsers to do whatever they think is appropriate per their platform's conventions. So

Re: [whatwg] HTMLForms: Implicit Submission with {display:none} button

2011-09-25 Thread Glenn Maynard
On Sun, Sep 25, 2011 at 1:39 AM, Ryosuke Niwa rn...@webkit.org wrote: This makes the least sense of all to me. visibility: hidden shouldn't have a side-effect like this. Why? From user's perspective, not having submit button, having a submit button with display: none, having a submit button

Re: [whatwg] HTMLForms: Implicit Submission with {display:none} button

2011-09-25 Thread Ryosuke Niwa
On Sun, Sep 25, 2011 at 7:49 AM, Glenn Maynard gl...@zewt.org wrote: This is an authoring question, not a user one; either the page's author intends the form to be submittable or he doesn't. Having visibility: hidden affect this is even more surprising to me as an author than display: none.

Re: [whatwg] HTMLForms: Implicit Submission with {display:none} button

2011-09-25 Thread Glenn Maynard
On Sun, Sep 25, 2011 at 11:46 AM, Ryosuke Niwa rn...@webkit.org wrote: On Sun, Sep 25, 2011 at 7:49 AM, Glenn Maynard gl...@zewt.org wrote: This is an authoring question, not a user one; either the page's author intends the form to be submittable or he doesn't. Having visibility: hidden

Re: [whatwg] HTMLForms: Implicit Submission with {display:none} button

2011-09-25 Thread Ryosuke Niwa
On Sat, Sep 24, 2011 at 11:06 PM, Kaustubh Atrawalkar kaust...@motorola.com wrote: My perspective would be absence of submit button (with either visibility:hidden OR display:none) would give user to create more enhanced pages that will allow implicit submission like just username password

Re: [whatwg] HTMLForms: Implicit Submission with {display:none} button

2011-09-25 Thread Kaustubh Atrawalkar
On Sun, Sep 25, 2011 at 10:10 PM, Ryosuke Niwa rn...@webkit.org wrote: On Sat, Sep 24, 2011 at 11:06 PM, Kaustubh Atrawalkar kaust...@motorola.com wrote: My perspective would be absence of submit button (with either visibility:hidden OR display:none) would give user to create more enhanced

Re: [whatwg] HTMLForms: Implicit Submission with {display:none} button

2011-09-25 Thread Glenn Maynard
On Sun, Sep 25, 2011 at 12:51 PM, Kaustubh Atrawalkar kaust...@motorola.com wrote: Yes, but author can just reduce his scripting by using default behavior provided by the browser engine. I agree that user may not know pressing enter results in general form submission, but in case of search he

Re: [whatwg] HTMLForms: Implicit Submission with {display:none} button

2011-09-25 Thread Ryosuke Niwa
On Sun, Sep 25, 2011 at 9:51 AM, Kaustubh Atrawalkar kaust...@motorola.comwrote: On Sun, Sep 25, 2011 at 10:10 PM, Ryosuke Niwa rn...@webkit.org wrote: On Sat, Sep 24, 2011 at 11:06 PM, Kaustubh Atrawalkar kaust...@motorola.com wrote: My perspective would be absence of submit button (with

Re: [whatwg] HTMLForms: Implicit Submission with {display:none} button

2011-09-25 Thread Glenn Maynard
On Sun, Sep 25, 2011 at 1:02 PM, Ryosuke Niwa rn...@webkit.org wrote: The current Trident/WebKit behavior has a nice side-effect to (without scripts) require a visible submit button to enable implicit form submission. I don't find that nice. As a user, it's very annoying when implicit form

Re: [whatwg] HTMLForms: Implicit Submission with {display:none} button

2011-09-25 Thread Ryosuke Niwa
On Sep 25, 2011 11:48 AM, Boris Zbarsky bzbar...@mit.edu wrote: On 9/24/11 4:45 PM, Ryosuke Niwa wrote: It does not do implicit submissio in the following conditions: - Two text fields Not doing that last is actually a requirement for web compat, last I looked at this. Furthermore, a

Re: [whatwg] HTMLForms: Implicit Submission with {display:none} button

2011-09-25 Thread Boris Zbarsky
On 9/25/11 5:35 PM, Ryosuke Niwa wrote: So Gecko fires a click event on a button even if it had display: none or visibiliy: hidden? In this situation, yes. Just like as if you called dispatchEvent on it. Of course you can't trigger click events on such a button using an actual mouse, since

Re: [whatwg] HTMLForms: Implicit Submission with {display:none} button

2011-09-24 Thread Ryosuke Niwa
On Fri, Sep 23, 2011 at 10:10 PM, Kaustubh Atrawalkar kaust...@motorola.com wrote: If the form has submit button with display property as none, will that form should be implicitly submitted on pressing enter key? This works in Opera Firefox but does not work in IE Safari as of now.

Re: [whatwg] HTMLForms: Implicit Submission with {display:none} button

2011-09-24 Thread Ryosuke Niwa
FYI, I checked Firefox 5's Internet Explorer 9's behaviors as well. IE9 does implicit submission in the following conditions: - One text field - One text field with one visible submit button - One text field with one display:none submit button - Two text fields with one visible

Re: [whatwg] HTMLForms: Implicit Submission with {display:none} button

2011-09-24 Thread Ryosuke Niwa
On Sat, Sep 24, 2011 at 9:47 AM, Ryosuke Niwa rn...@webkit.org wrote: WebKit's behavior is very confusing here. It does implicit submission in the following conditions: - One text fields - Two text fields Correction. WebKit does NOT do implicit submision for two text fields when

Re: [whatwg] HTMLForms: Implicit Submission with {display:none} button

2011-09-24 Thread Dimitri Glazkov
Hi folks -- I wrote a fairly comprehensive test suite to capture al this a while back: http://trac.webkit.org/browser/trunk/LayoutTests/fast/forms/implicit-submission.html Hope it helps! :DG On Sat, Sep 24, 2011 at 1:52 PM, Ryosuke Niwa rn...@webkit.org wrote: On Sat, Sep 24, 2011 at 9:47 AM,

Re: [whatwg] HTMLForms: Implicit Submission with {display:none} button

2011-09-24 Thread Glenn Maynard
On Fri, Sep 23, 2011 at 2:52 PM, Ian Hickson i...@hixie.ch wrote: The strict answer is that it's up to the browsers; the spec allows browsers to do whatever they think is appropriate per their platform's conventions. So both behaviours are compliant. Nothing in 4.10.22.2 Implicit submission

Re: [whatwg] HTMLForms: Implicit Submission with {display:none} button

2011-09-24 Thread Ryosuke Niwa
On Sat, Sep 24, 2011 at 4:55 PM, Glenn Maynard gl...@zewt.org wrote: On Sat, Sep 24, 2011 at 12:47 PM, Ryosuke Niwa rn...@webkit.org wrote: However, it doesn't submit when we have: - Two text fields with one display:none submit button ... Another outlier: Android's WebKit, at least in

[whatwg] HTMLForms: Implicit Submission with {display:none} button

2011-09-23 Thread Kaustubh Atrawalkar
Hi, There is an issue regarding form submit button which is little unclear from the specs mentioned in here http://www.whatwg.org/specs/web-apps/cu ... submission If the form has submit button with display property as none, will that form should be implicitly submitted on pressing enter key? This

Re: [whatwg] HTMLForms: Implicit Submission with {display:none} button

2011-09-23 Thread Ian Hickson
On Fri, 23 Sep 2011, Kaustubh Atrawalkar wrote: There is an issue regarding form submit button which is little unclear from the specs [...] If the form has submit button with display property as none, will that form should be implicitly submitted on pressing enter key? This works in

Re: [whatwg] HTMLForms: Implicit Submission with {display:none} button

2011-09-23 Thread Kaustubh Atrawalkar
If the form has submit button with display property as none, will that form should be implicitly submitted on pressing enter key? This works in Opera Firefox but does not work in IE Safari as of now. What is the expected behavior for this? The strict answer is that it's up to the