Re: [Wikitech-l] Checkered background on file description pages

2011-01-30 Thread Ashar Voultoiz
On 29/01/11 17:46, Krinkle wrote: snip Compare the following two pages (when logged out): * http://commons.wikimedia.org/wiki/File:A-gunner.gif * http://commons.wikimedia.org/wiki/File:A-gunner.svg We could remove the checker by default (pleasing the reader) and add a button to reveal the

Re: [Wikitech-l] Re sourceLoader + Windows + PHP bug 47689

2011-01-30 Thread Ilmari Karonen
On 01/29/2011 04:06 AM, Aaron Schulz wrote: In JavaScriptDistiller, inside of the createParser() function, we have: $parser-add( '/\\/\\*(.|[\\r\\n])*?\\*\\//' ); It took me hours to track down that this was causing Apache 2.1.11 to crash on nearly any page view on my test wiki. This

Re: [Wikitech-l] File licensing information support

2011-01-30 Thread Bryan Tong Minh
Hi, There have been a lot of mails since I last had the the time to reply, so I'll reply to some points in a single mail. On Sat, Jan 22, 2011 at 9:04 PM, Platonides platoni...@gmail.com wrote: An internally handled parser function doesn't conflict with showing it as a textbox. We could for

Re: [Wikitech-l] Re sourceLoader + Windows + PHP bug 47689

2011-01-30 Thread Platonides
Ilmari Karonen wrote: Hmm... I don't really know what's going on inside PHP's PCRE implementation, but you might want to try replacing that regexp with: $parser-add( '/\\/\\*.*?\\*\\//s' ); The add()s are combined into a single big regex, you can't set dot-all. Doing it with (?s) may be

Re: [Wikitech-l] Re sourceLoader + Windows + PHP bug 47689

2011-01-30 Thread Ilmari Karonen
On 01/30/2011 04:16 PM, Platonides wrote: Ilmari Karonen wrote: Hmm... I don't really know what's going on inside PHP's PCRE implementation, but you might want to try replacing that regexp with: $parser-add( '/\\/\\*.*?\\*\\//s' ); The add()s are combined into a single big regex, you

Re: [Wikitech-l] Farewell JSMin, Hello JavaScriptDistiller!

2011-01-30 Thread Brion Vibber
I noticed a regression in the JS minification with a bit of sloppy third-party code being imported through ResourceLoader in SVGEdit: https://bugzilla.wikimedia.org/show_bug.cgi?id=27046 I can work around it in the extension, but we should watch out and make sure we've got regression tests

Re: [Wikitech-l] Checkered background on file description pages

2011-01-30 Thread MZMcBride
Erik Moeller wrote: A simple show/hide transparency toggle for media with an alpha channel would be a nice standard solution. Defaults for a media repository like Wikimedia Commons could reasonably differ from those for a general reference source like Wikipedia, as typical user intentions are

Re: [Wikitech-l] Inclusion request for the Validator extension

2011-01-30 Thread Jeroen De Dauw
Hey, From the looks of the code, Validator, and various Validator based extensions appear to be using parser-parse() inside of hooks where they are supposed to be using -recursiveTagParse with a proper frame. I was not aware of the correct approach here apparently. I had a look at the docs and

Re: [Wikitech-l] Re sourceLoader + Windows + PHP bug 47689

2011-01-30 Thread Maciej Jaros
Ilmari Karonen (2011-01-30 15:19): On 01/30/2011 04:16 PM, Platonides wrote: Ilmari Karonen wrote: Hmm... I don't really know what's going on inside PHP's PCRE implementation, but you might want to try replacing that regexp with: $parser-add( '/\\/\\*.*?\\*\\//s' ); The add()s are