[MediaWiki-CodeReview] [MediaWiki r89452]: Revision status changed

2011-06-04 Thread MediaWiki Mail
User MaxSem changed the status of MediaWiki.r89452. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89452#c0 Commit summary: follow up r89278 — remove FTP support. ___ MediaWiki-CodeReview mailing list

Re: [Wikitech-l] IE6

2011-06-04 Thread Ashar Voultoiz
On 04/06/11 02:07, Mono mium wrote: I still supportinput type=crash. On a multiple millions visitors per day website, this is unacceptable. Most users do not even know what a 'browser' is. They just look at their computer desktop and double click the 'e' icon. Plus, 'internet explorer' sounds

[MediaWiki-CodeReview] [MediaWiki r89387]: Revision status changed

2011-06-04 Thread MediaWiki Mail
User MaxSem changed the status of MediaWiki.r89387. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89387#c0 Commit summary: Fix for r89166: need self ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r89451]: New comment added, and revision status changed

2011-06-04 Thread MediaWiki Mail
User Hashar changed the status of MediaWiki.r89451. Old Status: new New Status: ok User Hashar also posted a comment on MediaWiki.r89451. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89451#c17580 Commit summary: Followup r88124: fix the most glaring bug of the week Comment:

[MediaWiki-CodeReview] [MediaWiki r89455]: Revision status changed

2011-06-04 Thread MediaWiki Mail
User Reedy changed the status of MediaWiki.r89455. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89455#c0 Commit summary: svn:eol-style native ___ MediaWiki-CodeReview mailing list

Re: [Wikitech-l] On the IE6 query string security check breakage (bug 28235)

2011-06-04 Thread Tim Starling
On 04/06/11 03:53, Brion Vibber wrote: On Thu, Jun 2, 2011 at 5:21 PM, Tim Starling tstarl...@wikimedia.orgwrote: The main issue here is that we don't a wide variety of web servers set up for testing. We know that Apache lets you detect %2E versus dot via $_SERVER['REQUEST_URI'], but we don't

[MediaWiki-CodeReview] [MediaWiki r89359]: Revision status changed

2011-06-04 Thread MediaWiki Mail
User Krinkle changed the status of MediaWiki.r89359. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89359#c0 Commit summary: (bug 29117) A string is missing when the UI is in Hebrew Backport r88658 ___

[MediaWiki-CodeReview] [MediaWiki r89420]: Revision status changed

2011-06-04 Thread MediaWiki Mail
User Krinkle changed the status of MediaWiki.r89420. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89420#c0 Commit summary: Extension to r89419, removing a bugous CSS code ___ MediaWiki-CodeReview

[MediaWiki-CodeReview] [MediaWiki r89401]: Revision status changed

2011-06-04 Thread MediaWiki Mail
User Krinkle changed the status of MediaWiki.r89401. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89401#c0 Commit summary: (bug 29121) jquery.suggestions uses jquery.autoEllipsis but didn't have it in its dependency list, causing JS errors in

[MediaWiki-CodeReview] [MediaWiki r89406]: New comment added

2011-06-04 Thread MediaWiki Mail
User Happy-melon posted a comment on MediaWiki.r89406. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89406#c17581 Commit summary: Start unpicking r85288 (magic __get() accessor for RequestContext). Instead, bring back some of r86872 (abstract base class for classes providing

[MediaWiki-CodeReview] [MediaWiki r87164]: New comment added, and revision status changed

2011-06-04 Thread MediaWiki Mail
User Krinkle changed the status of MediaWiki.r87164. Old Status: new New Status: fixme User Krinkle also posted a comment on MediaWiki.r87164. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87164#c17582 Commit summary: Recommit r87129 and follow-ups but with a fix for the bug

[MediaWiki-CodeReview] [MediaWiki r87164]: New comment added, and revision status changed

2011-06-04 Thread MediaWiki Mail
User Krinkle changed the status of MediaWiki.r87164. Old Status: fixme New Status: new User Krinkle also posted a comment on MediaWiki.r87164. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87164#c17583 Commit summary: Recommit r87129 and follow-ups but with a fix for the bug

[MediaWiki-CodeReview] [MediaWiki r89419]: New comment added

2011-06-04 Thread MediaWiki Mail
User Huji posted a comment on MediaWiki.r89419. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89419#c17584 Commit summary: (bug 29263) Add LTR class to the shared CSS to be used for left-to-right text such as SQL queries shown in dberrortext and similiar messages in RTL

[MediaWiki-CodeReview] [MediaWiki r89408]: New comment added

2011-06-04 Thread MediaWiki Mail
User Nikerabbit posted a comment on MediaWiki.r89408. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89408#c17585 Commit summary: More unpicking of r85288. I think this is all of the magic method calls, but they're very hard to grep for (part of the problem with them!), so

[MediaWiki-CodeReview] [MediaWiki r89421]: Revision status changed

2011-06-04 Thread MediaWiki Mail
User Krinkle changed the status of MediaWiki.r89421. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89421#c0 Commit summary: Extension to r89419, I was too excited fixing the bug ___ MediaWiki-CodeReview

[MediaWiki-CodeReview] [MediaWiki r89466]: Revision status changed

2011-06-04 Thread MediaWiki Mail
User Krinkle changed the status of MediaWiki.r89466. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89466#c0 Commit summary: Follow up to r89419: Per Brion's comment on Code Review, a generically named ltr class is created and used to reduce the

[MediaWiki-CodeReview] [MediaWiki r89419]: Revision status changed

2011-06-04 Thread MediaWiki Mail
User Krinkle changed the status of MediaWiki.r89419. Old Status: fixme New Status: new Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89419#c0 Commit summary: (bug 29263) Add LTR class to the shared CSS to be used for left-to-right text such as SQL queries shown in dberrortext

[MediaWiki-CodeReview] [MediaWiki r89440]: Revision status changed

2011-06-04 Thread MediaWiki Mail
User Krinkle changed the status of MediaWiki.r89440. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89440#c0 Commit summary: Localisation updates for ToolserverI18N messages from translatewiki.net (2011-06-03 20:33:00 UTC)

[MediaWiki-CodeReview] [MediaWiki r89459]: New comment added, and revision status changed

2011-06-04 Thread MediaWiki Mail
User Krinkle changed the status of MediaWiki.r89459. Old Status: new New Status: fixme User Krinkle also posted a comment on MediaWiki.r89459. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89459#c17586 Commit summary: Add Jarry1250's Translate tool Possibly completely wrong,

[MediaWiki-CodeReview] [MediaWiki r89459]: New comment added, and revision status changed

2011-06-04 Thread MediaWiki Mail
User Krinkle changed the status of MediaWiki.r89459. Old Status: fixme New Status: ok User Krinkle also posted a comment on MediaWiki.r89459. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89459#c17587 Commit summary: Add Jarry1250's Translate tool Possibly completely wrong,

[MediaWiki-CodeReview] [MediaWiki r89464]: New comment added

2011-06-04 Thread MediaWiki Mail
User IAlex posted a comment on MediaWiki.r89464. Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/89464#c17588 Commit summary: Fixing fixme in r87164 (wrong if check) Comment: Thanks for the fix! ___

[MediaWiki-CodeReview] [MediaWiki r89470]: New comment added

2011-06-04 Thread MediaWiki Mail
User Krinkle posted a comment on MediaWiki.r89470. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89470#c17589 Commit summary: TsIntuition fixes * Re-alphabetize order Domains.php (r89459) * Synchronize Optional and Ignore marks between comments after ['en'], templates in

[MediaWiki-CodeReview] [MediaWiki r89402]: Revision status changed

2011-06-04 Thread MediaWiki Mail
User Krinkle changed the status of MediaWiki.r89402. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89402#c0 Commit summary: (bug 29104) Fix r86622: make splitlines default to false, makes much more sense

[Wikitech-l] Showing stub links by default - is it possible in a Wikimedia project?

2011-06-04 Thread Tisza Gergö
Hi all, MediaWiki has a user setting to add a CSS class to article links whose length is below a certain threshold (preferences/appearance/advanced options/threshold for stub link formatting). Is it possible to enable this by default on a Wikimedia wiki? Some of the advantages: - a lot of

[MediaWiki-CodeReview] [MediaWiki r89419]: Revision status changed

2011-06-04 Thread MediaWiki Mail
User Krinkle changed the status of MediaWiki.r89419. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89419#c0 Commit summary: (bug 29263) Add LTR class to the shared CSS to be used for left-to-right text such as SQL queries shown in dberrortext and

[MediaWiki-CodeReview] [MediaWiki r88301]: New comment added

2011-06-04 Thread MediaWiki Mail
User Solitarius posted a comment on MediaWiki.r88301. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/88301#c17592 Commit summary: Added UTF-8 encoding for data retrieved from DB Comment: In my MSSQLBackCompat external databases, nvarchar() columns are already encoded in utf-8.

Re: [Wikitech-l] [Foundation-l] YouTube and Creative Commons

2011-06-04 Thread emijrp
A nice script to download YouTube videos is youtube-dl[1]. Link that with a flv/mp4 - ogg converter and an uploader to Commons is trivial. [1] http://rg3.github.com/youtube-dl/ 2011/6/4 Michael Dale md...@wikimedia.org Comments inline: On Fri, Jun 3, 2011 at 4:51 PM, Brion Vibber

[MediaWiki-CodeReview] [MediaWiki r89408]: New comment added

2011-06-04 Thread MediaWiki Mail
User Platonides posted a comment on MediaWiki.r89408. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89408#c17593 Commit summary: More unpicking of r85288. I think this is all of the magic method calls, but they're very hard to grep for (part of the problem with them!), so

[MediaWiki-CodeReview] [MediaWiki r89408]: New comment added

2011-06-04 Thread MediaWiki Mail
User Platonides posted a comment on MediaWiki.r89408. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89408#c17594 Commit summary: More unpicking of r85288. I think this is all of the magic method calls, but they're very hard to grep for (part of the problem with them!), so

[MediaWiki-CodeReview] [MediaWiki r89292]: Revision status changed

2011-06-04 Thread MediaWiki Mail
User ^demon changed the status of MediaWiki.r89292. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89292#c0 Commit summary: Tweak HttpTest following r89278: * remove FTP test case URL (shouldn't actually work, and as a directory listing, not super

[MediaWiki-CodeReview] [MediaWiki r89408]: New comment added

2011-06-04 Thread MediaWiki Mail
User Happy-melon posted a comment on MediaWiki.r89408. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89408#c17595 Commit summary: More unpicking of r85288. I think this is all of the magic method calls, but they're very hard to grep for (part of the problem with them!), so

[MediaWiki-CodeReview] [MediaWiki r89408]: New comment added

2011-06-04 Thread MediaWiki Mail
User Happy-melon posted a comment on MediaWiki.r89408. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89408#c17596 Commit summary: More unpicking of r85288. I think this is all of the magic method calls, but they're very hard to grep for (part of the problem with them!), so

[MediaWiki-CodeReview] [MediaWiki r89472]: Revision status changed

2011-06-04 Thread MediaWiki Mail
User Reedy changed the status of MediaWiki.r89472. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89472#c0 Commit summary: Adding my USERINFO file. ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r89472]: New comment added

2011-06-04 Thread MediaWiki Mail
User Reedy posted a comment on MediaWiki.r89472. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89472#c17597 Commit summary: Adding my USERINFO file. Comment: Yay. Tied your SVN account in with your MW account :) ___

[MediaWiki-CodeReview] [MediaWiki r89471]: New comment added

2011-06-04 Thread MediaWiki Mail
User Reedy posted a comment on MediaWiki.r89471. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89471#c17598 Commit summary: Add BlockTest to the tests autoloader. Needed by ApiBlockTest.php Added tabs to other items (compare ignoring whitespace). Comment: Have you purposely

[MediaWiki-CodeReview] [MediaWiki r89408]: New comment added

2011-06-04 Thread MediaWiki Mail
User Platonides posted a comment on MediaWiki.r89408. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89408#c17599 Commit summary: More unpicking of r85288. I think this is all of the magic method calls, but they're very hard to grep for (part of the problem with them!), so

[MediaWiki-CodeReview] [MediaWiki r89408]: New comment added

2011-06-04 Thread MediaWiki Mail
User Platonides posted a comment on MediaWiki.r89408. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89408#c17600 Commit summary: More unpicking of r85288. I think this is all of the magic method calls, but they're very hard to grep for (part of the problem with them!), so

[MediaWiki-CodeReview] [MediaWiki r89474]: New comment added, and revision status changed

2011-06-04 Thread MediaWiki Mail
User Reedy changed the status of MediaWiki.r89474. Old Status: new New Status: fixme User Reedy also posted a comment on MediaWiki.r89474. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89474#c17601 Commit summary: Follow up r89408. Magic lang to getLang(). Comment: ialex

[MediaWiki-CodeReview] [MediaWiki r89474]: New comment added, and revision status changed

2011-06-04 Thread MediaWiki Mail
User IAlex changed the status of MediaWiki.r89474. Old Status: fixme New Status: new User IAlex also posted a comment on MediaWiki.r89474. Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/89474#c17602 Commit summary: Follow up r89408. Magic lang to

[MediaWiki-CodeReview] [MediaWiki r89479]: New comment added, and revision status changed

2011-06-04 Thread MediaWiki Mail
User MaxSem changed the status of MediaWiki.r89479. Old Status: new New Status: fixme User MaxSem also posted a comment on MediaWiki.r89479. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89479#c17603 Commit summary: Also support macports Comment: Did you mean tthas_binary

[MediaWiki-CodeReview] [MediaWiki r89254]: Revision status changed

2011-06-04 Thread MediaWiki Mail
User MaxSem changed the status of MediaWiki.r89254. Old Status: new New Status: reverted Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89254#c0 Commit summary: * trying to create a way to update/install extension already included in the LocalSettings.php * wgHooks and

[MediaWiki-CodeReview] [MediaWiki r89481]: Revision status changed

2011-06-04 Thread MediaWiki Mail
User Krinkle changed the status of MediaWiki.r89481. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89481#c0 Commit summary: Revert r89254: * It breaks if any extension uses any global except $IP, $wgHooks or $wgAutoloadClasses. Some unit tests

[MediaWiki-CodeReview] [MediaWiki r89481]: New comment added, and revision status changed

2011-06-04 Thread MediaWiki Mail
User MaxSem changed the status of MediaWiki.r89481. Old Status: ok New Status: new User MaxSem also posted a comment on MediaWiki.r89481. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89481#c17604 Commit summary: Revert r89254: * It breaks if any extension uses any global

[MediaWiki-CodeReview] [MediaWiki r89481]: Revision status changed

2011-06-04 Thread MediaWiki Mail
User ^demon changed the status of MediaWiki.r89481. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89481#c0 Commit summary: Revert r89254: * It breaks if any extension uses any global except $IP, $wgHooks or $wgAutoloadClasses. Some unit tests

Re: [Wikitech-l] Showing stub links by default - is it possible in a Wikimedia project?

2011-06-04 Thread Platonides
Tisza Gergö wrote: Hi all, MediaWiki has a user setting to add a CSS class to article links whose length is below a certain threshold (preferences/appearance/advanced options/threshold for stub link formatting). Is it possible to enable this by default on a Wikimedia wiki? No. Currently

[MediaWiki-CodeReview] [MediaWiki r89475]: New comment added

2011-06-04 Thread MediaWiki Mail
User ^demon posted a comment on MediaWiki.r89475. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89475#c17605 Commit summary: Added missing $PAGEEDITTIME replacement for impersonal mails Comment: Every time I see this I cry a little bit inside.

[MediaWiki-CodeReview] [MediaWiki r89476]: New comment added

2011-06-04 Thread MediaWiki Mail
User Krinkle posted a comment on MediaWiki.r89476. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89476#c17606 Commit summary: Fix for r89475: let's make this correctly Comment: Is $timecorrection not needed anymore ? ___

Re: [Wikitech-l] [Foundation-l] YouTube and Creative Commons

2011-06-04 Thread David Gerard
On 4 June 2011 17:47, Michael Dale md...@wikimedia.org wrote: On Fri, Jun 3, 2011 at 4:51 PM, Brion Vibber br...@pobox.com wrote: There's been some ongoing work on TimedMediaHandler extension which will replace the older OggHandler Yes, been hammering away on associated bugs. People can help

[MediaWiki-CodeReview] [MediaWiki r89476]: New comment added

2011-06-04 Thread MediaWiki Mail
User IAlex posted a comment on MediaWiki.r89476. Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/89476#c17607 Commit summary: Fix for r89475: let's make this correctly Comment: This was a copy/paste error. We are in sendImpersonal() here, so we need to