[MediaWiki-CodeReview] [MediaWiki r89482]: Revision status changed

2011-06-05 Thread MediaWiki Mail
User MaxSem changed the status of MediaWiki.r89482. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89482#c0 Commit summary: - Added messages - Several small fixes and improvements ___

[Wikitech-l] 2 new committers!

2011-06-05 Thread Chad
Just created two more accounts in SVN: Patrick Nagel - nagelp - Semantic MediaWiki stuff Guillaume Paumier - gpaumier - WMF staff, maintaining the blogs' skin Welcome :) -Chad ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org

[MediaWiki-CodeReview] [MediaWiki r89408]: New comment added

2011-06-05 Thread MediaWiki Mail
User Nikerabbit posted a comment on MediaWiki.r89408. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89408#c17608 Commit summary: More unpicking of r85288. I think this is all of the magic method calls, but they're very hard to grep for (part of the problem with them!), so

[MediaWiki-CodeReview] [MediaWiki r89408]: New comment added

2011-06-05 Thread MediaWiki Mail
User ^demon posted a comment on MediaWiki.r89408. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89408#c17609 Commit summary: More unpicking of r85288. I think this is all of the magic method calls, but they're very hard to grep for (part of the problem with them!), so let's

[MediaWiki-CodeReview] [MediaWiki r89408]: New comment added

2011-06-05 Thread MediaWiki Mail
User Nikerabbit posted a comment on MediaWiki.r89408. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89408#c17610 Commit summary: More unpicking of r85288. I think this is all of the magic method calls, but they're very hard to grep for (part of the problem with them!), so

[MediaWiki-CodeReview] [MediaWiki r89408]: New comment added

2011-06-05 Thread MediaWiki Mail
User ^demon posted a comment on MediaWiki.r89408. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89408#c17611 Commit summary: More unpicking of r85288. I think this is all of the magic method calls, but they're very hard to grep for (part of the problem with them!), so let's

[MediaWiki-CodeReview] [MediaWiki r89408]: New comment added

2011-06-05 Thread MediaWiki Mail
User Nikerabbit posted a comment on MediaWiki.r89408. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89408#c17612 Commit summary: More unpicking of r85288. I think this is all of the magic method calls, but they're very hard to grep for (part of the problem with them!), so

[MediaWiki-CodeReview] [MediaWiki r89408]: New comment added

2011-06-05 Thread MediaWiki Mail
User ^demon posted a comment on MediaWiki.r89408. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89408#c17613 Commit summary: More unpicking of r85288. I think this is all of the magic method calls, but they're very hard to grep for (part of the problem with them!), so let's

[MediaWiki-CodeReview] [MediaWiki r89388]: Revision status changed

2011-06-05 Thread MediaWiki Mail
User Hashar changed the status of MediaWiki.r89388. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89388#c0 Commit summary: Kill $wgWikiFarm. Only use in a wmf code path, and I can't find any evidence of this being use in WMF anywhere.

[MediaWiki-CodeReview] [MediaWiki r79769]: Revision status changed

2011-06-05 Thread MediaWiki Mail
User Hashar changed the status of MediaWiki.r79769. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/79769#c0 Commit summary: add comment per bug 17961 ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r79795]: Revision status changed

2011-06-05 Thread MediaWiki Mail
User Hashar changed the status of MediaWiki.r79795. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/79795#c0 Commit summary: [[user:Microchip08]] suggested that it'd be cool if special:contribs redirected to special:contributions. I also think it'd

[MediaWiki-CodeReview] [MediaWiki r80024]: Revision status changed

2011-06-05 Thread MediaWiki Mail
User Hashar changed the status of MediaWiki.r80024. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/80024#c0 Commit summary: Add tests for parser tag hooks. ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r80180]: Revision status changed

2011-06-05 Thread MediaWiki Mail
User Hashar changed the status of MediaWiki.r80180. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/80180#c0 Commit summary: Allow to disable the preprocessor cache with $wgPreprocessorCacheThreshold = false

[MediaWiki-CodeReview] [MediaWiki r80407]: New comment added

2011-06-05 Thread MediaWiki Mail
User Hashar posted a comment on MediaWiki.r80407. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/80407#c17617 Commit summary: (bug 2585) Image pages should send 404 if no image, no shared image and no description page (To be consistant with how non-existant article pages act).

[MediaWiki-CodeReview] [MediaWiki r81024]: Revision status changed

2011-06-05 Thread MediaWiki Mail
User Hashar changed the status of MediaWiki.r81024. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/81024#c0 Commit summary: Changed rule messages-mediawiki-* to messages-* since mediawiki here is the database name

[MediaWiki-CodeReview] [MediaWiki r89277]: New comment added, and revision status changed

2011-06-05 Thread MediaWiki Mail
User Krinkle changed the status of MediaWiki.r89277. Old Status: new New Status: fixme User Krinkle also posted a comment on MediaWiki.r89277. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89277#c17618 Commit summary: Added 'problem articles' view to dashboard; refactored

[MediaWiki-CodeReview] [MediaWiki r88277]: Revision status changed

2011-06-05 Thread MediaWiki Mail
User Hashar changed the status of MediaWiki.r88277. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/88277#c0 Commit summary: Update deprecated shortcuts to current values as of 2011-version of QUnit * equals - equal * same - deepEqual

[MediaWiki-CodeReview] [MediaWiki r87898]: Revision status changed

2011-06-05 Thread MediaWiki Mail
User Hashar changed the status of MediaWiki.r87898. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87898#c0 Commit summary: Continue implementation QUnit/TestSwarm integration (bug 28915) -- For now static html files. I have considered using

[MediaWiki-CodeReview] [MediaWiki r89277]: New comment added

2011-06-05 Thread MediaWiki Mail
User Krinkle posted a comment on MediaWiki.r89277. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89277#c17619 Commit summary: Added 'problem articles' view to dashboard; refactored dashboard code (populateAFStatistics.php, primarily); Added new schema sql scripts as well as

[MediaWiki-CodeReview] [MediaWiki r89277]: New comment added, and revision status changed

2011-06-05 Thread MediaWiki Mail
User Krinkle changed the status of MediaWiki.r89277. Old Status: fixme New Status: new User Krinkle also posted a comment on MediaWiki.r89277. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89277#c17620 Commit summary: Added 'problem articles' view to dashboard; refactored

[MediaWiki-CodeReview] [MediaWiki r86799]: Revision status changed

2011-06-05 Thread MediaWiki Mail
User Hashar changed the status of MediaWiki.r86799. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86799#c0 Commit summary: Move patch contributors to the right section Remove Jan Paul and Derk-Jan Hartman from patch contributors as they're

[MediaWiki-CodeReview] [MediaWiki r86770]: Revision status changed

2011-06-05 Thread MediaWiki Mail
User Hashar changed the status of MediaWiki.r86770. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86770#c0 Commit summary: Documentation Fix call to undefined self::getTitleFor ___ MediaWiki-CodeReview

[MediaWiki-CodeReview] [MediaWiki r86712]: Revision status changed

2011-06-05 Thread MediaWiki Mail
User Hashar changed the status of MediaWiki.r86712. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86712#c0 Commit summary: Update StartProfiler.sample after r86175 ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r86373]: New comment added

2011-06-05 Thread MediaWiki Mail
User Hashar posted a comment on MediaWiki.r86373. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86373#c17621 Commit summary: Removed action=print; I can't find anything using this Comment: I think it was used by the old skins and got replaced by printable=yes

[MediaWiki-CodeReview] [MediaWiki r86220]: Revision status changed

2011-06-05 Thread MediaWiki Mail
User Hashar changed the status of MediaWiki.r86220. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86220#c0 Commit summary: Consistent casing for PLURAL. ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r85204]: Revision status changed

2011-06-05 Thread MediaWiki Mail
User Hashar changed the status of MediaWiki.r85204. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85204#c0 Commit summary: Made index.php's profiling cosistent with other entry scripts ___

[MediaWiki-CodeReview] [MediaWiki r83882]: Revision status changed

2011-06-05 Thread MediaWiki Mail
User Hashar changed the status of MediaWiki.r83882. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/83882#c0 Commit summary: Follow-up r83855: MessagesQqq documentation ___ MediaWiki-CodeReview mailing

[MediaWiki-CodeReview] [MediaWiki r89198]: New comment added

2011-06-05 Thread MediaWiki Mail
User Krinkle posted a comment on MediaWiki.r89198. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89198#c17622 Commit summary: Suppress AFT from all print outputs. I am adding a @media rule, but also suppressing rendering of the widget in the printable version (which does not

[MediaWiki-CodeReview] [MediaWiki r89198]: New comment added

2011-06-05 Thread MediaWiki Mail
User Krinkle posted a comment on MediaWiki.r89198. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89198#c17623 Commit summary: Suppress AFT from all print outputs. I am adding a @media rule, but also suppressing rendering of the widget in the printable version (which does not

Re: [Wikitech-l] Showing stub links by default - is it possible in a Wikimedia project?

2011-06-05 Thread Nemo
Platonides writes: No. Currently it would mean not caching any page view. The feature would need to be adapted to allow efficient stub linking (I have some ideas about it, and the new linker makes things easier). Still, we might not allow stub links for anons in miser mode. Feel free to

Re: [Wikitech-l] Showing stub links by default - is it possible in a Wikimedia project?

2011-06-05 Thread Tisza Gergö
Platonides Platonides at gmail.com writes: Feel free to open a bug. Thanks, did so: https://bugzilla.wikimedia.org/show_bug.cgi?id=29276 ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org

[MediaWiki-CodeReview] [MediaWiki r89092]: Revision status changed

2011-06-05 Thread MediaWiki Mail
User Reedy changed the status of MediaWiki.r89092. Old Status: new New Status: deferred Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89092#c0 Commit summary: Followup r88598, seems 2 files didn't get commited ___

[MediaWiki-CodeReview] [MediaWiki r89470]: Revision status changed

2011-06-05 Thread MediaWiki Mail
User Krinkle changed the status of MediaWiki.r89470. Old Status: new New Status: deferred Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89470#c0 Commit summary: TsIntuition fixes * Re-alphabetize order Domains.php (r89459) * Synchronize Optional and Ignore marks between

[MediaWiki-CodeReview] [MediaWiki r89503]: Revision status changed

2011-06-05 Thread MediaWiki Mail
User Hashar changed the status of MediaWiki.r89503. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89503#c0 Commit summary: Adding method documentation Add a couple of explicit variable definitions Add some braces Add one false; to return under

[MediaWiki-CodeReview] [MediaWiki r89505]: Revision status changed

2011-06-05 Thread MediaWiki Mail
User Hashar changed the status of MediaWiki.r89505. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89505#c0 Commit summary: * (bug 29265) Mediawiki API documentation incomplete Add text about erroneous requests when sent to the api Remove extra

[MediaWiki-CodeReview] [MediaWiki r89506]: Revision status changed

2011-06-05 Thread MediaWiki Mail
User Hashar changed the status of MediaWiki.r89506. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89506#c0 Commit summary: Add missing word to r89505 ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r89477]: Revision status changed

2011-06-05 Thread MediaWiki Mail
User Hashar changed the status of MediaWiki.r89477. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89477#c0 Commit summary: Fix for r89474: added missing () to function call ___ MediaWiki-CodeReview

[MediaWiki-CodeReview] [MediaWiki r89500]: Revision status changed

2011-06-05 Thread MediaWiki Mail
User ^demon changed the status of MediaWiki.r89500. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89500#c0 Commit summary: Added blog per request on meta ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r89508]: Revision status changed

2011-06-05 Thread MediaWiki Mail
User Reedy changed the status of MediaWiki.r89508. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89508#c0 Commit summary: r88879, r89022: eol-style ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r89343]: Revision status changed

2011-06-05 Thread MediaWiki Mail
User Hashar changed the status of MediaWiki.r89343. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89343#c0 Commit summary: Added -Wname and -Wno-name parameters to configure the desired warnings Disable by default evil-@ and missed-docblock

[MediaWiki-CodeReview] [MediaWiki r89300]: New comment added

2011-06-05 Thread MediaWiki Mail
User Hashar posted a comment on MediaWiki.r89300. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89300#c17625 Commit summary: Add some doc comments on Cookie::validateCookieDomain() and Http::isValidUri(), which both have some failing test cases and are incomplete Comment:

[MediaWiki-CodeReview] [MediaWiki r88256]: Revision status changed

2011-06-05 Thread MediaWiki Mail
User Hashar changed the status of MediaWiki.r88256. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/88256#c0 Commit summary: * Changed load order in QUnit to mirror the order in MediaWiki itself. * Added testswarm.inject.js to SVN (Follow-up r87899)

[MediaWiki-CodeReview] [MediaWiki r88139]: New comment added, and revision status changed

2011-06-05 Thread MediaWiki Mail
User Hashar changed the status of MediaWiki.r88139. Old Status: new New Status: ok User Hashar also posted a comment on MediaWiki.r88139. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/88139#c17626 Commit summary: Add 'hash' = array( 'class' = 'HashBagOStuff' ) to

[MediaWiki-CodeReview] [MediaWiki r82807]: Revision status changed

2011-06-05 Thread MediaWiki Mail
User ^demon changed the status of MediaWiki.r82807. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/82807#c0 Commit summary: Implement getRequireOnlyOneParameterErrorMessages, to make the error messages requireOnlyOneParameter can throw. Use in 4

[MediaWiki-CodeReview] [MediaWiki r87687]: Revision status changed

2011-06-05 Thread MediaWiki Mail
User Hashar changed the status of MediaWiki.r87687. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87687#c0 Commit summary: Documentation Remove long deprecated isBot()/isSysop() in ApiMain ___

[MediaWiki-CodeReview] [MediaWiki r89497]: New comment added

2011-06-05 Thread MediaWiki Mail
User Jack Phoenix posted a comment on MediaWiki.r89497. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89497#c17627 Commit summary: sql request Comment: pre +CREATE TABLE IF NOT EXISTS `user_status` ( /pre We don't normally include the codeIF NOT EXISTS/code clause in our table

[MediaWiki-CodeReview] [MediaWiki r89499]: New comment added

2011-06-05 Thread MediaWiki Mail
User Jack Phoenix posted a comment on MediaWiki.r89499. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89499#c17628 Commit summary: Comment: Where's the commit message? ;-) There are a few [[Manual:Coding conventions|coding style]] issues, but since this is a work in

[MediaWiki-CodeReview] [MediaWiki r89498]: Revision status changed

2011-06-05 Thread MediaWiki Mail
User Jack Phoenix changed the status of MediaWiki.r89498. Old Status: new New Status: resolved Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89498#c0 Commit summary: info about this folder ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r88139]: New comment added

2011-06-05 Thread MediaWiki Mail
User Bryan posted a comment on MediaWiki.r88139. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/88139#c17629 Commit summary: Add 'hash' = array( 'class' = 'HashBagOStuff' ) to $wgObjectCaches; greatly speeds up importDump.php Comment: There are as far as I know no binaries for

[MediaWiki-CodeReview] [MediaWiki r87974]: Revision status changed

2011-06-05 Thread MediaWiki Mail
User ^demon changed the status of MediaWiki.r87974. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87974#c0 Commit summary: Followup r87942, fix svn props ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r84650]: Revision status changed

2011-06-05 Thread MediaWiki Mail
User ^demon changed the status of MediaWiki.r84650. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/84650#c0 Commit summary: Delete daft WebStoreStart.php file ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r89320]: Revision status changed

2011-06-05 Thread MediaWiki Mail
User ^demon changed the status of MediaWiki.r89320. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89320#c0 Commit summary: Further clarify revreview-tt-reject ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r89331]: Revision status changed

2011-06-05 Thread MediaWiki Mail
User ^demon changed the status of MediaWiki.r89331. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89331#c0 Commit summary: follow-up to r89329: rename 'roa-rup' to 'rup' in extension translations ___

[MediaWiki-CodeReview] [MediaWiki r89209]: Revision status changed

2011-06-05 Thread MediaWiki Mail
User ^demon changed the status of MediaWiki.r89209. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89209#c0 Commit summary: chg colour name from X11/CSS3 springgreen to hex notation as suggested ___

[MediaWiki-CodeReview] [MediaWiki r89266]: Revision status changed

2011-06-05 Thread MediaWiki Mail
User ^demon changed the status of MediaWiki.r89266. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89266#c0 Commit summary: * (bug 28767) Internal error on Special:CentralAuth/username ___

[MediaWiki-CodeReview] [MediaWiki r84993]: Revision status changed

2011-06-05 Thread MediaWiki Mail
User ^demon changed the status of MediaWiki.r84993. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/84993#c0 Commit summary: Adding certificate check I'm using to test for expired certificates ___

[MediaWiki-CodeReview] [MediaWiki r86987]: Revision status changed

2011-06-05 Thread MediaWiki Mail
User ^demon changed the status of MediaWiki.r86987. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86987#c0 Commit summary: Add DisableAccount to make-wmf-branch per r86932 CR ___ MediaWiki-CodeReview

[MediaWiki-CodeReview] [MediaWiki r88318]: Revision status changed

2011-06-05 Thread MediaWiki Mail
User ^demon changed the status of MediaWiki.r88318. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/88318#c0 Commit summary: Added blog per request on meta ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r88695]: Revision status changed

2011-06-05 Thread MediaWiki Mail
User ^demon changed the status of MediaWiki.r88695. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/88695#c0 Commit summary: Synchronize TestSwarm script. Looks like the previous version ignored the svn HEAD in /resources and only updated on a

[MediaWiki-CodeReview] [MediaWiki r88810]: Revision status changed

2011-06-05 Thread MediaWiki Mail
User ^demon changed the status of MediaWiki.r88810. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/88810#c0 Commit summary: Moved wfGetCaller(), wfGetAllCallers() and wfFormatStackFrame() near other related functions

[MediaWiki-CodeReview] [MediaWiki r88696]: Revision status changed

2011-06-05 Thread MediaWiki Mail
User ^demon changed the status of MediaWiki.r88696. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/88696#c0 Commit summary: Removing tests for no longer existing methods (Follow-up r88667). Should calm down TestSwarm.

[MediaWiki-CodeReview] [MediaWiki r88917]: Revision status changed

2011-06-05 Thread MediaWiki Mail
User ^demon changed the status of MediaWiki.r88917. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/88917#c0 Commit summary: Remove unused variables/globals Swap while to foreach ___ MediaWiki-CodeReview

Re: [Wikitech-l] Showing stub links by default - is it possible in a Wikimedia project?

2011-06-05 Thread MZMcBride
Aryeh Gregor wrote: It would be better if we could fix it so it didn't break caching at all, of course, such as by adding the coloring during a postprocessing stage, after the parser cache is invoked rather than before. There's a tracking bug about avoiding parser cache fragmentation:

[MediaWiki-CodeReview] [MediaWiki r88895]: Revision status changed

2011-06-05 Thread MediaWiki Mail
User ^demon changed the status of MediaWiki.r88895. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/88895#c0 Commit summary: Removed comment about the usage $wgTitle which is no longer true ___

[MediaWiki-CodeReview] [MediaWiki r88638]: Revision status changed

2011-06-05 Thread MediaWiki Mail
User ^demon changed the status of MediaWiki.r88638. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/88638#c0 Commit summary: Follow-up r88633: *Check useOnlyIfProtected() *Fixed URL param name typo added before commit

[MediaWiki-CodeReview] [MediaWiki r88930]: Revision status changed

2011-06-05 Thread MediaWiki Mail
User ^demon changed the status of MediaWiki.r88930. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/88930#c0 Commit summary: It's not just for 5.1! ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r88918]: Revision status changed

2011-06-05 Thread MediaWiki Mail
User ^demon changed the status of MediaWiki.r88918. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/88918#c0 Commit summary: Param documentation updates/added ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r88139]: New comment added

2011-06-05 Thread MediaWiki Mail
User Hashar posted a comment on MediaWiki.r88139. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/88139#c17631 Commit summary: Add 'hash' = array( 'class' = 'HashBagOStuff' ) to $wgObjectCaches; greatly speeds up importDump.php Comment: Might want XCache so :)

[MediaWiki-CodeReview] [MediaWiki r87706]: New comment added

2011-06-05 Thread MediaWiki Mail
User Hashar posted a comment on MediaWiki.r87706. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87706#c17634 Commit summary: Revert SQLite-related part of r87357: sauses SLQ errors, not needed Comment: Merged in 1.18 ___

[MediaWiki-CodeReview] [MediaWiki r87942]: New comment added

2011-06-05 Thread MediaWiki Mail
User Bryan posted a comment on MediaWiki.r87942. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87942#c17635 Commit summary: First checkin Comment: It's used for Wikimedia's thumb servers as far as I know. ___ MediaWiki-CodeReview

[MediaWiki-CodeReview] [MediaWiki r89524]: Revision status changed

2011-06-05 Thread MediaWiki Mail
User Reedy changed the status of MediaWiki.r89524. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89524#c0 Commit summary: Added PhpStorm project directory to ignores ___ MediaWiki-CodeReview mailing

Re: [Wikitech-l] Showing stub links by default - is it possible in a Wikimedia project?

2011-06-05 Thread Aryeh Gregor
On Sun, Jun 5, 2011 at 2:25 PM, MZMcBride z...@mzmcbride.com wrote: I think he's talking about changing the default value of $wgDefaultUserOptions's stubthreshold on a per-wiki basis. It's currently 0 everywhere, as far as I know. We could do that if we wanted to disable the parser cache for

[MediaWiki-CodeReview] [MediaWiki r87942]: New comment added

2011-06-05 Thread MediaWiki Mail
User RussNelson posted a comment on MediaWiki.r87942. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87942#c17636 Commit summary: First checkin Comment: As far as I know it's not used by Wikimedia's thumb servers. The thumb scaling cluster (which creates most thumbnails) is

[MediaWiki-CodeReview] [MediaWiki r87942]: New comment added

2011-06-05 Thread MediaWiki Mail
User RussNelson posted a comment on MediaWiki.r87942. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87942#c17637 Commit summary: First checkin Comment: It's all gone now, except for three nearly identical functions that I'd like to combine once I figure out how to deal with

[Wikitech-l] cruisecontrol for REL1_18

2011-06-05 Thread Ashar Voultoiz
Hello, I have shamelessly copy-pasted some code on cruisecontrol and enabled continuous integration for the REL1_18 branch. You can find it at the cruisecontrol entry point: http://ci.tesla.usability.wikimedia.org/cruisecontrol/ It comes without the tests in the 'Database' group

[MediaWiki-CodeReview] [MediaWiki r87942]: New comment added

2011-06-05 Thread MediaWiki Mail
User Bryan posted a comment on MediaWiki.r87942. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87942#c17638 Commit summary: First checkin Comment: I thought the 404 handler was part of WebStore, but a quick look through the config files shows that this is probably not the

[MediaWiki-CodeReview] [MediaWiki r89528]: New comment added, and revision status changed

2011-06-05 Thread MediaWiki Mail
User Bryan changed the status of MediaWiki.r89528. Old Status: new New Status: fixme User Bryan also posted a comment on MediaWiki.r89528. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89528#c17639 Commit summary: * (bug 22179) Internal use of API (FauxRequest) results in HTTP

Re: [Wikitech-l] about fixing broken tests in cruisecontrol

2011-06-05 Thread Ashar Voultoiz
On 01/06/11 19:28, Ashar Voultoiz wrote: Max Seminik raised the issue of codurr spamming the channel with a useless list of revisions that broke the tests. snip The long post is now available on mw.org : http://www.mediawiki.org/wiki/Fixing_broken_tests -- Ashar Voultoiz

[MediaWiki-CodeReview] [MediaWiki r89528]: New comment added, and revision status changed

2011-06-05 Thread MediaWiki Mail
User Reedy changed the status of MediaWiki.r89528. Old Status: fixme New Status: new User Reedy also posted a comment on MediaWiki.r89528. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89528#c17640 Commit summary: * (bug 22179) Internal use of API (FauxRequest) results in HTTP

[MediaWiki-CodeReview] [MediaWiki r89519]: Revision status changed

2011-06-05 Thread MediaWiki Mail
User Krinkle changed the status of MediaWiki.r89519. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89519#c0 Commit summary: Localisation updates for ToolserverI18N messages from translatewiki.net (2011-06-05 18:43:00 UTC)

Re: [Wikitech-l] Showing stub links by default - is it possible in a Wikimedia project?

2011-06-05 Thread Niklas Laxström
On 5 June 2011 21:09, Aryeh Gregor simetrical+wikil...@gmail.com wrote: On Sat, Jun 4, 2011 at 11:24 AM, Tisza Gergö gti...@gmail.com wrote: - a lot of editors seem to use it already to find articles which need some care, and currently it slows down page loading for them because it breaks

[MediaWiki-CodeReview] [MediaWiki r88133]: Revision status changed

2011-06-05 Thread MediaWiki Mail
User Hashar changed the status of MediaWiki.r88133. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/88133#c0 Commit summary: Marked some _Newtalk functions protected ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r88119]: Revision status changed

2011-06-05 Thread MediaWiki Mail
User Hashar changed the status of MediaWiki.r88119. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/88119#c0 Commit summary: Revert r88043. It was broken in several ways. ___ MediaWiki-CodeReview mailing

[MediaWiki-CodeReview] [MediaWiki r89527]: Revision status changed

2011-06-05 Thread MediaWiki Mail
User Krinkle changed the status of MediaWiki.r89527. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89527#c0 Commit summary: Folow-up r89526: tabs and eol-style :( ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r87272]: Revision status changed

2011-06-05 Thread MediaWiki Mail
User Hashar changed the status of MediaWiki.r87272. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87272#c0 Commit summary: Follow-up r83795: fix E_NOTICE due to undefined array member. ___

[MediaWiki-CodeReview] [MediaWiki r89529]: New comment added, and revision status changed

2011-06-05 Thread MediaWiki Mail
User Krinkle changed the status of MediaWiki.r89529. Old Status: new New Status: fixme User Krinkle also posted a comment on MediaWiki.r89529. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89529#c17643 Commit summary: Follow-up r89254 and r89481: re-did loading extension

[MediaWiki-CodeReview] [MediaWiki r87064]: Revision status changed

2011-06-05 Thread MediaWiki Mail
User Hashar changed the status of MediaWiki.r87064. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87064#c0 Commit summary: Remove unused mdy data format. ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r86364]: Revision status changed

2011-06-05 Thread MediaWiki Mail
User Hashar changed the status of MediaWiki.r86364. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86364#c0 Commit summary: Move User::isValidEmailAddr() to Sanitizer. ___ MediaWiki-CodeReview mailing

Re: [Wikitech-l] Showing stub links by default - is it possible in a Wikimedia project?

2011-06-05 Thread Aryeh Gregor
On Sun, Jun 5, 2011 at 4:46 PM, Niklas Laxström niklas.laxst...@gmail.com wrote: Why don't we just add the numbers to html and let JavaScript make sense out of them? We can't put the numbers in any form in the parser cache, because they'll become outdated as soon as the length of the linked

Re: [Wikitech-l] The return of the Weekend Sprint

2011-06-05 Thread Krinkle
Mark A. Hershberger wrote: === Require token for watching/unwatching pages === https://bugzilla.wikimedia.org/27655 Bryan doesn't have time to work on this one right now. Any one want to take a shot? Just to let others know (and avoid double work), I'm tackling this one now. --

[MediaWiki-CodeReview] [MediaWiki r89532]: Revision status changed

2011-06-05 Thread MediaWiki Mail
User Krinkle changed the status of MediaWiki.r89532. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89532#c0 Commit summary: Followup r89529 Fix non static caller of getExistingLocalSettings ___

[MediaWiki-CodeReview] [MediaWiki r89529]: Revision status changed

2011-06-05 Thread MediaWiki Mail
User Krinkle changed the status of MediaWiki.r89529. Old Status: fixme New Status: new Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89529#c0 Commit summary: Follow-up r89254 and r89481: re-did loading extension updates properly, now upgrading extension tables from web

[MediaWiki-CodeReview] [MediaWiki r89534]: Revision status changed

2011-06-05 Thread MediaWiki Mail
User Reedy changed the status of MediaWiki.r89534. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89534#c0 Commit summary: Fix copypaste error (Not a special page), follow-up (ancient) r10453 ___

[MediaWiki-CodeReview] [MediaWiki r89533]: Revision status changed

2011-06-05 Thread MediaWiki Mail
User Krinkle changed the status of MediaWiki.r89533. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89533#c0 Commit summary: Documentation updates and additions ___ MediaWiki-CodeReview mailing list

[Wikitech-l] Wikimedia projects + Open Library books?

2011-06-05 Thread Steven Walling
So the Open Library, a project by the Internet Archive that has a structured wiki page for every book and which also lends books online, has announced they just got new Read API.[1, 2] The announcement describes its as: The idea is, you can hit the Read API with an identifier or a series of

Re: [Wikitech-l] Showing stub links by default - is it possible in a Wikimedia project?

2011-06-05 Thread Platonides
Federico Leva (Nemo) wrote: Platonides writes: No. Currently it would mean not caching any page view. The feature would need to be adapted to allow efficient stub linking (I have some ideas about it, and the new linker makes things easier). Still, we might not allow stub links for anons in

Re: [Wikitech-l] Showing stub links by default - is it possible in a Wikimedia project?

2011-06-05 Thread Platonides
Aryeh Gregor wrote: On Sat, Jun 4, 2011 at 6:54 PM, Platonidesplatoni...@gmail.com wrote: No. Currently it would mean not caching any page view. The feature would need to be adapted to allow efficient stub linking (I have some ideas about it, and the new linker makes things easier). What

Re: [Wikitech-l] Showing stub links by default - is it possible in a Wikimedia project?

2011-06-05 Thread Ashar Voultoiz
On 06/06/11 00:09, Platonides wrote: snip No. Anything other than showing no stubs skips the cache. Since it skips cache, can not we disable that stub highlighter once for all? -- Ashar Voultoiz ___ Wikitech-l mailing list

Re: [Wikitech-l] Showing stub links by default - is it possible in a Wikimedia project?

2011-06-05 Thread K. Peachey
On Mon, Jun 6, 2011 at 8:48 AM, Ashar Voultoiz hashar+...@free.fr wrote: On 06/06/11 00:09, Platonides wrote: snip No. Anything other than showing no stubs skips the cache. Since it skips cache, can not we disable that stub highlighter once for all? Logged in users don't get cached versions

[MediaWiki-CodeReview] [MediaWiki r88400]: New comment added

2011-06-05 Thread MediaWiki Mail
User Wikinaut posted a comment on MediaWiki.r88400. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/88400#c17644 Commit summary: introduced an OpenID special pages group; new restricted special page OpenID Dashboard Comment: * The intention is to have full configuration info in

  1   2   >