[MediaWiki-CodeReview] [MediaWiki r89598]: Revision status changed

2011-06-07 Thread MediaWiki Mail
User MaxSem changed the status of MediaWiki.r89598. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89598#c0 Commit summary: ; ___ MediaWiki-CodeReview mailing list

[Wikitech-l] DOMAS THE GIANT HAS A POSSE

2011-06-07 Thread Brandon Harris
You will obey: http://commons.wikimedia.org/wiki/File:Domas-the-Giant-has-a-Posse.png ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l

Re: [Wikitech-l] DOMAS THE GIANT HAS A POSSE

2011-06-07 Thread Christopher Grant
Some of you guys need to work on your gang signs, hahah. - Chris 2011/6/7 Brandon Harris bhar...@wikimedia.org You will obey: http://commons.wikimedia.org/wiki/File:Domas-the-Giant-has-a-Posse.png ___ Wikitech-l mailing list

[MediaWiki-CodeReview] [MediaWiki r89263]: New comment added

2011-06-07 Thread MediaWiki Mail
User MaxSem posted a comment on MediaWiki.r89263. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89263#c17710 Commit summary: * suggestion for ExtensionUpdater that would handle DB install/update of extension from DatabaseUpdater * could also generate default code for

[MediaWiki-CodeReview] [MediaWiki r89263]: New comment added

2011-06-07 Thread MediaWiki Mail
User Freakolowsky posted a comment on MediaWiki.r89263. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89263#c17711 Commit summary: * suggestion for ExtensionUpdater that would handle DB install/update of extension from DatabaseUpdater * could also generate default code for

[MediaWiki-CodeReview] [MediaWiki r89623]: New comment added

2011-06-07 Thread MediaWiki Mail
User Hashar posted a comment on MediaWiki.r89623. Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/89623#c17712 Commit summary: * fixed table duplication for unit tests * fixed sequence handling when using DB prefix * deferring constraints on transaction,

[MediaWiki-CodeReview] [MediaWiki r89576]: New comment added

2011-06-07 Thread MediaWiki Mail
User Bryan posted a comment on MediaWiki.r89576. Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/89576#c17713 Commit summary: Followup r89542, validate hashes Comment: ApiQueryAllimages seems to be a rather arbitrary place for validateSha1Base36Hash().

[MediaWiki-CodeReview] [MediaWiki r89576]: New comment added

2011-06-07 Thread MediaWiki Mail
User Reedy posted a comment on MediaWiki.r89576. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89576#c17714 Commit summary: Followup r89542, validate hashes Comment: Indeed Well, tbh, we should probably move the whole validation bit up a level or 2, and move the actual

[MediaWiki-CodeReview] [MediaWiki r85918]: New comment added

2011-06-07 Thread MediaWiki Mail
User Happy-melon posted a comment on MediaWiki.r85918. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85918#c17715 Commit summary: Improvements to handling of 'catastrophic' errors, like unsupported PHP versions, no MySQL functions, no LocalSettings, etc. * Fix parsing of the

[MediaWiki-CodeReview] [MediaWiki r89576]: New comment added

2011-06-07 Thread MediaWiki Mail
User Reedy posted a comment on MediaWiki.r89576. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89576#c17716 Commit summary: Followup r89542, validate hashes Comment: But of course, they were put there originally, as that was the only place using them at the time

[MediaWiki-CodeReview] [MediaWiki r85918]: New comment added

2011-06-07 Thread MediaWiki Mail
User Happy-melon posted a comment on MediaWiki.r85918. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85918#c17717 Commit summary: Improvements to handling of 'catastrophic' errors, like unsupported PHP versions, no MySQL functions, no LocalSettings, etc. * Fix parsing of the

[MediaWiki-CodeReview] [MediaWiki r84475]: New comment added, and revision status changed

2011-06-07 Thread MediaWiki Mail
User Happy-melon changed the status of MediaWiki.r84475. Old Status: fixme New Status: new User Happy-melon also posted a comment on MediaWiki.r84475. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/84475#c17718 Commit summary: Blame hashar for this giant commit; he teased me

[MediaWiki-CodeReview] [MediaWiki r89637]: New comment added

2011-06-07 Thread MediaWiki Mail
User Peachey88 posted a comment on MediaWiki.r89637. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89637#c17719 Commit summary: Initial commit of new extension Notificator Comment: I believe you need to set up your svn autoprops for svn:eol style

[MediaWiki-CodeReview] [MediaWiki r86041]: New comment added, and revision status changed

2011-06-07 Thread MediaWiki Mail
User Happy-melon changed the status of MediaWiki.r86041. Old Status: fixme New Status: new User Happy-melon also posted a comment on MediaWiki.r86041. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86041#c17720 Commit summary: r86001, now with less scariness :P I took out the

[MediaWiki-CodeReview] [MediaWiki r86041]: New comment added

2011-06-07 Thread MediaWiki Mail
User Happy-melon posted a comment on MediaWiki.r86041. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86041#c17721 Commit summary: r86001, now with less scariness :P I took out the delete action and did purge instead, which is a much more self-contained action-with-a-form.

[MediaWiki-CodeReview] [MediaWiki r89637]: New comment added

2011-06-07 Thread MediaWiki Mail
User Patrick Nagel posted a comment on MediaWiki.r89637. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89637#c17722 Commit summary: Initial commit of new extension Notificator Comment: Oh, right! I did that on the other box, but forgot to do it here. Hope I fixed that

[MediaWiki-CodeReview] [MediaWiki r89640]: Revision status changed

2011-06-07 Thread MediaWiki Mail
User Reedy changed the status of MediaWiki.r89640. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89640#c0 Commit summary: svn:eol-style native ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r89641]: Revision status changed

2011-06-07 Thread MediaWiki Mail
User Reedy changed the status of MediaWiki.r89641. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89641#c0 Commit summary: svn:eol-style native ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r89637]: New comment added, and revision status changed

2011-06-07 Thread MediaWiki Mail
User Nikerabbit changed the status of MediaWiki.r89637. Old Status: new New Status: fixme User Nikerabbit also posted a comment on MediaWiki.r89637. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89637#c17723 Commit summary: Initial commit of new extension Notificator Comment:

[MediaWiki-CodeReview] [MediaWiki r85918]: New comment added

2011-06-07 Thread MediaWiki Mail
User Tim Starling posted a comment on MediaWiki.r85918. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85918#c17725 Commit summary: Improvements to handling of 'catastrophic' errors, like unsupported PHP versions, no MySQL functions, no LocalSettings, etc. * Fix parsing of the

[MediaWiki-CodeReview] [MediaWiki r89594]: New comment added, and revision status changed

2011-06-07 Thread MediaWiki Mail
User Hashar changed the status of MediaWiki.r89594. Old Status: new New Status: ok User Hashar also posted a comment on MediaWiki.r89594. Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/89594#c17726 Commit summary: Followup r89588, adding the DISTINCT

[MediaWiki-CodeReview] [MediaWiki r89594]: New comment added

2011-06-07 Thread MediaWiki Mail
User Reedy posted a comment on MediaWiki.r89594. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89594#c17727 Commit summary: Followup r89588, adding the DISTINCT keyword is somewhat helpful Comment: Don't computers suck? ___

[MediaWiki-CodeReview] [MediaWiki r89594]: New comment added, and revision status changed

2011-06-07 Thread MediaWiki Mail
User Hashar changed the status of MediaWiki.r89594. Old Status: ok New Status: new User Hashar also posted a comment on MediaWiki.r89594. Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/89594#c17728 Commit summary: Followup r89588, adding the DISTINCT

[Wikitech-l] Update Gadgets extension on WMF wikis

2011-06-07 Thread Ildefons Stułbia
Hi all, I would like to ask for deployment of new version of Gadgets extension. It would be great to get rid of MediaWiki:Common.js by splitting it into separate gadgets, enabled for everyone by default. Any registered user will be able to disable functionality he/she does not like. What is more,

[MediaWiki-CodeReview] [MediaWiki r89549]: Revision status changed

2011-06-07 Thread MediaWiki Mail
User Reedy changed the status of MediaWiki.r89549. Old Status: new New Status: resolved Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89549#c0 Commit summary: follow up r89513: avoid internal error when only invalid revids/pageids are passed

Re: [Wikitech-l] Update Gadgets extension on WMF wikis

2011-06-07 Thread Roan Kattouw
2011/6/7 Ildefons Stułbia ildefons.stul...@gmail.com: Hi all, I would like to ask for deployment of new version of Gadgets extension. It would be great to get rid of MediaWiki:Common.js by splitting it into separate gadgets, enabled for everyone by default. Any registered user will be able

Re: [Wikitech-l] Update Gadgets extension on WMF wikis

2011-06-07 Thread Max Semenik
On 07.06.2011, 17:52 Roan wrote: 2011/6/7 Ildefons Stułbia ildefons.stul...@gmail.com: Hi all, I would like to ask for deployment of new version of Gadgets extension. It would be great to get rid of MediaWiki:Common.js by splitting it into separate gadgets, enabled for everyone by default.

[MediaWiki-CodeReview] [MediaWiki r75486]: New comment added

2011-06-07 Thread MediaWiki Mail
User Helder.wiki posted a comment on MediaWiki.r75486. Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/75486#c17729 Commit summary: Introducing mediaWiki.language, and mediaWiki.message which are modeled after their PHP counterparts Language and wfMessage

[MediaWiki-CodeReview] [MediaWiki r88512]: Revision status changed

2011-06-07 Thread MediaWiki Mail
User MaxSem changed the status of MediaWiki.r88512. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/88512#c0 Commit summary: Fix up test so they can run from trunk ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r85918]: New comment added

2011-06-07 Thread MediaWiki Mail
User ^demon posted a comment on MediaWiki.r85918. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85918#c17730 Commit summary: Improvements to handling of 'catastrophic' errors, like unsupported PHP versions, no MySQL functions, no LocalSettings, etc. * Fix parsing of the three

[MediaWiki-CodeReview] [MediaWiki r89650]: New comment added, and revision status changed

2011-06-07 Thread MediaWiki Mail
User Reedy changed the status of MediaWiki.r89650. Old Status: new New Status: fixme User Reedy also posted a comment on MediaWiki.r89650. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89650#c17731 Commit summary: Comment: Username linked, but this file is missing

[MediaWiki-CodeReview] [MediaWiki r89649]: Revision status changed

2011-06-07 Thread MediaWiki Mail
User Reedy changed the status of MediaWiki.r89649. Old Status: new New Status: resolved Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89649#c0 Commit summary: Adding my USERINFO file ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r89650]: New comment added

2011-06-07 Thread MediaWiki Mail
User Reedy posted a comment on MediaWiki.r89650. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89650#c17732 Commit summary: Comment: Oh, and a commit summary! ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r89650]: New comment added

2011-06-07 Thread MediaWiki Mail
User Reedy posted a comment on MediaWiki.r89650. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89650#c17733 Commit summary: Comment: Make sure your [[Subversion/auto-props]] are set, even thought they won't have helped for this file

[MediaWiki-CodeReview] [MediaWiki r89558]: Revision status changed

2011-06-07 Thread MediaWiki Mail
User Catrope changed the status of MediaWiki.r89558. Old Status: new New Status: ok Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/89558#c0 Commit summary: * Added a REQUEST_URI check to the bug 28235 handling. * Moved most of the bug 28235 code out to a

[MediaWiki-CodeReview] [MediaWiki r89559]: Revision status changed

2011-06-07 Thread MediaWiki Mail
User Catrope changed the status of MediaWiki.r89559. Old Status: new New Status: ok Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/89559#c0 Commit summary: Test filename updates for r89558. ___

[MediaWiki-CodeReview] [MediaWiki r89651]: Revision status changed

2011-06-07 Thread MediaWiki Mail
User Reedy changed the status of MediaWiki.r89651. Old Status: new New Status: resolved Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89651#c0 Commit summary: ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r89654]: Revision status changed

2011-06-07 Thread MediaWiki Mail
User Reedy changed the status of MediaWiki.r89654. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89654#c0 Commit summary: modifying email ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r81536]: New comment added

2011-06-07 Thread MediaWiki Mail
User Catrope posted a comment on MediaWiki.r81536. Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/81536#c17734 Commit summary: (bug 19751) Filesystem is now checked during image undeletion * FSRepo::storeBatch() now does an sha1 check unless

[MediaWiki-CodeReview] [MediaWiki r89653]: Revision status changed

2011-06-07 Thread MediaWiki Mail
User ^demon changed the status of MediaWiki.r89653. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89653#c0 Commit summary: Fix r85021: extension tables weren't created in some cases ___

[MediaWiki-CodeReview] [MediaWiki r88492]: Revision status changed

2011-06-07 Thread MediaWiki Mail
User Catrope changed the status of MediaWiki.r88492. Old Status: new New Status: ok Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/88492#c0 Commit summary: Do not block the installer (through an unhandled exception) when we can't connect to ourself.

[MediaWiki-CodeReview] [MediaWiki r89650]: Revision status changed

2011-06-07 Thread MediaWiki Mail
User Reedy changed the status of MediaWiki.r89650. Old Status: fixme New Status: resolved Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89650#c0 Commit summary: ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r85021]: New comment added

2011-06-07 Thread MediaWiki Mail
User ^demon posted a comment on MediaWiki.r85021. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85021#c17735 Commit summary: (bug 28237) Installer doesn't create extension tables Comment: MaxSem: The more I think about it, DatabaseUpdater::addNewExtension() (r81266) is really

[MediaWiki-CodeReview] [MediaWiki r88871]: New comment added

2011-06-07 Thread MediaWiki Mail
User Catrope posted a comment on MediaWiki.r88871. Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/88871#c17736 Commit summary: * (bug 27465) Fix metadata extraction for SVG files using unusual namespace names The previous fix (in r82307) only checked

Re: [Wikitech-l] Update Gadgets extension on WMF wikis

2011-06-07 Thread Chad
2011/6/7 Ildefons Stułbia ildefons.stul...@gmail.com: I would like to ask for deployment of new version of Gadgets extension. It would be great to get rid of MediaWiki:Common.js by splitting it into separate gadgets, enabled for everyone by default. Well I'm not sure getting rid of Common.js

[MediaWiki-CodeReview] [MediaWiki r89003]: Revision status changed

2011-06-07 Thread MediaWiki Mail
User Catrope changed the status of MediaWiki.r89003. Old Status: new New Status: ok Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/89003#c0 Commit summary: * (bug 29174) Fix regression in upload-by-URL: files larger than PHP memory limit work again

[MediaWiki-CodeReview] [MediaWiki r89529]: New comment added

2011-06-07 Thread MediaWiki Mail
User ^demon posted a comment on MediaWiki.r89529. Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/89529#c17737 Commit summary: Follow-up r89254 and r89481: re-did loading extension updates properly, now upgrading extension tables from web interface really

[MediaWiki-CodeReview] [MediaWiki r87494]: Revision status changed

2011-06-07 Thread MediaWiki Mail
User ^demon changed the status of MediaWiki.r87494. Old Status: new New Status: ok Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/87494#c0 Commit summary: For bug 28738, have the installer check for the Suhosin GET variable length limit and set

[MediaWiki-CodeReview] [MediaWiki r85021]: New comment added

2011-06-07 Thread MediaWiki Mail
User MaxSem posted a comment on MediaWiki.r85021. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85021#c17738 Commit summary: (bug 28237) Installer doesn't create extension tables Comment: Yeah, makes sense. ___ MediaWiki-CodeReview

[MediaWiki-CodeReview] [MediaWiki r86041]: New comment added

2011-06-07 Thread MediaWiki Mail
User ^demon posted a comment on MediaWiki.r86041. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86041#c17739 Commit summary: r86001, now with less scariness :P I took out the delete action and did purge instead, which is a much more self-contained action-with-a-form. Also

[MediaWiki-CodeReview] [MediaWiki r89648]: New comment added, and revision status changed

2011-06-07 Thread MediaWiki Mail
User Brion VIBBER changed the status of MediaWiki.r89648. Old Status: new New Status: reverted User Brion VIBBER also posted a comment on MediaWiki.r89648. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89648#c17740 Commit summary: Another try at fixing bug 93 tilde signatures

[MediaWiki-CodeReview] [MediaWiki r89662]: Revision status changed

2011-06-07 Thread MediaWiki Mail
User MaxSem changed the status of MediaWiki.r89662. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89662#c0 Commit summary: Provisional revert of r89648: Another try at fixing bug 93 tilde signatures inside nowiki tags sometimes get expanded

[MediaWiki-CodeReview] [MediaWiki r87512]: Revision status changed

2011-06-07 Thread MediaWiki Mail
User Brion VIBBER changed the status of MediaWiki.r87512. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87512#c0 Commit summary: Fix for r87278: if we're installing with the same user we're going to use, skip creation grants since there's no

[MediaWiki-CodeReview] [MediaWiki r88076]: Revision status changed

2011-06-07 Thread MediaWiki Mail
User Brion VIBBER changed the status of MediaWiki.r88076. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/88076#c0 Commit summary: Fix bug in r87497, reported in CR: modules=foo,bar,baz would look for '.foo', '.ar' and '.az' . Now handling

[MediaWiki-CodeReview] [MediaWiki r87497]: Revision status changed

2011-06-07 Thread MediaWiki Mail
User Brion VIBBER changed the status of MediaWiki.r87497. Old Status: new New Status: resolved Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87497#c0 Commit summary: Per bug 28738 comment 4, pack ResourceLoader URLs by encoding foo.bar|foo.baz|bar.baz|bar.quux as

[MediaWiki-CodeReview] [MediaWiki r87411]: Revision status changed

2011-06-07 Thread MediaWiki Mail
User Platonides changed the status of MediaWiki.r87411. Old Status: new New Status: resolved Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87411#c0 Commit summary: Follow-up r87394: Add reference back to MediaWiki::performRequestForTitle per IAlex' comment.

[MediaWiki-CodeReview] [MediaWiki r89665]: New comment added

2011-06-07 Thread MediaWiki Mail
User Reedy posted a comment on MediaWiki.r89665. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89665#c17741 Commit summary: INITIAL COMMIT OF PAGE SCHEMAS. Comment: YOU NEED TO FIX YOUR SVN AUTOPROPS ___ MediaWiki-CodeReview mailing

[MediaWiki-CodeReview] [MediaWiki r89665]: Revision status changed

2011-06-07 Thread MediaWiki Mail
User Reedy changed the status of MediaWiki.r89665. Old Status: new New Status: fixme Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89665#c0 Commit summary: INITIAL COMMIT OF PAGE SCHEMAS. ___ MediaWiki-CodeReview mailing list

Re: [Wikitech-l] DOMAS THE GIANT HAS A POSSE

2011-06-07 Thread Platonides
Brandon Harris wrote: You will obey: http://commons.wikimedia.org/wiki/File:Domas-the-Giant-has-a-Posse.png OMG that's cool. But that Wikipedia book should have been about MySQL :) ___ Wikitech-l mailing list

[MediaWiki-CodeReview] [MediaWiki r88076]: New comment added

2011-06-07 Thread MediaWiki Mail
User Brion VIBBER posted a comment on MediaWiki.r88076. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/88076#c17742 Commit summary: Fix bug in r87497, reported in CR: modules=foo,bar,baz would look for '.foo', '.ar' and '.az' . Now handling prefixless modules correctly Comment:

[MediaWiki-CodeReview] [MediaWiki r87497]: New comment added

2011-06-07 Thread MediaWiki Mail
User Brion VIBBER posted a comment on MediaWiki.r87497. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87497#c17743 Commit summary: Per bug 28738 comment 4, pack ResourceLoader URLs by encoding foo.bar|foo.baz|bar.baz|bar.quux as foo.bar,baz|bar.baz,quux * Expand these URLs in

[MediaWiki-CodeReview] [MediaWiki r89667]: New comment added, and revision status changed

2011-06-07 Thread MediaWiki Mail
User Reedy changed the status of MediaWiki.r89667. Old Status: new New Status: ok User Reedy also posted a comment on MediaWiki.r89667. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89667#c17744 Commit summary: Comment: Please try and use commit summaries! ;)

[MediaWiki-CodeReview] [MediaWiki r89665]: Revision status changed

2011-06-07 Thread MediaWiki Mail
User Reedy changed the status of MediaWiki.r89665. Old Status: fixme New Status: new Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89665#c0 Commit summary: INITIAL COMMIT OF PAGE SCHEMAS. ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r87482]: New comment added

2011-06-07 Thread MediaWiki Mail
User Brion VIBBER posted a comment on MediaWiki.r87482. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87482#c17745 Commit summary: * Fix for bug 28534: IE 6 content type detection again * Fix for bug 28639: user object instance cache pollution * Release notes formatting tweak.

[MediaWiki-CodeReview] [MediaWiki r89668]: Revision status changed

2011-06-07 Thread MediaWiki Mail
User MaxSem changed the status of MediaWiki.r89668. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89668#c0 Commit summary: Fix (Api)BlockTest for Sqlite. getRangeStart()/getRangeEnd() were returning null for user blocks, which was then happily

[MediaWiki-CodeReview] [MediaWiki r87498]: New comment added

2011-06-07 Thread MediaWiki Mail
User Catrope posted a comment on MediaWiki.r87498. Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/87498#c17746 Commit summary: Fixes ForeignDBRepo SQL server connection. Fixes bug #28836. Comment: Untagging 1.17. Fixes a regression introduced after the

[MediaWiki-CodeReview] [MediaWiki r87468]: Revision status changed

2011-06-07 Thread MediaWiki Mail
User Brion VIBBER changed the status of MediaWiki.r87468. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87468#c0 Commit summary: Move CleanUpTest, fixes in next commit ___ MediaWiki-CodeReview mailing

[MediaWiki-CodeReview] [MediaWiki r87468]: Revision status changed

2011-06-07 Thread MediaWiki Mail
User Brion VIBBER changed the status of MediaWiki.r87468. Old Status: ok New Status: resolved Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87468#c0 Commit summary: Move CleanUpTest, fixes in next commit ___ MediaWiki-CodeReview

[MediaWiki-CodeReview] [MediaWiki r88798]: Revision status changed

2011-06-07 Thread MediaWiki Mail
User Brion VIBBER changed the status of MediaWiki.r88798. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/88798#c0 Commit summary: Followup r87468: remove refs to CleanUpTest from Makefile ___

[MediaWiki-CodeReview] [MediaWiki r87428]: Revision status changed

2011-06-07 Thread MediaWiki Mail
User Brion VIBBER changed the status of MediaWiki.r87428. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87428#c0 Commit summary: No current need for an alias to getPath() ___ MediaWiki-CodeReview

[MediaWiki-CodeReview] [MediaWiki r87414]: Revision status changed

2011-06-07 Thread MediaWiki Mail
User Brion VIBBER changed the status of MediaWiki.r87414. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87414#c0 Commit summary: Partial revert of r87345. Causing unreadable buttons in ArticleFeedback (http://i.imgur.com/PyxOw.png ), likely

[MediaWiki-CodeReview] [MediaWiki r87395]: Revision status changed

2011-06-07 Thread MediaWiki Mail
User Brion VIBBER changed the status of MediaWiki.r87395. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87395#c0 Commit summary: Follow-up r87326: Add regression test. ___ MediaWiki-CodeReview mailing

[MediaWiki-CodeReview] [MediaWiki r89652]: Revision status changed

2011-06-07 Thread MediaWiki Mail
User Hashar changed the status of MediaWiki.r89652. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89652#c0 Commit summary: Followup r89651 Fix props ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r89668]: New comment added

2011-06-07 Thread MediaWiki Mail
User Hashar posted a comment on MediaWiki.r89668. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89668#c17747 Commit summary: Fix (Api)BlockTest for Sqlite. getRangeStart()/getRangeEnd() were returning null for user blocks, which was then happily inserted into a NOT NULL column.

[MediaWiki-CodeReview] [MediaWiki r89668]: New comment added

2011-06-07 Thread MediaWiki Mail
User ^demon posted a comment on MediaWiki.r89668. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89668#c17748 Commit summary: Fix (Api)BlockTest for Sqlite. getRangeStart()/getRangeEnd() were returning null for user blocks, which was then happily inserted into a NOT NULL column.

[MediaWiki-CodeReview] [MediaWiki r87326]: New comment added, and revision status changed

2011-06-07 Thread MediaWiki Mail
User Brion VIBBER changed the status of MediaWiki.r87326. Old Status: new New Status: fixme User Brion VIBBER also posted a comment on MediaWiki.r87326. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87326#c17749 Commit summary: Fix Bug 28354: Edit tab is shown as view source

[MediaWiki-CodeReview] [MediaWiki r87400]: Revision status changed

2011-06-07 Thread MediaWiki Mail
User Brion VIBBER changed the status of MediaWiki.r87400. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87400#c0 Commit summary: Tag names can't contain template parameters (thanksfully) ___

[MediaWiki-CodeReview] [MediaWiki r87394]: Revision status changed

2011-06-07 Thread MediaWiki Mail
User Brion VIBBER changed the status of MediaWiki.r87394. Old Status: new New Status: resolved Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87394#c0 Commit summary: Remove references from function parameters in Wiki.php. They aren't needed for objects and sometimes cause

[MediaWiki-CodeReview] [MediaWiki r89668]: New comment added

2011-06-07 Thread MediaWiki Mail
User Happy-melon posted a comment on MediaWiki.r89668. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89668#c17750 Commit summary: Fix (Api)BlockTest for Sqlite. getRangeStart()/getRangeEnd() were returning null for user blocks, which was then happily inserted into a NOT NULL

[MediaWiki-CodeReview] [MediaWiki r89660]: New comment added

2011-06-07 Thread MediaWiki Mail
User Hashar posted a comment on MediaWiki.r89660. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89660#c17751 Commit summary: Get rid of addNewExtension()/getNewExtensions() method of adding new extensions (added in r81266). Since r85021, this isn't necessary because we run old

[MediaWiki-CodeReview] [MediaWiki r89660]: New comment added

2011-06-07 Thread MediaWiki Mail
User ^demon posted a comment on MediaWiki.r89660. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89660#c17752 Commit summary: Get rid of addNewExtension()/getNewExtensions() method of adding new extensions (added in r81266). Since r85021, this isn't necessary because we run old

[MediaWiki-CodeReview] [MediaWiki r87389]: Revision status changed

2011-06-07 Thread MediaWiki Mail
User Brion VIBBER changed the status of MediaWiki.r87389. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87389#c0 Commit summary: Drop the $out params I added before I added context to Skin, as well deprecate some of the $out params in other

[MediaWiki-CodeReview] [MediaWiki r87388]: Revision status changed

2011-06-07 Thread MediaWiki Mail
User Brion VIBBER changed the status of MediaWiki.r87388. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87388#c0 Commit summary: * fixed tableName handling for internal purposes (bug if using sharedDB as i need raw table name)

[MediaWiki-CodeReview] [MediaWiki r87382]: New comment added, and revision status changed

2011-06-07 Thread MediaWiki Mail
User Brion VIBBER changed the status of MediaWiki.r87382. Old Status: new New Status: ok User Brion VIBBER also posted a comment on MediaWiki.r87382. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87382#c17753 Commit summary: Add proper $out setting to Skin::getCategories which

[MediaWiki-CodeReview] [MediaWiki r87380]: New comment added, and revision status changed

2011-06-07 Thread MediaWiki Mail
User Brion VIBBER changed the status of MediaWiki.r87380. Old Status: new New Status: ok User Brion VIBBER also posted a comment on MediaWiki.r87380. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87380#c17754 Commit summary: Add hack to shut up fatals when getCategories() is

[MediaWiki-CodeReview] [MediaWiki r87349]: Revision status changed

2011-06-07 Thread MediaWiki Mail
User Brion VIBBER changed the status of MediaWiki.r87349. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87349#c0 Commit summary: Only one extension was using getThumbnail ___ MediaWiki-CodeReview

[MediaWiki-CodeReview] [MediaWiki r87349]: Revision status changed

2011-06-07 Thread MediaWiki Mail
User Brion VIBBER changed the status of MediaWiki.r87349. Old Status: ok New Status: resolved Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87349#c0 Commit summary: Only one extension was using getThumbnail ___ MediaWiki-CodeReview

[MediaWiki-CodeReview] [MediaWiki r87220]: Revision status changed

2011-06-07 Thread MediaWiki Mail
User Brion VIBBER changed the status of MediaWiki.r87220. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87220#c0 Commit summary: Convert r86795 tests into a dataProvider ___ MediaWiki-CodeReview mailing

[MediaWiki-CodeReview] [MediaWiki r87348]: Revision status changed

2011-06-07 Thread MediaWiki Mail
User Brion VIBBER changed the status of MediaWiki.r87348. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87348#c0 Commit summary: Follow up r87220. r86795 tests are now embedded into PreprocessorTest.php

[MediaWiki-CodeReview] [MediaWiki r87347]: New comment added, and revision status changed

2011-06-07 Thread MediaWiki Mail
User Brion VIBBER changed the status of MediaWiki.r87347. Old Status: new New Status: fixme User Brion VIBBER also posted a comment on MediaWiki.r87347. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87347#c17755 Commit summary: (bug 7) Special:Listfiles no longer throws an

[MediaWiki-CodeReview] [MediaWiki r89671]: Revision status changed

2011-06-07 Thread MediaWiki Mail
User Reedy changed the status of MediaWiki.r89671. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89671#c0 Commit summary: 1.17wmf1: Revert r89670, merged revs were intended for REL1_17 instead. This unmerges r87423, r88118, r88124, r88211,

[MediaWiki-CodeReview] [MediaWiki r89670]: Revision status changed

2011-06-07 Thread MediaWiki Mail
User Reedy changed the status of MediaWiki.r89670. Old Status: new New Status: reverted Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89670#c0 Commit summary: 1.17wmf1: MFT r87423, r88118, r88124, r88211, r88498, r89099, r89401, r89451

[MediaWiki-CodeReview] [MediaWiki r87347]: New comment added

2011-06-07 Thread MediaWiki Mail
User Catrope posted a comment on MediaWiki.r87347. Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/87347#c17756 Commit summary: (bug 7) Special:Listfiles no longer throws an error on bogus file entries Comment: You may want makeTitleSafe() instead,

[MediaWiki-CodeReview] [MediaWiki r87347]: New comment added

2011-06-07 Thread MediaWiki Mail
User ^demon posted a comment on MediaWiki.r87347. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87347#c17757 Commit summary: (bug 7) Special:Listfiles no longer throws an error on bogus file entries Comment: Yeah, makeTitleSafe(), whoops.

[Wikitech-l] I'm in ur trunk, reviewing pre-1.18 branch code

2011-06-07 Thread Brion Vibber
Currently working (mostly backwards) to fill in the Code Review holes from before 1.18 branch point: http://www.mediawiki.org/w/index.php?title=Special:Code/MediaWikioffset=87519path=%2Ftrunk%2Fphase3 Roadmap provisionally says July for 1.18 deployment:

[MediaWiki-CodeReview] [MediaWiki r89675]: Revision status changed

2011-06-07 Thread MediaWiki Mail
User Reedy changed the status of MediaWiki.r89675. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89675#c0 Commit summary: Forgot to press save on the comment ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r87346]: Revision status changed

2011-06-07 Thread MediaWiki Mail
User Brion VIBBER changed the status of MediaWiki.r87346. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87346#c0 Commit summary: We can't check if it's a parentNode-type == name_node so early, since it may be just a single } and end up being a

[MediaWiki-CodeReview] [MediaWiki r87339]: New comment added, and revision status changed

2011-06-07 Thread MediaWiki Mail
User Brion VIBBER changed the status of MediaWiki.r87339. Old Status: new New Status: ok User Brion VIBBER also posted a comment on MediaWiki.r87339. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87339#c17758 Commit summary: Fixes bug #28694: Set maxlength of revisiondelete

[MediaWiki-CodeReview] [MediaWiki r89529]: Revision status changed

2011-06-07 Thread MediaWiki Mail
User ^demon changed the status of MediaWiki.r89529. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89529#c0 Commit summary: Follow-up r89254 and r89481: re-did loading extension updates properly, now upgrading extension tables from web interface

[MediaWiki-CodeReview] [MediaWiki r89677]: New comment added, and revision status changed

2011-06-07 Thread MediaWiki Mail
User MaxSem changed the status of MediaWiki.r89677. Old Status: new New Status: fixme User MaxSem also posted a comment on MediaWiki.r89677. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89677#c17759 Commit summary: 1.17: MFT r88492, r88870, r88871, r89003, r89108, r89114,

  1   2   3   4   >