[MediaWiki-CodeReview] [MediaWiki r90337]: New comment added

2011-06-21 Thread MediaWiki Mail
User SPQRobin posted a comment on MediaWiki.r90337. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90337#c18427 Commit summary: Address comment by Platonides on r90320: * undefined variable $list in CategoryPage.php * move code in ParserOptions to a new member of Title class,

[MediaWiki-CodeReview] [MediaWiki r90518]: New comment added

2011-06-21 Thread MediaWiki Mail
User Siebrand posted a comment on MediaWiki.r90518. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90518#c18428 Commit summary: Interwiki extension: * correct alignment for RTL languages in the explication table * always align the URL as LTR Comment: The HTML in this code

[MediaWiki-CodeReview] [MediaWiki r90518]: New comment added

2011-06-21 Thread MediaWiki Mail
User SPQRobin posted a comment on MediaWiki.r90518. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90518#c18429 Commit summary: Interwiki extension: * correct alignment for RTL languages in the explication table * always align the URL as LTR Comment: Yeah, I know. A lot of the

[MediaWiki-CodeReview] [MediaWiki r90510]: New comment added

2011-06-21 Thread MediaWiki Mail
User Raymond posted a comment on MediaWiki.r90510. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90510#c18430 Commit summary: More escaping to reduce reviewer anxiety (love that word ;). Also escaping wfMsg() now, and thus had to remove em tags from i18n file. Comment: Just a

[MediaWiki-CodeReview] [MediaWiki r90337]: New comment added

2011-06-21 Thread MediaWiki Mail
User Nikerabbit posted a comment on MediaWiki.r90337. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90337#c18431 Commit summary: Address comment by Platonides on r90320: * undefined variable $list in CategoryPage.php * move code in ParserOptions to a new member of Title class,

[MediaWiki-CodeReview] [MediaWiki r90337]: New comment added

2011-06-21 Thread MediaWiki Mail
User SPQRobin posted a comment on MediaWiki.r90337. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90337#c18432 Commit summary: Address comment by Platonides on r90320: * undefined variable $list in CategoryPage.php * move code in ParserOptions to a new member of Title class,

[MediaWiki-CodeReview] [MediaWiki r60833]: New comment added

2011-06-21 Thread MediaWiki Mail
User Krinkle posted a comment on MediaWiki.r60833. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/60833#c18433 Commit summary: follow up r60829 Gah — really need to get E_STRICT working in my test environment. Comment: This was fixed in the follow-up r60834.

[MediaWiki-CodeReview] [MediaWiki r90359]: New comment added

2011-06-21 Thread MediaWiki Mail
User Matěj Grabovský posted a comment on MediaWiki.r90359. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90359#c18434 Commit summary: (bug 29443) Special:Undelete should invert checkboxes without reloading Committed patch with code originally by [[b:User:Darklama]] Comment:

[MediaWiki-CodeReview] [MediaWiki r90522]: Revision status changed

2011-06-21 Thread MediaWiki Mail
User Reedy changed the status of MediaWiki.r90522. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90522#c0 Commit summary: Fix r90500: move release note from API to bug fixes section ___

[MediaWiki-CodeReview] [pywikipedia r9300]: Revision status changed

2011-06-21 Thread MediaWiki Mail
User Lcawte changed the status of pywikipedia.r9300. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/pywikipedia/9300#c0 Commit summary: Update version. ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [pywikipedia r1505]: Revision status changed

2011-06-21 Thread MediaWiki Mail
User Lcawte changed the status of pywikipedia.r1505. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/pywikipedia/1505#c0 Commit summary: ignore family pyc's ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r90359]: New comment added

2011-06-21 Thread MediaWiki Mail
User Krinkle posted a comment on MediaWiki.r90359. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90359#c18435 Commit summary: (bug 29443) Special:Undelete should invert checkboxes without reloading Committed patch with code originally by [[b:User:Darklama]] Comment: I wrote

[MediaWiki-CodeReview] [MediaWiki r90349]: Revision status changed

2011-06-21 Thread MediaWiki Mail
User Platonides changed the status of MediaWiki.r90349. Old Status: ok New Status: reverted Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90349#c0 Commit summary: Follow-up r90340: just add the test file to SVN, which hopefully fixes the cruisecontrol problems.

[MediaWiki-CodeReview] [MediaWiki r90530]: New comment added

2011-06-21 Thread MediaWiki Mail
User Platonides posted a comment on MediaWiki.r90530. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90530#c18436 Commit summary: Revert r90483, if tesla has problems, it should get proper permissions to the affected folders (or change the test to use a temp folder) The test was

[MediaWiki-CodeReview] [MediaWiki r87731]: New comment added, and revision status changed

2011-06-21 Thread MediaWiki Mail
User Platonides changed the status of MediaWiki.r87731. Old Status: ok New Status: fixme User Platonides also posted a comment on MediaWiki.r87731. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87731#c18437 Commit summary: Automatic testing of SQLite updates from all

[MediaWiki-CodeReview] [MediaWiki r90421]: New comment added, and revision status changed

2011-06-21 Thread MediaWiki Mail
User Platonides changed the status of MediaWiki.r90421. Old Status: new New Status: fixme User Platonides also posted a comment on MediaWiki.r90421. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90421#c18438 Commit summary: (bug 29471) Exception thrown for files with invalid

[Wikitech-l] Store IP using varchar(40) is enough?

2011-06-21 Thread Ryan Chan
According to this: http://www.mediawiki.org/wiki/Manual:User_newtalk_table, IP was stored using varchar(40) . But seems 45 should be the safe instead of 39? http://stackoverflow.com/questions/4982701/best-way-to-store-ip-in-database ___ Wikitech-l

Re: [Wikitech-l] Store IP using varchar(40) is enough?

2011-06-21 Thread Brion Vibber
On Jun 21, 2011 9:29 AM, Ryan Chan ryanchan...@gmail.com wrote: According to this: http://www.mediawiki.org/wiki/Manual:User_newtalk_table, IP was stored using varchar(40) . But seems 45 should be the safe instead of 39?

[MediaWiki-CodeReview] [MediaWiki r90522]: New comment added

2011-06-21 Thread MediaWiki Mail
User Bawolff posted a comment on MediaWiki.r90522. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90522#c18439 Commit summary: Fix r90500: move release note from API to bug fixes section Comment: Thanks. I can't believe I did that.

[MediaWiki-CodeReview] [MediaWiki r81122]: New comment added

2011-06-21 Thread MediaWiki Mail
User NeilK posted a comment on MediaWiki.r81122. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/81122#c18440 Commit summary: adding directories for jasmine test library Comment: I have to move over some libraries there before Wikimania at least, or my talk won't be much

Re: [Wikitech-l] Store IP using varchar(40) is enough?

2011-06-21 Thread Krinkle
MediaWiki indeed doesn't store IP-addresses directly. This is for a few reasons, one of which is sorting them from MySQL for block ranges. It uses ip2long [1] for IPv4 addresses and a base conversion of raw HEX for IPv6 [2]. See also the source of MediaWiki's IP.php class [3] -- Krinkle [1]

[MediaWiki-CodeReview] [MediaWiki r87212]: New comment added, and revision status changed

2011-06-21 Thread MediaWiki Mail
User Brion VIBBER changed the status of MediaWiki.r87212. Old Status: new New Status: resolved User Brion VIBBER also posted a comment on MediaWiki.r87212. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87212#c18441 Commit summary: Added wgIsMainPage (Title-isMainPage) to

[MediaWiki-CodeReview] [MediaWiki r90099]: Revision status changed

2011-06-21 Thread MediaWiki Mail
User Brion VIBBER changed the status of MediaWiki.r90099. Old Status: new New Status: resolved Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90099#c0 Commit summary: Only define 'isMainPage' if we are on the main page, the new mw.config library is specifically built for this

[MediaWiki-CodeReview] [MediaWiki r90337]: New comment added

2011-06-21 Thread MediaWiki Mail
User Nikerabbit posted a comment on MediaWiki.r90337. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90337#c18442 Commit summary: Address comment by Platonides on r90320: * undefined variable $list in CategoryPage.php * move code in ParserOptions to a new member of Title class,

[MediaWiki-CodeReview] [MediaWiki r81122]: New comment added

2011-06-21 Thread MediaWiki Mail
User ^demon posted a comment on MediaWiki.r81122. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/81122#c18443 Commit summary: adding directories for jasmine test library Comment: Fair enough, I'll take my finger off the trigger :)

[MediaWiki-CodeReview] [MediaWiki r90533]: New comment added

2011-06-21 Thread MediaWiki Mail
User Nikerabbit posted a comment on MediaWiki.r90533. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90533#c18444 Commit summary: Class Comment: We don't end PHP files with nowiki?/nowiki anymore. ___ MediaWiki-CodeReview mailing

[MediaWiki-CodeReview] [MediaWiki r90535]: New comment added

2011-06-21 Thread MediaWiki Mail
User Nikerabbit posted a comment on MediaWiki.r90535. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90535#c18445 Commit summary: Comment: MediaWiki provides jQuery nowdays. Please always use a commit message. ___

[MediaWiki-CodeReview] [MediaWiki r90528]: New comment added

2011-06-21 Thread MediaWiki Mail
User Nikerabbit posted a comment on MediaWiki.r90528. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90528#c18446 Commit summary: fixed IE breakage Comment: Debugging code left in?? ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r90337]: New comment added

2011-06-21 Thread MediaWiki Mail
User SPQRobin posted a comment on MediaWiki.r90337. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90337#c18447 Commit summary: Address comment by Platonides on r90320: * undefined variable $list in CategoryPage.php * move code in ParserOptions to a new member of Title class,

[MediaWiki-CodeReview] [MediaWiki r90337]: New comment added

2011-06-21 Thread MediaWiki Mail
User Nikerabbit posted a comment on MediaWiki.r90337. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90337#c18448 Commit summary: Address comment by Platonides on r90320: * undefined variable $list in CategoryPage.php * move code in ParserOptions to a new member of Title class,

[MediaWiki-CodeReview] [MediaWiki r90342]: Revision status changed

2011-06-21 Thread MediaWiki Mail
User Platonides changed the status of MediaWiki.r90342. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90342#c0 Commit summary: Fix double setTargetLanguage of r90337 ___ MediaWiki-CodeReview mailing

[MediaWiki-CodeReview] [MediaWiki r90337]: New comment added

2011-06-21 Thread MediaWiki Mail
User SPQRobin posted a comment on MediaWiki.r90337. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90337#c18449 Commit summary: Address comment by Platonides on r90320: * undefined variable $list in CategoryPage.php * move code in ParserOptions to a new member of Title class,

[MediaWiki-CodeReview] [MediaWiki r90452]: New comment added, and revision status changed

2011-06-21 Thread MediaWiki Mail
User Brion VIBBER changed the status of MediaWiki.r90452. Old Status: new New Status: ok User Brion VIBBER also posted a comment on MediaWiki.r90452. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90452#c18450 Commit summary: Partial revert of r86734: restore mPrefix - I still

[MediaWiki-CodeReview] [MediaWiki r86734]: Revision status changed

2011-06-21 Thread MediaWiki Mail
User Brion VIBBER changed the status of MediaWiki.r86734. Old Status: new New Status: resolved Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86734#c0 Commit summary: Cleanup next/prev links on special:search. Removed unused mPrefix.

[MediaWiki-CodeReview] [MediaWiki r86709]: New comment added, and revision status changed

2011-06-21 Thread MediaWiki Mail
User Brion VIBBER changed the status of MediaWiki.r86709. Old Status: new New Status: resolved User Brion VIBBER also posted a comment on MediaWiki.r86709. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86709#c18451 Commit summary: Updated patch from Bergi re: r86676 with

[MediaWiki-CodeReview] [MediaWiki r86676]: New comment added, and revision status changed

2011-06-21 Thread MediaWiki Mail
User Brion VIBBER changed the status of MediaWiki.r86676. Old Status: new New Status: resolved User Brion VIBBER also posted a comment on MediaWiki.r86676. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86676#c18452 Commit summary: Fix bug #28642 - wrong part-commentEnd set to

[MediaWiki-CodeReview] [MediaWiki r90528]: New comment added

2011-06-21 Thread MediaWiki Mail
User Jeroen De Dauw posted a comment on MediaWiki.r90528. Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/90528#c18453 Commit summary: fixed IE breakage Comment: Will remove once the issue has been fully fixed.

[MediaWiki-CodeReview] [MediaWiki r88231]: New comment added

2011-06-21 Thread MediaWiki Mail
User Brion VIBBER posted a comment on MediaWiki.r88231. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/88231#c18454 Commit summary: Fix ProfilerSimpleTextBreakage introduced by r86633 Comment: Needs merge to 1.18 to fix r86633. ___

[MediaWiki-CodeReview] [MediaWiki r88232]: New comment added

2011-06-21 Thread MediaWiki Mail
User Brion VIBBER posted a comment on MediaWiki.r88232. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/88232#c18455 Commit summary: unbreak ProfilerSimpleTrace, some Profile refactoring made it not worky :( Also, add it to AutoLoader Comment: Needs merge to 1.18 to fix r86633

[MediaWiki-CodeReview] [MediaWiki r90536]: New comment added

2011-06-21 Thread MediaWiki Mail
User Siebrand posted a comment on MediaWiki.r90536. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90536#c18456 Commit summary: Comment: Please do n ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org

[MediaWiki-CodeReview] [MediaWiki r86335]: New comment added, and revision status changed

2011-06-21 Thread MediaWiki Mail
User Aaron Schulz changed the status of MediaWiki.r86335. Old Status: new New Status: fixme User Aaron Schulz also posted a comment on MediaWiki.r86335. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86335#c18458 Commit summary: (bug 28583) chase down and beat to death external

[MediaWiki-CodeReview] [MediaWiki r90536]: New comment added

2011-06-21 Thread MediaWiki Mail
User Siebrand posted a comment on MediaWiki.r90536. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90536#c18457 Commit summary: Comment: Dang. iPhone edit screwup. Meant to write: please dO not make commits without a summary. In case you do, please use this comment system to

[MediaWiki-CodeReview] [MediaWiki r86336]: Revision status changed

2011-06-21 Thread MediaWiki Mail
User Aaron Schulz changed the status of MediaWiki.r86336. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86336#c0 Commit summary: Revert avars deprecation in r11308 Swap a couple of name() to getName()

[MediaWiki-CodeReview] [MediaWiki r86339]: Revision status changed

2011-06-21 Thread MediaWiki Mail
User Aaron Schulz changed the status of MediaWiki.r86339. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86339#c0 Commit summary: Follow-up r86255: getTitleFor() was not migrated. ___

[MediaWiki-CodeReview] [MediaWiki r90093]: Revision status changed

2011-06-21 Thread MediaWiki Mail
User Aaron Schulz changed the status of MediaWiki.r90093. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90093#c0 Commit summary: Followup to r86347, r86797: change SpecialUndelete-mFile to mFilename to remove conflict with SpecialPage-mFile which

[MediaWiki-CodeReview] [MediaWiki r86481]: Revision status changed

2011-06-21 Thread MediaWiki Mail
User Aaron Schulz changed the status of MediaWiki.r86481. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86481#c0 Commit summary: Follow-up r86407: missed a file (and some random documentation); I'm surprised it worked without it.

[MediaWiki-CodeReview] [MediaWiki r86505]: Revision status changed

2011-06-21 Thread MediaWiki Mail
User Aaron Schulz changed the status of MediaWiki.r86505. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86505#c0 Commit summary: Follow-up r86407: Add type hinting to SpecialPage::userCanExecute() overrides to avoid E_STRICT errors. Everywhere

[MediaWiki-CodeReview] [MediaWiki r86407]: Revision status changed

2011-06-21 Thread MediaWiki Mail
User Aaron Schulz changed the status of MediaWiki.r86407. Old Status: new New Status: resolved Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86407#c0 Commit summary: Follow-up r86255: don't special-case redirecting special pages in executePath(), make them subclass a

[MediaWiki-CodeReview] [MediaWiki r86383]: Revision status changed

2011-06-21 Thread MediaWiki Mail
User Aaron Schulz changed the status of MediaWiki.r86383. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86383#c0 Commit summary: Follow-up r86347: fix undefined variable by actually returning the type suggested in the documentation.

[MediaWiki-CodeReview] [MediaWiki r86347]: New comment added, and revision status changed

2011-06-21 Thread MediaWiki Mail
User Aaron Schulz changed the status of MediaWiki.r86347. Old Status: new New Status: fixme User Aaron Schulz also posted a comment on MediaWiki.r86347. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86347#c18459 Commit summary: Cleanup in SpecialPage.php: * Enforce private

[MediaWiki-CodeReview] [MediaWiki r86255]: New comment added

2011-06-21 Thread MediaWiki Mail
User Aaron Schulz posted a comment on MediaWiki.r86255. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86255#c18460 Commit summary: Refactor the factory/i18n/list/etc static methods from SpecialPage into their own class; there's no reason we need to be parsing them in every

[MediaWiki-CodeReview] [MediaWiki r86225]: Revision status changed

2011-06-21 Thread MediaWiki Mail
User Brion VIBBER changed the status of MediaWiki.r86225. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86225#c0 Commit summary: follow-up r86195 (Sort of). Make sure the string there can really be exploded before calling explode on it. I

[MediaWiki-CodeReview] [MediaWiki r86255]: Revision status changed

2011-06-21 Thread MediaWiki Mail
User Aaron Schulz changed the status of MediaWiki.r86255. Old Status: new New Status: resolved Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86255#c0 Commit summary: Refactor the factory/i18n/list/etc static methods from SpecialPage into their own class; there's no reason we

[MediaWiki-CodeReview] [MediaWiki r86349]: Revision status changed

2011-06-21 Thread MediaWiki Mail
User Aaron Schulz changed the status of MediaWiki.r86349. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86349#c0 Commit summary: checks for userbuckets added ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r86363]: Revision status changed

2011-06-21 Thread MediaWiki Mail
User Aaron Schulz changed the status of MediaWiki.r86363. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86363#c0 Commit summary: Apply LoadBalancer related fixes Patches by Yuvi Panda From (bug 28583) Remove all /* private */ declarations in

[MediaWiki-CodeReview] [MediaWiki r86398]: Revision status changed

2011-06-21 Thread MediaWiki Mail
User Aaron Schulz changed the status of MediaWiki.r86398. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86398#c0 Commit summary: Put the code for waiting for slave lag the new-and-improved way (using master position) in

[MediaWiki-CodeReview] [MediaWiki r86403]: Revision status changed

2011-06-21 Thread MediaWiki Mail
User Aaron Schulz changed the status of MediaWiki.r86403. Old Status: new New Status: deferred Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86403#c0 Commit summary: Splited to separate files, created GadgetsView. Export was removed as it's not going to be used in its present

[MediaWiki-CodeReview] [MediaWiki r86421]: Revision status changed

2011-06-21 Thread MediaWiki Mail
User Aaron Schulz changed the status of MediaWiki.r86421. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86421#c0 Commit summary: ClickTracking: Add some more indexes ___ MediaWiki-CodeReview mailing

[MediaWiki-CodeReview] [MediaWiki r89862]: Revision status changed

2011-06-21 Thread MediaWiki Mail
User ^demon changed the status of MediaWiki.r89862. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89862#c0 Commit summary: Add missing language name ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r90262]: Revision status changed

2011-06-21 Thread MediaWiki Mail
User ^demon changed the status of MediaWiki.r90262. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90262#c0 Commit summary: Add release note for r89329 (renamed localisation 'roa-rup' to 'rup') ___

[MediaWiki-CodeReview] [MediaWiki r89856]: New comment added

2011-06-21 Thread MediaWiki Mail
User ^demon posted a comment on MediaWiki.r89856. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89856#c18461 Commit summary: Follow-up to r75241 / 75241: rename LanguageBat_smg to LanguageSgs Comment: Release-notes, $wgDummyLanguageCodes, etc? You did those similar changes in

[MediaWiki-CodeReview] [MediaWiki r86633]: New comment added

2011-06-21 Thread MediaWiki Mail
User Aaron Schulz posted a comment on MediaWiki.r86633. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86633#c18462 Commit summary: * Added Profiler::isStub() to check if we are using a stub profiler, instead of checking whether $wgProfiler is set * Replaced wfProfileClose() and

[MediaWiki-CodeReview] [MediaWiki r86633]: New comment added

2011-06-21 Thread MediaWiki Mail
User ^demon posted a comment on MediaWiki.r86633. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86633#c18463 Commit summary: * Added Profiler::isStub() to check if we are using a stub profiler, instead of checking whether $wgProfiler is set * Replaced wfProfileClose() and

[MediaWiki-CodeReview] [MediaWiki r90540]: Revision status changed

2011-06-21 Thread MediaWiki Mail
User ^demon changed the status of MediaWiki.r90540. Old Status: new New Status: deferred Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90540#c0 Commit summary: Added table cell centering to stylesheet ___ MediaWiki-CodeReview mailing

[MediaWiki-CodeReview] [MediaWiki r89856]: New comment added

2011-06-21 Thread MediaWiki Mail
User SPQRobin posted a comment on MediaWiki.r89856. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89856#c18464 Commit summary: Follow-up to r75241 / 75241: rename LanguageBat_smg to LanguageSgs Comment: Bat-smg - sgs had been done in r74771, r75240, r75241 and r75244. However,

[MediaWiki-CodeReview] [MediaWiki r89856]: New comment added

2011-06-21 Thread MediaWiki Mail
User ^demon posted a comment on MediaWiki.r89856. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89856#c18465 Commit summary: Follow-up to r75241 / 75241: rename LanguageBat_smg to LanguageSgs Comment: Ah ok, thanks for the links that makes it way clearer :)

[MediaWiki-CodeReview] [MediaWiki r89856]: Revision status changed

2011-06-21 Thread MediaWiki Mail
User ^demon changed the status of MediaWiki.r89856. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89856#c0 Commit summary: Follow-up to r75241 / 75241: rename LanguageBat_smg to LanguageSgs ___

[MediaWiki-CodeReview] [MediaWiki r86633]: Revision status changed

2011-06-21 Thread MediaWiki Mail
User Aaron Schulz changed the status of MediaWiki.r86633. Old Status: new New Status: resolved Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86633#c0 Commit summary: * Added Profiler::isStub() to check if we are using a stub profiler, instead of checking whether $wgProfiler is

[MediaWiki-CodeReview] [MediaWiki r86716]: Revision status changed

2011-06-21 Thread MediaWiki Mail
User Aaron Schulz changed the status of MediaWiki.r86716. Old Status: new New Status: deferred Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86716#c0 Commit summary: Proposed DB schema, first approach ___ MediaWiki-CodeReview mailing

[MediaWiki-CodeReview] [MediaWiki r86725]: Revision status changed

2011-06-21 Thread MediaWiki Mail
User Aaron Schulz changed the status of MediaWiki.r86725. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86725#c0 Commit summary: Doc comment updates for CoreTagHooks callback functions + Parser::setHook() Parser::setTransparentTagHook(). Added

[MediaWiki-CodeReview] [MediaWiki r89664]: Revision status changed

2011-06-21 Thread MediaWiki Mail
User Aaron Schulz changed the status of MediaWiki.r89664. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89664#c0 Commit summary: Commenty tweaky stuffs ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r89669]: Revision status changed

2011-06-21 Thread MediaWiki Mail
User Aaron Schulz changed the status of MediaWiki.r89669. Old Status: new New Status: deferred Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89669#c0 Commit summary: introduction sentence for the renderers demo ___

[MediaWiki-CodeReview] [MediaWiki r89682]: Revision status changed

2011-06-21 Thread MediaWiki Mail
User Aaron Schulz changed the status of MediaWiki.r89682. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89682#c0 Commit summary: Started documenting changes needed. ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r89697]: Revision status changed

2011-06-21 Thread MediaWiki Mail
User Aaron Schulz changed the status of MediaWiki.r89697. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89697#c0 Commit summary: Fix (bug 29307) Line-height in pre is too narrow, edges overlap in some environments

[MediaWiki-CodeReview] [MediaWiki r89720]: Revision status changed

2011-06-21 Thread MediaWiki Mail
User Aaron Schulz changed the status of MediaWiki.r89720. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89720#c0 Commit summary: * Added release notes for REL1_17 changes up to and including r89676. * Updates for 1.17.0rc1 with speculative release

[MediaWiki-CodeReview] [MediaWiki r89728]: Revision status changed

2011-06-21 Thread MediaWiki Mail
User Aaron Schulz changed the status of MediaWiki.r89728. Old Status: new New Status: deferred Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89728#c0 Commit summary: Localization update for he. ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r89731]: Revision status changed

2011-06-21 Thread MediaWiki Mail
User Aaron Schulz changed the status of MediaWiki.r89731. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89731#c0 Commit summary: * fixed regex to work * added missing directories ___

[MediaWiki-CodeReview] [MediaWiki r89738]: Revision status changed

2011-06-21 Thread MediaWiki Mail
User Aaron Schulz changed the status of MediaWiki.r89738. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89738#c0 Commit summary: Revert r89374, r88936 backports. ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r89746]: Revision status changed

2011-06-21 Thread MediaWiki Mail
User Aaron Schulz changed the status of MediaWiki.r89746. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89746#c0 Commit summary: Remove logging code ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r89779]: New comment added, and revision status changed

2011-06-21 Thread MediaWiki Mail
User Aaron Schulz changed the status of MediaWiki.r89779. Old Status: new New Status: fixme User Aaron Schulz also posted a comment on MediaWiki.r89779. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89779#c18467 Commit summary: Fix messages on Special:ArticleFeedback per Howie

[MediaWiki-CodeReview] [MediaWiki r89788]: Revision status changed

2011-06-21 Thread MediaWiki Mail
User Aaron Schulz changed the status of MediaWiki.r89788. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89788#c0 Commit summary: Fix grammar in message per Howie: pageS, plural ___ MediaWiki-CodeReview

[MediaWiki-CodeReview] [MediaWiki r89790]: Revision status changed

2011-06-21 Thread MediaWiki Mail
User Aaron Schulz changed the status of MediaWiki.r89790. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89790#c0 Commit summary: Removed some usage of error suppression operator ___ MediaWiki-CodeReview

[MediaWiki-CodeReview] [MediaWiki r89706]: New comment added

2011-06-21 Thread MediaWiki Mail
User Platonides posted a comment on MediaWiki.r89706. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89706#c18468 Commit summary: Reinstate r79122 (fix for bug 14404), reverting r83868. The real bug seem to have been r86131, fixed in r88902 (1.17) and r88902 (1.18). This is not

[MediaWiki-CodeReview] [MediaWiki r89792]: Revision status changed

2011-06-21 Thread MediaWiki Mail
User Aaron Schulz changed the status of MediaWiki.r89792. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89792#c0 Commit summary: If this was ever passed an empty string it would spit PHP Notice: Uninitialized string offset: 0...

[MediaWiki-CodeReview] [MediaWiki r89706]: New comment added

2011-06-21 Thread MediaWiki Mail
User Aaron Schulz posted a comment on MediaWiki.r89706. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89706#c18469 Commit summary: Reinstate r79122 (fix for bug 14404), reverting r83868. The real bug seem to have been r86131, fixed in r88902 (1.17) and r88902 (1.18). This is

[MediaWiki-CodeReview] [MediaWiki r89794]: Revision status changed

2011-06-21 Thread MediaWiki Mail
User Aaron Schulz changed the status of MediaWiki.r89794. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89794#c0 Commit summary: Recommit SpecialPage.php and SpecialPageFactory.php parts of r89406 (removal of magic __get() accessor for

[MediaWiki-CodeReview] [MediaWiki r89796]: Revision status changed

2011-06-21 Thread MediaWiki Mail
User Aaron Schulz changed the status of MediaWiki.r89796. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89796#c0 Commit summary: Marked Article::doRedirect() as deprecated, was used by Article::insertNewArticle() and Article::updateArticle() that

[MediaWiki-CodeReview] [MediaWiki r90483]: Revision status changed

2011-06-21 Thread MediaWiki Mail
User Reedy changed the status of MediaWiki.r90483. Old Status: new New Status: reverted Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90483#c0 Commit summary: Mark test incomplete for a legitimate reason like trying to serialize a PDO object--rather than imaginary ones such as

[MediaWiki-CodeReview] [MediaWiki r90483]: Revision status changed

2011-06-21 Thread MediaWiki Mail
User Reedy changed the status of MediaWiki.r90483. Old Status: reverted New Status: new Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90483#c0 Commit summary: Mark test incomplete for a legitimate reason like trying to serialize a PDO object--rather than imaginary ones such as

[MediaWiki-CodeReview] [MediaWiki r89800]: Revision status changed

2011-06-21 Thread MediaWiki Mail
User Aaron Schulz changed the status of MediaWiki.r89800. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89800#c0 Commit summary: Self revert r89797: At least the block log link is wrong. I should not commit when bed calls me :/

[MediaWiki-CodeReview] [MediaWiki r89797]: Revision status changed

2011-06-21 Thread MediaWiki Mail
User Aaron Schulz changed the status of MediaWiki.r89797. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89797#c0 Commit summary: Simplify link construction a bit. ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r90543]: Revision status changed

2011-06-21 Thread MediaWiki Mail
User ^demon changed the status of MediaWiki.r90543. Old Status: new New Status: deferred Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90543#c0 Commit summary: Localisation updates for ToolserverI18N messages from translatewiki.net (2011-06-21 20:05:00)

[MediaWiki-CodeReview] [MediaWiki r89833]: Revision status changed

2011-06-21 Thread MediaWiki Mail
User Aaron Schulz changed the status of MediaWiki.r89833. Old Status: new New Status: resolved Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89833#c0 Commit summary: Simplify link construction a bit. ___ MediaWiki-CodeReview mailing

[MediaWiki-CodeReview] [MediaWiki r89846]: Revision status changed

2011-06-21 Thread MediaWiki Mail
User Aaron Schulz changed the status of MediaWiki.r89846. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89846#c0 Commit summary: Minor edits for compatibility. ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r89848]: New comment added, and revision status changed

2011-06-21 Thread MediaWiki Mail
User Aaron Schulz changed the status of MediaWiki.r89848. Old Status: new New Status: ok User Aaron Schulz also posted a comment on MediaWiki.r89848. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89848#c18470 Commit summary: Follow-up: r89845: Forgot to commit changes in the

[MediaWiki-CodeReview] [MediaWiki r89869]: Revision status changed

2011-06-21 Thread MediaWiki Mail
User Aaron Schulz changed the status of MediaWiki.r89869. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89869#c0 Commit summary: Changed more magic __get method calls to accessors, were throwing notices

[MediaWiki-CodeReview] [MediaWiki r89872]: Revision status changed

2011-06-21 Thread MediaWiki Mail
User Aaron Schulz changed the status of MediaWiki.r89872. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89872#c0 Commit summary: Moved part of action handling functions near other ones ___

Re: [Wikitech-l] Code review for 1.18: Keeping it awesome!

2011-06-21 Thread Tomasz Finc
thats all sorts of awesome. --tomasz On Tue, Jun 21, 2011 at 1:06 PM, Mark A. Hershberger mhershber...@wikimedia.org wrote: A quick glance at http://toolserver.org/~robla/crstats/crstats.118all.html late last week showed we were making awesome progress.  Today, it looks like we can easily

[MediaWiki-CodeReview] [MediaWiki r89875]: Revision status changed

2011-06-21 Thread MediaWiki Mail
User Aaron Schulz changed the status of MediaWiki.r89875. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89875#c0 Commit summary: And I forgot to commit this file in r89874 ___ MediaWiki-CodeReview

[MediaWiki-CodeReview] [MediaWiki r89874]: Revision status changed

2011-06-21 Thread MediaWiki Mail
User Aaron Schulz changed the status of MediaWiki.r89874. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89874#c0 Commit summary: * Made Special:RevisionDelete use the local variables stored in the RequestContext object instead of global ones and

  1   2   3   >