[MediaWiki-CodeReview] [MediaWiki r91817]: New comment added

2011-07-11 Thread MediaWiki Mail
User IAlex posted a comment on MediaWiki.r91817. Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/91817#c19415 Commit summary: Now that the hooks ArticleDelete and ArticleDeleteComplete are called from WikiPage::doDeleteArticle() and not anymore from

[MediaWiki-CodeReview] [MediaWiki r91749]: New comment added

2011-07-11 Thread MediaWiki Mail
User F.trott posted a comment on MediaWiki.r91749. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91749#c19416 Commit summary: r86603 : Updating module name of mediawiki.legacy.edit in SemanticForms Extension Comment: Do we need a version switch here? SF still states

[MediaWiki-CodeReview] [MediaWiki r91749]: New comment added

2011-07-11 Thread MediaWiki Mail
User DieBuche posted a comment on MediaWiki.r91749. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91749#c19417 Commit summary: r86603 : Updating module name of mediawiki.legacy.edit in SemanticForms Extension Comment: We're already inside a pseudo version switch: if (

[MediaWiki-CodeReview] [MediaWiki r91548]: New comment added

2011-07-11 Thread MediaWiki Mail
User Schnark posted a comment on MediaWiki.r91548. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91548#c19418 Commit summary: Redoing r87173 with scrollbars instead of word-wrap per CR Comment: Look at http://translatewiki.net/wiki/MediaWiki:Common.css versus

[MediaWiki-CodeReview] [MediaWiki r91749]: New comment added

2011-07-11 Thread MediaWiki Mail
User F.trott posted a comment on MediaWiki.r91749. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91749#c19419 Commit summary: r86603 : Updating module name of mediawiki.legacy.edit in SemanticForms Extension Comment: Yes, but it does not cover the switch from

[MediaWiki-CodeReview] [MediaWiki r91548]: New comment added

2011-07-11 Thread MediaWiki Mail
User DieBuche posted a comment on MediaWiki.r91548. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91548#c19420 Commit summary: Redoing r87173 with scrollbars instead of word-wrap per CR Comment: You can also scroll by selecting dragging the text to the right. Not perfect

[MediaWiki-CodeReview] [MediaWiki r91749]: New comment added

2011-07-11 Thread MediaWiki Mail
User DieBuche posted a comment on MediaWiki.r91749. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91749#c19421 Commit summary: r86603 : Updating module name of mediawiki.legacy.edit in SemanticForms Extension Comment: Right. I'll add one later

Re: [Wikitech-l] thumbnail generation for Extension:OggHandler

2011-07-11 Thread Dmitriy Sintsov
* Michael Dale md...@wikimedia.org [Fri, 08 Jul 2011 10:52:52 -0700]: I recommend using the static binaries hosted on firefogg or if you want to compile it your self using the build tools provided there: http://firefogg.org/nightly/ Hi Michael, thank you for the tips. Static binary for

Re: [Wikitech-l] thumbnail generation for Extension:OggHandler

2011-07-11 Thread Dmitriy Sintsov
I run MediaWiki 1.17.0 (r6) and use TimedMediaHandler is r91852. I always prefer to run stable MW and latest extensions. Is it wrong idea? 2011/07/11 15:12:51 [error] 21984#0: *1029 FastCGI sent in stderr: PHP Warning: array_merge(): Argument #1 is not an array in /var/www/wiki/universe/extensi

[MediaWiki-CodeReview] [MediaWiki r91854]: New comment added

2011-07-11 Thread MediaWiki Mail
User Raymond posted a comment on MediaWiki.r91854. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91854#c19422 Commit summary: SocialProfile: add a special page, Special:GenerateTopUsersReport, to generate the report of the users who earned the most points during the past week

Re: [Wikitech-l] thumbnail generation for Extension:OggHandler

2011-07-11 Thread Dmitriy Sintsov
Yes, locally patched both issues, now runs fine. $wgExcludeFromThumbnailPurge is not defined in 1.17, made a check. BTW, it is a bit evil to exclude some extensions from Purge. Maybe there should be another action Superpurge? Linker::link() was called statically in TranscodeStatusTable class.

Re: [Wikitech-l] Wikimedia engineering report for June 2011

2011-07-11 Thread Paul Houle
On 7/1/2011 11:19 AM, Guillaume Paumier wrote: *Academic publications authentication proxy* --- Chad Horohoe http://www.mediawiki.org/wiki/User:%5Edemon started a project whose goal is to allow selected Wikimedians to access third-party academic publishing sites to help with content

[MediaWiki-CodeReview] [MediaWiki r91882]: New comment added

2011-07-11 Thread MediaWiki Mail
User Reedy posted a comment on MediaWiki.r91882. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91882#c19423 Commit summary: Added Global statistics support Comment: 1 very minor issue is pre if(! $is_new_rating ) { /pre Should really be pre if( !$is_new_rating ) { /pre The

[MediaWiki-CodeReview] [MediaWiki r91882]: New comment added

2011-07-11 Thread MediaWiki Mail
User Yuvipanda posted a comment on MediaWiki.r91882. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91882#c19424 Commit summary: Added Global statistics support Comment: Ow, isn't !$ kinda weird? Is there any particular reasoning for this? Doesn't the ! get lost with the $?

[MediaWiki-CodeReview] [MediaWiki r91882]: New comment added

2011-07-11 Thread MediaWiki Mail
User ^demon posted a comment on MediaWiki.r91882. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91882#c19425 Commit summary: Added Global statistics support Comment: No, it's the way we format our code :) ___ MediaWiki-CodeReview

[MediaWiki-CodeReview] [MediaWiki r91627]: New comment added

2011-07-11 Thread MediaWiki Mail
User ^demon posted a comment on MediaWiki.r91627. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91627#c19426 Commit summary: Initial import of GSoC project. Comment: This is the review of your proposed schema: * I see you used my old mwreleases schema for tracking MediaWiki

[MediaWiki-CodeReview] [MediaWiki r91882]: New comment added

2011-07-11 Thread MediaWiki Mail
User Yuvipanda posted a comment on MediaWiki.r91882. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91882#c19427 Commit summary: Added Global statistics support Comment: Dammit, whining doesn't seem to get me anywhere. Will fix. ___

[MediaWiki-CodeReview] [MediaWiki r89165]: New comment added

2011-07-11 Thread MediaWiki Mail
User Yuvipanda posted a comment on MediaWiki.r89165. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89165#c19428 Commit summary: Added entry for alias file Comment: http://xkcd.com/583/ ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r89165]: New comment added

2011-07-11 Thread MediaWiki Mail
User Bawolff posted a comment on MediaWiki.r89165. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89165#c19429 Commit summary: Added entry for alias file Comment: Do you have [[Manual:$wgDevelopmentWarnings]] on? ___

[MediaWiki-CodeReview] [MediaWiki r91854]: New comment added

2011-07-11 Thread MediaWiki Mail
User Jack Phoenix posted a comment on MediaWiki.r91854. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91854#c19430 Commit summary: SocialProfile: add a special page, Special:GenerateTopUsersReport, to generate the report of the users who earned the most points during the past

Re: [Wikitech-l] thumbnail generation for Extension:OggHandler

2011-07-11 Thread Michael Dale
Thanks for this thread, Please do commit fixes for 1.17, If not obvious already I have really only been targeting trunk. While the extension has been around since before 1.16, it would be very complicated to restore the custom resource loader it was using before there was a resource loader in

[MediaWiki-CodeReview] [MediaWiki r88815]: Revision status changed

2011-07-11 Thread MediaWiki Mail
User Aaron Schulz changed the status of MediaWiki.r88815. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/88815#c0 Commit summary: * Check existence in correct language * Simplify a bit existence check

[MediaWiki-CodeReview] [MediaWiki r90256]: New comment added, and revision status changed

2011-07-11 Thread MediaWiki Mail
User Bawolff changed the status of MediaWiki.r90256. Old Status: fixme New Status: new User Bawolff also posted a comment on MediaWiki.r90256. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90256#c19431 Commit summary: (follow-up r86567) per CR rename the class

[MediaWiki-CodeReview] [MediaWiki r91784]: New comment added, and revision status changed

2011-07-11 Thread MediaWiki Mail
User Aaron Schulz changed the status of MediaWiki.r91784. Old Status: new New Status: ok User Aaron Schulz also posted a comment on MediaWiki.r91784. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91784#c19432 Commit summary: Pass the User object to

[MediaWiki-CodeReview] [MediaWiki r88727]: Revision status changed

2011-07-11 Thread MediaWiki Mail
User Aaron Schulz changed the status of MediaWiki.r88727. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/88727#c0 Commit summary: Simplify message existence checks by using wfMessage() instead of wfEmptyMsg()

[MediaWiki-CodeReview] [MediaWiki r91807]: Revision status changed

2011-07-11 Thread MediaWiki Mail
User Catrope changed the status of MediaWiki.r91807. Old Status: new New Status: deferred Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/91807#c0 Commit summary: Localisation updates for core and extension messages from translatewiki.net (2011-07-09

[MediaWiki-CodeReview] [MediaWiki r91886]: New comment added

2011-07-11 Thread MediaWiki Mail
User Reedy posted a comment on MediaWiki.r91886. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91886#c19433 Commit summary: (bug 29797) Error: Tried to load block with invalid type when subpages are disabled for user pages. Patch by Jarry1250 Comment: pre

[MediaWiki-CodeReview] [MediaWiki r90687]: Revision status changed

2011-07-11 Thread MediaWiki Mail
User Catrope changed the status of MediaWiki.r90687. Old Status: new New Status: ok Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/90687#c0 Commit summary: move comment ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r91854]: New comment added

2011-07-11 Thread MediaWiki Mail
User Raymond posted a comment on MediaWiki.r91854. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91854#c19434 Commit summary: SocialProfile: add a special page, Special:GenerateTopUsersReport, to generate the report of the users who earned the most points during the past week

[MediaWiki-CodeReview] [MediaWiki r91030]: Revision status changed

2011-07-11 Thread MediaWiki Mail
User Catrope changed the status of MediaWiki.r91030. Old Status: new New Status: ok Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/91030#c0 Commit summary: InstantCommons files also have -1 as page id; handle this case when dealing with filename

[MediaWiki-CodeReview] [MediaWiki r91886]: New comment added

2011-07-11 Thread MediaWiki Mail
User SPQRobin posted a comment on MediaWiki.r91886. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91886#c19435 Commit summary: (bug 29797) Error: Tried to load block with invalid type when subpages are disabled for user pages. Patch by Jarry1250 Comment: Ah, didn't know that,

[MediaWiki-CodeReview] [MediaWiki r91525]: Revision status changed

2011-07-11 Thread MediaWiki Mail
User Catrope changed the status of MediaWiki.r91525. Old Status: new New Status: ok Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/91525#c0 Commit summary: (part of bug 24692) Make RTL versions of the arrows at the top of UploadWizard

[MediaWiki-CodeReview] [MediaWiki r91887]: Revision status changed

2011-07-11 Thread MediaWiki Mail
User Reedy changed the status of MediaWiki.r91887. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91887#c0 Commit summary: Jarry1250 = Harry Burt, per Reedy on r91886 ___ MediaWiki-CodeReview mailing

[MediaWiki-CodeReview] [MediaWiki r91074]: Revision status changed

2011-07-11 Thread MediaWiki Mail
User Aaron Schulz changed the status of MediaWiki.r91074. Old Status: new New Status: resolved Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91074#c0 Commit summary: * Modified some methods of SpecialWatchlist to be non-static so that they can use $this-getTitle() instead of

[MediaWiki-CodeReview] [MediaWiki r91875]: New comment added

2011-07-11 Thread MediaWiki Mail
User Siebrand posted a comment on MediaWiki.r91875. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91875#c19436 Commit summary: * (bug 16699) {{#language:}} accepts second parameter to specify the language in which the language name is wanted. Coverage depends on the cldr

[MediaWiki-CodeReview] [MediaWiki r89005]: Revision status changed

2011-07-11 Thread MediaWiki Mail
User Aaron Schulz changed the status of MediaWiki.r89005. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89005#c0 Commit summary: Refactor MessageBlobStore::updateModule() to remove the multi-language update behavior. Instead of updating all

[MediaWiki-CodeReview] [MediaWiki r91461]: Revision status changed

2011-07-11 Thread MediaWiki Mail
User Aaron Schulz changed the status of MediaWiki.r91461. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91461#c0 Commit summary: Override IndexPager::getTitle() in AlphabeticPager instance of core to not rely on $wgTitle

[MediaWiki-CodeReview] [MediaWiki r91889]: Revision status changed

2011-07-11 Thread MediaWiki Mail
User Reedy changed the status of MediaWiki.r91889. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91889#c0 Commit summary: Fix MIME types of images added in r91525 ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r91551]: Revision status changed

2011-07-11 Thread MediaWiki Mail
User Aaron Schulz changed the status of MediaWiki.r91551. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91551#c0 Commit summary: Override Pager::getTitle() in core subclasses of ReverseChronologicalPager that don't have it

[MediaWiki-CodeReview] [MediaWiki r91677]: New comment added

2011-07-11 Thread MediaWiki Mail
User Aaron Schulz posted a comment on MediaWiki.r91677. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91677#c19437 Commit summary: * Fixed comment * Wrap arround RequestContext::msg() instead of doing that all that stuff once more Comment: Ah, my SVN copy was outdated ;)

[MediaWiki-CodeReview] [MediaWiki r91677]: Revision status changed

2011-07-11 Thread MediaWiki Mail
User Aaron Schulz changed the status of MediaWiki.r91677. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91677#c0 Commit summary: * Fixed comment * Wrap arround RequestContext::msg() instead of doing that all that stuff once more

[MediaWiki-CodeReview] [MediaWiki r91800]: Revision status changed

2011-07-11 Thread MediaWiki Mail
User Aaron Schulz changed the status of MediaWiki.r91800. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91800#c0 Commit summary: Call doMarkPatrolled() on the RecentChange object instead of calling RecentChange::markPatrolled() that will create a

[MediaWiki-CodeReview] [MediaWiki r89001]: Revision status changed

2011-07-11 Thread MediaWiki Mail
User Aaron Schulz changed the status of MediaWiki.r89001. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89001#c0 Commit summary: Fix issue on the live site causing RL requests for ext.uploadWizard to consistently take more than 5 seconds: the

[MediaWiki-CodeReview] [MediaWiki r88705]: Revision status changed

2011-07-11 Thread MediaWiki Mail
User Aaron Schulz changed the status of MediaWiki.r88705. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/88705#c0 Commit summary: Rewriting mw.loader test suite. The previous one didn't work properly in IE6-IE8.

[MediaWiki-CodeReview] [MediaWiki r91875]: New comment added

2011-07-11 Thread MediaWiki Mail
User Nikerabbit posted a comment on MediaWiki.r91875. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91875#c19438 Commit summary: * (bug 16699) {{#language:}} accepts second parameter to specify the language in which the language name is wanted. Coverage depends on the cldr

[MediaWiki-CodeReview] [MediaWiki r91844]: New comment added

2011-07-11 Thread MediaWiki Mail
User Brion VIBBER posted a comment on MediaWiki.r91844. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91844#c19439 Commit summary: Add test suite for jquery.byteLimit: - Tests to verify that the byteLength does not exceed the byteLimit when inserting more characters - Tests to

[MediaWiki-CodeReview] [MediaWiki r91875]: New comment added

2011-07-11 Thread MediaWiki Mail
User Siebrand posted a comment on MediaWiki.r91875. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91875#c19440 Commit summary: * (bug 16699) {{#language:}} accepts second parameter to specify the language in which the language name is wanted. Coverage depends on the cldr

[MediaWiki-CodeReview] [MediaWiki r88646]: Revision status changed

2011-07-11 Thread MediaWiki Mail
User Aaron Schulz changed the status of MediaWiki.r88646. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/88646#c0 Commit summary: * Simplify message existence checks by using wfMessage() instead of wfMsg() with wfEmptyMsg() * Fixed one check in

[MediaWiki-CodeReview] [MediaWiki r91830]: Revision status changed

2011-07-11 Thread MediaWiki Mail
User Siebrand changed the status of MediaWiki.r91830. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91830#c0 Commit summary: Tweak extension credits, add description message Add extension to Translatewiki, ping r87714 to inform the author

[MediaWiki-CodeReview] [MediaWiki r91875]: New comment added

2011-07-11 Thread MediaWiki Mail
User Nikerabbit posted a comment on MediaWiki.r91875. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91875#c19441 Commit summary: * (bug 16699) {{#language:}} accepts second parameter to specify the language in which the language name is wanted. Coverage depends on the cldr

[MediaWiki-CodeReview] [MediaWiki r91844]: New comment added, and revision status changed

2011-07-11 Thread MediaWiki Mail
User Brion VIBBER changed the status of MediaWiki.r91844. Old Status: new New Status: resolved User Brion VIBBER also posted a comment on MediaWiki.r91844. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91844#c19442 Commit summary: Add test suite for jquery.byteLimit: - Tests

[MediaWiki-CodeReview] [MediaWiki r91894]: Revision status changed

2011-07-11 Thread MediaWiki Mail
User Krinkle changed the status of MediaWiki.r91894. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91894#c0 Commit summary: Followup r91844: fix jquery.byteLimit test cases on IE6, IE7 str[i] doesn't work on these older browsers; use

[MediaWiki-CodeReview] [MediaWiki r91891]: Revision status changed

2011-07-11 Thread MediaWiki Mail
User Krinkle changed the status of MediaWiki.r91891. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91891#c0 Commit summary: * (bug 29804) Fix byte-length-limited fields to check the length of to-be-added char instead of hardcoding a possible

[MediaWiki-CodeReview] [MediaWiki r88071]: Revision status changed

2011-07-11 Thread MediaWiki Mail
User Aaron Schulz changed the status of MediaWiki.r88071. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/88071#c0 Commit summary: Follow-up r88054: Update messages.inc ___ MediaWiki-CodeReview mailing

[MediaWiki-CodeReview] [MediaWiki r91857]: Revision status changed

2011-07-11 Thread MediaWiki Mail
User Krinkle changed the status of MediaWiki.r91857. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91857#c0 Commit summary: follow-up to r91853 - revising comments to explain the new logic, also guarding against javascript error in case of

[MediaWiki-CodeReview] [MediaWiki r88054]: Revision status changed

2011-07-11 Thread MediaWiki Mail
User Aaron Schulz changed the status of MediaWiki.r88054. Old Status: new New Status: resolved Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/88054#c0 Commit summary: (bug 23002) Imagelinks table not updated after imagemove. The actual bug was inconsistent behaviour between

[MediaWiki-CodeReview] [MediaWiki r91853]: New comment added

2011-07-11 Thread MediaWiki Mail
User Krinkle posted a comment on MediaWiki.r91853. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91853#c19444 Commit summary: Use more strict if-statement to decide whether to reload current page or rebuild url. - Extracting the current url without the hash-tag - Building the

Re: [Wikitech-l] testing mobile browsers?

2011-07-11 Thread Brion Vibber
On Sat, Jul 9, 2011 at 2:30 AM, Ashar Voultoiz hashar+...@free.fr wrote: * Safari, Opera Mozilla for mobile : they are probably mostly the same as the desktop version. I have not found emulators for them. * Android : has an emulator. On my computer it is painfully slow and not usable for

[MediaWiki-CodeReview] [MediaWiki r91896]: Revision status changed

2011-07-11 Thread MediaWiki Mail
User Krinkle changed the status of MediaWiki.r91896. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91896#c0 Commit summary: Follow-up r91895: Call parent destructor as well, just to be safe. ___

Re: [Wikitech-l] testing mobile browsers?

2011-07-11 Thread Steven Walling
On Mon, Jul 11, 2011 at 11:40 AM, Brion Vibber br...@pobox.com wrote: default redirection to the appropriate view based on device I can tell you right now that Firefox for Android has never redirected to the mobile site for me. If you want more device/version details let me know... Steven

Re: [Wikitech-l] Postmortem for the MediaWiki 1.17 release

2011-07-11 Thread Ashar Voultoiz
On 07/07/11 03:42, Rob Lanphier wrote: http://live.gnome.org/ThreePointOne snip having clear deadlines for proposing new features, deadlines for features being done or pulled, and other date-risk mitigation strategies. Having a roadmap like Gnome is the way I am advocating. Another way I

Re: [Wikitech-l] Postmortem for the MediaWiki 1.17 release

2011-07-11 Thread Ashar Voultoiz
On 07/07/11 03:42, Rob Lanphier wrote: we're probably too reliant on Tim to not only drive but execute many steps. snip Additionally, we will probably experiment with other team members (e.g. Chad) performing at least alpha or beta releases. This is actually a great way to train new people.

Re: [Wikitech-l] testing mobile browsers?

2011-07-11 Thread Jay Ashworth
- Original Message - From: Brion Vibber br...@pobox.com * default redirection to the appropriate view based on device Please remember that some people with high-function browsers *want* the low-function results... and some people with *what your code thinks are low-function browsers*

Re: [Wikitech-l] testing mobile browsers?

2011-07-11 Thread Stephen Bain
On Sat, Jul 9, 2011 at 7:30 PM, Ashar Voultoiz hashar+...@free.fr wrote: * Android : has an emulator. On my computer it is painfully slow and not usable for anything. I can connect to TestSwarm with the stock Android browser on 2.3 (though it's identifying it as 2.2) but it won't give me any

Re: [Wikitech-l] testing mobile browsers?

2011-07-11 Thread Stephen Bain
On Tue, Jul 12, 2011 at 5:59 AM, Stephen Bain stephen.b...@gmail.com wrote: TestSwarm 'doesn't need my help' when I load it with Fennec 5 or Opera Mobile 11.1. Though Opera does allow you to set the UA to mobile or desktop, and it will let me run tests when set to the desktop version.

Re: [Wikitech-l] testing mobile browsers?

2011-07-11 Thread Brion Vibber
On Mon, Jul 11, 2011 at 12:56 PM, Jay Ashworth j...@baylink.com wrote: - Original Message - From: Brion Vibber br...@pobox.com * default redirection to the appropriate view based on device Please remember that some people with high-function browsers *want* the low-function

[MediaWiki-CodeReview] [MediaWiki r91842]: Revision status changed

2011-07-11 Thread MediaWiki Mail
User Aaron Schulz changed the status of MediaWiki.r91842. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91842#c0 Commit summary: * Changed dynamic calls to Linker methods into static ones * Also preferably pass a Language object instead of a Skin

[MediaWiki-CodeReview] [MediaWiki r91804]: Revision status changed

2011-07-11 Thread MediaWiki Mail
User Aaron Schulz changed the status of MediaWiki.r91804. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91804#c0 Commit summary: Added Request::setLang() and RequestContext::setSkin(); the latter will clone the object and set the context on it.

[MediaWiki-CodeReview] [MediaWiki r91744]: Revision status changed

2011-07-11 Thread MediaWiki Mail
User Aaron Schulz changed the status of MediaWiki.r91744. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91744#c0 Commit summary: Fix for r78786: make Special:Wantedpages includable again ___

[MediaWiki-CodeReview] [MediaWiki r91862]: Revision status changed

2011-07-11 Thread MediaWiki Mail
User Aaron Schulz changed the status of MediaWiki.r91862. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91862#c0 Commit summary: Override UsersPager::getTitle() in ActiveUsersPager ___

[MediaWiki-CodeReview] [MediaWiki r91864]: Revision status changed

2011-07-11 Thread MediaWiki Mail
User Aaron Schulz changed the status of MediaWiki.r91864. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91864#c0 Commit summary: Call Linker methods statically and removed the $mSkin member ___

Re: [Wikitech-l] ResourceLoader JavaScript validation on trunk (bug 28626)

2011-07-11 Thread Brion Vibber
On Wed, Jul 6, 2011 at 3:04 PM, Brion Vibber br...@pobox.com wrote: Only the parser is being used right now, in two places: - on the JavaScriptMinifier test cases to confirm that results are valid JS (should be extended to a fuzz tester, probably) - on each individual file loaded via

[MediaWiki-CodeReview] [MediaWiki r91859]: Revision status changed

2011-07-11 Thread MediaWiki Mail
User Aaron Schulz changed the status of MediaWiki.r91859. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91859#c0 Commit summary: Removed print and render actions from the check: * print was removed in 86373 * render does not reach this point since

[MediaWiki-CodeReview] [MediaWiki r91820]: Revision status changed

2011-07-11 Thread MediaWiki Mail
User Aaron Schulz changed the status of MediaWiki.r91820. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91820#c0 Commit summary: Disable feed mode when including the page. I know that there is already r87705 to address this, but this one is

[MediaWiki-CodeReview] [MediaWiki r91861]: Revision status changed

2011-07-11 Thread MediaWiki Mail
User Aaron Schulz changed the status of MediaWiki.r91861. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91861#c0 Commit summary: Use getPageTitle() to set the page title instead of doing it manually ___

[MediaWiki-CodeReview] [MediaWiki r91732]: Revision status changed

2011-07-11 Thread MediaWiki Mail
User Aaron Schulz changed the status of MediaWiki.r91732. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91732#c0 Commit summary: Create a new RequestContext to use its OutputPage and Skin members instead of messing with global ones

[MediaWiki-CodeReview] [MediaWiki r80612]: New comment added

2011-07-11 Thread MediaWiki Mail
User Siebrand posted a comment on MediaWiki.r80612. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/80612#c19445 Commit summary: Partial revert r78450: doQuery() and query() are not the same. You can't just swap one for the other without checking what might be using the result

[MediaWiki-CodeReview] [MediaWiki r89817]: New comment added

2011-07-11 Thread MediaWiki Mail
User Siebrand posted a comment on MediaWiki.r89817. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89817#c19446 Commit summary: Fix for logic error in r89529 causing a notice. Comment: Tagging 1.18 because r89529 is tagged 1.18. ___

[MediaWiki-CodeReview] [MediaWiki r90531]: New comment added

2011-07-11 Thread MediaWiki Mail
User Siebrand posted a comment on MediaWiki.r90531. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90531#c19447 Commit summary: Follow up with the problem noted in r90530. You can't pass the result of a function to reset(), since it expects a reference. Those random errors show

[MediaWiki-CodeReview] [MediaWiki r90866]: New comment added

2011-07-11 Thread MediaWiki Mail
User Siebrand posted a comment on MediaWiki.r90866. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90866#c19448 Commit summary: Tweaked r90766 messages. Still awkward. Also, this still needs JS to disable the check if all is selected, to be less confusing. Comment: Tagged 1.18

[MediaWiki-CodeReview] [MediaWiki r90793]: New comment added

2011-07-11 Thread MediaWiki Mail
User Siebrand posted a comment on MediaWiki.r90793. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90793#c19449 Commit summary: *sigh*...added bit left off of r90789 Comment: Tagged 1.18 because r90789 is tagged 1.18. ___

[MediaWiki-CodeReview] [MediaWiki r83791]: Revision status changed

2011-07-11 Thread MediaWiki Mail
User Aaron Schulz changed the status of MediaWiki.r83791. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/83791#c0 Commit summary: (bug 2581, bug 6834) Added links to thumbnail in several resolutions to the file description page. The sizes are set

Re: [Wikitech-l] testing mobile browsers?

2011-07-11 Thread Patrick Reilly
On Mon, Jul 11, 2011 at 1:36 PM, Brion Vibber br...@pobox.com wrote: On Mon, Jul 11, 2011 at 12:36 PM, Tomasz Finc tf...@wikimedia.org wrote: Firefox is tough as the current version has the exact same UA on mobile phones AND tablets. And since we don't redirect tablets we haven't switched it

[MediaWiki-CodeReview] [MediaWiki r83778]: Revision status changed

2011-07-11 Thread MediaWiki Mail
User Aaron Schulz changed the status of MediaWiki.r83778. Old Status: new New Status: resolved Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/83778#c0 Commit summary: (bug 14706) Added support for the Imagick PHP extension. Based on patch by Leslie Hoare. Scaler type is imext.

[MediaWiki-CodeReview] [MediaWiki r50526]: New comment added

2011-07-11 Thread MediaWiki Mail
User Siebrand posted a comment on MediaWiki.r50526. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/50526#c19450 Commit summary: fixing spacing Comment: This rev has been marked todo for the past 2 years. Quick check came up with almost

[MediaWiki-CodeReview] [MediaWiki r83280]: Revision status changed

2011-07-11 Thread MediaWiki Mail
User Aaron Schulz changed the status of MediaWiki.r83280. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/83280#c0 Commit summary: Follow-up r83183, r83202: * Update SpecialCheckUser.php to new location of IP functions * Spin out the

[MediaWiki-CodeReview] [MediaWiki r50526]: New comment added

2011-07-11 Thread MediaWiki Mail
User Tfinc posted a comment on MediaWiki.r50526. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/50526#c19451 Commit summary: fixing spacing Comment: Fixed in r51000 ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r83280]: New comment added

2011-07-11 Thread MediaWiki Mail
User Aaron Schulz posted a comment on MediaWiki.r83280. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/83280#c19452 Commit summary: Follow-up r83183, r83202: * Update SpecialCheckUser.php to new location of IP functions * Spin out the 'hide-other-field-if-select-box-not-on-other'

[MediaWiki-CodeReview] [MediaWiki r79856]: New comment added, and revision status changed

2011-07-11 Thread MediaWiki Mail
User Brion VIBBER changed the status of MediaWiki.r79856. Old Status: ok New Status: fixme User Brion VIBBER also posted a comment on MediaWiki.r79856. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/79856#c19453 Commit summary: Bug 26563: Add bytes changed per revision for stub

[MediaWiki-CodeReview] [MediaWiki r91842]: New comment added

2011-07-11 Thread MediaWiki Mail
User Siebrand posted a comment on MediaWiki.r91842. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91842#c19454 Commit summary: * Changed dynamic calls to Linker methods into static ones * Also preferably pass a Language object instead of a Skin one or boolean indicating whether

[MediaWiki-CodeReview] [MediaWiki r79856]: New comment added

2011-07-11 Thread MediaWiki Mail
User Brion VIBBER posted a comment on MediaWiki.r79856. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/79856#c19455 Commit summary: Bug 26563: Add bytes changed per revision for stub and full article dumps Comment: Added to shell bugs: bug 29819.

[MediaWiki-CodeReview] [MediaWiki r91885]: New comment added

2011-07-11 Thread MediaWiki Mail
User Brion VIBBER posted a comment on MediaWiki.r91885. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91885#c19456 Commit summary: (follow-up r90256) Unit tests. Comment: Hmm... this seems to sound like it'll *drop* metadata from a paged tiff file proxied from another site

[MediaWiki-CodeReview] [MediaWiki r91870]: New comment added, and revision status changed

2011-07-11 Thread MediaWiki Mail
User Brion VIBBER changed the status of MediaWiki.r91870. Old Status: new New Status: fixme User Brion VIBBER also posted a comment on MediaWiki.r91870. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91870#c19457 Commit summary: wgAction incorrectly asumes 'view' instead of

[MediaWiki-CodeReview] [MediaWiki r91873]: New comment added, and revision status changed

2011-07-11 Thread MediaWiki Mail
User Brion VIBBER changed the status of MediaWiki.r91873. Old Status: new New Status: fixme User Brion VIBBER also posted a comment on MediaWiki.r91873. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91873#c19458 Commit summary: r91870 : Got tricked into believing it was

[MediaWiki-CodeReview] [MediaWiki r91870]: New comment added, and revision status changed

2011-07-11 Thread MediaWiki Mail
User Brion VIBBER changed the status of MediaWiki.r91870. Old Status: fixme New Status: reverted User Brion VIBBER also posted a comment on MediaWiki.r91870. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91870#c19459 Commit summary: wgAction incorrectly asumes 'view' instead

[MediaWiki-CodeReview] [MediaWiki r91873]: New comment added, and revision status changed

2011-07-11 Thread MediaWiki Mail
User Brion VIBBER changed the status of MediaWiki.r91873. Old Status: fixme New Status: reverted User Brion VIBBER also posted a comment on MediaWiki.r91873. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91873#c19460 Commit summary: r91870 : Got tricked into believing it was

[MediaWiki-CodeReview] [MediaWiki r91776]: New comment added

2011-07-11 Thread MediaWiki Mail
User NeilK posted a comment on MediaWiki.r91776. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91776#c19461 Commit summary: start special page for viewing archived content. Comment: FYI Archive is an overloaded term in MediaWiki, since old deleted pages are also called

[MediaWiki-CodeReview] [MediaWiki r91776]: New comment added

2011-07-11 Thread MediaWiki Mail
User NeilK posted a comment on MediaWiki.r91776. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91776#c19462 Commit summary: start special page for viewing archived content. Comment: Also, in general, try to move configuration into its own block or method. It's much better if

[MediaWiki-CodeReview] [MediaWiki r91869]: New comment added, and revision status changed

2011-07-11 Thread MediaWiki Mail
User Brion VIBBER changed the status of MediaWiki.r91869. Old Status: new New Status: fixme User Brion VIBBER also posted a comment on MediaWiki.r91869. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91869#c19463 Commit summary: use tab name, not tab index for anchors on

[MediaWiki-CodeReview] [MediaWiki r91869]: New comment added, and revision status changed

2011-07-11 Thread MediaWiki Mail
User Brion VIBBER changed the status of MediaWiki.r91869. Old Status: fixme New Status: resolved User Brion VIBBER also posted a comment on MediaWiki.r91869. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91869#c19464 Commit summary: use tab name, not tab index for anchors on

  1   2   >