[MediaWiki-CodeReview] [MediaWiki r91937]: New comment added

2011-07-12 Thread MediaWiki Mail
User Zhenya posted a comment on MediaWiki.r91937. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91937#c19472 Commit summary: Comment: *Changed the position and css of the userstatus feature *Now the messsage length is [1..70] letters *The message length (and letters left is

[MediaWiki-CodeReview] [MediaWiki r91939]: New comment added, and revision status changed

2011-07-12 Thread MediaWiki Mail
User Nikerabbit changed the status of MediaWiki.r91939. Old Status: new New Status: fixme User Nikerabbit also posted a comment on MediaWiki.r91939. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91939#c19473 Commit summary: wrongly deleted it in previous revision Comment:

[MediaWiki-CodeReview] [MediaWiki r91871]: New comment added, and revision status changed

2011-07-12 Thread MediaWiki Mail
User Krinkle changed the status of MediaWiki.r91871. Old Status: new New Status: fixme User Krinkle also posted a comment on MediaWiki.r91871. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91871#c19474 Commit summary: Add action-* class to body. Bug 4438. Based on patch by

[MediaWiki-CodeReview] [MediaWiki r91943]: New comment added, and revision status changed

2011-07-12 Thread MediaWiki Mail
User IAlex changed the status of MediaWiki.r91943. Old Status: new New Status: fixme User IAlex also posted a comment on MediaWiki.r91943. Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/91943#c19475 Commit summary: r91942: Add nosuchaction also if

[MediaWiki-CodeReview] [MediaWiki r91943]: Revision status changed

2011-07-12 Thread MediaWiki Mail
User DieBuche changed the status of MediaWiki.r91943. Old Status: fixme New Status: reverted Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91943#c0 Commit summary: r91942: Add nosuchaction also if action not in ___

[MediaWiki-CodeReview] [MediaWiki r91944]: Revision status changed

2011-07-12 Thread MediaWiki Mail
User DieBuche changed the status of MediaWiki.r91944. Old Status: new New Status: reverted Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91944#c0 Commit summary: r91943. Add global. ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r91947]: New comment added, and revision status changed

2011-07-12 Thread MediaWiki Mail
User Nikerabbit changed the status of MediaWiki.r91947. Old Status: new New Status: fixme User Nikerabbit also posted a comment on MediaWiki.r91947. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91947#c19476 Commit summary: escape brackets before using in regex for filtering

[MediaWiki-CodeReview] [MediaWiki r91939]: New comment added, and revision status changed

2011-07-12 Thread MediaWiki Mail
User Nikerabbit changed the status of MediaWiki.r91939. Old Status: fixme New Status: ok User Nikerabbit also posted a comment on MediaWiki.r91939. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91939#c19477 Commit summary: wrongly deleted it in previous revision Comment:

[MediaWiki-CodeReview] [MediaWiki r91965]: New comment added

2011-07-12 Thread MediaWiki Mail
User Jack Phoenix posted a comment on MediaWiki.r91965. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91965#c19478 Commit summary: Preprocess the text in the current Parser instance instead of creating a new one Comment: pre +var_dump( $image_list ); /pre Whoops :)

[MediaWiki-CodeReview] [MediaWiki r91959]: New comment added, and revision status changed

2011-07-12 Thread MediaWiki Mail
User Jack Phoenix changed the status of MediaWiki.r91959. Old Status: new New Status: ok User Jack Phoenix also posted a comment on MediaWiki.r91959. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91959#c19479 Commit summary: reverted changes in SpecialUserBoard Comment: This

[MediaWiki-CodeReview] [MediaWiki r91967]: Revision status changed

2011-07-12 Thread MediaWiki Mail
User ^demon changed the status of MediaWiki.r91967. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91967#c0 Commit summary: libxml = 2.7.3 ha a 10mb cap on the size of a text node and the LIBXML_PARSEHUGE lets us override that, needed for lucid

Re: [Wikitech-l] thumbnail generation for Extension:OggHandler

2011-07-12 Thread Dmitriy Sintsov
On 12.07.2011 8:30, Tim Starling wrote: On 08/07/11 21:18, Dmitriy Sintsov wrote: Hi! What's the proper way of thumbnail generation for Ogg media handler, so it will work like at commons? This is documented in the OggHandler README file:

[MediaWiki-CodeReview] [MediaWiki r91940]: Revision status changed

2011-07-12 Thread MediaWiki Mail
User Aaron Schulz changed the status of MediaWiki.r91940. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91940#c0 Commit summary: Non-concurrent pop_type() since the $row === false case was being hit 99% of the time on WMF in a backlog situation.

[MediaWiki-CodeReview] [MediaWiki r91969]: Revision status changed

2011-07-12 Thread MediaWiki Mail
User Aaron Schulz changed the status of MediaWiki.r91969. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91969#c0 Commit summary: * In EditPage.php: don't add the separator if getCancelLink() returns an empty string * In TalkHere extension:

[MediaWiki-CodeReview] [MediaWiki r91684]: Revision status changed

2011-07-12 Thread MediaWiki Mail
User Catrope changed the status of MediaWiki.r91684. Old Status: new New Status: ok Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/91684#c0 Commit summary: One more fix for the for in loops. Follow up to r91347

[MediaWiki-CodeReview] [MediaWiki r91663]: New comment added

2011-07-12 Thread MediaWiki Mail
User Catrope posted a comment on MediaWiki.r91663. Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/91663#c19480 Commit summary: (bug 29497) To support protocol-relative URLs in external links, add '//' to $wgUrlProtocols and remove a useless \b in the

[MediaWiki-CodeReview] [MediaWiki r91869]: New comment added

2011-07-12 Thread MediaWiki Mail
User Duplicatebug posted a comment on MediaWiki.r91869. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91869#c19481 Commit summary: use tab name, not tab index for anchors on Special:Preferences. Bug 29672 . Patch by Jarry1250. Ping r91757 Comment: Not backward compatible. If

[MediaWiki-CodeReview] [MediaWiki r91869]: New comment added

2011-07-12 Thread MediaWiki Mail
User Brion VIBBER posted a comment on MediaWiki.r91869. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91869#c19482 Commit summary: use tab name, not tab index for anchors on Special:Preferences. Bug 29672 . Patch by Jarry1250. Ping r91757 Comment: I'm quite willing to lose

[MediaWiki-CodeReview] [MediaWiki r91965]: Revision status changed

2011-07-12 Thread MediaWiki Mail
User Aaron Schulz changed the status of MediaWiki.r91965. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91965#c0 Commit summary: Preprocess the text in the current Parser instance instead of creating a new one

[MediaWiki-CodeReview] [MediaWiki r91973]: New comment added, and revision status changed

2011-07-12 Thread MediaWiki Mail
User Brion VIBBER changed the status of MediaWiki.r91973. Old Status: new New Status: reverted User Brion VIBBER also posted a comment on MediaWiki.r91973. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91973#c19483 Commit summary: Bug 24254: Output JS var wgCategories on other

[MediaWiki-CodeReview] [MediaWiki r91817]: Revision status changed

2011-07-12 Thread MediaWiki Mail
User Aaron Schulz changed the status of MediaWiki.r91817. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91817#c0 Commit summary: Now that the hooks ArticleDelete and ArticleDeleteComplete are called from WikiPage::doDeleteArticle() and not

[MediaWiki-CodeReview] [MediaWiki r91974]: Revision status changed

2011-07-12 Thread MediaWiki Mail
User Aaron Schulz changed the status of MediaWiki.r91974. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91974#c0 Commit summary: Revert r91973 Bug 24254: Output JS var wgCategories on other actions than view as well This code just looks really

[MediaWiki-CodeReview] [MediaWiki r91975]: New comment added, and revision status changed

2011-07-12 Thread MediaWiki Mail
User Brion VIBBER changed the status of MediaWiki.r91975. Old Status: new New Status: ok User Brion VIBBER also posted a comment on MediaWiki.r91975. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91975#c19484 Commit summary: * Added token to watch links * Call Linker methods

[MediaWiki-CodeReview] [MediaWiki r91966]: New comment added, and revision status changed

2011-07-12 Thread MediaWiki Mail
User Brion VIBBER changed the status of MediaWiki.r91966. Old Status: new New Status: fixme User Brion VIBBER also posted a comment on MediaWiki.r91966. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91966#c19485 Commit summary: (bug 12205) Bidirectional names in action=credits

[MediaWiki-CodeReview] [MediaWiki r91941]: Revision status changed

2011-07-12 Thread MediaWiki Mail
User ^demon changed the status of MediaWiki.r91941. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91941#c0 Commit summary: corrected sequence of include and run update-php during the manual installation process description

[MediaWiki-CodeReview] [MediaWiki r91951]: New comment added, and revision status changed

2011-07-12 Thread MediaWiki Mail
User Aaron Schulz changed the status of MediaWiki.r91951. Old Status: new New Status: ok User Aaron Schulz also posted a comment on MediaWiki.r91951. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91951#c19486 Commit summary: Use createContext() instead of using the global

[MediaWiki-CodeReview] [MediaWiki r91951]: New comment added, and revision status changed

2011-07-12 Thread MediaWiki Mail
User Brion VIBBER changed the status of MediaWiki.r91951. Old Status: ok New Status: new User Brion VIBBER also posted a comment on MediaWiki.r91951. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91951#c19487 Commit summary: Use createContext() instead of using the global

[MediaWiki-CodeReview] [MediaWiki r91949]: New comment added, and revision status changed

2011-07-12 Thread MediaWiki Mail
User Brion VIBBER changed the status of MediaWiki.r91949. Old Status: new New Status: ok User Brion VIBBER also posted a comment on MediaWiki.r91949. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91949#c19488 Commit summary: Revert r91942, r91943 reimplement. wgActions

[MediaWiki-CodeReview] [MediaWiki r91942]: New comment added, and revision status changed

2011-07-12 Thread MediaWiki Mail
User Brion VIBBER changed the status of MediaWiki.r91942. Old Status: new New Status: resolved User Brion VIBBER also posted a comment on MediaWiki.r91942. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91942#c19489 Commit summary: Followup r91871 per CR. Write back the

[MediaWiki-CodeReview] [MediaWiki r91871]: New comment added

2011-07-12 Thread MediaWiki Mail
User Brion VIBBER posted a comment on MediaWiki.r91871. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91871#c19490 Commit summary: Add action-* class to body. Bug 4438. Based on patch by Subfader Comment: r94942, r91949 handle this to my satisfaction; the couple specific

[MediaWiki-CodeReview] [MediaWiki r91925]: New comment added, and revision status changed

2011-07-12 Thread MediaWiki Mail
User Brion VIBBER changed the status of MediaWiki.r91925. Old Status: new New Status: fixme User Brion VIBBER also posted a comment on MediaWiki.r91925. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91925#c19491 Commit summary: CodeReview: Add a dropdown to revision list to

[MediaWiki-CodeReview] [MediaWiki r91966]: New comment added

2011-07-12 Thread MediaWiki Mail
User SPQRobin posted a comment on MediaWiki.r91966. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91966#c19492 Commit summary: (bug 12205) Bidirectional names in action=credits are split and displayed incorrectly when wrapped to the next line. Comment: They are user names, I

[MediaWiki-CodeReview] [MediaWiki r90193]: Revision status changed

2011-07-12 Thread MediaWiki Mail
User Aaron Schulz changed the status of MediaWiki.r90193. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90193#c0 Commit summary: Removed $wgProto. Previously, setting this undocumented global variable to anything other than the part of $wgServer

[MediaWiki-CodeReview] [MediaWiki r91985]: New comment added

2011-07-12 Thread MediaWiki Mail
User ^demon posted a comment on MediaWiki.r91985. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91985#c19493 Commit summary: Bug #29807 — Special:PasswordReset listed on Special:SpecialPages when Authplugin allowPasswordChange() is false After my spanking last week, I've gone

[MediaWiki-CodeReview] [MediaWiki r91927]: Revision status changed

2011-07-12 Thread MediaWiki Mail
User Aaron Schulz changed the status of MediaWiki.r91927. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91927#c0 Commit summary: Revert r91870, r91873 -- seems to be trying to remove the 'view' action on diff views; diffs are a subset of regular

[MediaWiki-CodeReview] [MediaWiki r91895]: Revision status changed

2011-07-12 Thread MediaWiki Mail
User Aaron Schulz changed the status of MediaWiki.r91895. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91895#c0 Commit summary: Add unit tests for $wgGroupPermissions/$wgRevokePermissions ___

[MediaWiki-CodeReview] [MediaWiki r91986]: New comment added, and revision status changed

2011-07-12 Thread MediaWiki Mail
User Brion VIBBER changed the status of MediaWiki.r91986. Old Status: new New Status: ok User Brion VIBBER also posted a comment on MediaWiki.r91986. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91986#c19494 Commit summary: MFT r90723 Comment: Make it so!

[MediaWiki-CodeReview] [MediaWiki r91989]: Revision status changed

2011-07-12 Thread MediaWiki Mail
User ^demon changed the status of MediaWiki.r91989. Old Status: new New Status: deferred Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91989#c0 Commit summary: Localisation updates for ToolserverI18N messages from translatewiki.net (2011-07-12 19:35:00)

[MediaWiki-CodeReview] [MediaWiki r91909]: Revision status changed

2011-07-12 Thread MediaWiki Mail
User Reedy changed the status of MediaWiki.r91909. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91909#c0 Commit summary: 1.17wmf1: Update WikimediaLicenseTexts to trunk state ___ MediaWiki-CodeReview

[MediaWiki-CodeReview] [MediaWiki r90740]: Revision status changed

2011-07-12 Thread MediaWiki Mail
User ^demon changed the status of MediaWiki.r90740. Old Status: deferred New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90740#c0 Commit summary: Export special page alias for 'fa' for bug 29563 ___ MediaWiki-CodeReview

[MediaWiki-CodeReview] [MediaWiki r91758]: New comment added, and revision status changed

2011-07-12 Thread MediaWiki Mail
User ^demon changed the status of MediaWiki.r91758. Old Status: new New Status: ok User ^demon also posted a comment on MediaWiki.r91758. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91758#c19495 Commit summary: MFT to REL1_18: r89099, r89108 : message key 'noemail' r88231,

[MediaWiki-CodeReview] [MediaWiki r91982]: Revision status changed

2011-07-12 Thread MediaWiki Mail
User Reedy changed the status of MediaWiki.r91982. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91982#c0 Commit summary: Followup r91832: move maintenance script from core to Renameuser extension. ___

[MediaWiki-CodeReview] [MediaWiki r91995]: Revision status changed

2011-07-12 Thread MediaWiki Mail
User ^demon changed the status of MediaWiki.r91995. Old Status: new New Status: deferred Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91995#c0 Commit summary: Localisation updates for core and extension messages from translatewiki.net (2011-07-12 19:38:00 UTC)

[MediaWiki-CodeReview] [MediaWiki r91980]: New comment added

2011-07-12 Thread MediaWiki Mail
User Nikerabbit posted a comment on MediaWiki.r91980. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91980#c19496 Commit summary: Added WikiPageFactory class with newFromTitle() function Comment: Weren't we supposed to use FooClass::factory pattern? Why do we need a new class

[MediaWiki-CodeReview] [MediaWiki r91980]: New comment added

2011-07-12 Thread MediaWiki Mail
User Aaron Schulz posted a comment on MediaWiki.r91980. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91980#c19497 Commit summary: Added WikiPageFactory class with newFromTitle() function Comment: Are we? Is this on mw.org? So you'd have a WikiPage::factory() method?

[MediaWiki-CodeReview] [MediaWiki r91980]: New comment added

2011-07-12 Thread MediaWiki Mail
User Nikerabbit posted a comment on MediaWiki.r91980. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91980#c19499 Commit summary: Added WikiPageFactory class with newFromTitle() function Comment: # Yes I've been under that impression # I have no idea. # Yes I've understood it

[MediaWiki-CodeReview] [MediaWiki r91890]: Revision status changed

2011-07-12 Thread MediaWiki Mail
User ^demon changed the status of MediaWiki.r91890. Old Status: new New Status: deferred Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91890#c0 Commit summary: Sync testswarm cli scripts: - Note these are not being used by TestSwarm but for TestSwarm. This is the script in

[MediaWiki-CodeReview] [MediaWiki r91772]: New comment added

2011-07-12 Thread MediaWiki Mail
User ^demon posted a comment on MediaWiki.r91772. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91772#c19500 Commit summary: Inline CSS is bad in itself and bad for RTL support (why was there even a message containing CSS?) Comment: Is the shared.css change in core intended?

[MediaWiki-CodeReview] [MediaWiki r80512]: Revision status changed

2011-07-12 Thread MediaWiki Mail
User ^demon changed the status of MediaWiki.r80512. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/80512#c0 Commit summary: followup r80511: make {{PAGENAMEE}} and friends also call wfEscapeWikiText() (why is the code duplicated, anyway??)

[MediaWiki-CodeReview] [MediaWiki r83535]: Revision status changed

2011-07-12 Thread MediaWiki Mail
User ^demon changed the status of MediaWiki.r83535. Old Status: new New Status: reverted Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/83535#c0 Commit summary: * Followup r76127 and r83521 by adding parsertests and using caseFold ___

[MediaWiki-CodeReview] [MediaWiki r76127]: Revision status changed

2011-07-12 Thread MediaWiki Mail
User ^demon changed the status of MediaWiki.r76127. Old Status: ok New Status: reverted Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/76127#c0 Commit summary: Resolves Bug#542 by removing the link title from in-wiki links where the title just duplicates the link text.

[MediaWiki-CodeReview] [MediaWiki r76129]: Revision status changed

2011-07-12 Thread MediaWiki Mail
User ^demon changed the status of MediaWiki.r76129. Old Status: ok New Status: reverted Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/76129#c0 Commit summary: followup r76127 - update parser tests. ___ MediaWiki-CodeReview mailing

[MediaWiki-CodeReview] [MediaWiki r86741]: Revision status changed

2011-07-12 Thread MediaWiki Mail
User ^demon changed the status of MediaWiki.r86741. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86741#c0 Commit summary: Breaking the 'math' table setup out to Math extension. Should be the last main step in extension-ification of the math

[MediaWiki-CodeReview] [MediaWiki r89085]: Revision status changed

2011-07-12 Thread MediaWiki Mail
User ^demon changed the status of MediaWiki.r89085. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89085#c0 Commit summary: Fix issues raised through TestSwarm * Instead of delete window.foobar whitelist the global in QUnit.config.pollution ** the

[MediaWiki-CodeReview] [MediaWiki r92000]: Revision status changed

2011-07-12 Thread MediaWiki Mail
User Reedy changed the status of MediaWiki.r92000. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92000#c0 Commit summary: Removing unnecessary BOMs ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r91277]: Revision status changed

2011-07-12 Thread MediaWiki Mail
User ^demon changed the status of MediaWiki.r91277. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91277#c0 Commit summary: throw an exception on !is_executable( $wgExiv2Command ) ___

[MediaWiki-CodeReview] [MediaWiki r91758]: New comment added

2011-07-12 Thread MediaWiki Mail
User Hashar posted a comment on MediaWiki.r91758. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91758#c19501 Commit summary: MFT to REL1_18: r89099, r89108 : message key 'noemail' r88231, r88232 : fix ProfilerSimpleTextBreakage (fix r86633) Comment: I merge using several time:

[MediaWiki-CodeReview] [MediaWiki r91758]: New comment added

2011-07-12 Thread MediaWiki Mail
User Reedy posted a comment on MediaWiki.r91758. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91758#c19502 Commit summary: MFT to REL1_18: r89099, r89108 : message key 'noemail' r88231, r88232 : fix ProfilerSimpleTextBreakage (fix r86633) Comment: Roan has a list of like 10

[MediaWiki-CodeReview] [MediaWiki r91758]: New comment added

2011-07-12 Thread MediaWiki Mail
User Catrope posted a comment on MediaWiki.r91758. Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/91758#c19503 Commit summary: MFT to REL1_18: r89099, r89108 : message key 'noemail' r88231, r88232 : fix ProfilerSimpleTextBreakage (fix r86633) Comment:

[MediaWiki-CodeReview] [MediaWiki r91994]: Revision status changed

2011-07-12 Thread MediaWiki Mail
User ^demon changed the status of MediaWiki.r91994. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91994#c0 Commit summary: Fixed failing XML tests (on windows) due to newline vs carriage return discrepancy...ugh

[MediaWiki-CodeReview] [MediaWiki r91871]: New comment added

2011-07-12 Thread MediaWiki Mail
User Krinkle posted a comment on MediaWiki.r91871. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91871#c19504 Commit summary: Add action-* class to body. Bug 4438. Based on patch by Subfader Comment: r94942 Did I miss something :O ?

[MediaWiki-CodeReview] [MediaWiki r92005]: New comment added

2011-07-12 Thread MediaWiki Mail
User Hashar posted a comment on MediaWiki.r92005. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92005#c19505 Commit summary: Fix r14202 (!!): this validates the protocol against the regex for the second time (preg_split has already made sure it matches wfUrlProtocols() so no

[Wikitech-l] Anonymization, virtualization, and community measurement tools

2011-07-12 Thread Sumana Harihareswara
http://www.harihareswara.net/sumana/2011/06/29/1 That's my report from visiting June's Open Source Bridge conference. I thought this list might especially want to know about: * A tool to sanitize MySQL databases, to provide realistic but anonymized test data to developers and researchers:

[MediaWiki-CodeReview] [MediaWiki r14202]: Revision status changed

2011-07-12 Thread MediaWiki Mail
User Hashar changed the status of MediaWiki.r14202. Old Status: old New Status: resolved Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/14202#c0 Commit summary: Fix #5918: links autonumbering now work for all defined protocols. ___

[MediaWiki-CodeReview] [MediaWiki r91999]: Revision status changed

2011-07-12 Thread MediaWiki Mail
User Awjrichards changed the status of MediaWiki.r91999. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91999#c0 Commit summary: changing country_code query string variable to country to match required id's for payflowpro and allow automated

[MediaWiki-CodeReview] [MediaWiki r92006]: New comment added

2011-07-12 Thread MediaWiki Mail
User ^demon posted a comment on MediaWiki.r92006. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92006#c19506 Commit summary: Parser tests for protocol-relative URLs, for r91663 and r92005 Comment: Tests pass for me :D ___

[MediaWiki-CodeReview] [MediaWiki r91772]: New comment added

2011-07-12 Thread MediaWiki Mail
User SPQRobin posted a comment on MediaWiki.r91772. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91772#c19507 Commit summary: Inline CSS is bad in itself and bad for RTL support (why was there even a message containing CSS?) Comment: Yes, they are general classes that can be

[MediaWiki-CodeReview] [MediaWiki r91871]: New comment added

2011-07-12 Thread MediaWiki Mail
User Brion VIBBER posted a comment on MediaWiki.r91871. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91871#c19508 Commit summary: Add action-* class to body. Bug 4438. Based on patch by Subfader Comment: ahem make that r91942 :D

[Wikitech-l] Minor API change, ApiUpload

2011-07-12 Thread Ian Baker
I've made a minor API change ApiUpload, for stashed files. It's not a commonly used API and the change shouldn't break anything external, but I figured I should post just in case. Temporarily stashed files now have their metadata stored in the database instead of the session. This allows for

[MediaWiki-CodeReview] [MediaWiki r91772]: New comment added

2011-07-12 Thread MediaWiki Mail
User ^demon posted a comment on MediaWiki.r91772. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91772#c19510 Commit summary: Inline CSS is bad in itself and bad for RTL support (why was there even a message containing CSS?) Comment: My point is that I don't see them

[MediaWiki-CodeReview] [MediaWiki r91772]: New comment added

2011-07-12 Thread MediaWiki Mail
User SPQRobin posted a comment on MediaWiki.r91772. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91772#c19511 Commit summary: Inline CSS is bad in itself and bad for RTL support (why was there even a message containing CSS?) Comment: I made use of mw-align-end in Collection

Re: [Wikitech-l] Minor API change, ApiUpload

2011-07-12 Thread Brion Vibber
On Tue, Jul 12, 2011 at 2:25 PM, Ian Baker iba...@wikimedia.org wrote: I've made a minor API change ApiUpload, for stashed files. It's not a commonly used API and the change shouldn't break anything external, but I figured I should post just in case. Temporarily stashed files now have their

[MediaWiki-CodeReview] [MediaWiki r92012]: New comment added

2011-07-12 Thread MediaWiki Mail
User Krinkle posted a comment on MediaWiki.r92012. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92012#c19512 Commit summary: * Made (un)watch action show a form if the token is bad/missing (this handles unwatch links given in emails) * Changed misleading watch/unwatch subtitle

[MediaWiki-CodeReview] [MediaWiki r92012]: New comment added

2011-07-12 Thread MediaWiki Mail
User Jack Phoenix posted a comment on MediaWiki.r92012. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92012#c19513 Commit summary: * Made (un)watch action show a form if the token is bad/missing (this handles unwatch links given in emails) * Changed misleading watch/unwatch

[MediaWiki-CodeReview] [MediaWiki r92009]: New comment added, and revision status changed

2011-07-12 Thread MediaWiki Mail
User Brion VIBBER changed the status of MediaWiki.r92009. Old Status: new New Status: fixme User Brion VIBBER also posted a comment on MediaWiki.r92009. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92009#c19514 Commit summary: Refactored UploadStash and related classes to use

[MediaWiki-CodeReview] [MediaWiki r92013]: New comment added

2011-07-12 Thread MediaWiki Mail
User Siebrand posted a comment on MediaWiki.r92013. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92013#c19515 Commit summary: Follow-up to r86811: changed MWInit::classExists() to class_exists() - the former is only defined in MW = 1.18, which goes against the whole point of

[MediaWiki-CodeReview] [MediaWiki r92014]: Revision status changed

2011-07-12 Thread MediaWiki Mail
User Krinkle changed the status of MediaWiki.r92014. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92014#c0 Commit summary: Fixed r92012 comment ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r91992]: Revision status changed

2011-07-12 Thread MediaWiki Mail
User Aaron Schulz changed the status of MediaWiki.r91992. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91992#c0 Commit summary: Followup r91832, fix 2 undefined $db for $dbw ___ MediaWiki-CodeReview

[MediaWiki-CodeReview] [MediaWiki r92013]: New comment added

2011-07-12 Thread MediaWiki Mail
User ^demon posted a comment on MediaWiki.r92013. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92013#c19516 Commit summary: Follow-up to r86811: changed MWInit::classExists() to class_exists() - the former is only defined in MW = 1.18, which goes against the whole point of the

Re: [Wikitech-l] Minor API change, ApiUpload

2011-07-12 Thread Ian Baker
The actual change to the API is pretty simple. First, the 'sessionkey' parameter has been superseded by 'filekey', though 'sessionkey' remains for compatibility. Seems to me like this doesn't need any client-visible changes; any objection to just leaving it labeled as is? It's a

[MediaWiki-CodeReview] [MediaWiki r91832]: New comment added

2011-07-12 Thread MediaWiki Mail
User Aaron Schulz posted a comment on MediaWiki.r91832. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91832#c19517 Commit summary: fix issues after failed renameUser; this script will ask for lots of confirmation, better safe than sorry. Comment: Please uncomment the

[MediaWiki-CodeReview] [MediaWiki r91832]: New comment added

2011-07-12 Thread MediaWiki Mail
User Aaron Schulz posted a comment on MediaWiki.r91832. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91832#c19518 Commit summary: fix issues after failed renameUser; this script will ask for lots of confirmation, better safe than sorry. Comment: Yeah, lots of duplication

[MediaWiki-CodeReview] [MediaWiki r91983]: Revision status changed

2011-07-12 Thread MediaWiki Mail
User Siebrand changed the status of MediaWiki.r91983. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91983#c0 Commit summary: eol w/s before commiting real patch ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r91835]: Revision status changed

2011-07-12 Thread MediaWiki Mail
User Siebrand changed the status of MediaWiki.r91835. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91835#c0 Commit summary: AddAdd 6 missing Creative Commons licenses. ___ MediaWiki-CodeReview mailing

[MediaWiki-CodeReview] [MediaWiki r91792]: Revision status changed

2011-07-12 Thread MediaWiki Mail
User Siebrand changed the status of MediaWiki.r91792. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91792#c0 Commit summary: Forgot wm-license-artwork-inscriptions ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r91790]: Revision status changed

2011-07-12 Thread MediaWiki Mail
User Siebrand changed the status of MediaWiki.r91790. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91790#c0 Commit summary: Add fields for the Artwork template at Commons. ___ MediaWiki-CodeReview

[MediaWiki-CodeReview] [MediaWiki r90953]: Revision status changed

2011-07-12 Thread MediaWiki Mail
User Siebrand changed the status of MediaWiki.r90953. Old Status: deferred New Status: resolved Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90953#c0 Commit summary: Followup r90926 for Translatewiki ___ MediaWiki-CodeReview mailing

[MediaWiki-CodeReview] [MediaWiki r91832]: New comment added

2011-07-12 Thread MediaWiki Mail
User Aaron Schulz posted a comment on MediaWiki.r91832. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91832#c19519 Commit summary: fix issues after failed renameUser; this script will ask for lots of confirmation, better safe than sorry. Comment: Also, does this have to

[MediaWiki-CodeReview] [MediaWiki r91993]: Revision status changed

2011-07-12 Thread MediaWiki Mail
User Aaron Schulz changed the status of MediaWiki.r91993. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91993#c0 Commit summary: Documentation ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r91892]: Revision status changed

2011-07-12 Thread MediaWiki Mail
User Aaron Schulz changed the status of MediaWiki.r91892. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91892#c0 Commit summary: ping r91875 ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r92002]: New comment added

2011-07-12 Thread MediaWiki Mail
User Siebrand posted a comment on MediaWiki.r92002. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92002#c19520 Commit summary: Follow-up r91997, moved newFromTitle() function to WikiPage.php and renamed to factory(). This avoids an extra class. Comment: Incorrect follow-up

Re: [Wikitech-l] thumbnail generation for Extension:OggHandler

2011-07-12 Thread Tim Starling
On 13/07/11 01:45, Dmitriy Sintsov wrote: -- checking for module 'vorbis=1.2.3' -- package 'vorbis=1.2.3' not found -- checking for module 'vorbisenc=1.2.3' -- package 'vorbisenc=1.2.3' not found CentOS 5 only has libvorbis 1.1.2, not 1.2.3. You will need to do a source install of a newer

[MediaWiki-CodeReview] [MediaWiki r91997]: Revision status changed

2011-07-12 Thread MediaWiki Mail
User Siebrand changed the status of MediaWiki.r91997. Old Status: new New Status: fixme Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91997#c0 Commit summary: Amending minor glitches in a message text, seen by Lloffiwr, see

[MediaWiki-CodeReview] [MediaWiki r91786]: Revision status changed

2011-07-12 Thread MediaWiki Mail
User Siebrand changed the status of MediaWiki.r91786. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91786#c0 Commit summary: Follow-up r91770: only translate when possible ___ MediaWiki-CodeReview

[MediaWiki-CodeReview] [MediaWiki r91770]: Revision status changed

2011-07-12 Thread MediaWiki Mail
User Siebrand changed the status of MediaWiki.r91770. Old Status: new New Status: resolved Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91770#c0 Commit summary: Translate the block expiry date I wonder why this hasn't been done yet...

[MediaWiki-CodeReview] [MediaWiki r92002]: New comment added

2011-07-12 Thread MediaWiki Mail
User Aaron Schulz posted a comment on MediaWiki.r92002. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92002#c19521 Commit summary: Follow-up r91997, moved newFromTitle() function to WikiPage.php and renamed to factory(). This avoids an extra class. Comment: r92002

[MediaWiki-CodeReview] [MediaWiki r89892]: New comment added

2011-07-12 Thread MediaWiki Mail
User Siebrand posted a comment on MediaWiki.r89892. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89892#c19522 Commit summary: (bug 20044) Misaligned text on file pages (RTL wikis only) Comment: Shouldn't this be done with flip/noflip?

[MediaWiki-CodeReview] [MediaWiki r92002]: New comment added

2011-07-12 Thread MediaWiki Mail
User Siebrand posted a comment on MediaWiki.r92002. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92002#c19523 Commit summary: Follow-up r91997, moved newFromTitle() function to WikiPage.php and renamed to factory(). This avoids an extra class. Comment: That is THIS rev :).

[MediaWiki-CodeReview] [MediaWiki r92013]: New comment added

2011-07-12 Thread MediaWiki Mail
User Siebrand posted a comment on MediaWiki.r92013. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92013#c19524 Commit summary: Follow-up to r86811: changed MWInit::classExists() to class_exists() - the former is only defined in MW = 1.18, which goes against the whole point of

[MediaWiki-CodeReview] [MediaWiki r91932]: Revision status changed

2011-07-12 Thread MediaWiki Mail
User Aaron Schulz changed the status of MediaWiki.r91932. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91932#c0 Commit summary: Followup r91833 -- use Sanitizer::escapeId's 'noninitial' option when generating sanitized ID for a sidebar entry;

  1   2   >