[Wikitech-l] Map internationalization beat: more on how our maps work with OSM data

Following up on yesterday’s announcement encouraging people to try out internationalized maps on testwiki [1], I added more information today [2] about how the feature works. In particular, in yesterday’s post we introduced the new map parameter and value, lang=“local”, which causes a map to

[Wikitech-l] Changes to SWAT deployment policies, effective Monday April 30th

Hello, I have made two changes to SWAT policies today. First, we now disallow multi-sync patch deployments. See T187761[0]. This means that the sync order of files is determined by git commit parent relationships (or Gerrit's "depends-on"). This is to prevent SWAT deployers from accidentally

Re: [Wikitech-l] "PHP test coverage decreased" - really?

On Thu, Apr 26, 2018 at 3:55 PM, Kunal Mehta wrote: > | includes/Storage/RevisionSlots.php| 58.33 | 49.35 | > Most of the issue there is that hasSameContent() is not being recorded as "covered" at all because you forgot the @covers annotation on

Re: [Wikitech-l] "PHP test coverage decreased" - really?

If you haven't checked out https://doc.wikimedia.org/cover/, you should! You can see what code is covered (and by which tests) and what code is not covered if you want to generally improve test coverage. Two things: 1) A coverage report like that, instead of just numbers showing the relative

Re: [Wikitech-l] "PHP test coverage decreased" - really?

-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 Hi, On 04/26/2018 12:02 PM, Daniel Kinzler wrote: > Hi all! > > While I think it's great that CI is making sure that test coverage > improves, I'm struggeling with making this work for me. It seems > to me the stats that are used to detect test

Re: [Wikitech-l] "PHP test coverage decreased" - really?

On 26/04/18 19:02, Daniel Kinzler wrote: Also, am I correct in thinking that I could introduce a completely new 1000 line class with no tests, and that would *not* be detected as decreasing coverage, since the new class didn't have any coverage before? Given that I've done similar (not a

[Wikitech-l] "PHP test coverage decreased" - really?

Hi all! While I think it's great that CI is making sure that test coverage improves, I'm struggeling with making this work for me. It seems to me the stats that are used to detect test coverage are faulty, or at least unintuitive. See for instance .