On Thu, Oct 20, 2011 at 2:39 PM, Brion Vibber br...@pobox.com wrote:
As Tim noted, the particular case in Special:Undelete is probably an
example
of old code using a lazy interface due to old assumptions, and should
actually be changed to use a proper File reference, and have a method to
On Wed, Oct 19, 2011 at 12:55 PM, Happy Melon happy.melon.w...@gmail.comwrote:
On 19 October 2011 20:41, Russell Nelson russnel...@gmail.com wrote:
In order to support viewing deleted files (currently a blocker bug in
SwiftMedia), I'm going to refactor File::getPath() into a new public
In order to support viewing deleted files (currently a blocker bug in
SwiftMedia), I'm going to refactor File::getPath() into a new public
function File::getLocalPath(), which will return an instance of a new
class TempLocalPath, which will have two methods: getPath(), and
close(). This class will
On 19 October 2011 20:41, Russell Nelson russnel...@gmail.com wrote:
In order to support viewing deleted files (currently a blocker bug in
SwiftMedia), I'm going to refactor File::getPath() into a new public
function File::getLocalPath(), which will return an instance of a new
class
On 19 October 2011 23:06, Platonides platoni...@gmail.com wrote:
El 19/10/11 21:41, Russell Nelson escribió:
In order to support viewing deleted files (currently a blocker bug in
SwiftMedia), I'm going to refactor File::getPath() into a new public
function File::getLocalPath(), which will
This is needed because some code asks for a path to the file without
having a File. For example SpecialUndelete::showFile(). Basically
encapsulation punch-through. This is a clean-up. If you disagree, of
course feel free to propose something else.
On Wed, Oct 19, 2011 at 6:06 PM, Platonides
Russell Nelson wrote:
This is needed because some code asks for a path to the file without
having a File. For example SpecialUndelete::showFile(). Basically
encapsulation punch-through. This is a clean-up. If you disagree, of
course feel free to propose something else.
They should be changed
On Wed, Oct 19, 2011 at 7:00 PM, Platonides platoni...@gmail.com wrote:
Russell Nelson wrote:
This is needed because some code asks for a path to the file without
having a File. For example SpecialUndelete::showFile(). Basically
encapsulation punch-through. This is a clean-up. If you disagree,
