Re: [Wikitech-l] Github/Gerrit mirroring

2013-03-16 Thread Daniel Friesen
On Sat, 09 Mar 2013 13:06:06 -0800, Tyler Romeo tylerro...@gmail.com wrote: - Developers don't understand rebasing - This is not a Gerrit thing. Rebasing in Git is an essential feature that anybody who uses Git should know how to use, even if on Github. Why? Because git-rebase is

Re: [Wikitech-l] Github/Gerrit mirroring

2013-03-16 Thread Daniel Friesen
On Thu, 14 Mar 2013 19:19:34 -0700, Tyler Romeo tylerro...@gmail.com wrote: Can we please be real here? The reason more contributors come in through GitHub than through Gerrit is because they *already have a GitHub account*. My browser is always logged into GitHub, and it's at the point

Re: [Wikitech-l] Github/Gerrit mirroring

2013-03-15 Thread Ryan Lane
On Thu, Mar 14, 2013 at 10:02 PM, Quim Gil q...@wikimedia.org wrote: This thread has probably reached that limit of fresh arguments. Can we continue with proper documentation, reporting and patches? We care about GitHub and we believe it is an important source of potential contributors. This

Re: [Wikitech-l] Github/Gerrit mirroring

2013-03-15 Thread Juliusz Gonera
On 03/14/2013 08:36 PM, Erik Moeller wrote: And I wouldn't be too quick to celebrate the increased vendor lock-in of a large percentage of the open source community into an ecosystem of partially proprietary tools and services (the GitHub engine itself, the official GitHub applications, etc.).

Re: [Wikitech-l] Github/Gerrit mirroring

2013-03-14 Thread Juliusz Gonera
On 03/09/2013 01:06 PM, Tyler Romeo wrote: I strongly disagree that Gerrit is harder to learn than Github. The only difficult thing to understand is the web UI, which takes only a few minutes to really get used to. Let's look at the biggest complaints: Let's not forget about this one:

Re: [Wikitech-l] Github/Gerrit mirroring

2013-03-14 Thread Juliusz Gonera
On 03/08/2013 10:20 AM, Bartosz Dziewoński wrote: On Fri, 08 Mar 2013 17:07:18 +0100, Antoine Musso hashar+...@free.fr wrote: I guess the whole idea of using GitHub is for public relation and to attract new people. Then, if a developer is not willing to learn Gerrit, its code is probably not

Re: [Wikitech-l] Github/Gerrit mirroring

2013-03-14 Thread Juliusz Gonera
On 03/08/2013 08:55 AM, Andrew Otto wrote: I've been hosting my puppet-cdh4 (Hadoop) repository on Github for a while now. I am planning on moving this into Gerrit. I've been getting pretty high quality pull requests for the last month or so from a couple of different users. (Including

Re: [Wikitech-l] Github/Gerrit mirroring

2013-03-14 Thread Andrew Otto
I've been hosting my puppet-cdh4 (Hadoop) repository on Github for a while now. I am planning on moving this into Gerrit. Why do you want to move it to gerrit then? Security reasons. All puppet repos have to be hosted by WMF and reviewed by ops before we can use it in production. On Mar

Re: [Wikitech-l] Github/Gerrit mirroring

2013-03-14 Thread Tyler Romeo
Can we please be real here? The reason more contributors come in through GitHub than through Gerrit is because they *already have a GitHub account*. My browser is always logged into GitHub, and it's at the point where I can casually just fork a project and begin working on it, whereas with Gerrit

Re: [Wikitech-l] Github/Gerrit mirroring

2013-03-14 Thread Juliusz Gonera
On 03/14/2013 07:19 PM, Tyler Romeo wrote: Like I said before, if you know how to use Git, you know how to use Gerrit (and the contra-positive is true as well). The primary thing holding people back is that it's confusing and not user friendly enough to make an account and get working. Imagine

Re: [Wikitech-l] Github/Gerrit mirroring

2013-03-14 Thread Brian Wolff
On 2013-03-14 11:20 PM, Tyler Romeo tylerro...@gmail.com wrote: Can we please be real here? The reason more contributors come in through GitHub than through Gerrit is because they *already have a GitHub account*. My browser is always logged into GitHub, and it's at the point where I can

Re: [Wikitech-l] Github/Gerrit mirroring

2013-03-14 Thread K. Peachey
On Fri, Mar 15, 2013 at 12:19 PM, Tyler Romeo tylerro...@gmail.com wrote: Can we please be real here? The reason more contributors come in through GitHub than through Gerrit is because they *already have a GitHub account*. My browser is always logged into GitHub, ?!? Unless you magically had a

Re: [Wikitech-l] Github/Gerrit mirroring

2013-03-14 Thread Erik Moeller
On Thu, Mar 14, 2013 at 7:46 PM, Juliusz Gonera jgon...@wikimedia.org wrote: I wouldn't be that optimistic, maybe it would slightly increase. Having an account is one of the factors but I wouldn't underestimate user friendliness. The first time I tried to find the URL to clone a repo in

Re: [Wikitech-l] Github/Gerrit mirroring

2013-03-14 Thread Quim Gil
This thread has probably reached that limit of fresh arguments. Can we continue with proper documentation, reporting and patches? We care about GitHub and we believe it is an important source of potential contributors. This is why we are mirroring our repos there, and this is why we are

Re: [Wikitech-l] Github/Gerrit mirroring

2013-03-10 Thread Tim Landscheidt
Dan Andreescu dandree...@wikimedia.org wrote: [...] The point I'm trying to make is that the problems with Gerrit are not problems with Gerrit, but actually problems with Git itself. If you can't handle the basics of Gerrit, it's because you don't know how to use Git. And at that point

Re: [Wikitech-l] Github/Gerrit mirroring

2013-03-10 Thread Waldir Pimenta
On Sat, Mar 9, 2013 at 8:39 PM, Ryan Lane rlan...@gmail.com wrote: On Sat, Mar 9, 2013 at 12:15 PM, Yuri Astrakhan yuriastrak...@gmail.com wrote: Should we re-start the lets migrate to github discussion? No. To be fair, though I understand the arguments against using github (though

Re: [Wikitech-l] Github/Gerrit mirroring

2013-03-10 Thread Waldir Pimenta
On Sun, Mar 10, 2013 at 8:55 AM, Waldir Pimenta wal...@email.com wrote: Are there strong reasons do dismiss it that weren't stated in that page? Sorry, forgot the link: http://www.mediawiki.org/wiki/Git/Gerrit_evaluation#GitLab ___ Wikitech-l mailing

Re: [Wikitech-l] Github/Gerrit mirroring

2013-03-10 Thread Tyler Romeo
On Sun, Mar 10, 2013 at 12:06 AM, Dan Andreescu dandree...@wikimedia.orgwrote: I disagree and I have a very simple counter-point. Gerrit makes it basically impossible to work in a git-flow style ( http://nvie.com/posts/a-successful-git-branching-model/ ). From what I understand, rebasing

Re: [Wikitech-l] Github/Gerrit mirroring

2013-03-10 Thread Ryan Lane
On Sun, Mar 10, 2013 at 12:55 AM, Waldir Pimenta wal...@email.com wrote: On Sat, Mar 9, 2013 at 8:39 PM, Ryan Lane rlan...@gmail.com wrote: On Sat, Mar 9, 2013 at 12:15 PM, Yuri Astrakhan yuriastrak...@gmail.com wrote: Should we re-start the lets migrate to github discussion?

Re: [Wikitech-l] Github/Gerrit mirroring

2013-03-09 Thread Matthew Bowker
Hi, all! Then, if a developer is not willing to learn Gerrit, its code is probably not worth the effort of integrating github/gerrit. That will just add some more poor quality code to you review queues. Submitting a patch to gerrit and even fixing it after code review is not that hard. (Of

Re: [Wikitech-l] Github/Gerrit mirroring

2013-03-09 Thread Yuri Astrakhan
Should we re-start the lets migrate to github discussion? P.S. no, this is not a troll attempt, I am trying to understand if the costs of not getting quality volunteers is worth the benefits of gerrit, or if the two-system solution would solve all perceived complexities. Moreover, I do not know

Re: [Wikitech-l] Github/Gerrit mirroring

2013-03-09 Thread Ryan Lane
On Sat, Mar 9, 2013 at 12:15 PM, Yuri Astrakhan yuriastrak...@gmail.comwrote: Should we re-start the lets migrate to github discussion? No. - Ryan ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org

Re: [Wikitech-l] Github/Gerrit mirroring

2013-03-09 Thread Brian Wolff
On 2013-03-08 2:20 PM, Bartosz Dziewoński matma@gmail.com wrote: On Fri, 08 Mar 2013 17:07:18 +0100, Antoine Musso hashar+...@free.fr wrote: I guess the whole idea of using GitHub is for public relation and to attract new people. Then, if a developer is not willing to learn Gerrit, its

Re: [Wikitech-l] Github/Gerrit mirroring

2013-03-09 Thread Yuri Astrakhan
Yes, lots of bad content might be submitted, but usually it is easy and quick to spot, and could become good content over time. What I think we should follow is the model that most other big open source projects follow, which does seem to have lower barrier of entry. On Sat, Mar 9, 2013 at 3:51

Re: [Wikitech-l] Github/Gerrit mirroring

2013-03-09 Thread Jon Robson
So, why am I not trying to learn Gerrit or try to submit patches? Because it's not worth my time. The interface is so far outside of what I'm used to, and it's just so touchy. By comparison, GitHub has a solid, no frills, Mac app that handles all of the important stuff. And, even when I

Re: [Wikitech-l] Github/Gerrit mirroring

2013-03-09 Thread Tyler Romeo
I strongly disagree that Gerrit is harder to learn than Github. The only difficult thing to understand is the web UI, which takes only a few minutes to really get used to. Let's look at the biggest complaints: - Submitting patchsets is hard - Install git-review and then just replace the git

Re: [Wikitech-l] Github/Gerrit mirroring

2013-03-09 Thread Steven Walling
On Mar 9, 2013 12:39 PM, Ryan Lane rlan...@gmail.com wrote: On Sat, Mar 9, 2013 at 12:15 PM, Yuri Astrakhan yuriastrak...@gmail.com wrote: Should we re-start the lets migrate to github discussion? No. - Ryan I agree with what everyone has been saying about the barrier to entry with

Re: [Wikitech-l] Github/Gerrit mirroring

2013-03-09 Thread Brian Wolff
On 2013-03-09 5:04 PM, Jon Robson jdlrob...@gmail.com wrote: So, why am I not trying to learn Gerrit or try to submit patches? Because it's not worth my time. The interface is so far outside of what I'm used to, and it's just so touchy. By comparison, GitHub has a solid, no frills, Mac app

Re: [Wikitech-l] Github/Gerrit mirroring

2013-03-09 Thread Jon Robson
In theory you are right - more folks = more awesomeness. In practice this involves a lot of effort, effort that people often are not willing to put in. Just look at our rather poor history with bugzilla patches (although things have improved) I see this as a good problem to have. On the short

Re: [Wikitech-l] Github/Gerrit mirroring

2013-03-09 Thread Tim Landscheidt
Tyler Romeo tylerro...@gmail.com wrote: [...] The point I'm trying to make is that the problems with Gerrit are not problems with Gerrit, but actually problems with Git itself. If you can't handle the basics of Gerrit, it's because you don't know how to use Git. And at that point I don't

Re: [Wikitech-l] Github/Gerrit mirroring

2013-03-09 Thread Dan Andreescu
[...] The point I'm trying to make is that the problems with Gerrit are not problems with Gerrit, but actually problems with Git itself. If you can't handle the basics of Gerrit, it's because you don't know how to use Git. And at that point I don't see how GitHub is going to make things

Re: [Wikitech-l] Github/Gerrit mirroring

2013-03-09 Thread Bartosz Dziewoński
On Sun, 10 Mar 2013 06:06:47 +0100, Dan Andreescu dandree...@wikimedia.org wrote: As for the argument that this will lower code quality, I think the burden of proof is on those making that assumption. You want me to link to patches created by contributors who have been carefully walked

Re: [Wikitech-l] Github/Gerrit mirroring

2013-03-09 Thread Yuri Astrakhan
On Sun, Mar 10, 2013 at 1:08 AM, Bartosz Dziewoński matma@gmail.comwrote: You want me to link to patches created by contributors who have been carefully walked through the process of submitting something to gerrit? Because I can do that, but it would be a little demeaning. (I can even

Re: [Wikitech-l] Github/Gerrit mirroring

2013-03-08 Thread Antoine Musso
Le 05/03/13 11:27, Krinkle a écrit : If all we do is immediately copy the PR, submit it to Gerrit and close the PR saying Please create a WMFLabs account, learn all of fucking Gerrit, and then continue on Gerrit to finalise the patch, then we should just kill PR now. That always has been my

Re: [Wikitech-l] Github/Gerrit mirroring

2013-03-08 Thread Dan Andreescu
... Then, if a developer is not willing to learn Gerrit, its code is probably not worth the effort of us integrating github/gerrit. That will just add some more poor quality code to your review queues. That seems like a pretty big assumption, and likely to be wrong. The simpler the code

Re: [Wikitech-l] Github/Gerrit mirroring

2013-03-08 Thread Quim Gil
On 03/08/2013 08:31 AM, Dan Andreescu wrote: ... Then, if a developer is not willing to learn Gerrit, its code is probably not worth the effort of us integrating github/gerrit. That will just add some more poor quality code to your review queues. imho GitHub has the potential to get us a

Re: [Wikitech-l] Github/Gerrit mirroring

2013-03-08 Thread Andrew Otto
I've been hosting my puppet-cdh4 (Hadoop) repository on Github for a while now. I am planning on moving this into Gerrit. I've been getting pretty high quality pull requests for the last month or so from a couple of different users. (Including CentOS support, supporting MapReduce v1 as well

Re: [Wikitech-l] Github/Gerrit mirroring

2013-03-08 Thread Jon Robson
On 8 Mar 2013 10:47, Quim Gil q...@wikimedia.org wrote: On 03/08/2013 08:31 AM, Dan Andreescu wrote: ... Then, if a developer is not willing to learn Gerrit, its code is probably not worth the effort of us integrating github/gerrit. That will just add some more poor quality code to your

Re: [Wikitech-l] Github/Gerrit mirroring

2013-03-08 Thread Bartosz Dziewoński
On Fri, 08 Mar 2013 17:07:18 +0100, Antoine Musso hashar+...@free.fr wrote: I guess the whole idea of using GitHub is for public relation and to attract new people. Then, if a developer is not willing to learn Gerrit, its code is probably not worth the effort of us integrating github/gerrit.

Re: [Wikitech-l] Github/Gerrit mirroring

2013-03-08 Thread Antoine Musso
Le 08/03/13 09:21, Jon Robson a écrit : +1 to me the need to create a gerrit account is a huge barrier for entry. I think we are missing out on attracting small but useful patches from developers who are not heavily invested in the project and have no wish to become regular core

Re: [Wikitech-l] Github/Gerrit mirroring

2013-03-08 Thread Chad
On Fri, Mar 8, 2013 at 11:50 AM, Antoine Musso hashar+...@free.fr wrote: Le 08/03/13 09:21, Jon Robson a écrit : +1 to me the need to create a gerrit account is a huge barrier for entry. I think we are missing out on attracting small but useful patches from developers who are not heavily

[Wikitech-l] Github/Gerrit mirroring

2013-03-05 Thread Jon Robson
I was wondering what the latest on this was (I can't seem to find any recent updates in my mailing list). The MobileFrontend project was reassured to see a github user commenting on our commits in github. It's made me more excited about a universe where pull requests made in github show up in

Re: [Wikitech-l] Github/Gerrit mirroring

2013-03-05 Thread Krinkle
On Mar 5, 2013, at 6:39 PM, Jon Robson jdlrob...@gmail.com wrote: I was wondering what the latest on this was (I can't seem to find any recent updates in my mailing list). The MobileFrontend project was reassured to see a github user commenting on our commits in github. It's made me more

Re: [Wikitech-l] Github/Gerrit mirroring

2013-03-05 Thread Chad
There's some upstream developers working on a github plugin. I was going to mention it once there was something worth showing (which there isn't yet). -Chad On Mar 5, 2013 9:39 AM, Jon Robson jdlrob...@gmail.com wrote: I was wondering what the latest on this was (I can't seem to find any