[MediaWiki-CodeReview] [MediaWiki r98578]: New comment added, and revision status changed
User Hashar changed the status of MediaWiki.r98578. Old Status: new New Status: resolved User Hashar also posted a comment on MediaWiki.r98578. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/98578#c26640 Commit summary: * (bug 12130) Initial newlines are now preserved correctly during editing HTML browsers strip the first newline from the literal contents of a textarea, but keep any additional newlines beyond that. Prepending an extra newline in Html::textarea() when the contained text started with a newline makes our output basically look like this: textarea -- (this added newline is ignored) -- (any original newline here is preserved) blah blah/textarea This seems to consistently resolve the stripping of single initial newlines from every edit operation as seen on bug 12130; as noted on comments there https://bugzilla.wikimedia.org/show_bug.cgi?id=12130#c17 this had deleterious effects on Wikisource, where transcription/proofreading tends to involve breaking up lots of little pages, which may have a significant newline at the start of a page boundary. Text that didn't have initial newlines won't see any difference in the HTML output. Followup to test cases in r98576, which confirm that supported browsers consistently have this behavior. Comment: Assuming this one is fine with followups. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r98578]: New comment added, and revision status changed
User Nikerabbit changed the status of MediaWiki.r98578. Old Status: new New Status: fixme User Nikerabbit also posted a comment on MediaWiki.r98578. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/98578#c23734 Commit summary: * (bug 12130) Initial newlines are now preserved correctly during editing HTML browsers strip the first newline from the literal contents of a textarea, but keep any additional newlines beyond that. Prepending an extra newline in Html::textarea() when the contained text started with a newline makes our output basically look like this: textarea -- (this added newline is ignored) -- (any original newline here is preserved) blah blah/textarea This seems to consistently resolve the stripping of single initial newlines from every edit operation as seen on bug 12130; as noted on comments there https://bugzilla.wikimedia.org/show_bug.cgi?id=12130#c17 this had deleterious effects on Wikisource, where transcription/proofreading tends to involve breaking up lots of little pages, which may have a significant newline at the start of a page boundary. Text that didn't have initial newlines won't see any difference in the HTML output. Followup to test cases in r98576, which confirm that supported browsers consistently have this behavior. Comment: Causes regression in Translate extension (extra newline in the input), when textarea content is set to null instead of empty string. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r98578]: New comment added, and revision status changed
User Brion VIBBER changed the status of MediaWiki.r98578. Old Status: fixme New Status: new User Brion VIBBER also posted a comment on MediaWiki.r98578. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/98578#c23769 Commit summary: * (bug 12130) Initial newlines are now preserved correctly during editing HTML browsers strip the first newline from the literal contents of a textarea, but keep any additional newlines beyond that. Prepending an extra newline in Html::textarea() when the contained text started with a newline makes our output basically look like this: textarea -- (this added newline is ignored) -- (any original newline here is preserved) blah blah/textarea This seems to consistently resolve the stripping of single initial newlines from every edit operation as seen on bug 12130; as noted on comments there https://bugzilla.wikimedia.org/show_bug.cgi?id=12130#c17 this had deleterious effects on Wikisource, where transcription/proofreading tends to involve breaking up lots of little pages, which may have a significant newline at the start of a page boundary. Text that didn't have initial newlines won't see any difference in the HTML output. Followup to test cases in r98576, which confirm that supported browsers consistently have this behavior. Comment: Per notes on r98892 the particular issue is now resolved by r98889. May be desirable to improve the EditPage hooks as Translate has to jump through some hoops to set the initial text consistently, so just to keep in mind for future. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
