Re: Dragon v7 pref on wine 0.9

2005-11-08 Thread wino
On Tue, 08 Nov 2005 01:06:50 +0100, Robert Shearman [EMAIL PROTECTED] wrote: [EMAIL PROTECTED] wrote: Is it still too early to expect much from wine ole and just add all ole related dlls to winecfg as native only? No. Please report any bugs with the builtin ones and I'll see what I can

Re: Question about contents of STARTUPINFO structure and non WinMain entry points

2005-11-08 Thread Eric POUECH
you likely have to fix dlls/ntdll/thread.c (in thread_init) so that the RTL_USER_PROCESS_PARAMETERS has the correct flag set (or alternatively, in dlls/kernel/process.c, in for example build_initial_environment) Note that winecrt0 is only used for winelib apps, so it's not used in case of windows

Re: kernel/comm.c - page fault in thread

2005-11-08 Thread Uwe Bonnes
Cihan == Cihan ALTINAY [EMAIL PROTECTED] writes: Cihan Hi again, Sorry for the double post and the stupid default Cihan From-Header (not my machine). I replaced my modified comm.c with Cihan the latest CVS, made the changes as described below and still got Cihan communication

Re: DirectDrawEnumerateExW calls DirectDrawEnumerateExA

2005-11-08 Thread Saulius Krasuckas
* On Thu, 27 Oct 2005, Lionel Ulmer wrote: You mean, if some day M$ changes ddraw.h so that szDescription type becomes WCHAR, right? Well, the API is like this: HRESULT WINAPI DirectDrawEnumerateExW( LPDDENUMCALLBACKEXW lpCallback, LPVOID lpContext, DWORD dwFlags); With: typedef

Re: compile error: server/event.c

2005-11-08 Thread Kuba Ober
I have problem with compiling after cvs update. Please help! $ tar xvjf wine-0.9.tar.bz2 $ mv wine-0.9 wine $ tar xvzf wine-cvsdirs-0.9.tar.gz $ cd wine $ export CVSROOT=:pserver:[EMAIL PROTECTED]:/home/wine $ cvs login $ cvs update -PAd $ ./configure Aren't one supposed to regenerate

Help exterminate Solaris issues

2005-11-08 Thread Robert Lunnon
Could I suggest where someone adds #ifdefs for linux, bsd, etc such as in the recent GlobalMemoryStatusEx issue I just fixed, that the original authors include an #else clause which raises a warning to alert us poor Solaris (and other OS) maintainers to the fact we have to do something. In the

Re: reenable SPI_{GET,SET}BORDER tests and make them pass on wine

2005-11-08 Thread Alexandre Julliard
Rein Klazes [EMAIL PROTECTED] writes: source file; - made the tests pass on wine: - - non client metric value of iBorderWidth initialized correctly; - - SPI_SETBORDER updates non client metrics; - - SPI_SETNONCLIENTMETRICS may save border width value to registry; - - borderwidth has a

tabs to throw off from an indentation

2005-11-08 Thread Saulius Krasuckas
Hello, I'd like to get rid of tabs I encounter when reading existing Wine code. Will my patches be let into the tree if I will submit such no-op changes (one patch for one file) from time to time just before normal, operational patches.

Re: tabs to throw off from an indentation

2005-11-08 Thread Alexandre Julliard
Saulius Krasuckas [EMAIL PROTECTED] writes: Will my patches be let into the tree if I will submit such no-op changes (one patch for one file) from time to time just before normal, operational patches. No, please don't do that. -- Alexandre Julliard [EMAIL PROTECTED]

Re: tabs to throw off from an indentation

2005-11-08 Thread Saulius Krasuckas
* On Tue, 8 Nov 2005, Alexandre Julliard wrote: * Saulius Krasuckas [EMAIL PROTECTED] writes: Will my patches be let into the tree if I will submit such no-op changes (one patch for one file) from time to time just before normal, operational patches. No, please don't do that. OK,

Re: [wininet]add implementation of few more options

2005-11-08 Thread Dmitry Timoshkov
Vijay Kiran Kamuju [EMAIL PROTECTED] wrote: + retval=InternetQueryOptionA(hinet,INTERNET_OPTION_USER_AGENT,NULL,len); + err=GetLastError(); + ok(len == strlen(useragent)+1,Got wrong user agent length %ld len instead of %d\n,len,strlen(useragent)); + ok(retval == 0,Got wrong return value

Re: tabs to throw off from an indentation

2005-11-08 Thread Dmitry Timoshkov
Saulius Krasuckas [EMAIL PROTECTED] wrote: OK, and what tab size should I assume when I see it in simple one level indent -- 4 or 8 space characters? Tab is 8 characters by definition. -- Dmitry.

Re: tabs to throw off from an indentation

2005-11-08 Thread Saulius Krasuckas
* On Tue, 8 Nov 2005, Dmitry Timoshkov wrote: * Saulius Krasuckas [EMAIL PROTECTED] wrote: OK, and what tab size should I assume when I see it in simple one level indent -- 4 or 8 space characters? Tab is 8 characters by definition. The question isn't about world wide definition, it's

Regression in patch 21129

2005-11-08 Thread Michael Jung
Hi, The patch http://cvs.winehq.org/patch.py?id=21129 caused a regression, which shows in emule's options dialog (v0.46c). I've attached screenshots. A number of err:imagelist:ImageList_ReplaceIcon no color! messages are given on the console. Bye, -- Michael Jung [EMAIL PROTECTED]

[PATCH] variable number of arguments in macro __ONLY_IN_WINELIB()

2005-11-08 Thread Berend Reitsma
Hi, With gcc 2.95.4 I am getting a compile error when compiling dlls/mapi32/tests/prop.c because of the use of the FAR keyword: gcc -c -I. -I. -I../../../include -I../../../include -D_REENTRANT -fPIC -Wall -pipe -mpreferred-stack-boundary=2 -fno-strict-aliasing -gstabs+ -Wpointer-arith -g -O2 -o

Re: compile error: server/event.c

2005-11-08 Thread Marcus Meissner
On Mon, Nov 07, 2005 at 08:31:19PM +0100, Sütő Gergely wrote: Hello! (Sorry for my bad English.) I have problem with compiling after cvs update. Please help! $ tar xvjf wine-0.9.tar.bz2 $ mv wine-0.9 wine $ tar xvzf wine-cvsdirs-0.9.tar.gz $ cd wine $ export CVSROOT=:pserver:[EMAIL

Re: RESEND [wininet]add implementation of few more options

2005-11-08 Thread Dmitry Timoshkov
Vijay Kiran Kamuju [EMAIL PROTECTED] wrote: as previous implementation had some bugs use this version +case INTERNET_OPTION_VERSION: { -if (*lpdwBufferLength sizeof(HTTP_VERSION_INFO)) -INTERNET_SetLastError(ERROR_INSUFFICIENT_BUFFER); +

Re: RESEND [wininet]add implementation of few more options

2005-11-08 Thread Andreas Mohr
Hi, On Wed, Nov 09, 2005 at 12:07:57AM +0800, Dmitry Timoshkov wrote: Vijay Kiran Kamuju [EMAIL PROTECTED] wrote: + char useragent[] = {'W','i','n','i','n','e','t',' ','T','e','s','t',0 }; char useragent[] = Wininet Test; works just fine. Maybe it works, but not fine ;) static const

Re: [PATCH] variable number of arguments in macro __ONLY_IN_WINELIB()

2005-11-08 Thread Kuba Ober
In include/windef.h the definition of FAR is a call to the macro __ONLY_IN_WINELIB with no arguments. The attached patch changes the definition of the macro to use variable arguments According to some documentation I found on the web When it comes to things that may break code for many

Regression with icons being black?

2005-11-08 Thread Paul Vriens
Hi, just started Process Explorer with latest CVS and the icons for the processes are black instead of colorful. I will do some regression testing. Anyone experiencing the same? Cheers, Paul.

Re: Regression with icons being black?

2005-11-08 Thread Michael Stefaniuc
Paul Vriens wrote: Hi, just started Process Explorer with latest CVS and the icons for the processes are black instead of colorful. I will do some regression testing. You do not need to; look for Michael Jung's email with subject Regression in patch 21129 on wine-devel. Anyone experiencing

Re: Regression with icons being black?

2005-11-08 Thread Michael Jung
Hi Paul, On Tuesday 08 November 2005 18:03, Paul Vriens wrote: just started Process Explorer with latest CVS and the icons for the processes are black instead of colorful. I will do some regression testing. Anyone experiencing the same? Yes, I guess it's:

Re: Dragon v7 pref on wine 0.9

2005-11-08 Thread Robert Shearman
[EMAIL PROTECTED] wrote: On Tue, 08 Nov 2005 01:06:50 +0100, Robert Shearman [EMAIL PROTECTED] wrote: [EMAIL PROTECTED] wrote: Is it still too early to expect much from wine ole and just add all ole related dlls to winecfg as native only? No. Please report any bugs with the builtin

Ok to call CoInitialize in the file dialogs?

2005-11-08 Thread Michael Jung
Hi all, Some shell namespace extensions only work if COM is initialized (For instance the brand-new shell instance objects ;) Go download the free (as in beer) Shell Object Editor from www.tropictech.de if you want to try them.). On WinXP those work without the application calling CoInitialize

Re: Regression with icons being black?

2005-11-08 Thread Paul Vriens
On Tue, 2005-11-08 at 18:22 +0100, Michael Jung wrote: Hi Paul, On Tuesday 08 November 2005 18:03, Paul Vriens wrote: just started Process Explorer with latest CVS and the icons for the processes are black instead of colorful. I will do some regression testing. Anyone experiencing

Needs some guidance (aclui/netapi32)

2005-11-08 Thread Paul Vriens
Hi, I'm trying to add some extra functions to our netapi32 (domain service related stuff) as this is needed by Process Explorer (or actually by native aclui.dll). I've experienced some crashes, so I tried it with a native netapi32 and the crashes still occur: fixme:advapi:LsaLookupSids

Re: compile error: server/event.c

2005-11-08 Thread Sütő Gergely
Hali! The line numbers are off. Can you check cvs diff -u if there is any conflict caused by the cvs update? Ciao, Marcus I deleted all and I started from beginning. $ tar xvjf wine-0.9.tar.bz2 $ mv wine-0.9 wine $ tar xvzf wine-cvsdirs-0.9.tar.gz $ cd wine $ export

cvswine can't find files

2005-11-08 Thread Coleman Jeremy D SrA 50 OSS/OSOT1
I have been trying to use cvswine because it has the d3d9 patches merged. The problem I run into is that for some reason it is unable to find required files (particularly dlls) even when run from within the same directory. I have seen this happen with the following programs so far.

Re: RESEND [wininet]add implementation of few more options

2005-11-08 Thread Robert Shearman
Vijay Kiran Kamuju wrote: +case INTERNET_OPTION_ASYNC: +case INTERNET_OPTION_ASYNC_ID: +case INTERNET_OPTION_ASYNC_PRIORITY: +case INTERNET_OPTION_CALLBACK_FILTER: +case INTERNET_OPTION_CODEPAGE: +case INTERNET_OPTION_CONNECT_BACKOFF: +

Re: Ok to call CoInitialize in the file dialogs?

2005-11-08 Thread Michael Jung
Hi Rob, On Tuesday 08 November 2005 19:59, Robert Shearman wrote: The only objection is that in general it is bad to force a threading model and that the caller should be the one specifying it. I guess that's not a problem. If COM isn't initialized prior to the call to SHBrowseForFolder it

kernel32/tests thread.ok fails

2005-11-08 Thread Paul Vriens
Hi, the traces are my doing, but: thread.c:660:test_CreateThread_basic() thread.c:662:test_CreateThread_suspended() thread.c:664:test_SuspendThread() thread.c:666:test_TerminateThread() thread.c:668:test_CreateThread_stack() thread.c:670:test_thread_priority() thread.c:672:test_GetThreadTimes()

Re: KERNEL: GetTempFileNameW should not require prefix

2005-11-08 Thread James Hawkins
On 11/8/05, Phil Lodwick [EMAIL PROTECTED] wrote: Hi, _tempnam(., NULL) fails when using the builtin msvcrt.dll. This is because GetTempFileNameW was requiring a non-NULL prefix. This is my first patch submission. Please let me know if I am doing it wrong as I have more to come. A test

Re: kernel32/tests thread.ok fails

2005-11-08 Thread Paul Vriens
On Tue, 2005-11-08 at 21:22 +0100, Paul Vriens wrote: Hi, the traces are my doing, but: thread.c:660:test_CreateThread_basic() thread.c:662:test_CreateThread_suspended() thread.c:664:test_SuspendThread() thread.c:666:test_TerminateThread() thread.c:668:test_CreateThread_stack()

Re: Ok to call CoInitialize in the file dialogs?

2005-11-08 Thread Robert Shearman
Michael Jung wrote: Hi Rob, On Tuesday 08 November 2005 19:59, Robert Shearman wrote: The only objection is that in general it is bad to force a threading model and that the caller should be the one specifying it. I guess that's not a problem. If COM isn't initialized prior to the

Re: KERNEL: GetTempFileNameW should not require prefix

2005-11-08 Thread Dimi Paun
Index: path.c === RCS file: /home/wine/wine/dlls/kernel/path.c,v retrieving revision 1.26 diff -u -r1.26 path.c --- path.c 8 Nov 2005 11:01:03 - 1.26 +++ path.c 8 Nov 2005 19:54:35 - Please create the diff from the

Re: Question about contents of STARTUPINFO structure and non WinMain entry points

2005-11-08 Thread James Liggett
On Tue, 2005-11-08 at 09:43 +0100, Eric POUECH wrote: you likely have to fix dlls/ntdll/thread.c (in thread_init) so that the RTL_USER_PROCESS_PARAMETERS has the correct flag set (or alternatively, in dlls/kernel/process.c, in for example build_initial_environment) I tried modifying the

Wine API Documentation

2005-11-08 Thread Robert Shearman
Hi, At the moment we have a very outdated version of the auto-generated make htmlpages Wine API documentation at http://source.winehq.org/WineAPI/ I want to fix this. * *I believe that the API documentation is important for a number of reasons: 1. It might provide info to ISVs that might think

Re: Wine API Documentation

2005-11-08 Thread James Hawkins
On 11/8/05, Robert Shearman [EMAIL PROTECTED] wrote: *I believe that the API documentation is important for a number of reasons: 1. It might provide info to ISVs that might think about porting an app to Wine as to whether the APIs that they use are implemented or not. 2. It provides info about

Re: RESEND [wininet]add implementation of few more options

2005-11-08 Thread Vijay Kiran Kamuju
Hi, I have made changes, sending them soon. Dimitry: In your first suggestion, i think using a new variable is not a good idea. It has been done like that for all options and previously for the same options. next time i will think of something valid. In your third suggestion, you asked me not to

Re: crypt32: plug memory leaks

2005-11-08 Thread Robert Shearman
Juan Lang wrote: Hope you don't mind the memory function changes, they helped me debug the leaks. ChangeLog: - use macros for memory allocation for easier debugging - plug memory leaks I'm not sure why you need to use these extra macros for memory allocation. Can't you simply replace the

Re: crypt32: plug memory leaks

2005-11-08 Thread Juan Lang
--- Robert Shearman [EMAIL PROTECTED] wrote: I'm not sure why you need to use these extra macros for memory allocation. Can't you simply replace the CryptMem* functions during debugging with a macro? Not without an uglier hack, the CryptMem functions are exported. I can just define new

Re: crypt32: plug memory leaks

2005-11-08 Thread Robert Shearman
Juan Lang wrote: --- Robert Shearman [EMAIL PROTECTED] wrote: I'm not sure why you need to use these extra macros for memory allocation. Can't you simply replace the CryptMem* functions during debugging with a macro? Not without an uglier hack, the CryptMem functions are exported.

Re: crypt32: plug memory leaks

2005-11-08 Thread Dimi Paun
On Tue, 2005-11-08 at 22:21 -0600, Robert Shearman wrote: You can still #define them to whatever you want in the header file, as long as you #undef them before the implementation of the CryptMem* functions and redefine them afterwards. Yeah, please do that, the additional level of indirection

Re: RESEND [wininet]add implementation of few more options

2005-11-08 Thread James Hawkins
On 11/9/05, Vijay Kiran Kamuju [EMAIL PROTECTED] wrote: In your third suggestion, you asked me not to set to 0, if set to 0xdeadbeef, that means i have to check for 0xdeadbeef. :(. when does API set its error to 0, what might be the cases generally. You have to set the last error to a crazy

Re: RESEND [wininet]add implementation of few more options

2005-11-08 Thread Vijay Kiran Kamuju
I tried in test program initilizing the length varaible like DWORD len=0; Then its giving me garbage, didnt try other possibilities. Thanks, Vijay On 11/9/05, James Hawkins [EMAIL PROTECTED] wrote: On 11/9/05, Vijay Kiran Kamuju [EMAIL PROTECTED] wrote: In your third suggestion, you asked me

Re: RESEND [wininet]add implementation of few more options

2005-11-08 Thread Dmitry Timoshkov
Vijay Kiran Kamuju [EMAIL PROTECTED] wrote: I have made changes, sending them soon. Dimitry: In your first suggestion, i think using a new variable is not a good idea. It has been done like that for all options and previously for the same options. next time i will think of something valid.

Re: added implementation of some more options - try3

2005-11-08 Thread Dmitry Timoshkov
Vijay Kiran Kamuju [EMAIL PROTECTED] wrote: Added implementation for INTERNET_OPTION_VERSION Added implementation for INTERNET_OPTION_USER_AGENT Fixed behavior for INTERNET_OPTION_HTTP_VERSION Added implementation for unsupported options Added some minimalist testcases In this version

Re: RESEND [wininet]add implementation of few more options

2005-11-08 Thread Vijay Kiran Kamuju
On 11/9/05, Dmitry Timoshkov [EMAIL PROTECTED] wrote: Vijay Kiran Kamuju [EMAIL PROTECTED] wrote: I have made changes, sending them soon. Dimitry: In your first suggestion, i think using a new variable is not a good idea. It has been done like that for all options and previously for

Re: XEmbed Systray Support

2005-11-08 Thread Vijay Kiran Kamuju
could you please send a new patch as per latest cvs or 0.9 I would like to test this patch. with 0.9 its not applying properly Thanks, Vijay On 10/27/05, James Liggett [EMAIL PROTECTED] wrote: On Wed, 2005-10-19 at 14:33 +0200, Alexandre Julliard wrote: I'm afraid it's too big a change to get

Re: Needs some guidance (aclui/netapi32)

2005-11-08 Thread Juan Lang
Hi Paul, I'm trying to add some extra functions to our netapi32 (domain service related stuff) as this is needed by Process Explorer (or actually by native aclui.dll). Cool. I'd just try to stub out the missing functions for now if I were you. Maybe this is what you're already trying. I

Re: added implementation of some more options - try3

2005-11-08 Thread Juan Lang
Hi Vijay, thanks for adding test cases this time. + hurl = InternetConnectA(hinet,www.winehq.com,INTERNET_DEFAULT_HTTP_PORT, NULL,NULL,INTERNET_SERVICE_HTTP,0,0); + ok((hurl != 0x0),InternetConnect Failed\n); You should just clean up if this fails, there are many reasons a connect to

Re: Wine API Documentation

2005-11-08 Thread Ivan Leo Puoti
Robert Shearman wrote: *It appears that this was previously generated at release time by the wine_release script (http://cvs.winehq.org/cvsweb/tools/wine_release), but was disabled over 2 years ago. I was wondering what the reason was, but I guess it is that it takes a long time to build and a

Re: tabs to throw off from an indentation

2005-11-08 Thread Ivan Leo Puoti
Saulius Krasuckas wrote: The question isn't about world wide definition, it's about preference inside Wine project. But OK, I will use tabs in a tabby files. Please use spaces, we can't get rid of existing tabs but let's not make things worse. Ivan.