Re: dlls/wined3d/device.c GetCreationParameters

2006-01-17 Thread Robert Shearman
Aric Cyr wrote: Al Tobey tobert at gmail.com writes: Here is the new patch. I did some additional testing and couldn't get the same app to fail on that function again. It still works with this new patch, so I'm assuming for now that it's correct.Anyways, thanks again. Hi Al,

Re: [rpcrt4] Properly created named pipes

2006-01-17 Thread Robert Shearman
Thomas Weidenmueller wrote: Created the named pipes with the FILE_FLAG_OVERLAPPED flag, otherwise the call to ConnectNamedPipe() will block the server thread if no connection can be established, which causes the rpc server to dead-lock during startup. Hi Thomas, I have a patch that

Re: dlls/wined3d/device.c GetCreationParameters

2006-01-17 Thread H. Verbeet
On 17/01/06, Robert Shearman [EMAIL PROTECTED] wrote: This should never be NULL as where did the application get the address of the function from? Well, The function could be called directly from inside wined3d, or the application could store the address somewhere. Something along the lines of:

Re: [rpcrt4] Properly created named pipes

2006-01-17 Thread Thomas Weidenmueller
Robert Shearman wrote: I have a patch that converts rpcrt4 over to using overlapped I/O, but I didn't submit it because the performance on Wine is horrible. When using overlapped I/O we have to perform several more server calls than when using non-overlapped I/O. Also, I think that this patch

Re: dlls/wined3d/device.c GetCreationParameters

2006-01-17 Thread Aric Cyr
H. Verbeet hverbeet at gmail.com writes: On 17/01/06, Robert Shearman rob at codeweavers.com wrote: This should never be NULL as where did the application get the address of the function from? Well, The function could be called directly from inside wined3d, or the application could store

Re: dlls/wined3d/device.c GetCreationParameters

2006-01-17 Thread Alexandre Julliard
Aric Cyr [EMAIL PROTECTED] writes: Ya, I thought about that after I sent my previous mail as well... an assert would probably be more useful for checking This. I also disagree that This is guaranteed to always be non-NULL. There really is no way you can force policy how a user calls the

Re: dlls/wined3d/device.c GetCreationParameters

2006-01-17 Thread Andreas Mohr
Hi, On Tue, Jan 17, 2006 at 11:16:42AM +0100, Alexandre Julliard wrote: Aric Cyr [EMAIL PROTECTED] writes: Ya, I thought about that after I sent my previous mail as well... an assert would probably be more useful for checking This. I also disagree that This is guaranteed to always

Re: [rpcrt4] Properly created named pipes

2006-01-17 Thread Robert Shearman
Thomas Weidenmueller wrote: Robert Shearman wrote: I have a patch that converts rpcrt4 over to using overlapped I/O, but I didn't submit it because the performance on Wine is horrible. When using overlapped I/O we have to perform several more server calls than when using non-overlapped I/O.

Re: WINED3D: [02/02] IWineD3DSurfaceImpl_SetContainer IWineD3DVolumeImpl_SetContainer refcount fixes.

2006-01-17 Thread H. Verbeet
What is wrong with this patch / what can I do to fix it?

Re: dlls/wined3d/device.c GetCreationParameters

2006-01-17 Thread Aric Cyr
Andreas Mohr andi at rhlx01.fht-esslingen.de writes: On Tue, Jan 17, 2006 at 11:16:42AM +0100, Alexandre Julliard wrote: Aric Cyr Aric.Cyr at gmail.com writes: Ya, I thought about that after I sent my previous mail as well... an assert would probably be more useful for checking This.

[rpcrt4] Properly created named pipes

2006-01-17 Thread Thomas Weidenmueller
Created the named pipes with the FILE_FLAG_OVERLAPPED flag, otherwise the call to ConnectNamedPipe() will block the server thread if no connection can be established, which causes the rpc server to dead-lock during startup. - Thomas Index: dlls/rpcrt4/rpc_binding.c

Mandriva problems

2006-01-17 Thread Krister Hallergard
Have asked this question to several news groups without getting any response. Was suggested that I submit it to you Krister Hallergard Lytham UK Have problems to install quite a few programs with wine - Mandriva 2006 that I can install without problems with other distros (SuSE10.0, Fedora

Re: [rpcrt4] Properly created named pipes

2006-01-17 Thread Thomas Weidenmueller
Robert Shearman wrote: Thomas Weidenmueller wrote: If what you say is true about the PIPE_NOWAIT flag affecting this then it should be easy to fix. The PIPE_NOWAIT flag is documented in the PSDK. In fact, named pipes are handled slightly differently in ReadFile/WriteFile. Even if the named

GIT rebase changes

2006-01-17 Thread Mike McCormack
Hi GIT users, The GIT guys have made rebase and pull incompatible, and to use rebase (which is likely what we want to do for Wine), you must use fetch then rebase, not pull (which does a merge). See: http://article.gmane.org/gmane.linux.kernel/365410 The error message that you get if you

Unixfs as ShellFSFolder?

2006-01-17 Thread Michael Jung
Hi all, I guess I'm responsible for a lot of redundant code between the implementations of filesystem shellfolders in shell32/shlfdr_fs.c and shfldr_unixfs.c. While I've always tried to re-use as much code as possible, unixfs by nature has to use posix apis to get hold of the unix filesystem.

Re: GIT rebase changes

2006-01-17 Thread Michael Stefaniuc
Hi! Mike McCormack wrote: The GIT guys have made rebase and pull incompatible, and to use rebase (which is likely what we want to do for Wine), you must use fetch then rebase, not pull (which does a merge). Depends if you want to keep your old history or not. git pull works nicely. See:

RE: Unixfs as ShellFSFolder?

2006-01-17 Thread Ge van Geldorp
From: Michael Jung What do people think about getting rid of shfldr_fs.c in the long run, in order to remove the redundancy? Does ReactOS use wine's shell32.dll? I guess it would be a problem for them? Yes, we do and yes, it would be a problem... We don't import the shfldr_unixfs.c file

Re: HW address w/o connection in iphlpapi

2006-01-17 Thread most
Juan, When you boot a linux box without an ethernet connection, and eth0 configuration fails, GetAdaptersInfo does not return MAC address info for eth0. The problem seems to be that enumerateInterfaces (in dlls/iphlpapi/ifenum.c) doesn't create a record for eth0, because SIOCGIFCONF doesn't

Benchmarks for 0.9.5

2006-01-17 Thread Tom Wickline
Hello, Please take with a large dose of salt. http://wiki.winehq.org/BenchMark-0.9.5 Tom -- Pain needs not cry for me...

Re: Benchmarks for 0.9.5

2006-01-17 Thread Chris Morgan
We appear to be faster now, leading in 67 tests vs. 63 for a previous set of benchmarks? Its difficult to see the trend over time having to go back and forth between pages. Chris On 1/17/06, Tom Wickline [EMAIL PROTECTED] wrote: Hello, Please take with a large dose of salt.

Re: winspool/tests: dump filename and version of the tested file

2006-01-17 Thread James Hawkins
On 1/17/06, Detlef Riekenberg [EMAIL PROTECTED] wrote: Changelog: - winspool/tests: dump filename and version of the tested file - use name for all includes We generally have a policy of silence for the test suite unless a failure occurrs. Why do you need to output the version tested? --

Re: Benchmarks for 0.9.5

2006-01-17 Thread Tom Wickline
On 1/17/06, Chris Morgan [EMAIL PROTECTED] wrote: We appear to be faster now, leading in 67 tests vs. 63 for a previous set of benchmarks? Its difficult to see the trend over time having to go back and forth between pages. Chris There is going to be a rather significant change taking place

Re: GIT rebase changes

2006-01-17 Thread Michael Stefaniuc
I hate to reply to myself, but ... Michael Stefaniuc wrote: Mike McCormack wrote: The GIT guys have made rebase and pull incompatible, and to use rebase (which is likely what we want to do for Wine), you must use fetch then rebase, not pull (which does a merge). Depends if you want to keep

Re: Benchmarks for 0.9.5

2006-01-17 Thread Tom Wickline
On 1/17/06, Tom Wickline [EMAIL PROTECTED] wrote: Hello, Please take with a large dose of salt. http://wiki.winehq.org/BenchMark-0.9.5 Add more salt, I have the 3dmark2000 result browser installed and can get scores from full screen runs now. Tom

Re: Benchmarks for 0.9.5

2006-01-17 Thread Dimi Paun
From: Tom Wickline [EMAIL PROTECTED] I was going to put the new results next to the old wine results, but I re-ran some of the test on XP as well because wine will run the HDD test in pcmark04 now. I can put up a page with 20050419 results vs 0.9.5 ?? That would be great, but please don't

winspool/tests: a Space before the printername is invalid

2006-01-17 Thread Detlef Riekenberg
Am Dienstag, den 17.01.2006, 13:08 -0600 schrieb Wine Bugs: --- Additional Comments From [EMAIL PROTECTED] 2006-17-01 13:08 --- And to make it complete, space before printer name in customized printing dialog is still present. (mayby small bug in ISS?) This Patch validates, that

TaxAct 2005 file problem

2006-01-17 Thread James E. LaBarre
As usual, this year's version of TaxAct has the same defect (or programming screw-up) it's had for years now that prevents it from being usable under Wine. The app installs fine, and will start to run as if it was sufficiently compatible with Wine. The problem with TA is that it *always* tries

CVS build error on RH9

2006-01-17 Thread Robert Reif
This patch: http://www.winehq.org/pipermail/wine-cvs/2006-January/020350.html doesn't compile on RH9. make[2]: Entering directory `/home/wine/wine/dlls/d3d8' gcc -c -I. -I. -I../../include -I../../include -I/usr/X11R6/include -D__WINESRC__ -D_REENTRANT -fPIC -Wall -pipe

Re: Benchmarks for 0.9.5

2006-01-17 Thread Scott Ritchie
On Tue, 2006-01-17 at 17:22 -0500, Dimi Paun wrote: From: Tom Wickline [EMAIL PROTECTED] I was going to put the new results next to the old wine results, but I re-ran some of the test on XP as well because wine will run the HDD test in pcmark04 now. I can put up a page with 20050419

Re: Benchmarks for 0.9.5

2006-01-17 Thread Aric Cyr
Tom Wickline twickline at gmail.com writes: On 1/17/06, Tom Wickline twickline at gmail.com wrote: Hello, Please take with a large dose of salt. http://wiki.winehq.org/BenchMark-0.9.5 Add more salt, I have the 3dmark2000 result browser installed and can get scores from full screen

Re: HW address w/o connection in iphlpapi

2006-01-17 Thread Juan Lang
Dang. It doesn't work for down devices. When I run strace on a program that uses getifaddrs, the socket is opened with IPROTO_IP: socket(PF_INET, SOCK_DGRAM, IPPROTO_IP) = 14 ioctl(14, 0x8912, 0x2084d3a8) = 0 That's SIOCGIFCONF. So it looks like getifaddrs isn't doing anything