Re: [Re] Vertex pipeline replacement

2008-10-31 Thread Austin English
On Thu, Oct 30, 2008 at 11:22 PM, James Hawkins [EMAIL PROTECTED] wrote: On Thu, Oct 30, 2008 at 10:07 PM, James McKenzie [EMAIL PROTECTED] wrote: Tobias Jakobi wrote: Short feedback: - Max Payne 2: works as expected, I don't see any visual changes - Morrowind: 3D rendering breaks completly,

Re: [Re] Vertex pipeline replacement

2008-10-31 Thread Henri Verbeet
2008/10/31 Austin English [EMAIL PROTECTED]: Apply a single patch at a time until it breaks. You'll probably just end up with patch 12, which is huge and enables the entire thing.

Re: wininet: let automated testers force all DNS lookups to return localhost

2008-10-31 Thread Hans Leidekker
On Friday 31 October 2008 12:45:58 Dan Kegel wrote: The public internet can (and does) go pear-shaped in the middle of test runs, which means any test that tries to access the public internet is de facto flaky, even if it tries to protect itself by skipping if the internet is down. So

Re: wininet: let automated testers force all DNS lookups to return localhost

2008-10-31 Thread Dan Kegel
On Fri, Oct 31, 2008 at 5:32 AM, Hans Leidekker [EMAIL PROTECTED] wrote: What happened to your /etc/hosts proposal? It has the advantage that we don't need changes to Wine source code. But the disadvantage that we need to know which servers the test code is going to look up. I guess I should

patchwatcher problem

2008-10-31 Thread Vitaly Perov
Hi! Today I sent the patch netapi32: add stub for NetShareAdd On the old patchwatcher it fails: winspool.drv:info.c:1281: Test failed: Parameter size wrong! 4 expected got 0 My patch changes only netapi32. I have no idea why the winespool.drv test can fail. On the new patchwatcher it have

Re: wininet: let automated testers force all DNS lookups to return localhost

2008-10-31 Thread Hans Leidekker
On Friday 31 October 2008 13:39:36 Dan Kegel wrote: On Fri, Oct 31, 2008 at 5:32 AM, Hans Leidekker [EMAIL PROTECTED] wrote: What happened to your /etc/hosts proposal? It has the advantage that we don't need changes to Wine source code. But the disadvantage that we need to know which

Re: [Re] Vertex pipeline replacement

2008-10-31 Thread James Mckenzie
James Hawkins [EMAIL PROTECTED] at Oct 30, 2008 9:22 PM wrote about Re: [Re] Vertex pipeline replacement On Thu, Oct 30, 2008 at 10:07 PM, James McKenzie [EMAIL PROTECTED] wrote: Tobias Jakobi wrote: Short feedback: - Max Payne 2: works as expected, I don't see any visual changes -

Re: wininet: let automated testers force all DNS lookups to return localhost

2008-10-31 Thread James Mckenzie
Hans Leidekker [EMAIL PROTECTED] at Oct 31, 2008 5:32 AM wrote about Re: wininet: let automated testers force all DNS lookups to return localhost Only include this in debugging builds. What happened to your /etc/hosts proposal? It has the advantage that we don't need changes to Wine

Re: wininet: let automated testers force all DNS lookups to return localhost

2008-10-31 Thread Henri Verbeet
2008/10/31 James Mckenzie [EMAIL PROTECTED]: This would not work on Macs as /etc/hosts is locked to admins only and would be a problem to implement. I don't see how that's a problem, or how that's different from eg. Linux. More on-topic, I don't think it would be hard to do some LD_PRELOAD

Re: wininet: let automated testers force all DNS lookups to return localhost

2008-10-31 Thread Hans Leidekker
On Friday 31 October 2008 15:52:43 James Mckenzie wrote: What happened to your /etc/hosts proposal? It has the advantage that we don't need changes to Wine source code. This would not work on Macs as /etc/hosts is locked to admins only and would be a problem to implement. That's true for

Re: wininet: let automated testers force all DNS lookups to return localhost

2008-10-31 Thread Dan Kegel
On Fri, Oct 31, 2008 at 6:15 AM, Hans Leidekker [EMAIL PROTECTED] wrote: Yes, I think this could use a bit of standardization. Perhaps we could have a scheme like this: http.test.winehq.org ftp.test.winehq.org ldap.test.winehq.org pop3.test.winehq.org ... And mandate that networked

Re: wininet: let automated testers force all DNS lookups to return localhost

2008-10-31 Thread Dan Kegel
On Fri, Oct 31, 2008 at 8:11 AM, Henri Verbeet [EMAIL PROTECTED] wrote: 2008/10/31 James Mckenzie [EMAIL PROTECTED]: This would not work on Macs as /etc/hosts is locked to admins only and would be a problem to implement. I don't see how that's a problem, or how that's different from eg.

RE: [Re] Vertex pipeline replacement

2008-10-31 Thread Stefan Dösinger
If you know which patch might have broken this, start there. If you do not, a normal regression test is a good idea. It will always be the last patch. This patch does the real thing, the others are just making the infrastructure more flexible. So a regression test in this case is mostly useless

Re: malloc to HeapAlloc in dlls/kernel32/process.c

2008-10-31 Thread Michael Stefaniuc
Hello Pete, Pete Myers wrote: Hi, this is my first ever commit to the Wine project. In line with http://wiki.winehq.org/ReplaceMalloc this is a small patch that changes all malloc calls in ./dlls/kernel32/process.c to HeapAlloc. Changelog: * malloc calls in dlls/kernel32/process.c have

Re: wininet: let automated testers force all DNS lookups to return localhost

2008-10-31 Thread Henri Verbeet
2008/10/31 Dan Kegel [EMAIL PROTECTED]: How would we do this on Windows? (We need the winetest results to be reliable, too.) That was the main reason I didn't go for LD_PRELOAD... I guess we do some sort of DLL injection, but I haven't done it personally before. - Dan You could patch the

Re: wininet: let automated testers force all DNS lookups to return localhost

2008-10-31 Thread Dan Kegel
On Fri, Oct 31, 2008 at 8:51 AM, Henri Verbeet [EMAIL PROTECTED] wrote: 2008/10/31 Dan Kegel [EMAIL PROTECTED]: How would we do this on Windows? (We need the winetest results to be reliable, too.) That was the main reason I didn't go for LD_PRELOAD... I guess we do some sort of DLL

Re: [Re] Vertex pipeline replacement

2008-10-31 Thread Tobias Jakobi
Stefan Dösinger wrote: If you know which patch might have broken this, start there. If you do not, a normal regression test is a good idea. It will always be the last patch. This patch does the real thing, the others are just making the infrastructure more flexible. So a regression test in

re: patchwatcher problem

2008-10-31 Thread Dan Kegel
Vitaly Perov wrote: Today I sent the patch netapi32: add stub for NetShareAdd On the old patchwatcher it fails: winspool.drv:info.c:1281: Test failed: Parameter size wrong! 4 expected got 0 My patch changes only netapi32. I have no idea why the winespool.drv test can fail. Sorry, I think

RE: [Re] Vertex pipeline replacement

2008-10-31 Thread Stefan Dösinger
What about opening a metabug and adding all apps what break with the new code? Or do you wanna have all this in separate bug reports? Just file a bug report, assign it to me, and make it clear that this new code breaks things. I have one reported problem fixed already, and I am currently

Please, look at my patch, I'm not sure it's correct

2008-10-31 Thread Vitaly Perov
Hi, This patch add a stub implementation of IMarshal interface. I have no experience at implementing interfaces, so I'm not sure it's implemented correctly. Please, look at this patch. I'll be grateful for any remarks. Thank you. -- Best wishes, Vitaly Perov Russia, Saint-Petersburg.

Re: DIrectSound on top of openAL ?

2008-10-31 Thread Chris Robinson
On Friday 31 October 2008 10:11:12 am you wrote: I think that your dsound-openAL wrapper could be used verbatim in wine, if wine provides an openal32.dll - native openal wrapper (as with opengl32). I have one of those, too, but it's not yet suitable for inclusion into Wine. In particular, I

Re: D3DXMatrixstack: where to go....

2008-10-31 Thread Henri Verbeet
2008/10/31 Jérôme Gardou [EMAIL PROTECTED]: Henri Verbeet a écrit : Actually, I just cleaned up your patches, and will probably submit the first few later today. Are you going to finish it or can I send the few missing functions ? Sure, go ahead. I sent all the patches I wrote for this.

RE: [Re] Vertex pipeline replacement

2008-10-31 Thread Stefan Dösinger
Here is an updated version of the patches. Can you retest the games? (the ones that worked already as well as the broken ones) What are the differences? - Proper handling of RHW vertices which do not come from a vbo(should fix Star Wars Jedi Knight 1) - Proper handling of the alpha value in the

Re: D3DXMatrixstack: where to go....

2008-10-31 Thread Henri Verbeet
2008/10/31 Jérôme Gardou [EMAIL PROTECTED]: OK, patches will be sent soon. By the way, what if I call multiply on a new stack, the push, then pop ? Will the top matrix be identity, or the one with which I multiplied the first time ? I guess this calls a testcase ... I think it should return

General script for installing Wine build dependencies

2008-10-31 Thread Dan Kegel
I have in the past written one script per version of Ubuntu to install Wine's build dependencies. Many versions on, that's getting old, and I figure it'd be better to have a single script that handles all common versions on Linux. I've taken a first stab at that, combining my scripts for gutsy