RE: Bugzilla upgrade - opening attachments in browser

2009-05-20 Thread Nicklas Börjesson
It seems the bugzilla upgrade stopped allowing opening attachments in browser. I can comfirm this on several platforms and browsers. //Nicklas

Re: [PATCH] winhttp: avoid NULL ptr dereference (Coverity 927)

2009-05-20 Thread Marcus Meissner
On Tue, May 19, 2009 at 01:46:31PM +0200, Paul Vriens wrote: Marcus Meissner wrote: +lend2: TRACE(%d --\n, bSuccess); return bSuccess; } Hi Marcus, After AJ's remark you marked this Coverity one as lpwhr can not be NULL. Should we thus delete the NULL == lpwhr altogether?

Re: News on Wine 1.1.21/MacOSX/XQuartz 2.3.3

2009-05-20 Thread Mike Kronenberg
Hi, It's not about being willing to, but plain lack of time. I follow this list closely and work as time permits. After half a year, it's been four weeks now that I am able again to build and test on a regular base again. There are other components on OS X that need some love, like the

Re: News on Wine 1.1.21/MacOSX/XQuartz 2.3.3

2009-05-20 Thread Mike Kronenberg
On 18.05.2009, at 06:56, Dmitry Timoshkov wrote: James McKenzie jjmckenzi...@earthlink.net wrote: Austin: Contact Mike Kronenberg or Zach Drayer and see what they currently have. IMHO since they haven't even bothered so far to change the license from GPL to LGPL to match Wine, and clarify

malloc() use in rpcrt4/tests/server.c

2009-05-20 Thread Francois Gouget
Is there a specific reason for using malloc() in these tests? Testing that rpcrt4 does not assume HeapAlloc pointers? (but why would it even care?) Here are the relevant lines: in midl_user_allocate(): dlls/rpcrt4/tests/server.c:56: use HeapXxx(): return malloc(n); in array_tests():

Re: News on Wine 1.1.21/MacOSX/XQuartz 2.3.3

2009-05-20 Thread Roderick Colenbrander
On Tue, May 19, 2009 at 6:41 PM, Mike Kronenberg mike.kronenb...@kronenberg.org wrote: On 18.05.2009, at 06:56, Dmitry Timoshkov wrote: James McKenzie jjmckenzi...@earthlink.net wrote: Austin: Contact Mike Kronenberg or Zach Drayer and see what they currently have. IMHO since they haven't

Re: [PATCH 7/8] urlmon: Added MIME filter handling in BindProtocol tests.

2009-05-20 Thread Jacek Caban
Hi Paul, Paul Vriens wrote: Jacek Caban wrote: --- dlls/urlmon/tests/protocol.c | 723 +++--- 1 files changed, 608 insertions(+), 115 deletions(-) Hi Jacek, This introduces

Re: News on Wine 1.1.21/MacOSX/XQuartz 2.3.3

2009-05-20 Thread Austin English
On Wed, May 20, 2009 at 4:46 AM, Roderick Colenbrander thunderbir...@gmail.com wrote: On Tue, May 19, 2009 at 6:41 PM, Mike Kronenberg mike.kronenb...@kronenberg.org wrote: On 18.05.2009, at 06:56, Dmitry Timoshkov wrote: James McKenzie jjmckenzi...@earthlink.net wrote: Austin: Contact

Re: [PATCH] Add missing classes for DOMDocument in msxml, and add test-cases back it up.

2009-05-20 Thread Austin English
On Tue, May 19, 2009 at 3:07 PM, Judy Devyak judyca...@ameritech.net wrote: You forgot the patch. -- -Austin

Re: Bugzilla upgrade - opening attachments in browser

2009-05-20 Thread Austin English
On Wed, May 20, 2009 at 6:05 AM, Igor Tarasov tarasov.i...@gmail.com wrote: attachment.cgi shows that it relies on allow_attachment_display parameter in bugzilla configuration. It has to be set to true. -- Igor Can a bugzilla admin please enable this? -- -Austin

Re: gdiplus: implement partially transparent solid fill brushes

2009-05-20 Thread Vincent Povirk
Don't commit this one. I forgot to pre-multiply the alpha. Vincent Povirk On Wed, May 20, 2009 at 11:33 AM, Vincent Povirk vinc...@codeweavers.com wrote:

Entry point not found for GetDiskInfoA (wininet_crosstest.exe)

2009-05-20 Thread Detlef Riekenberg
In dlls/wininet/tests/urlcache.c, GetDiskInfoA is called, but wininet.dll (native and wine) export this function only by ordinal. When I build the crosstest, my mingw [i586-mingw32msvc-gcc (GCC) 4.2.1-sjlj (mingw32-2)] creates a named Import for GetDiskInfoA with an ordinal hint of 65. Using

Re: Change BITS_IBackgroundCopyJob_SetPriority to a stub so the EvE-Online patcher works.

2009-05-20 Thread Ricardo Filipe
2009/5/20 Tim Wright t...@splhi.com The EvE-online updater blows up because it's trying to set the download priority in BITS (qmgr) and that isn't implemented. Simply stubbing it to return S_OK is sufficient to allow it to work. Third attempt at sending. For some reason, it isn't being

Re: Need help writing test

2009-05-20 Thread Igor Tarasov
Hi! I still need help on this case, any advice is appreciated. 2009/4/25 Igor Tarasov tarasov.i...@gmail.com: Hi! I've found few visual glitches in comctl32/toolbar, and now try to write this all down as conformance tests, but I have some problems. I see that there is bug, when I test it

Re: Bugzilla upgrade - opening attachments in browser

2009-05-20 Thread Jeremy Newman
OK, it is now enabled. -Newman Austin English wrote: On Wed, May 20, 2009 at 6:05 AM, Igor Tarasov tarasov.i...@gmail.com wrote: attachment.cgi shows that it relies on allow_attachment_display parameter in bugzilla configuration. It has to be set to true. -- Igor Can a bugzilla admin