Re: Implications for Wine from the Ubuntu Developer Summit

2009-06-02 Thread Daniel Devine
On Tuesday 02 June 2009 11:26:36 Scott Ritchie wrote: Hello everyone, I've just returned from the Ubuntu Developer Summit in Barcelona last week. A lot of interesting stuff that concerns Wine happened there, and a lot of applies to every distro. I'll give a brief summary in this email.

Re: gdiplus: add support for string alignment to GdipDrawString

2009-06-02 Thread Paul Vriens
Stephan Rose wrote: Adds support for aligning a string inside the given bounding rectangle for GdipDrawString. Both vertical and horizontal alignments implemented. Hi Stephan, No remarks about the real contents of the

Re: Fw: Need a temporary list moderator

2009-06-02 Thread Daniel Devine
On Tuesday 02 June 2009 00:42:13 Stefan Leichter wrote: Am Monday 01 June 2009 16:13:43 schrieb Luke Bratch: --- On Thu, 28/5/09, Luke Bratch l_bra...@yahoo.co.uk wrote: In a couple of weeks I'm going to be travelling around India for about a month, from 14th June - 17th July, so I'll

Re: Implications for Wine from the Ubuntu Developer Summit

2009-06-02 Thread Francois Gouget
On Tue, 2 Jun 2009, Ben Klein wrote: 2009/6/2 Scott Ritchie sc...@open-vote.org: [...] First, I talked with a Pulseaudio expert about what we can do to make things work better.  He said that if we want good compatibility we will need our ALSA stack to use the Pulseaudio safe subset:

Re: Implications for Wine from the Ubuntu Developer Summit

2009-06-02 Thread Roderick Colenbrander
On Tue, Jun 2, 2009 at 10:08 AM, Francois Gouget fgou...@free.fr wrote: On Tue, 2 Jun 2009, Ben Klein wrote: 2009/6/2 Scott Ritchie sc...@open-vote.org: [...] First, I talked with a Pulseaudio expert about what we can do to make things work better.  He said that if we want good

Re: gdi32: Stub for GdiEntry13()

2009-06-02 Thread Nikolay Sivov
Vincent Povirk wrote: I think you should add @ stdcall DdQueryDisplaySettingsUniqueness() line to gdi32.spec file, otherwise you will get message like this: err:module:find_forwarded_export function not found for forward 'gdi32.DdQueryDisplaySettingsUniqueness' used by LC:\\windows\\system32

Re: XI2 DirectInput mouse implementation RFC (Tarballed)

2009-06-02 Thread Fenixk19
I've tried XI2 Direct Input realisation with last xorg versions. It need some function name fixes to build. Here is a fixed file. As soon, as my wine will be build, i'll test the changes. /* * X11 DirectInput device support * * Copyright (C) 2009 Paul TBBle Hampson * * This library is free

Re: [2/5] libwine: Add a generic red-black tree.

2009-06-02 Thread Alexandre Julliard
Henri Verbeet hverb...@codeweavers.com writes: +void wine_rb_init(struct wine_rb_tree *tree, wine_rb_compare_func_t *compare) +{ +tree-compare = compare; +tree-root = NULL; +tree-stack.entries = malloc(16 * sizeof(*tree-stack.entries)); +if (!tree-stack.entries) +{ +

Re: [3/3] d3dx9: Test the return codes of the D3DXGetImageInfo functions

2009-06-02 Thread Alexandre Julliard
Tony Wasserka tony.wasse...@freenet.de writes: +/* D3DXGetImageInfoFromFile */ +todo_wine { +hr = D3DXGetImageInfoFromFileA(bmp1x1.bmp, info); +ok(hr == D3D_OK, D3DXGetImageInfoFromFile returned %#x, expected %#x\n, hr, D3D_OK); +} + +hr =

Re: [1/3] wininet: Check for bad allocation in HeapReAlloc

2009-06-02 Thread Alexandre Julliard
Jason Green jav...@gmail.com writes: @@ -4213,10 +4213,10 @@ static INT HTTP_GetResponseHeaders(LPWININETHTTPREQW lpwhr, BOOL clear) /* regenerate raw headers */ while (cchRawHeaders + buflen + strlenW(szCrLf) cchMaxRawHeaders) -{ cchMaxRawHeaders *= 2; -

Re: shlwapi: add test for CombineUrl

2009-06-02 Thread Alexandre Julliard
Aric Stewart a...@codeweavers.com writes: Associated with bug 18063 which is fixed. Apparently not: ../../../tools/runtest -q -P wine -M shlwapi.dll -T ../../.. -p shlwapi_test.exe.so url.c touch url.ok url.c:781: Test failed: Got length 22, expected 21 url.c:786: Test failed: Got length 22,

Re: jscript: Added NAN definition (1/10)

2009-06-02 Thread Alexandre Julliard
Piotr Caban piotr.ca...@gmail.com writes: diff --git a/dlls/jscript/jscript_main.c b/dlls/jscript/jscript_main.c index 37266e5..740bb06 100644 --- a/dlls/jscript/jscript_main.c +++ b/dlls/jscript/jscript_main.c @@ -38,6 +38,21 @@ static const CLSID CLSID_JScriptAuthor = static const CLSID

Re: (resend) [1/2] kernel32/tests: Add tests for CreateFile errors and opening volumes

2009-06-02 Thread Alexandre Julliard
Guy Albertelli galbe...@neo.rr.com writes: +hFile = CreateFileA( filename, GENERIC_READ | GENERIC_WRITE, +FILE_SHARE_READ | FILE_SHARE_WRITE, +NULL, OPEN_EXISTING, +p[i].options, NULL ); +if

Re: Website: Point the Development pages entirely to the Wiki.

2009-06-02 Thread Jeremy Newman
I'm holding this patch hostage until the Wiki is updated with the new theme. -Newman Jeremy White wrote: --- templates/en/home.template |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/templates/en/home.template b/templates/en/home.template index bad2f62..870a934

Re: shlwapi: add test for CombineUrl

2009-06-02 Thread Aric Stewart
Humm, how odd, it was working here on my mac. i will test further. -aric Alexandre Julliard wrote: Aric Stewart a...@codeweavers.com writes: Associated with bug 18063 which is fixed. Apparently not: ../../../tools/runtest -q -P wine -M shlwapi.dll -T ../../.. -p shlwapi_test.exe.so

Re: Website: Point the Development pages entirely to the Wiki.

2009-06-02 Thread Scott Ritchie
Jeremy Newman wrote: I'm holding this patch hostage until the Wiki is updated with the new theme. -Newman Jeremy White wrote: --- templates/en/home.template |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/templates/en/home.template

Re: Implications for Wine from the Ubuntu Developer Summit

2009-06-02 Thread Scott Ritchie
Roderick Colenbrander wrote: On Tue, Jun 2, 2009 at 10:08 AM, Francois Gouget fgou...@free.fr wrote: On Tue, 2 Jun 2009, Ben Klein wrote: 2009/6/2 Scott Ritchie sc...@open-vote.org: [...] First, I talked with a Pulseaudio expert about what we can do to make things work better. He said that

Re: [2/5] libwine: Add a generic red-black tree.

2009-06-02 Thread Henri Verbeet
Alexandre Julliard wrote: You can't hardcode malloc(), the allocator needs to be configurable, particularly for use from the memory management code. Also printing an ERR in that sort of code is not acceptable, errors need to be propagated correctly and handled by the user. I also still think

Re: Implications for Wine from the Ubuntu Developer Summit -- Pulseaudio

2009-06-02 Thread Susan Cragin
2009/6/2 Scott Ritchie sc...@open-vote.org: First, I talked with a Pulseaudio expert about what we can do to make things work better.  He said that if we want good compatibility we will need our ALSA stack to use the Pulseaudio safe subset:

Re: Website: Point the Development pages entirely to the Wiki.

2009-06-02 Thread Jeremy Newman
Scott Ritchie wrote: Jeremy Newman wrote: I'm holding this patch hostage until the Wiki is updated with the new theme. Aren't you the one who's updating the wiki to the theme? No. I currently do not have access to the Wiki. That is hosted by elsewhere. We are willing, and have the space/cpu

Re: Website: Point the Development pages entirely to the Wiki.

2009-06-02 Thread Dimi Paun
On Tue, 2009-06-02 at 09:10 -0500, Jeremy Newman wrote: Scott Ritchie wrote: Jeremy Newman wrote: I'm holding this patch hostage until the Wiki is updated with the new theme. Aren't you the one who's updating the wiki to the theme? No. I currently do not have access to the Wiki.

Re: gdiplus: add support for string alignment to GdipDrawString (try 2)

2009-06-02 Thread Vincent Povirk
Without doing any actual testing: The vertical alignment stuff looks right to me. Horizontal alignment is suspicious. If the world transform rotates the text 90 degrees, DrawTextW can't be getting enough information to center the text. Then again, I'm not sure if rotation works properly with

Re: gdiplus: add support for string alignment to GdipDrawString (try 2)

2009-06-02 Thread Stephan Rose
Without doing any actual testing: The vertical alignment stuff looks right to me. Horizontal alignment is suspicious. If the world transform rotates the text 90 degrees, DrawTextW can't be getting enough information to center the text. Then again, I'm not sure if rotation works properly with

Re: gdiplus: add support for string alignment to GdipDrawString (try 2)

2009-06-02 Thread Vincent Povirk
(reply didn't go to list as I expected, grr..) Naw, it should still work normally. I've done aligned rotated text under windows before with DrawTextW, you still pass the rect like you would if it wasn't rotated and set the alignment flags. The world transform should take care of getting

Re: gdiplus: add support for string alignment to GdipDrawString (try 2)

2009-06-02 Thread Stephan Rose
(reply didn't go to list as I expected, grr..) Naw, it should still work normally. I've done aligned rotated text under windows before with DrawTextW, you still pass the rect like you would if it wasn't rotated and set the alignment flags. The world transform should take care of getting it

Re: kernel32/tests: Add tests for GetLocaleInfo with SUBLANG_NEUTRAL

2009-06-02 Thread Paul Vriens
Detlef Riekenberg wrote: Add tests to show, that GetLocaleInfo assume SUBLANG_DEFAULT, when called with an LCID that provide SUBLANG_NEUTRAL Hi Detlef, This one introduces failures on NT4 and below and on some boxes

Re: gdiplus: add support for string alignment to GdipDrawString (try 2)

2009-06-02 Thread Michael Stefaniuc
. If you don't feel confident with git it is probably a good idea to backup your current branch git branch master-20090602 of this size, that isn't that big a deal. But on larger changes I could see that being a bit problematic. But maybe I'm just not used to it. =) bye michael

Re: gdiplus: add support for string alignment to GdipDrawString (try 2)

2009-06-02 Thread Vincent Povirk
Maybe, but builtin gdiplus has its own world transform and doesn't use the gdi32 one. That's what transform_and_round_points is for. True but you're still using the GDI32 DrawText to actually render the text. transform_and_round_points is only doing what it says, transforming the

Re: kernel32/tests: Add tests for GetLocaleInfo with SUBLANG_NEUTRAL

2009-06-02 Thread Detlef Riekenberg
This one introduces failures on NT4 and below and on some boxes with a non-English locale. Argh .. Could you have a look? Yes. Thanks for the fast report. -- By by ... Detlef

Re: gdiplus: add support for string alignment to GdipDrawString (try 2)

2009-06-02 Thread Vincent Povirk
* You can use git commit with the -a switch to modify the last commit. Whoops, I meant --amend. -a is something else.

Re: [ole32/tests] Fix a crash on NT4

2009-06-02 Thread Paul Vriens
Paul Vriens wrote: Changelog Fix a crash on NT4 Please don't use this one. I will soon sent a few others to replace this one. -- Cheers, Paul.

Re: [2/5] libwine: Add a generic red-black tree.

2009-06-02 Thread Alexandre Julliard
Henri Verbeet hverb...@codeweavers.com writes: Alexandre Julliard wrote: You can't hardcode malloc(), the allocator needs to be configurable, particularly for use from the memory management code. Also printing an ERR in that sort of code is not acceptable, errors need to be propagated

Re: [2/5] libwine: Add a generic red-black tree.

2009-06-02 Thread Henri Verbeet
Alexandre Julliard wrote: Yes, that looks fine. It would probably look nicer to merge the allocator and the compare function into a single structure, and just store a pointer to it like a vtbl; but that's a minor detail. It's easy enough to store a pointer to the allocator instead of making a

Re: [2/5] libwine: Add a generic red-black tree.

2009-06-02 Thread Alexandre Julliard
Henri Verbeet hverb...@codeweavers.com writes: Alexandre Julliard wrote: Yes, that looks fine. It would probably look nicer to merge the allocator and the compare function into a single structure, and just store a pointer to it like a vtbl; but that's a minor detail. It's easy enough to

Re: Alexandre Julliard : rpcrt4: Change the allocation of delegated stub methods so that we never need to free them .

2009-06-02 Thread Steven Edwards
On Tue, Jun 2, 2009 at 9:44 AM, Alexandre Julliard julli...@winehq.org wrote: +#define MAX_BLOCKS 64  /* 64k methods should be enough for anybody */ lol, best. comment. ever! -- Steven Edwards There is one thing stronger than all the armies in the world, and that is an idea whose time has

[Request for review] wrc: Add support for nameID with quotes

2009-06-02 Thread Tijnema
Hello all, I was just checking around some old bugs and found 786 still opened. I've written a patch for it, but I want to know if I'm anywhere close to get it in. I'm sorry if I'm only wasting your time. Matijn From 60244428d2ef1af082c99acce6e51da9ef247eec Mon Sep 17 00:00:00 2001 From: Matijn

HICON Patches - Request for reviews

2009-06-02 Thread Joel Holdsworth
Hi All, I've been working on alpha support in HICONs and HIMAGELISTs. This patch set includes my earlier test patch (plus modifications as per the comments), and fixes up DrawIcon, DrawIconEx and CURSORICON_CreateIconFromBMI. I've tested the test patch on 2k, XP, and Vista - but any other test

Re: (resend) [1/2] kernel32/tests: Add tests for CreateFile errors and opening volumes

2009-06-02 Thread Guy Albertelli
On Tue, 2009-06-02 at 13:17 +0200, Alexandre Julliard wrote: Guy Albertelli galbe...@neo.rr.com writes: +hFile = CreateFileA( filename, GENERIC_READ | GENERIC_WRITE, +FILE_SHARE_READ | FILE_SHARE_WRITE, +NULL, OPEN_EXISTING, +

Re: gdiplus: Add test cases for GdipDrawCurve

2009-06-02 Thread Vincent Povirk
+/* make a graphics object and pen object */ +status = GdipCreateFromHDC(hdc, graphics); +expect(Ok, status); +ok(hdc != NULL, Expected HDC to be initialized\n); + +status = GdipCreateFromHDC(hdc, graphics); +expect(Ok, status); +ok(graphics != NULL, Expected

Re: gdiplus: Add test cases for GdipDrawCurve

2009-06-02 Thread Andrew Eikum
Vincent Povirk wrote: +/* make a graphics object and pen object */ +status = GdipCreateFromHDC(hdc, graphics); +expect(Ok, status); +ok(hdc != NULL, Expected HDC to be initialized\n); + +status = GdipCreateFromHDC(hdc, graphics); +expect(Ok, status); +

The present state of Direct3D in WINE

2009-06-02 Thread MD.IMAM HOSSAIN
Dear, WINE Developers, Thanks to all of you for creating an environment where people can enjoy games. I very much pleased by the present state of WINE's Direct3D. In my short range of views on earlier versions of wine Grend Theft Auto San Andreas runs very slowly. But now it is very playable. On

Tests passing on one more platform!

2009-06-02 Thread Dan Kegel
I just had a look at http://test.winehq.org and it seems that as of a couple days ago, a Win2000 machine has started passing all the tests! That's three OSs now: Win2000, Win2003, and WinXP. (Not all systems with those OSs pass the tests, but still, having even one box per OS pass them is a nice

Re: The present state of Direct3D in WINE

2009-06-02 Thread Francois Gouget
On Wed, 3 Jun 2009, MD.IMAM HOSSAIN wrote: [...] From my experiment with recent version of WINE 1.1.22 : 3DMark 2001 has vertex shader problem (Under Game Lobby and Vertex Shader test). Hitman 2 Silent Assassin (No Human Body could be seen). Hitman 3 Contracts (No Human Body could be seen).