Re: [TRY 4] user32/tests: Add tests for STM_SETIMAGE and STM_SETICONmessage processing

2009-09-29 Thread Dmitry Timoshkov
Ilya Shpigor shpi...@etersoft.ru wrote: +flush_sequence(); +SendMessageW(hwnd, STM_SETIMAGE, (WPARAM)IMAGE_BITMAP, (LPARAM)hbm); +todo_wine ok_sequence(WmSetImageErrStaticSeq, STM_SETIMAGE on a static, FALSE); + +flush_sequence(); +SendMessageW(hwnd, STM_SETIMAGE,

programs: add extrac32 tool

2009-09-29 Thread Kirill K. Smirnov
Hi, +int PASCAL wWinMain ( HINSTANCE hInstance, HINSTANCE prev, LPWSTR cmdline, int show ) +{ extrac32 is a console application, isn't it? Why not wmain() instead? And get rid of rather complex ParseCmdLine(). +if (!SetupIterateCabinetW( pszCabFile, 0, (PSP_FILE_CALLBACK) ExtCabCallback,

Re: programs: add extrac32 tool

2009-09-29 Thread Andrey Turkin
extrac32 is not a console program; on Windows it doesn't create a console and doesn't write anything to stdout or stderr regardless of command line. I agree those FIXMEs you pointed out are not FIXMEs really - some of them are errors and some should be warnings. I'll fix them. Kirill K.

Re: RFC: Sharing a wineprefix

2009-09-29 Thread Francois Gouget
On Sat, 26 Sep 2009, Paul Chitescu wrote: [...] What you're proposing here is essentially an overlay file system. [...] You should also know that any such simplistic approach can fail in interesting and hardly to debug ways unless the user's prefix is wiped (which you already noted) which

Re: [PATCH 02/15] comctl32/monthcal: Make tests not depend from each other

2009-09-29 Thread Paul Vriens
On 09/27/2009 07:51 PM, Nikolay Sivov wrote: Changelog: - Inependent tests are always better and more scalable. Hi Nikolay, This one seems (there were more for monthcal.c) to have introduced 2 test failures on a

Modifying Subsystem in Winelib executables

2009-09-29 Thread Greg Geldorp
To fix one of the tests (shell32:shlexec) I'd like to copy the test executable and change the Subsystem type from IMAGE_SUBSYSTEM_WINDOWS_CUI (console app) to IMAGE_SUBSYSTEM_WINDOWS_GUI (GUI app) in the copy. Piece of cake for PE files, get the IMAGE_DOS_HEADER, follow it to the IMAGE_NT_HEADERS

Re: [PATCH 02/15] comctl32/monthcal: Make tests not depend from each other

2009-09-29 Thread Nikolay Sivov
Paul Vriens wrote: On 09/27/2009 07:51 PM, Nikolay Sivov wrote: Changelog: - Inependent tests are always better and more scalable. Hi Nikolay, This one seems (there were more for monthcal.c) to have introduced 2

Re: [PATCH 10/10] add tests for SHOpenRegStream2A and SHCreateMemStream

2009-09-29 Thread Alexandre Julliard
Peter Oberndorfer kumbay...@arcor.de writes: +#define test_streamsize(stream, size) \ +{ \ +STATSTG stat; \ +HRESULT result; \ +result = IStream_Stat(stream, stat, STATFLAG_NONAME); \ +ok(result == S_OK, IStream::Stat failed %08x\n, result); \ +ok(stat.cbSize.QuadPart

Re: Modifying Subsystem in Winelib executables

2009-09-29 Thread Alexandre Julliard
Greg Geldorp ggeld...@vmware.com writes: My limited understanding of the structure of Winelib executables makes doing the same for testing on Wine quite a bit harder. I assume there's still a IMAGE_NT_HEADERS structure in there somewhere and with some research I'll probably be able to locate

Re: Modifying Subsystem in Winelib executables

2009-09-29 Thread Paul Vriens
On 09/29/2009 12:11 PM, Greg Geldorp wrote: To fix one of the tests (shell32:shlexec) I'd like to copy the test executable and change the Subsystem type from IMAGE_SUBSYSTEM_WINDOWS_CUI (console app) to IMAGE_SUBSYSTEM_WINDOWS_GUI (GUI app) in the copy. Piece of cake for PE files, get the

Re: wininet(1/3): Only initialize SSL_CTX once

2009-09-29 Thread Hans Leidekker
Hi Juan, These patches collectively fix bug 18364, which was a crash in OpenSSL in a multithreaded app (utorrent.exe.) The bug reporter sees long delays between torrents starting up after applying these patches, which makes we wonder if the ssl lock effectively serializes secure https

help with dwBackBufferCount in backbuffer surfaces needed

2009-09-29 Thread Markus Stockhausen
Hi, currently I'm investigating bug 1660 and hopefully I found the reason for the misbehaviour. The only problem is, that I do not know what results I have to expect in windows. So it would be very helpful if someone can execute the attached testcase in a native environment so that I can fix the

Re: help with dwBackBufferCount in backbuffer surfaces needed

2009-09-29 Thread Paul Vriens
On 09/29/2009 01:27 PM, Markus Stockhausen wrote: Hi, currently I'm investigating bug 1660 and hopefully I found the reason for the misbehaviour. The only problem is, that I do not know what results I have to expect in windows. So it would be very helpful if someone can execute the attached

Re: help with dwBackBufferCount in backbuffer surfaces needed

2009-09-29 Thread Jeff Zaroyko
On Tue, Sep 29, 2009 at 9:27 PM, Markus Stockhausen markus.stockhau...@collogia.de wrote: Hi, currently I'm investigating bug 1660 and hopefully I found the reason for the misbehaviour. The only problem is, that I do not know what results I have to expect in windows. So it would be very

Re: help with dwBackBufferCount in backbuffer surfaces needed

2009-09-29 Thread Markus Stockhausen
Am Dienstag, den 29.09.2009, 13:42 +0200 schrieb Paul Vriens: Hi Markus, On fully up-to-date Windows XP Professional SP3: dsurface.c:1262: Test failed: backbuffer surface has dwBackBufferCount==0 Thanks to Jeff and Paul for your cross checks. The result makes me happy and I will send a

Re: help with dwBackBufferCount in backbuffer surfaces needed

2009-09-29 Thread Detlef Riekenberg
On Di, 2009-09-29 at 13:27 +0200, Markus Stockhausen wrote: The test will fail in Windows and Wine to get the results in both cases. The result will show like this: dsurface.c:1264: Test failed: backbuffer surface has dwBackBufferCount==2 This is 0 here with ATI Radeon R100 on Win98se, w2k

RE: Modifying Subsystem in Winelib executables

2009-09-29 Thread Greg Geldorp
From: Paul Vriens [mailto:paul.vriens.w...@gmail.com] Can't we just compile shell32 tests as a GUI app? I don't think that will work, but I'll look into it. Wine tests expect to have access to stdout. At the very least you won't see output when running the test manually on Windows. Not sure

Re: set caps.dwBackBufferCount=0 for backbuffer surface

2009-09-29 Thread Paul Vriens
On 09/29/2009 03:01 PM, Markus Stockhausen wrote: Hi Markus, Please stick to the coding style of the file, or at least the surrounding code (implementation and test). -- Cheers, Paul.

Re: server(4/5): Setting a process's affinity sets all of its threads' affinities too

2009-09-29 Thread Alexandre Julliard
Juan Lang juan.l...@gmail.com writes: +static void set_process_affinity( struct process *process, affinity_t affinity ) +{ +struct thread *thread; + +process-affinity = affinity; + +suspend_process( process ); +LIST_FOR_EACH_ENTRY( thread, process-thread_list, struct

Re: ole32/tests: guard ReleaseStgMedium with SUCCEEDED

2009-09-29 Thread Alexandre Julliard
joerg-cyril.hoe...@t-systems.com writes: @@ -1401,7 +1405,7 @@ static void test_getdatahere(void) hr = IDataObject_GetDataHere(get, fmt, med); ok(hr == S_OK, got %08x\n, hr); ok(med.tymed == TYMED_HGLOBAL, got %x\n, med.tymed); -ReleaseStgMedium(med); +

Re: wininet: Handle finding ftp files in subdirectories and using wildcards.

2009-09-29 Thread Detlef Riekenberg
On Sa, 2009-09-26 at 22:15 -0500, Mike Ruprecht wrote: +if (lpszSearchPath) +HeapFree(GetProcessHeap(), 0, lpszSearchPath); + Please remove the unneeded if(lpszSearchPath) before HeapFree. -- By by ... Detlef

Re: set caps.dwBackBufferCount=0 for backbuffer surface

2009-09-29 Thread Markus Stockhausen
Am Dienstag, den 29.09.2009, 15:10 +0200 schrieb Paul Vriens: On 09/29/2009 03:01 PM, Markus Stockhausen wrote: Hi Markus, Please stick to the coding style of the file, or at least the surrounding code

Re: set caps.dwBackBufferCount=0 for backbuffer surface

2009-09-29 Thread Paul Vriens
On 09/29/2009 03:33 PM, Markus Stockhausen wrote: Am Dienstag, den 29.09.2009, 15:10 +0200 schrieb Paul Vriens: On 09/29/2009 03:01 PM, Markus Stockhausen wrote: Hi Markus, Please stick to the coding style of the

Re: wininet(1/3): Only initialize SSL_CTX once

2009-09-29 Thread Juan Lang
Hi Hans, The bug reporter sees long delays between torrents starting up after applying these patches, which makes we wonder if the ssl lock effectively serializes secure https requests? There isn't a single SSL lock. There's an interlocked exchange for assigning SSL_CTX, which should only be

Re: ddraw: set dwBackBufferCount=0 in CreateSurface for backbuffer

2009-09-29 Thread Stefan Dösinger
Am 29.09.2009 um 15:09 schrieb Markus Stockhausen: Sorry for the incomplete topic of my first mail. patch.diff The patch looks ok to me

Re: comctl32: Send the parent notification after the Wine has set the tooltip position (bug #14336)

2009-09-29 Thread Ilya Shpigor
On Monday 28 September 2009 19:36:05 you wrote: Could you please add a test for that? Test for this patch has been sent: comctl32/tests: Add test for setting the tooltips position by parent -- Best regards, Ilya Shpigor.