Re: kernel32/tests: Pass test on error code returned by Windows 7

2009-10-04 Thread Paul Vriens
On 10/04/2009 09:10 AM, Dmitry Kislyuk wrote: +ok( GetLastError() == 0xdeadbeef || GetLastError() == 2 /* Win 7 */, +expected 0xdeadbeef or 2, got %d\n, GetLastError()); Don't use magic numbers, ERROR_FILE_NOT_FOUND would be better. -- Cheers, Paul.

Re: urlmon #11: Move setting protocol_sink to separated function.

2009-10-04 Thread Paul Vriens
On 10/04/2009 02:54 AM, Austin English wrote: 2009/10/3 ink Griffioeninkie...@hotmail.com: Forgot the patch. Apart from that, a little bit more context would be nice as well. -- Cheers, Paul.

Re: [ntdll] Move file attribute logic to new function DIR_get_attributes()

2009-10-04 Thread Juan Lang
Hi Dan, in patch 2/3, +TRACE(fd %d, name %s, attrib %x\n, fd, debugstr_a(unix_fname), *pattrib); +*pattrib = attributes; Any reason you're tracing *pattrib before you set it? + * If unix_fname is not NULL, DIR_is_hidden_file is called to do .dotfile check This is a change from the

Re: Image List tests for comctl32 v6

2009-10-04 Thread André Hentschel
Joel Holdsworth schrieb: It works for precreated manifest as a separate file (not compiled in), isn't it? If so you could do a trick that I spotted here http://www.winehq.org/pipermail/wine-patches/2009-September/078869.html for a first time - here another process is created after main test

Re: Image List tests for comctl32 v6

2009-10-04 Thread Nikolay Sivov
Joel Holdsworth wrote: It works for precreated manifest as a separate file (not compiled in), isn't it? If so you could do a trick that I spotted here http://www.winehq.org/pipermail/wine-patches/2009-September/078869.html for a first time - here another process is created after main test binary

Re: [2/2] ntdll: Implement FILE_ATTRIBUTE_HIDDEN and FILE_ATTRIBUTE_SYSTEM support (take 6)

2009-10-04 Thread Detlef Riekenberg
On Do, 2009-10-01 at 16:59 -0700, Dan Kegel wrote: +/*** + * wrap_getxattr + * Retrieve extended attribute of posix file into given buffer. + * Use fd if given, else use fname; caller only sets one or the other. +

Re: kernel32/tests: Pass test on error code returned by Windows 7

2009-10-04 Thread Paul Vriens
On 10/05/2009 05:09 AM, Dmitry Kislyuk wrote: --- On *Sun, 10/4/09, Paul Vriens /paul.vriens.w...@gmail.com/* wrote: From: Paul Vriens paul.vriens.w...@gmail.com Subject: Re: kernel32/tests: Pass test on error code returned by Windows 7 To: dim...@rocketmail.com Cc: