Re: urlmon/protocol tests

2009-10-07 Thread Paul Vriens
On 10/06/2009 09:32 PM, Jacek Caban wrote: Hi Paul, Paul Vriens wrote: Hi Jacek, I've been looking at the tests reports and we seem to have a few spurious errors: http://test.winehq.org/data/tests/urlmon:protocol.html The ones I mean are: protocol.c:2535: Testing http protocol (direct

Re: 1/3 winex11: move XRENDERINFO allocation in a separate function

2009-10-07 Thread Henri Verbeet
2009/10/6 Roderick Colenbrander thunderbir...@gmail.com: +static XRENDERINFO alloc_xrenderinfo() That's not a prototype. I'm not entirely sure how strict winex11.drv is about this, but it seems to me that if alloc_xrenderinfo() can return NULL, the calling code should be able to handle that as

Re: 2/3 winex11: add get_xrender_picture

2009-10-07 Thread Henri Verbeet
2009/10/6 Roderick Colenbrander thunderbir...@gmail.com: +if(!physDev-xrender) +alloc_xrenderinfo(physDev); This doesn't match what alloc_xrenderinfo() in your previous patch does. Note that the compiler would have returned an error here if alloc_xrenderinfo() had a proper prototype.

advapi32 : event logging/tracing

2009-10-07 Thread Paul Vriens
Hi, We currently have advapi32\eventlog.c that deals with event logging related functions. I somebody (i.e. me) would like to start working on the event tracing functions should these go to eventtrace.c or be combined with eventlog.c? Same question for the tests of course. -- Cheers,

Re: [2/2] ntdll: Implement FILE_ATTRIBUTE_HIDDEN and FILE_ATTRIBUTE_SYSTEM support (take 6)

2009-10-07 Thread Michael Stefaniuc
Dan Kegel wrote: On Sun, Oct 4, 2009 at 2:58 PM, Detlef Riekenberg wine@web.de wrote: Code, which is called very often, should produce as less overhead as possible. I suggest to use static inline. I have 'static' already. The compiler's probably better at deciding when to use inline

Re: urlmon/protocol tests

2009-10-07 Thread Jacek Caban
Hi Paul, Paul Vriens wrote: Hi Jacek, The second one never happened on any of my boxes. I'm also not able to reproduce the first failure. As said, it happens intermittently and, so it seems, only when running winetest? I do see two boxes (Jeff's Vista box and Aurimas's XP box) that

Re: 1/3 winex11: move XRENDERINFO allocation in a separate function [attempt 2]

2009-10-07 Thread Jacek Caban
Hi Roderick, Roderick Colenbrander wrote: Hi, This is an updated version which uses a proper function prototype for alloc_xrenderinfo. Further it checks whether the function succeeded in XRender_SelectFont. EnterCriticalSection(xrender_cs); -if(!physDev-xrender) { -

Re: urlmon/protocol tests

2009-10-07 Thread Paul Vriens
On 10/07/2009 11:37 AM, Jacek Caban wrote: I was able to reproduce the cookie failure by setting cookies for winehq.org. I've sent a patch. The other problem remains. Thanks for looking into that. -- Cheers, Paul.

Re: system.drv16: Merge CreateSystemTimer() into WIN16_CreateSystemTimer().

2009-10-07 Thread Alexandre Julliard
Francois Gouget fgou...@free.fr writes: I did not take the extra step of renaming WIN16_CreateSystemTimer() to CreateSystemTimer(), CreateSystemTimer16() or something else as the naming convention was not clear to me. Also, it's possible the CreateSystemTimer() prototype in

Re: kernel32/tests: Save last error before calling lstrcmpA() since it may reset GLE (try 2)

2009-10-07 Thread Alexandre Julliard
Ge van Geldorp ggeld...@vmware.com writes: Changelog: kernel32/tests: Save last error before calling lstrcmpA() since it may reset GLE It would be better to split the tests, first check length and last error, then check string contents. -- Alexandre Julliard julli...@winehq.org

Re: msadp32: Do not enumerate 8bit PCM formats, they cannot be converted.

2009-10-07 Thread Alexandre Julliard
joerg-cyril.hoe...@t-systems.com writes: I found it illogical to advertise unusable 8bit formats. But I did not cross check whether MS-Windows would do so. Please do, and then if they are really not needed remove them, don't leave them commented out with no explanation. Is it supported to

Re: [2/2] ntdll: Implement FILE_ATTRIBUTE_HIDDEN and FILE_ATTRIBUTE_SYSTEM support (take 6)

2009-10-07 Thread Steven Edwards
On Tue, Oct 6, 2009 at 10:20 PM, Dan Kegel d...@kegel.com wrote: Your code handle different parameter for the attr functions. Is it possible, that code, which is compiled for one ABI version can call the implementation of the other ABI version? Not sure I follow.   Can you rephrase that? I

Re: [2/2] ntdll: Implement FILE_ATTRIBUTE_HIDDEN and FILE_ATTRIBUTE_SYSTEM support (take 6)

2009-10-07 Thread Dan Kegel
On Wed, Oct 7, 2009 at 6:59 AM, Steven Edwards winehac...@gmail.com wrote: I don't know if this is what Detlef means but I think the attr functions and structures differ slightly on other Unixen. At least I am pretty sure they differ enough on OS X from Linux or Solaris to cause problems.

Re: [2/2] ntdll: Implement FILE_ATTRIBUTE_HIDDEN and FILE_ATTRIBUTE_SYSTEM support (take 6)

2009-10-07 Thread Ken Thomases
Hi Dan, On Oct 7, 2009, at 9:24 AM, Dan Kegel wrote: Yeah, the patch handles OS X [...] Tangentially related to this xattr issue, are you aware of BSD's chflags system call and the st_flags field of struct stat? On Mac OS X (and any other BSD which defines UF_HIDDEN),

Multiple wineservers?

2009-10-07 Thread Nicholas LaRoche
Is it possible to run more than 1 version of wineserver concurrently? -Nick

Re: [2/2] ntdll: Implement FILE_ATTRIBUTE_HIDDEN and FILE_ATTRIBUTE_SYSTEM support (take 6)

2009-10-07 Thread Dan Kegel
On Wed, Oct 7, 2009 at 9:21 AM, Ken Thomases k...@codeweavers.com wrote: Tangentially related to this xattr issue, are you aware of BSD's chflags system call and the st_flags field of struct stat?  On Mac OS X (and any other BSD which defines UF_HIDDEN), FILE_ATTRIBUTE_HIDDEN is better

Re: Multiple wineservers?

2009-10-07 Thread Ken Thomases
On Oct 7, 2009, at 11:43 AM, Nicholas LaRoche wrote: Is it possible to run more than 1 version of wineserver concurrently? If each is referencing a different WINEPREFIX, yes. Cheers, Ken

Re: [2/2] ntdll: Implement FILE_ATTRIBUTE_HIDDEN and FILE_ATTRIBUTE_SYSTEM support (take 6)

2009-10-07 Thread Ken Thomases
On Oct 7, 2009, at 11:46 AM, Dan Kegel wrote: On Wed, Oct 7, 2009 at 9:21 AM, Ken Thomases k...@codeweavers.com wrote: It would also be good to check for UF_IMMUTABLE|SF_IMMUTABLE to determine FILE_ATTRIBUTE_READONLY, and set UF_IMMUTABLE when setting FILE_ATTRIBUTE_READONLY, although

Re: comctl32: initial theming tests (try 4)

2009-10-07 Thread Nikolay Sivov
André Hentschel wrote: --- dlls/comctl32/tests/Makefile.in |1 + dlls/comctl32/tests/theming.c | 235 +++ 2 files changed, 236 insertions(+), 0 deletions(-) create mode 100644 dlls/comctl32/tests/theming.c Hi, Andre. +#ifdef __i386__ +#define

Re: comctl32: initial theming tests (try 4)

2009-10-07 Thread André Hentschel
Nikolay Sivov schrieb: André Hentschel wrote: --- dlls/comctl32/tests/Makefile.in |1 + dlls/comctl32/tests/theming.c | 235 +++ 2 files changed, 236 insertions(+), 0 deletions(-) create mode 100644 dlls/comctl32/tests/theming.c Hi, Andre.

Re: comctl32: initial theming tests (try 4)

2009-10-07 Thread Nikolay Sivov
André Hentschel wrote: Nikolay Sivov schrieb: André Hentschel wrote: --- dlls/comctl32/tests/Makefile.in |1 + dlls/comctl32/tests/theming.c | 235 +++ 2 files changed, 236 insertions(+), 0 deletions(-) create mode 100644

Re: comctl32: initial theming tests (try 4)

2009-10-07 Thread André Hentschel
Nikolay Sivov schrieb: André Hentschel wrote: Nikolay Sivov schrieb: André Hentschel wrote: --- dlls/comctl32/tests/Makefile.in |1 + dlls/comctl32/tests/theming.c | 235 +++ 2 files changed, 236 insertions(+), 0 deletions(-) create

Re: comctl32: initial theming tests (try 4)

2009-10-07 Thread Nikolay Sivov
André Hentschel wrote: Nikolay Sivov schrieb: We already have this stuff defined in v6util.h. No reason to duplicate I suppose. My reason is, that the compiler warns that i am not using the functions inside v6util.h when i use it. Sorry, don't follow you. Does

Re: comctl32: initial theming tests (try 4)

2009-10-07 Thread Owen Rudge
Ah, I see, no, it won't link I think without static. Some time ago I thought about adding v6util.c back and move code here, I'm not very familiar with makefile generation but I think we could place this new v6util.c into C_SRCS section of test makefile (if it's allowed of course, but I think

Re: Fixing bug #2181, standard EDIT class extra value

2009-10-07 Thread Julius Schwartzenberg
Dmitry Timoshkov wrote: Julius Schwartzenberg julius.schwartzenb...@gmail.com wrote: This obviously won't work for 64-bit. I'd suggest to make extra 2 * sizeof(void *). and add a comment about compatibility. ok(cls.cbWndExtra sizeof(void *), blah ...\n) doesn't require any intermediate

Re: Multiple wineservers?

2009-10-07 Thread David Gerard
2009/10/7 Nicholas LaRoche nlaro...@vt.edu: Is it possible to run more than 1 version of wineserver concurrently? You can run more than one instance from a given version of Wine - set the WINEPREFIX accordingly. (CrossOver has good support for this, calling it bottles.).

Re: Multiple wineservers?

2009-10-07 Thread Austin English
On Wed, Oct 7, 2009 at 2:20 PM, David Gerard dger...@gmail.com wrote: I suppose you could run different versions of Wine if you needed to by a similar process, e.g.    WINEPREFIX=/home/user/.wine101 /usr/bin/wine app1.exe    WINEPREFIX=/home/user/.wine1130 ~/wine/wine app2.exe Yes, you can.

Re: Fixing bug #2181, standard EDIT class extra value

2009-10-07 Thread Dmitry Timoshkov
Julius Schwartzenberg julius.schwartzenb...@gmail.com wrote: static const WCHAR editW[] = {'E','d','i','t',0}; +#ifdef _WIN64 +#define EDIT_EXTRA_VALUE sizeof(EDITSTATE *) +#else +#define EDIT_EXTRA_VALUE 6 /* This has to be 6 for 32-bit, otherwise Civilization II crashes, bug #2181 */

Re: Fixing bug #2181, standard EDIT class extra value

2009-10-07 Thread Dmitry Timoshkov
Dmitry Timoshkov dmi...@codeweavers.com wrote: +#ifdef _WIN64 +ok(cls.cbWndExtra == 8, expected 6, got %d\n, cls.cbWndExtra); +#else +ok(cls.cbWndExtra == 6, expected 6, got %d\n, cls.cbWndExtra); +#endif +} +} You should check the return value of GetClassInfoEx() and put

New winetricks 20091007: new verbs vcexpress2005sp1, nodialogcrash, sandbox, atmlib, psdkwin7

2009-10-07 Thread Dan Kegel
Another month, another winetricks. A half-dozen new verbs and lots of updates, too. And oddly, winetricks is starting to become useful on Windows. (What can I say? I develop on Windows, too, and I missed winetricks there.) Updates since 20090913: * added mozillabuild, vcexpress2005sp1 *