Re: [PATCH 4/5] comctl32/tests: Add further tests for IImageList

2009-11-19 Thread Owen Rudge
Owen, also please use more reasonable names for particular tests - dotest means nothing. I agree that the test names are not particularly descriptive. However, I chose those names to indicate that the tests match the existing DoTest functions. Perhaps both sets of functions should ideally

Fedora users, please test mci patch about time-out/hanging machine

2009-11-19 Thread Joerg-Cyril.Hoehle
Hi, Testhq.org results from 17th of November about winmm:mci were striking: All machines producing a timeout had f11 in their name. (Another day, some f11 machines passed the tests). http://test.winehq.org/data/4990ca0ea342bd115a9a46047b3b2de599cb916e/index_Wine.html Please test whether the

Re: Fedora users, please test mci patch about time-out/hanging machine

2009-11-19 Thread Michael Stefaniuc
Hello! joerg-cyril.hoe...@t-systems.com wrote: Testhq.org results from 17th of November about winmm:mci were striking: All machines producing a timeout had f11 in their name. (Another day, some f11 machines passed the tests).

Re: Test for Bug 4543: Testers needed

2009-11-19 Thread Dmitry Timoshkov
Charles Davis cda...@mymail.mines.edu wrote: Why don't you use the same way of comparing EMFs as other tests do, compare_emf_bits()/dump_emf_bits()/dump_emf_records()? Because I didn't look. I guess I'll rewrite the tests to use these functions. OK, here's a version that uses the same method

Re: [PATCH 4/5] comctl32/tests: Add further tests for IImageList

2009-11-19 Thread Nikolay Sivov
Owen Rudge wrote: Owen, also please use more reasonable names for particular tests - dotest means nothing. I agree that the test names are not particularly descriptive. However, I chose those names to indicate that the tests match the existing DoTest functions. Perhaps both sets of functions

Re: shell32/tests: Remove atime tests in ITEMIDLIST_format test.

2009-11-19 Thread Paul Vriens
On 11/19/2009 01:23 PM, Austin Lund wrote: -ok (pFileStructA-uFileDate == pFileStructW-uDate2 -pFileStructA-uFileTime == pFileStructW-uTime2, -Last write time should match last access time!\n); - Hi Austin, Is there no other way to get

Re: Wine Icons - final round

2009-11-19 Thread André Hentschel
Joel Holdsworth schrieb: Please let me know what you think - or if you have any comments. After the last two rounds, I'm hoping that we should basically be at a stage where most people are happy. I love it! The only thing disturbing is that wineglass of notepad is on the left, where all

Re: Problem to download git

2009-11-19 Thread James Mckenzie
On Wed, Nov 18, 2009 at 11:22 PM, Dan Kegel d...@kegel.com wrote: I'm having network errors with git tonight, too.  e.g. $ git pull fatal: The remote end hung up unexpectedly Hangs up about half the time for me too tonight. +1. The second pull worked. James McKenzie

Re: Problem to download git

2009-11-19 Thread James Mckenzie
error: Unable to get pack file http://source.winehq.org/git/wine.git/objects/pack/pack- 7c2ab792c6e1c8f603b784f9dcb81f56f03bbf75.pack Is this on a Mac, by any chance? I had similar problems using MacPorts's git with a proxy server. I also had Linux running in a VM on that machine, and

Difficulties with Regression Testing

2009-11-19 Thread James Mckenzie
All: I've been running regression tests to find a commit between wine-1.1.10 and wine-1.1.11 that breaks the EM_FORMATRANGE patch or to discover what I need to do to fix the patch to make it work with wine-1.1.11. I've been following the instructions on the Regression Testing Wiki page. I am

Re: Wine Icons - final round

2009-11-19 Thread Reece Dunn
2009/11/18 Joel Holdsworth j...@airwebreathe.org.uk: Hi All, Please let me know what you think - or if you have any comments. After the last two rounds, I'm hoping that we should basically be at a stage where most people are happy. Very nice! My only comment is that the monitor for

New valgrind results, this time with overrun checks and lots of new errors.

2009-11-19 Thread Dan Kegel
http://kegel.com/wine/valgrind/logs/2009-11-18-21.51/ is the first full run with the heap tail check enabled. Here are the first few new problems it found. Somehow, it found a bunch of invalid reads in http://kegel.com/wine/valgrind/logs/2009-11-18-21.51/vg-advapi32_crypt.txt all in a function

Re: Difficulties with Regression Testing

2009-11-19 Thread Austin English
On Thu, Nov 19, 2009 at 8:51 AM, James Mckenzie jjmckenzi...@earthlink.net wrote: All: I've been running regression tests to find a commit between wine-1.1.10 and wine-1.1.11 that breaks the EM_FORMATRANGE patch or to discover what I need to do to fix the patch to make it work with

Re: winspool.drv: Acroread 9.2 relies on the buffer sizes returned by GetPrinterA and GetPrinterDriverA being large enough to hold their respective unicode versions' data.

2009-11-19 Thread Alexandre Julliard
Huw Davies h...@codeweavers.com writes: --- dlls/winspool.drv/info.c |8 +--- 1 files changed, 5 insertions(+), 3 deletions(-) This doesn't work here: ../../../tools/runtest -q -P wine -M winspool.drv -T ../../.. -p winspool.drv_test.exe.so info.c touch info.ok info.c:2269: Test

Re: shell32: deal better with spaces in ASSOCSTR_COMMAND values

2009-11-19 Thread Alexandre Julliard
Damjan Jovanovic damjan@gmail.com writes: @@ -324,7 +324,14 @@ static HRESULT ASSOC_GetExecutable(IQueryAssociationsImpl *This, else { pszStart = pszCommand; -pszEnd = strchrW(pszStart, ' '); +for (pszEnd = pszStart; (pszEnd = strchrW(pszEnd, ' ')); pszEnd++) +

Re: New valgrind results, this time with overrun checks and lots of new errors.

2009-11-19 Thread Nikolay Sivov
Dan Kegel wrote: http://kegel.com/wine/valgrind/logs/2009-11-18-21.51/ is the first full run with the heap tail check enabled. So you use some private patches for that, why aren't they merged? Here are the first few new problems it found. Somehow, it found a bunch of invalid reads in

Re: Difficulties with Regression Testing

2009-11-19 Thread James Mckenzie
From: Austin English austinengl...@gmail.com Sent: Nov 19, 2009 10:31 AM To: James Mckenzie jjmckenzi...@earthlink.net Cc: Wine Development Mailing List wine-devel@winehq.org Subject: Re: Difficulties with Regression Testing On Thu, Nov 19, 2009 at 8:51 AM, James Mckenzie

Re: Difficulties with Regression Testing

2009-11-19 Thread Austin English
On Thu, Nov 19, 2009 at 9:41 AM, James Mckenzie jjmckenzi...@earthlink.net wrote: From: Austin English austinengl...@gmail.com Sent: Nov 19, 2009 10:31 AM To: James Mckenzie jjmckenzi...@earthlink.net Cc: Wine Development Mailing List wine-devel@winehq.org Subject: Re: Difficulties with Regression

Re: Difficulties with Regression Testing

2009-11-19 Thread James Mckenzie
Austin English wrote: On Thu, Nov 19, 2009 at 9:41 AM, James Mckenzie jjmckenzi...@earthlink.net wrote: From: Austin English austinengl...@gmail.com Sent: Nov 19, 2009 10:31 AM To: James Mckenzie jjmckenzi...@earthlink.net Cc: Wine Development Mailing List wine-devel@winehq.org Subject: Re:

GdiplusAbort type needs to be translated from C++ to C

2009-11-19 Thread Vincent Povirk
The Windows SDK defines the following type: struct __declspec(novtable) GdiplusAbort { virtual HRESULT __stdcall Abort(void) = 0; }; I think that the following is a workable translation: diff --git a/include/gdiplustypes.h b/include/gdiplustypes.h index 4f97432..444123f 100644 ---

UMR in CertIsRDNAttrsInCertificateName()

2009-11-19 Thread Dan Kegel
http://kegel.com/wine/valgrind/logs/2009-11-18-21.51/vg-crypt32_cert.txt shows a new UMR (purify-speak for uninitialized memory read) error Conditional jump or move depends on uninitialised value(s) at strncmp (mc_replace_strmem.c:386) by find_matching_rdn_attr (cert.c:1877) by

UMR in CRYPT_RemoveStringFromMultiString()

2009-11-19 Thread Dan Kegel
Hi Juan, http://kegel.com/wine/valgrind/logs/2009-11-18-21.51/vg-crypt32_oid.txt says Invalid read of size 1 at memmove (mc_replace_strmem.c:613) by CRYPT_RemoveStringFromMultiString (oid.c:885) by CryptUnregisterDefaultOIDFunction (oid.c:1010) by

Re: GdiplusAbort type needs to be translated from C++ to C

2009-11-19 Thread Frank Richter
On 19.11.2009 17:23, Vincent Povirk wrote: The Windows SDK defines the following type: struct __declspec(novtable) GdiplusAbort { virtual HRESULT __stdcall Abort(void) = 0; }; I don't think I can provide a proper C++ definition because the abi depends on the compiler. Depends;

msi regression in today's git

2009-11-19 Thread Susan Cragin
Installed Dragon NaturallySpeaking using clean prefix and today's git. Instal went without errors but when I tried to open the program it said that the install hadn't completed correctly. Specifically, iexplore.exe was missing. I looked at the terminal output for the run but there wasn't

Write-past-end in FileMonikerImpl_DecomposePath()

2009-11-19 Thread Dan Kegel
http://kegel.com/wine/valgrind/logs/2009-11-18-21.51/diff-hlink_hlink.txt http://kegel.com/wine/valgrind/logs/2009-11-18-21.51/vg-hlink_hlink.txt shows a new error thanks to the heap tail check. Looks like a level-of-indirection-during-allocation error, 1039 strgtable =

Re: GdiplusAbort type needs to be translated from C++ to C

2009-11-19 Thread Vincent Povirk
On Thu, Nov 19, 2009 at 11:05 AM, Frank Richter frank.rich...@gmail.com wrote: Does this look correct? You forgot __stdcall on 'Abort' member of gpabort_vtable. WINAPI should be equivalent, but you're probably right. I should match the windows headers/documentation. -- Vincent Povirk

Re: New valgrind results, this time with overrun checks and lots of new errors.

2009-11-19 Thread Dan Kegel
On Thu, Nov 19, 2009 at 7:37 AM, Nikolay Sivov bungleh...@gmail.com wrote: http://kegel.com/wine/valgrind/logs/2009-11-18-21.51/ is the first full run with the heap tail check enabled. So you use some private patches for that, why aren't they merged? 'Cause I just wrote it an hour before that

Re: Problem to download git

2009-11-19 Thread paulo lesgaz
I still have the same problem today And I use Linux. Not a mac. I have a very slow connection here (128kb/s) (French polynesia :D). Could it be the culprit? D. Adam da...@analyst:~$ export http_proxy=”http://proxy.upf.pf:8080″ da...@analyst:~$ git clone http://source.winehq.org/git/wine.git

Re: Problem to download git

2009-11-19 Thread Paul Vriens
On 11/19/2009 07:43 PM, paulo lesgaz wrote: I still have the same problem today And I use Linux. Not a mac. I have a very slow connection here (128kb/s) (French polynesia :D). Could it be the culprit? D. Adam I had issues a few hours ago and I have 20Mb/s. I don't use a proxy and on second

Re: Fedora users, please test mci patch about time-out/hanging machine

2009-11-19 Thread Hin-Tak Leung
pulseaudio occasionally gets into a confusion by itself. I found I need to do pulseaudio --cleanup-shm from time to time. --- On Thu, 19/11/09, joerg-cyril.hoe...@t-systems.com joerg-cyril.hoe...@t-systems.com wrote: Hi, Testhq.org results from 17th of November about winmm:mci were

Re: FAT32 support (was: [RFC] Handle process token groups in server/file.c::sd_to_mode)

2009-11-19 Thread Ben Peddell
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Paul Chitescu wrote: How should server/file.c sd_to_mode() deal with filesystems that don't support full POSIX ownership and access permissions? It is quite popular to mount FAT filesystems - either from a removable media or a partition shared

Re: winspool.drv: Acroread 9.2 relies on the buffer sizes returned by GetPrinterA and GetPrinterDriverA being large enough to hold their respective unicode versions' data.

2009-11-19 Thread Detlef Riekenberg
On Do, 2009-11-19 at 13:18 +, Huw Davies wrote: --- dlls/winspool.drv/info.c |8 +--- 1 files changed, 5 insertions(+), 3 deletions(-) ANSI functions in winspool.drv have this behavior since w2k. We have already a test for EnumPrintersA/W [required by Outlook2003) I prefer to

Re: Write-past-end in FileMonikerImpl_DecomposePath()

2009-11-19 Thread Dan Kegel
Filed as http://bugs.winehq.org/show_bug.cgi?id=20760 On Thu, Nov 19, 2009 at 9:11 AM, Dan Kegel d...@kegel.com wrote: http://kegel.com/wine/valgrind/logs/2009-11-18-21.51/diff-hlink_hlink.txt http://kegel.com/wine/valgrind/logs/2009-11-18-21.51/vg-hlink_hlink.txt shows a new error thanks to

Re: shell32/tests: Remove atime tests in ITEMIDLIST_format test.

2009-11-19 Thread Austin Lund
2009/11/19 Paul Vriens paul.vriens.w...@gmail.com: On 11/19/2009 01:23 PM, Austin Lund wrote: -                ok (pFileStructA-uFileDate == pFileStructW-uDate2 -                    pFileStructA-uFileTime == pFileStructW-uTime2, -                    Last write time should match last access

New version of my test for bug 4543

2009-11-19 Thread Charles Davis
Hi, This is a new version of my test for bug 4543. This time, I followed Dmitry's suggestion of using the existing functions for comparing the contents of EMFs. I can't build tests for Windows both due to bug 20763 and due to the fact that I don't have any Windows boxes, so once again I need

Re: New version of my test for bug 4543

2009-11-19 Thread Ricardo Filipe
2009/11/19 Charles Davis cda...@mymail.mines.edu: Hi, This is a new version of my test for bug 4543. This time, I followed Dmitry's suggestion of using the existing functions for comparing the contents of EMFs. I can't build tests for Windows both due to bug 20763 and due to the fact that I

Re: msi regression in today's git -- NEVER MIND

2009-11-19 Thread Susan Cragin
I had a bad git. Re-did everything and now it works. Sorry about that. Susan -Original Message- Installed Dragon NaturallySpeaking using clean prefix and today's git. Instal went without errors but when I tried to open the program it said that the install hadn't completed correctly.

Re: New version of my test for bug 4543

2009-11-19 Thread Charles Davis
Ricardo Filipe wrote: 2009/11/19 Charles Davis cda...@mymail.mines.edu: Hi, This is a new version of my test for bug 4543. This time, I followed Dmitry's suggestion of using the existing functions for comparing the contents of EMFs. I can't build tests for Windows both due to bug 20763 and

Re: New version of my test for bug 4543

2009-11-19 Thread Charles Davis
Paul Vriens wrote: On 11/19/2009 11:17 PM, Charles Davis wrote: Hi, This is a new version of my test for bug 4543. This time, I followed Dmitry's suggestion of using the existing functions for comparing the contents of EMFs. I can't build tests for Windows both due to bug 20763 and due to

Re: New valgrind results, this time with overrun checks and lots of new errors.

2009-11-19 Thread Nikolay Sivov
Dan Kegel wrote: On Thu, Nov 19, 2009 at 7:37 AM, Nikolay Sivov bungleh...@gmail.com wrote: http://kegel.com/wine/valgrind/logs/2009-11-18-21.51/ is the first full run with the heap tail check enabled. So you use some private patches for that, why aren't they merged? 'Cause I

Re: New valgrind results, this time with overrun checks and lots of new errors.

2009-11-19 Thread Dan Kegel
On Thu, Nov 19, 2009 at 8:38 PM, Nikolay Sivov bungleh...@gmail.com wrote: I'm not sure about the user (i.e. developer) interface for turning the heap check on.  Should it be automatic when one does warn+heap? If I got it right it makes sense to enable this only running under valgrind

Re: d3dx9_36: add a stub for D3DXCreateTextureFromFileInMemory

2009-11-19 Thread Jeff Zaroyko
On Fri, Nov 20, 2009 at 4:56 AM, Austin English austinengl...@gmail.com wrote: Should fix http://bugs.winehq.org/show_bug.cgi?id=13605 -- -Austin Does it really fix it, the function still remains unimplemented, crash or no crash... a bug will probably just be filed after it to say the

Re: New valgrind results, this time with overrun checks and lots of new errors.

2009-11-19 Thread Austin English
On Thu, Nov 19, 2009 at 11:16 PM, Dan Kegel d...@kegel.com wrote: On Thu, Nov 19, 2009 at 8:38 PM, Nikolay Sivov bungleh...@gmail.com wrote: I'm not sure about the user (i.e. developer) interface for turning the heap check on.  Should it be automatic when one does warn+heap? If I got it

Re: d3dx9_36: add a stub for D3DXCreateTextureFromFileInMemory

2009-11-19 Thread Austin English
On Fri, Nov 20, 2009 at 12:05 AM, Jeff Zaroyko jeffzaro...@gmail.com wrote: On Fri, Nov 20, 2009 at 4:56 AM, Austin English austinengl...@gmail.com wrote: Should fix http://bugs.winehq.org/show_bug.cgi?id=13605 -- -Austin Does it really fix it, the function still remains unimplemented,

Re: d3dx9_36: add a stub for D3DXCreateTextureFromFileInMemory

2009-11-19 Thread Jeff Zaroyko
On Fri, Nov 20, 2009 at 6:18 PM, Austin English austinengl...@gmail.com wrote: On Fri, Nov 20, 2009 at 12:05 AM, Jeff Zaroyko jeffzaro...@gmail.com wrote: On Fri, Nov 20, 2009 at 4:56 AM, Austin English austinengl...@gmail.com wrote: Should fix http://bugs.winehq.org/show_bug.cgi?id=13605

Re: d3dx9_36: add a stub for D3DXCreateTextureFromFileInMemory

2009-11-19 Thread Austin English
On Fri, Nov 20, 2009 at 1:38 AM, Jeff Zaroyko jeffzaro...@gmail.com wrote: On Fri, Nov 20, 2009 at 6:18 PM, Austin English austinengl...@gmail.com wrote: On Fri, Nov 20, 2009 at 12:05 AM, Jeff Zaroyko jeffzaro...@gmail.com wrote: On Fri, Nov 20, 2009 at 4:56 AM, Austin English