Re: The (Casual) Game Support Report in Wine (Jan 2009)

2010-01-06 Thread Christian Costa
Reece Dunn a écrit : 1/ the games themselves tend to work very well (and have done for a long while now thanks to the great work CodeWeavers did in getting DirectDraw and Direct3D working); While you are at in, you can also thanks people that worked in this area in their spare time. A+

Re: The (Casual) Game Support Report in Wine (Jan 2009)

2010-01-06 Thread Reece Dunn
2010/1/6 Christian Costa titan.co...@wanadoo.fr: Reece Dunn a écrit :  1/  the games themselves tend to work very well (and have done for a long while now thanks to the great work CodeWeavers did in getting DirectDraw and Direct3D working); While you are at in, you can also thanks people

Re: ole32/tests: remove a test, as it fails or hangs on Vista+

2010-01-06 Thread Paul Vriens
On 01/05/2010 08:05 PM, André Hentschel wrote: vista and 2k8: fails w7:timeout --- dlls/ole32/tests/clipboard.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/dlls/ole32/tests/clipboard.c b/dlls/ole32/tests/clipboard.c index 626d244..4a9e234 100644 ---

Re: The (Casual) Game Support Report in Wine (Jan 2009)

2010-01-06 Thread Christian Costa
Reece Dunn a écrit : 2010/1/6 Christian Costa titan.co...@wanadoo.fr: Reece Dunn a écrit : 1/ the games themselves tend to work very well (and have done for a long while now thanks to the great work CodeWeavers did in getting DirectDraw and Direct3D working); While you are at

Re: [PATCH] wined3d: Do not try to use not available texture stages in set_tex_op_nvr

2010-01-06 Thread Henri Verbeet
2010/1/5 Christian Costa titan.co...@wanadoo.fr: Here it is. The fixme message is : fixme:d3d:set_tex_op_nvrc GL_INVALID_ENUM (0x500) from set_tex_op_nvrc() @ nvidia_texture_shader.c / 460 Looks like the context creation code invalidates those states simply because they exist. Does the

Re: gdi32: Use the LOGFONT charset field on OEM font creation

2010-01-06 Thread Dmitry Timoshkov
Ilya Shpigor shpi...@etersoft.ru wrote: If the Terminal font will be changed in test to Tahoma this still be failed. Are you sure what the current behavior of the WineEngCreateFontInstance is correct? When the user create logical font with OEM charset the GetTextCharset function will be

Re: Wine FIXME Report 2009 Aug - Dec

2010-01-06 Thread Damjan Jovanovic
On Wed, Jan 6, 2010 at 2:45 AM, Vincent Povirk madewokherd+8...@gmail.com wrote: It might be interesting to select for err:module:import_dll lines, which are (sometimes) missing dll's.   77   |   99  | ole:CoGetClassObject no class object {9a5ea990-3034-4d6f-9128-01f3c61022bc} could be

Re: [4/5] WineD3D: Implement manual fencing with GL_APPLE_flush_buffer_range

2010-01-06 Thread Henri Verbeet
2010/1/5 Stefan Dösinger stefandoesin...@gmx.at: After the discussion on IRC I wasn't quite sure what you intended with wined3d_event_query_wait(), but maybe it was something like this: More something along the lines of the attached patch, actually. There are of course some intermediate steps.

Re: [PATCH] kernel32: GetPrivateProfileSectionNamesA error checking (Coverity)

2010-01-06 Thread Paul Vriens
On 01/06/2010 01:26 PM, Marcus Meissner wrote: +if (!RtlCreateUnicodeStringFromAsciiz(filenameW, filename)) { +SetLastError(ERROR_OUTOFMEMORY); +return 0; +} Aren't you leaking bufferW here? -- Cheers, Paul.

Re: [PATCH] kernel32: GetPrivateProfileSectionNamesA error checking (Coverity)

2010-01-06 Thread Alexandre Julliard
Marcus Meissner mar...@jet.franken.de writes: buffer and size need to be either 0 at the same time or not, otherwise this breaks up. Windows is inconsistent (either crashes or returns invalids), so we can just add checking. If Windows crashes we don't need extra checks. Just tell Coverity

Re: [PATCH] kernel32: GetPrivateProfileSectionNamesA error checking (Coverity)

2010-01-06 Thread Marcus Meissner
On Wed, Jan 06, 2010 at 01:34:28PM +0100, Alexandre Julliard wrote: Marcus Meissner mar...@jet.franken.de writes: buffer and size need to be either 0 at the same time or not, otherwise this breaks up. Windows is inconsistent (either crashes or returns invalids), so we can just add

Re: [PATCH] kernel32: GetPrivateProfileSectionNamesA error checking (Coverity)

2010-01-06 Thread Paul Vriens
On 01/06/2010 01:59 PM, Marcus Meissner wrote: diff --git a/dlls/kernel32/tests/profile.c b/dlls/kernel32/tests/profile.c index e3f7156..8e64e73 100644 --- a/dlls/kernel32/tests/profile.c +++ b/dlls/kernel32/tests/profile.c @@ -266,6 +266,10 @@ static void test_profile_sections_names(void)

Re: [PATCH] kernel32: GetPrivateProfileSectionNamesA error checking (Coverity)

2010-01-06 Thread Paul Vriens
On 01/06/2010 01:59 PM, Marcus Meissner wrote: diff --git a/dlls/kernel32/tests/profile.c b/dlls/kernel32/tests/profile.c index e3f7156..8e64e73 100644 --- a/dlls/kernel32/tests/profile.c +++ b/dlls/kernel32/tests/profile.c @@ -266,6 +266,10 @@ static void test_profile_sections_names(void)

Fwd: The (Casual) Game Support Report in Wine (Jan 2009)

2010-01-06 Thread David Gerard
whoops, sending to list as well! -- Forwarded message -- From: David Gerard dger...@gmail.com Date: 2010/1/6 Subject: Re: The (Casual) Game Support Report in Wine (Jan 2009) To: Reece Dunn mscl...@googlemail.com 2010/1/5 Reece Dunn mscl...@googlemail.com:  2/  the major

Re: The (Casual) Game Support Report in Wine (Jan 2009)

2010-01-06 Thread Reece Dunn
2010/1/6 David Gerard dger...@gmail.com: whoops, sending to list as well! 2010/1/5 Reece Dunn mscl...@googlemail.com:  2/  the major issues appear to be in the application launchers used by different game providers (most of which are in the current wine implementation of the IE browser

Re: [PATCH] Don't generate FIXME warnings for DllCanUnloadNow.

2010-01-06 Thread Maarten Lankhorst
Hi Reece, Reece Dunn schreef: NOTE: Some of the DllCanUnloadNow functions always return S_OK. I intend to address that in a separate patch once I have investigated whether the DLLs implement COM objects or not. When a dll is first implemented it probably returns S_OK since no interfaces

re: [PATCH] kernel32: GetPrivateProfileSectionNamesA error checking (Coverity)

2010-01-06 Thread Dan Kegel
AJ wrote: Marcus Meissner marcus at jet.franken.de writes: buffer and size need to be either 0 at the same time or not, otherwise this breaks up. Windows is inconsistent (either crashes or returns invalids), so we can just add checking. If Windows crashes we don't need extra checks. Just tell

Re: [PATCH] Don't generate FIXME warnings for DllCanUnloadNow.

2010-01-06 Thread Reece Dunn
2010/1/6 Maarten Lankhorst m.b.lankho...@gmail.com: Hi Reece, Reece Dunn schreef: NOTE: Some of the DllCanUnloadNow functions always return S_OK. I intend to address that in a separate patch once I have investigated whether the DLLs implement COM objects or not. When a dll is first

Re: [PATCH] kernel32: GetPrivateProfileSectionNamesA error checking (Coverity)

2010-01-06 Thread Paul Vriens
On 01/06/2010 04:03 PM, Dan Kegel wrote: AJ wrote: Marcus Meissnermarcus at jet.franken.de writes: buffer and size need to be either 0 at the same time or not, otherwise this breaks up. Windows is inconsistent (either crashes or returns invalids), so we can just add checking. If Windows

Re: [PATCH] kernel32: GetPrivateProfileSectionNamesA error checking (Coverity)

2010-01-06 Thread Alexandre Julliard
Dan Kegel d...@kegel.com writes: AJ wrote: Marcus Meissner marcus at jet.franken.de writes: buffer and size need to be either 0 at the same time or not, otherwise this breaks up. Windows is inconsistent (either crashes or returns invalids), so we can just add checking. If Windows crashes we

Re: Wine FIXME Report 2009 Aug - Dec

2010-01-06 Thread Kai Blin
On Wednesday 06 January 2010 01:02:04 Reece Dunn wrote: 2010/1/5 Michael Stefaniuc mstef...@redhat.com:  2040  |  36   | ntdll:RtlNtStatusToDosErrorNoTeb no mapping for c109 0xc109 is NT_STATUS_MESSAGE_NOT_FOUND according to

Re: [PATCH] kernel32: GetPrivateProfileSectionNamesA error checking (Coverity)

2010-01-06 Thread Dan Kegel
On Wed, Jan 6, 2010 at 7:21 AM, Alexandre Julliard julli...@winehq.org wrote: Crashing is the best behavior. Adding parameter checks all over the place only hides bugs. I keep forgetting that crashing is good sometimes :-)

Re: Wine FIXME Report 2009 Aug - Dec

2010-01-06 Thread Kai Blin
On Wednesday 06 January 2010 17:49:12 Kai Blin wrote: I'll send a patch. I see Wolfram beat me to it. :) Cheers, Kai -- Kai Blin WorldForge developer http://www.worldforge.org/ Wine developerhttp://wiki.winehq.org/KaiBlin Samba team member http://www.samba.org/samba/team/ --

New Icon set

2010-01-06 Thread Detlef Riekenberg
Hi Joel When I read your preview page in Firefox, the lens for print preview in idb_std_small.bmp is to large. You can't detect the printer behind the lens. (LCD Resolution here is 1400x1050) As an Idea for an improvement, the print preview menu icon in Firefox is readable: The lens is a bit

Re: mlang: [RESEND] Print a FIXME only for unused parameter (Wine FIXME Report)

2010-01-06 Thread James Hawkins
On Wed, Jan 6, 2010 at 3:28 PM, Detlef Riekenberg wine@web.de wrote: According to MSDN, both parameter are unused and must be 0/NULL A FIXME for every call is useless (there is no PATCH 1/2, so a resend without that prefix) -- By by ... Detlef ---  dlls/mlang/mlang.c |    8

Re: FIXMEs in DllCanUnloadNow and friends (and how to handle them)

2010-01-06 Thread James McKenzie
Reece Dunn wrote: Hi, As a result of the Wine FIXME Report 2009 Aug - Dec thread, I created the following to hunt for DllCanUnloadNow calls that were marked as being FIXME stubs: Thank you for the patch, Reece. James McKenzie

Re: gdi32: Use the LOGFONT charset field on OEM font creation

2010-01-06 Thread Ilya Shpigor
On Tuesday 05 January 2010 17:08:52 Dmitry Timoshkov wrote: Ilya Shpigor shpi...@etersoft.ru wrote: Some explanation for this patch: The fsCsb is bitfield that is used as boolean value. If this is false the DEFAULT_CHARSET is using and the real charset is choosen through the current

Re: user32: Do not allow a change of capture if the currently capture window is a menu unless explicitly specified

2010-01-06 Thread Paul Vriens
On 01/07/2010 03:33 AM, Peter Dons Tychsen wrote: +/* check that SetCapture fails for another window and that it does not touch the error code */ +set_cap_wnd = SetCapture(hWnd); +err = GetLastError(); +ok(!set_cap_wnd, ReleaseCapture should have